- Increase the overlap between the preview items and the background
so that it appears more intentional (lots of reports of users
thinking that its a bug)
- Fix bug where clip path was still clipping icons when
dragging and swiping to home.
Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
close folder on 2nd page, ensure clipping
ensure no preview items are clipped in drag view
ensure no preview items are clipped in swipe up to home
test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
of folder icons
drag and drop folder in and out of hotseat
create folders (2 icon, 3 icon, 4 icon)
Change-Id: Id49bae33438e10248bef05450d7e2c92c2140748
- Remove fade since we no longer clip icons.
- Ensures a clean handoff between drag view and folder icon preview item.
Bug: 175329686
Test: create folder / add items to folder
Change-Id: Iaab592410734b0b5239dbbddbb9b2ed5a9f5d8b0
- Switch Circle to PathShape as it allows for more flexibility on
choosing what gets cropped.
- Remove shadows, and stroke.
Bug: 188095988
Test: manual
Change-Id: I602b3efcd35c2c11dc3461f49099c2f2a56eae59
- 3 item folder preview has the first item on top of the other 2
- Skip first frame of the folder open animation as there is no
visual change in that first frame.
Bug: 175329686
Test: visual
Change-Id: Ida9a55ee5093c49f230cdf22d7943b2a6a7ed42d
The old folder preview and animation relied on creating bitmaps for transition.
As we move to hardware bitmaps, creating custom bitmaps which rely on icon bitmaps
would be costly (hardware bitmaps are immutable and cannot be drawn on a software canvas).
Bug: 35428783
Change-Id: I39869ed44feb6a886985ad15775bc1ab55565727
Instead of changing the display order of the Folder to preserve
the upper left quadrant, we are opting to change the Folder Icon
preview to always show the upper left quadrant.
This means that when adding items to a Folder, the preview items
may change. (They will change when the column size increases).
Bug: 27944225
Bug: 63140071
Change-Id: I863c2479469d68559cab2878030c2087d48217d6
The goal is to eventually move all of the PreviewBackground and
Preview Item drawing out of the FolderIcon class.
Bug: 36022592
Change-Id: Ie0552bb4ca8a7e232c1c454a23558940e9394a14
without going through the child'draw pass.
Also simplifying the draw code for the FolderIcon to remove any cycling invalidate calls
Bug: 62900800
Change-Id: I17009a5347a1c3c35426313ac759e0240ce6a395
This class verifies whether an item in a Foder is displayed in
the FolderIcon preview, based on the item's rank.
We use this class to determine which items in a Folder will be
displayed in the preview.
Bug: 35064148
Change-Id: Ia21bccbd95c348efeac62591ae3696a4c60b5339
-> When there is disparity between the cached icon size and the available space
in the preview, the folder preview could appear not as intended (either
overly crammed, or overly spacious)
issue 27701193
Change-Id: I9f97012ba569d1419b1e3f661cd26761b2a36285
-> Refactored the preview background rendering to be much more self-contained.
This cleans up a lot of code in the CellLayout, and keeps the logic in the
right place.
-> We switch to software rendering for performance and compatibility reasons.
-> Removed all assets.
-> FolderIcon accept animation includes animation of the clipped region.
-> 1:1 hand-off of drawing of the FolderIcon background between the FolderIcon
and the CellLayout. Unfortunately, CellLayout rendering is still required
to work around clipping issues (due to use of software layer). We also
need this to support folder creation feedback.
Change-Id: Ib8f7fa6359dfedff8145f38dd50ba03849ca0d51
-> Tracking individual drawing parms for each item
-> This enables animation of the preview items as the preview changes
Change-Id: I1b8f650cb28dc09cfb921bbdc93f2a3db61178fd
-> Modeled as a set of items around a circle
-> Modulate the radius and icon size as number of items grow
-> Clip the icons by a circular clip aligned to the background drawable
Remaining issues
-> Probably want to move to a programmaticly drawn circle + shadow
-> Anti-aliasing of the clipped region will need more attention
-> Need to animate all items in the preview as it changes (this
wasn't required before)
Change-Id: I678ec605f6c8a34e9d7e4aec4e9583e36a9ef394
