Commit Graph

3013 Commits

Author SHA1 Message Date
Tracy Zhou
d727db3c87 Merge "Pass home rotation state to SysUI" into sc-dev 2021-05-17 17:18:42 +00:00
Tracy Zhou
3ed7ee76c4 Merge "Detach nav bar from app after settling into overview" into sc-dev 2021-05-17 17:11:14 +00:00
TreeHugger Robot
6facaad569 Merge "Revert to overview coming from the side instead of bottom" into sc-dev 2021-05-17 17:04:43 +00:00
Alina Zaidi
f0e11cbbc3 Merge "Modify pin widget dialog open-close animation." into sc-dev 2021-05-17 16:51:50 +00:00
Yogisha Dixit
07449132fb Merge "Log widget features." into sc-dev 2021-05-15 15:07:40 +00:00
Winson Chung
8b74cbbf96 Merge "Add a content overlay for auto-enter w/o a source hint rect" into sc-dev 2021-05-14 23:44:24 +00:00
Yogisha Dixit
0b15c7ee07 Log widget features.
Design doc: go/widgets-logging
Note that this doesn't log dynamic colors yet. I'll work on that in a
follow-up CL.

Bug: 185778648
Test: manual
Change-Id: I04249ef267907b4112c220fb206e077d1bee783a
2021-05-15 00:26:41 +01:00
Tony Wickham
82d5a0681d Revert to overview coming from the side instead of bottom
Test: Visually checking all of these. As appropriate, repeat in 0, 2, 3
button modes, landscape/portrait/fake landscape, and 3P launcher
- Quick switch from home
- Home to overview
- Overview to home (swipe up)
- Overview to home (tap outside)
- Overview to home (back invocation)
- Quick switch from app
- Swipe up and hold from app
- Dismiss an app
- Empty recents
- Split select state to home
- Modal state to home
Fixes: 185411781

Change-Id: If00a22fee35c832a259bfc62808efbac5990ce2e
2021-05-14 16:06:44 -07:00
Zak Cohen
02ca6c14dd Merge "Overview - don't update task overlay on thumbnail update." into sc-dev 2021-05-14 21:52:55 +00:00
Cyrus Boadway
a27ebc1633 Merge "Add interaction jank monitoring for widget app launch CUJ" into sc-dev 2021-05-14 17:40:16 +00:00
Tracy Zhou
7ad2e846b4 Detach nav bar from app after settling into overview
Fixes: 185042209
Test: manual
Change-Id: Id302ac9f8e86c3af6b2c05a4314401505eb26b1e
2021-05-14 10:37:44 -07:00
Alina Zaidi
d80cec62b4 Modify pin widget dialog open-close animation.
Pin widget sheet should open from bottom up and close on drag down.
Behaviour with navigation bar is similar to that of widgets bottom sheet.

Add a drag layer and reuse AbstractSlideInView for open-close
animation.

Test: Tested manually- opening, closing through dragging/ cancel button/
back button. Adding widget to screen by dragging/ add to home screen
button.
Bug: 186124244

Change-Id: I4b77d5bdd4ed1689b651847dfed69d19cafa7456
2021-05-14 17:59:50 +01:00
Sunny Goyal
10dfa61db8 Merge "Revert "Revert "Exposing AnimatorListeners in StateManager to receive both success and failure callback""" into sc-dev 2021-05-14 15:46:14 +00:00
Tracy Zhou
c9bf0f6161 Pass home rotation state to SysUI
Fixes: 185962767
Test: manual

Change-Id: I3d2103b665f099a087545a97fdb84bc240b8d261
2021-05-13 22:12:12 -07:00
zakcohen
a6ca69aa53 Overview - don't update task overlay on thumbnail update.
Only init and reset the task overlay on the enabled state of the overlay
changing.
Previously the overlay was also updated when the thumbnail changed, but
this can happen for lots of different reasons so was causing janky
transitions and potentially excess work in code that was following the
overlay.

The overlay code really only cares about the thumbnail after the task has
settled, so should be safe to ignore the thumbnail updates.



Bug: 188097940
Test: local build and run on p5
Change-Id: I4ad1767046cb0316af19713bc188788d8f581d7c
2021-05-13 16:35:49 -07:00
TreeHugger Robot
e010332efd Merge "Enable free scroll immediately if gesture goes to overview" into sc-dev 2021-05-13 21:23:05 +00:00
Tony Wickham
1eea52296b Merge "Remove mOnRecentsScrollListener when continuing quick switch gesture" into sc-dev 2021-05-13 19:49:41 +00:00
Alex Chau
6a5920c682 Enable free scroll immediately if gesture goes to overview
Fixes: 186871947
Test: Swipe up from app, scroll immediately, free scroll should be enabled
Change-Id: I20b782df04fb6e61dfd5c7e82e1ab90dbd6ed8fc
2021-05-13 20:39:15 +01:00
Cyrus Boadway
a1d303e531 Merge "Register a remote animation for the next activity start" into sc-dev 2021-05-13 19:33:59 +00:00
Cyrus Boadway
c169e5b9af Register a remote animation for the next activity start
Widgets are permitted to start broadcast receivers which launch
activities, otherwise known as a broadcast trampoline. Unfortunately,
launch animations provided through ActivityOptions are not applied to
the activity launch.

If a widget interaction's pending intent is not an activity, set a
return animation for the next activity start, in the event it starts an
activity.

Bug: 169042867
Test: presubmit
Change-Id: Ibbee9cadcd5153e285433fcb1b8038d77b1384a2
2021-05-13 17:56:14 +00:00
Winson Chung
549ea0b3a9 Merge "Skip setting up ui if the handler is already invalidated" into sc-dev 2021-05-13 17:28:06 +00:00
Sunny Goyal
01b32466c3 Revert "Revert "Exposing AnimatorListeners in StateManager to receive both success and failure callback""
This reverts commit d7f11d5fb9.

Reason for revert: Fixed initial error
Bug: 185554764

Change-Id: I32cc49f9b3820166736ceb347f33577939aa6efa
2021-05-13 10:23:35 -07:00
Winson Chung
af7c86ada5 Skip setting up ui if the handler is already invalidated
- Also unregister the task stack listener in case the restart
  message comes in right before the animation is finished

Bug: 186760990
Test: Swipe up/quickswitch repeatedly
Change-Id: I5af7a26f05e7c15e099d6666e4662fd1af9aa861
2021-05-12 20:33:32 -07:00
Tony Wickham
8239ed8733 Remove mOnRecentsScrollListener when continuing quick switch gesture
Test: Quick switch from A to B, touch nav during the transition and
continue quick switching to C; ensure running task doesn't jump to
fullscreen randomly throughout the scroll
Fixes: 186269584

Change-Id: Ibebad3d8c8e8f86c7f53a028c75bb5916369df7f
2021-05-12 16:54:57 -07:00
Hongwei Wang
da21eb9159 Merge "Skip setShelfHeight if Launcher is not started" into sc-dev 2021-05-12 23:42:35 +00:00
TreeHugger Robot
7c58b4c7dc Merge "Revert "Exposing AnimatorListeners in StateManager to receive both success and failure callback"" into sc-dev 2021-05-12 23:37:33 +00:00
Jonathan Miranda
951962cd05 Merge "Tuning app close, and turn on flag." into sc-dev 2021-05-12 23:28:59 +00:00
Winson Chung
8dbba26e76 Add a content overlay for auto-enter w/o a source hint rect
Bug: 184703546
Test: Swipe up from app with auto-enter but no source hint rect

Signed-off-by: Winson Chung <winsonc@google.com>
Change-Id: Ib6f03dc6b11d37c44d732c75adabf45d1795fefc
2021-05-12 15:19:52 -07:00
Jon Miranda
b3a267b58a Tuning app close, and turn on flag.
- Tracks centery, slowed things down a bit

* We will be replacing StaggeredWorkspaceAnim with
  another animation, but I'm keeping it here in
  case we decide to turn the flag off later on.

Bug: 173107751
Test: manual
Change-Id: I5cd54ec374ad07c4912aff125a905b3b1dc7ebd5
2021-05-12 15:04:15 -07:00
Winson Chung
d7f11d5fb9 Revert "Exposing AnimatorListeners in StateManager to receive both success and failure callback"
This reverts commit a75f576890.

Reason for revert: b/187887269
Bug: 187887269

Change-Id: I8a56ff7054e71cf30b113fdaa213397dae0c53cb
2021-05-12 21:25:22 +00:00
Tony Wickham
b9e275d233 Merge "Defer some heavy work from final frame of app -> home transition" into sc-dev 2021-05-12 18:59:41 +00:00
Vinit Nayak
3f349db912 Merge "Prevent thumbnails from shifting if placeholder view doesn't overlap" into sc-dev 2021-05-12 18:04:49 +00:00
TreeHugger Robot
e0a94aa750 Merge "Forces a back region for sandbox even if gesture nav is disabled." into sc-dev 2021-05-12 17:34:15 +00:00
Tony Wickham
ce07a3721a Defer some heavy work from final frame of app -> home transition
- Call reapplyState() on the next frame after settling on home.
- Post some calls from RecentsView#reset() to the next frame.
- Remove onSwipeUpToRecentsComplete() which only called reapplyState()
  uncessarily.
- Also animate TASK_SECONDARY_TRANSLATION back to 0 to ensure state
  machine is in sync with long swipe resistance properties.

Test: profile swipe to home, significantly reduced last frame time.
Bug: 183139317
Change-Id: I37b1829f6f1d5a718e99c131935b87b5200d567f
2021-05-12 10:07:35 -07:00
Cyrus Boadway
6015c3fb03 Merge "Improve widget-activity transition animation for translucent activities" into sc-dev 2021-05-12 15:19:42 +00:00
Cyrus Boadway
670473301a Improve widget-activity transition animation for translucent activities
Activities may be translucent. In that case, the widget should not
visually be a part of the activity launch or return animations.

Bug: 169042867
Test: manual
Change-Id: Ifb690672f71854e491fa240a6c7f0d882910a47c
2021-05-12 11:47:33 +00:00
Andy Wickham
3404138583 Forces a back region for sandbox even if gesture nav is disabled.
When gesture nav is disabled, this config value returns 0,
preventing the back gesture from being recognized.
Probably we won't show the sandbox in that case, but it'd
be good to have a reasonable fallback just in case.

Bug: 186715828
Test: Manual with gesture nav enabled and disabled
Change-Id: Ic5e03bede80521670f81e6ac7b02f364259b9f96
2021-05-12 02:33:48 -07:00
Andy Wickham
53a44a2e51 Merge "Update gesture navigation tutorial." into sc-dev 2021-05-12 09:31:44 +00:00
Ryan Lin
83abf3354b Merge "Do not detect system gesture with new system ui state flag" into sc-dev 2021-05-12 03:00:14 +00:00
Evan Rosky
937371bfb3 Merge "Revert "Fix a bug in TouchInteractionService for fixed-display input rotation"" into sc-dev 2021-05-12 02:09:06 +00:00
Evan Rosky
f78ba72379 Revert "Fix a bug in TouchInteractionService for fixed-display input rotation"
This reverts commit 04fb7ee44c.

Reason for revert: This wasn't the right fix.

Bug: 179274888
Change-Id: Ic9aaf2b43252533837206cc82ac5fd1f2d7297f8
2021-05-12 02:09:00 +00:00
Schneider Victor-tulias
e3af6c6513 Update gesture navigation tutorial.
- Updated gesture navigation feedback videos.
- Added feedback motion loop videos.
- Updated strings.
- Added alternate strings for when the user launches tutorial steps from the Tips app.

Test: manual
bug: 169687177
Change-Id: I87d475e1510a25ffefea14dbd0b224a063e7cad8
2021-05-11 18:14:29 -07:00
Hongwei Wang
6fc623d0b9 Skip setShelfHeight if Launcher is not started
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/gIqsb2WlagwQ8ly3q3RHI0
Bug: 184797356
Test: atest WMShellFlickerTests:PipShelfHeightTest
Test: manual, see video
Change-Id: Ia02b2da110b05341dfbf92b9d8d7fca4bbf6bdb3
2021-05-11 16:42:42 -07:00
Tracy Zhou
6dce7b6366 Merge "Do not pip when ending live tile in Overview" into sc-dev 2021-05-11 23:23:35 +00:00
TreeHugger Robot
d7c6e44ba9 Merge "Exposing AnimatorListeners in StateManager to receive both success and failure callback" into sc-dev 2021-05-11 22:21:42 +00:00
Winson Chung
3956b3ea84 Merge "Revert "Invalidate when switching to new consumer"" into sc-dev 2021-05-11 21:21:18 +00:00
Sunny Goyal
a75f576890 Exposing AnimatorListeners in StateManager to receive both success and failure callback
Updating various callers to use onSuccess or onEnd appropriately

Test: Manual
Bug: 185554764
Change-Id: I357dd1fdbe111e7a30d4c8dee520fbd7d9956b7d
2021-05-11 13:53:14 -07:00
Tracy Zhou
5465527e16 Merge "Check if mRecentsAnimationController is null before switching to screenshot" into sc-dev 2021-05-11 20:44:17 +00:00
Tracy Zhou
be0bb572da Do not pip when ending live tile in Overview
Test: manual
Fixes: 187855255
Change-Id: Iadf808d41692c7dd37de28388b689f01bf045ea9
2021-05-11 13:23:16 -07:00
Winson Chung
ff67905f89 Revert "Invalidate when switching to new consumer"
This reverts commit 4df3b23225
and Id0a6a1c5301c66a515cefcab58b77495081c6190, as we have another
change to try and address the original issue.

Bug: 185909226
Change-Id: Ic2c08833e066090a43b989f2f470de298174e84d
2021-05-11 19:51:52 +00:00