Commit Graph

236 Commits

Author SHA1 Message Date
Sunny Goyal
ee5de5d13d Merge "Using window touch slop for gesture instead of normal touch slop This would prevent intercepting taps on the home button" into ub-launcher3-master 2018-02-26 21:23:12 +00:00
Sunny Goyal
37bbe39dc0 Using window touch slop for gesture instead of normal touch slop
This would prevent intercepting taps on the home button

Bug: 73188263
Change-Id: Ic0085a9109ee9045da56c48a86a21cc023e57748
2018-02-26 12:25:52 -08:00
TreeHugger Robot
790822ab22 Merge "Ensuring that all the pending tasks are run before marking the ViewOnDrawExecutor as completed." into ub-launcher3-master 2018-02-26 19:10:40 +00:00
Tony Wickham
03f62371de Close task menu when clicking on its icon
Bug: 70294936
Change-Id: I1e774626c73b06d60da9b3be40d1ec80ac8eaa2d
2018-02-23 15:50:01 -08:00
TreeHugger Robot
33d1c3c0ea Merge "Normalizing icons in recents view" into ub-launcher3-master 2018-02-23 23:13:17 +00:00
Sunny Goyal
338d15d232 Normalizing icons in recents view
Change-Id: I1d95c1abf158044ca5666473f976b49f7997ca27
2018-02-23 12:26:25 -08:00
Sunny Goyal
a52d2eca83 Moving the hotseat by same amount as the task window bottom when dragging
Bug: 73354752
Change-Id: I7d20e718aab9bc9be75b4d536f1aa8b87c385caf
2018-02-23 10:12:07 -08:00
Sunny Goyal
0e7724cef7 Ensuring that all the pending tasks are run
before marking the ViewOnDrawExecutor as completed.

Also fixing model writer not updated on rotation

Change-Id: I5ecd7ac865b939ffa4c02afe892bd773d9f275c3
2018-02-22 17:27:13 -08:00
TreeHugger Robot
a12bd507d1 Merge "Adding some trace logging around RecentsController" into ub-launcher3-master 2018-02-23 01:23:40 +00:00
Winson Chung
a7843583be Fix flash when switching from app window to snapshot.
- If there is any delay in launcher draw, then we will finish the
  transition and hide the app window before launcher has had a chance to
  draw the task view with the updated snapshot.

Change-Id: I81c5b467f32520fd7474bde0e89819336292e84f
2018-02-22 16:42:44 -08:00
Sunny Goyal
8a7351fec6 Adding some trace logging around RecentsController
Change-Id: Ieb019d3d8c5f8540cba7b162f4c6f911d2005f5a
2018-02-22 16:32:46 -08:00
Sunny Goyal
5c86b5d9cd Synchronizing invalidating interaction handler with the eventQueue.
In some cases, eventQueue could be running on the background thread where as
the invalidate happens on the UI thread, which could cause race conditions in
touch consumer

Change-Id: Iebd84238eb2b5d6774beaa3bc21afdeb09e62561
2018-02-22 13:42:55 -08:00
Sunny Goyal
d70e75a514 Removing launcher dependency when logging quickstep interaction
as Launcher may not be ready when the touch gesture completes.

Change-Id: Ia69eb7bfb0340f7b7ce9b6c67be8851e5429f867
2018-02-22 10:21:41 -08:00
TreeHugger Robot
668dd40a98 Merge "Fixing window transform not changing monotonically with shift" into ub-launcher3-master 2018-02-22 00:37:02 +00:00
Sunny Goyal
30897aaa1d Temporarily enabling various tracing for debug devices
Change-Id: Iebee7d0a4c408f50ab911b31edbec12499a42844
2018-02-21 15:58:40 -08:00
Sunny Goyal
b1e2e2956e Fixing window transform not changing monotonically with shift
Change-Id: I40f095e73ca1cdb994d34aecc2c6be90f3e0f25b
2018-02-21 14:56:17 -08:00
Hyunyoung Song
41431af541 Merge "Quick step/scrub/switch logging - state transition happening due to Home and back is handled by specifying src target as 'from' container and dst target as the 'to' container - Source and Destination container shows FROM and TO state for SWIPE/FLING - event.isStateChange = true indicates that an action resulted in state transition - Elapsed container millis is the screen time on the source container" into ub-launcher3-master 2018-02-21 07:00:45 +00:00
Hyunyoung Song
b3fbc0ba8f Quick step/scrub/switch logging
- state transition happening due to Home and back is handled by
  specifying src target as 'from' container and dst target as the 'to'
  container
- Source and Destination container shows FROM and TO state for SWIPE/FLING
- event.isStateChange = true indicates that an action resulted in
  state transition
- Elapsed container millis is the screen time on the source container

Bug: 70181187

- logcat printout with setprop log.tag.UserEvent VERBOSE
1) State: WORKSPACE -> ALLAPPS
  action:FLING direction=UP
  Source child:HOTSEAT id=0	parent:WORKSPACE id=0
  Destination child:ALLAPPS
  Elapsed container 1225 ms, session 1225 ms, action 0 ms

2) ALLAPPS -> HOMESCREEN
  action:FLING direction=DOWN
  Source child:ALLAPPS	parent:ALLAPPS
  Destination child:WORKSPACE id=0
  Elapsed container 971 ms, session 2197 ms, action 0 ms

3) HOMESCREEN -> OVERVIEW
  action:FLING direction=UP
  Source child:NAVBAR	parent:WORKSPACE id=0
  Destination child:TASKSWITCHER
  Elapsed container 4834 ms, session 4834 ms, action 0 ms

4) OVERVIEW-> ALLAPPS
  action:FLING direction=UP
  Source child:TASK	parent:TASKSWITCHER
  Destination child:ALLAPPS
  Elapsed container 2176 ms, session 7010 ms, action 0 ms

5) ALLAPPS->OVERVIEW
  action:FLING direction=DOWN
  Source child:ALLAPPS	parent:ALLAPPS
  Destination child:TASKSWITCHER
  Elapsed container 3683 ms, session 10693 ms, action 0 ms

6) OVERVIEW-> HOMESCREEN
  action:FLING direction=DOWN
  Source child:TASK	parent:TASKSWITCHER
  Destination child:WORKSPACE id=0
  Elapsed container 2108 ms, session 12801 ms, action 0 ms

7) APPS-> OVERVIEW
  action:FLING direction=UP
  Source child:NAVBAR	parent:APP
  Destination child:TASKSWITCHER
  Elapsed container 104 ms, session 104 ms, action 0 ms

8) Quickscrub: action:DRAGANDDROP Source child: QUICK

9) Quickswitch: action:FLING Source child: QUICK

Change-Id: I5898230859ff600f48a2a873a40b670fe4d39a0d
2018-02-20 22:40:19 -08:00
Sunny Goyal
60876ac0d7 Handling recents animation cancelation
When the animation is cancelled, if remove the pending handler
(incase it has not executed yet) and revert back to the old
state if it has executed.

Change-Id: Iddc305aaaeae78c06cbf6c1c271254409cc1487d
2018-02-20 16:06:06 -08:00
Winson Chung
b186136a37 Merge "Re-enable deferring recents animation on back button." into ub-launcher3-master 2018-02-20 20:46:41 +00:00
Winson Chung
82db735196 Re-enable deferring recents animation on back button.
Bug: 73242451
Test: Swipe up over back button, ensure that we don't start the animation
      until the threshold is crossed

Change-Id: If84c39370428f8ea5bf9d5f7110d17227f00ccc0
2018-02-20 10:19:46 -08:00
Tony Wickham
f2f08fc4c6 Merge "Fix task icon not showing if you press home" into ub-launcher3-master 2018-02-20 17:59:11 +00:00
TreeHugger Robot
40583a2f9b Merge "Increase initial delay for auto-advancing on quickscrub." into ub-launcher3-master 2018-02-20 17:22:51 +00:00
Tony
ff35921926 Fix task icon not showing if you press home
Instead of setting the icon scale to 0 in showTask(), which is
called whenever we get a new intent, only set it to 0 when
starting the swipe up gesture.

Change-Id: I657a1c5763c60b65e28f453ffe854ae8dab83bbc
2018-02-20 09:21:17 -08:00
Winson Chung
df7eb4ca86 Increase initial delay for auto-advancing on quickscrub.
- Also reduce the number of quickscrub sections

Change-Id: I34334d2bf79bd7e720f8b4efa4ac18c6be894704
2018-02-20 09:11:28 -08:00
Tony Wickham
096948022c Merge "Hide split screen option if app doesn't support it" into ub-launcher3-master 2018-02-20 16:44:05 +00:00
TreeHugger Robot
41157f3ca2 Merge "Tweaks to synchronized app transitions." into ub-launcher3-master 2018-02-20 15:06:48 +00:00
Tony
73296f2793 Hide split screen option if app doesn't support it
Bug: 73120439
Bug: 70294936
Change-Id: I3cfb665d54f59222936aa6f735275b692b0a7e54
2018-02-18 16:52:17 -08:00
Tony Wickham
5f72d3b8b6 Merge "Fix a couple bugs with back button visibility" into ub-launcher3-master 2018-02-18 19:51:55 +00:00
Tony Wickham
0c22a6c2c7 Fix a couple bugs with back button visibility
- Fix back button flickering when returning to NORMAL state instead of
  finishing a gesture to, say, ALL_APPS. This is achieved by posting
  changes to the back visibility on the UI thread (binder calls are
  posted on the background thread).
- Restore back button when touch service reconnects (in case we were
  forced into an app when launcher is force-stopped, for instance).

Change-Id: I3731ee43d66965ce7cd8cf026174aabfe2d5c56c
2018-02-16 15:55:16 -08:00
Jon Miranda
863e05556e Tweaks to synchronized app transitions.
* Animations appear snappier by using new interpolators
  ie. new EXAGGERATED_EASE and updated AGGRESSIVE_EASE_IN_OUT
* Updated app icon/window alpha to make the motion/synchronization clearer.

Bug: 70220260
Change-Id: Ib05efc7f58d53b070e58f682f30651e31f9b3524
2018-02-16 15:44:40 -08:00
Sunny Goyal
841bbf07d0 Serializing all event handling from SystemUI
> EventQueue is only accessed on the binder thread
> For every new touch down, we use a new event queue to prevent race conditions
> All event hendling are serialized by event queue (including quick switch/scrub)
> Using state handlers for quick scrub

Bug: 73356768
Change-Id: Idde33a348270b8167a087129f177d5d2b54f5822
2018-02-16 14:00:09 -08:00
Tony Wickham
bd3a798aa2 Merge "Fix a couple quickscrub issues" into ub-launcher3-master 2018-02-16 16:42:02 +00:00
TreeHugger Robot
19a3906ec0 Merge "Revert "Revert "Generating fake “to Recents” events for overview NOT from task""" into ub-launcher3-master 2018-02-16 04:44:26 +00:00
TreeHugger Robot
7fa87bb1f1 Merge "Revert "Revert "Remove back button when on home screen""" into ub-launcher3-master 2018-02-16 04:43:59 +00:00
Winson Chung
021c06cde9 Don't rely on ORIENTATION_BEHIND, lock th rotation during the gesture.
Bug: 73486148
Change-Id: I83650c6a3ba8634fb37a5792614e958fb01dd7b8
2018-02-15 19:40:24 -08:00
Winson Chung
d782394132 Revert "Revert "Remove back button when on home screen""
This reverts commit dd176e65e3.

Reason for revert: Post-drop revert

Change-Id: If93eb4bca636bfba2471c8992621a59895bfcbe2
2018-02-16 03:23:47 +00:00
Winson Chung
9d286e6753 Revert "Revert "Generating fake “to Recents” events for overview NOT from task""
This reverts commit 53daa2cae8.

Reason for revert: Post-drop revert

Change-Id: I74a4d473951d7990424610adfcd4483135c817c5
2018-02-16 03:23:38 +00:00
Winson Chung
6485766bd1 Merge "Revert "Remove back button when on home screen"" into ub-launcher3-master 2018-02-16 03:04:30 +00:00
Winson Chung
3b26183907 Merge "Revert "Generating fake “to Recents” events for overview NOT from task"" into ub-launcher3-master 2018-02-16 03:04:25 +00:00
Winson Chung
dd176e65e3 Revert "Remove back button when on home screen"
This reverts commit 663759e444.

Reason for revert: Temporary revert for NL build

Change-Id: I8614ee348e6e9290c0de0dfdf3e24663f220e356
2018-02-16 02:42:26 +00:00
Winson Chung
53daa2cae8 Revert "Generating fake “to Recents” events for overview NOT from task"
This reverts commit d46e428706.

Reason for revert: Temporary revert for NL build

Change-Id: I0bb46d0fc56a12c642a0ea8610e7a86002a21ada
2018-02-16 02:42:00 +00:00
Tony Wickham
fa3efe9494 Fix a couple quickscrub issues
- Always launch workspace card if it's focused when quick scrub ends
  - Previously it would get stuck if quick scrub end was called on
    a background thread (since it was trying to touch RecentsView)
  - Prevent user from being able to get to the workspace card if
    starting quick scrub from an app by introducing bounds checking
- Prevent getting stuck in overview when ending quick scrub
  - There was a race condition where the task wouldn't launch if
    the animation to recents hadn't yet finished. Now there is a
    callback to ensure that launchTask() is always called after.

Bug: 70180755
Change-Id: I3c131011634880a97de8c2935c3ebdab26494b48
2018-02-15 17:21:56 -08:00
TreeHugger Robot
cfab8c5ded Merge "Generating fake “to Recents” events for overview NOT from task" into ub-launcher3-master 2018-02-16 00:24:11 +00:00
Vadim Tryshev
d46e428706 Generating fake “to Recents” events for overview NOT from task
These records are required by “Transition Delay - Hot Launch From
Recents” test. It doesn’t look at transition times for this event. They
are just a part of its expected sequence of events.

I generate transition delay times as zeroes because no one is looking at
them.

Bug: 72967764
Test: atest google/perf/app-transition/app-transition-from-recents-trace
Change-Id: I4a5b76b95c6c4b54e7fb620951342a3ed8564aed
2018-02-15 16:13:28 -08:00
Winson Chung
748c55bc76 Merge "Prevent rotation during quickscrub gesture." into ub-launcher3-master 2018-02-15 21:58:47 +00:00
Tony Wickham
22a24c1aa2 Merge "Remove back button when on home screen" into ub-launcher3-master 2018-02-15 21:49:26 +00:00
Tony Wickham
663759e444 Remove back button when on home screen
Add OverviewInteractionState to handle setting OverviewInteractionFlags.

Hide back button when in NORMAL state and launcher's window is focused.
Show it when in other states or when launcher's window loses focus.

Change-Id: I35919561b9972789e995f1cc434c23e2afe9e77c
2018-02-15 12:20:16 -08:00
Winson Chung
9004912eaa Prevent rotation during quickscrub gesture.
Bug: 73486148
Change-Id: Ia435608484e49daf93ff4aa675da11ea4f0fd421
2018-02-15 11:35:37 -08:00
Sunny Goyal
c36d6eefae Temporarily disabling model preloading
Bug: 73399920
Change-Id: Ia4a93c77a3209c6a9b2baae02a3ee3d6abb693d4
2018-02-14 20:46:31 -08:00