Commit Graph

15357 Commits

Author SHA1 Message Date
Tracy Zhou
ed96865005 Merge "Center taskbar nav buttons in small screen" into udc-qpr-dev 2023-08-08 00:12:54 +00:00
Treehugger Robot
77204f4608 Merge "Add better logging around long launcher operations during unfold" into udc-qpr-dev 2023-08-07 17:25:05 +00:00
Treehugger Robot
93e088dc1c Merge changes Ifa66cfb7,Ied7867fb into udc-qpr-dev
* changes:
  Add dynamic thresholds for taskbar based on screen size.
  Add ENABLE_DYNAMIC_TASKBAR_THRESHOLDS feature flag.
2023-08-07 16:27:36 +00:00
Nicolo' Mazzucato
e120fcfa47 Add better logging around long launcher operations during unfold
This logging helps understanding what's going on in Launcher main thread
 during unfold from perfetto traces.

Test: Perfetto trace after unfolding
Bug: 292472402
Change-Id: I7a037d9a129deb4bfe4310fdba664b87164ef2ca
2023-08-07 12:18:10 +00:00
Tracy Zhou
dcae0e86ac Center taskbar nav buttons in small screen
Bug: 288311605
Test: All the buttons are in centered in all orientations
Change-Id: Ibb9dc57e38a2e61c426f1edfbf771634d5e3cbb1
2023-08-06 21:03:04 -07:00
Tracy Zhou
b7cd64d5b7 Merge "Update nav button color when nav button layout changes" into udc-qpr-dev 2023-08-05 07:01:07 +00:00
Bill Yi
830e67c5c5 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-08-05 03:31:42 +00:00
Randy Pfohl
7d19aecf5a Merge "attempting to catch security exception to prevent full crash" into udc-qpr-dev 2023-08-04 22:50:40 +00:00
Jon Miranda
a625f58737 Add dynamic thresholds for taskbar based on screen size.
Bug: 274467454
Test: Manually test that each threshold is as expected
Change-Id: Ifa66cfb78f544bb4d14391e70badc92589d47a26
2023-08-04 14:35:56 -07:00
randypfohl
d6568db503 attempting to catch security exception to prevent full crash
Test: built locally

Bug: 283074997
Change-Id: I9b60740c6de04422f69534e6a17d1858018f61e9
2023-08-04 13:40:01 -07:00
Federico Baron
410344860c Merge "Add logs around BaseDepthController to investigate b/291401432" into udc-qpr-dev 2023-08-04 19:44:40 +00:00
Ats Jenk
f00906cc3d Merge "Use window corner radius for desktop task snapshots" into udc-qpr-dev 2023-08-04 17:55:12 +00:00
Bill Yi
98830fcbd6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib3a3dee039404b6f7fdad4d2ac524ea78262a5d3
2023-08-03 18:58:26 -07:00
Vinit Nayak
3adfa41951 Merge "Ensure matching insets for taskbar gesture and 3 button nav" into udc-qpr-dev 2023-08-03 00:49:21 +00:00
Vinit Nayak
1fd1b68870 Ensure matching insets for taskbar gesture and 3 button nav
* WM checks that the number of insets don't change for
a given window once it's added. Previously when we changed
nav modes the window was removed and a new one was added, so
changing insets amounts/types didn't matter.
* Now that we use the same window and re-provide the insets,
the number of them provided have to match (insets values themselves
can change as much as needed)
* Fix minor bug when checking bit mask for gravity

Test: Switch between nav modes, no crash; no change in behavior
w/ flag turned off
Bug: 274517647
Flag: persist.wm.debug.hide_navbar_window
Change-Id: I750f843e8210ba1c800b61ac79664265924c054a

Change-Id: Idba4e8e1888fa58bf872c04cb042f77a8b5b0573
2023-08-02 14:21:31 -07:00
Pat Manning
a0e328abe7 Merge "Add test to access overview app menu." into udc-qpr-dev 2023-08-02 18:02:29 +00:00
Pat Manning
ccf611234a Add test to access overview app menu.
Approved tapl DD: go/tapl-overview-task-menu-app-info

Fix: 292081139
Test: TaplTestsQuickstep.
Change-Id: Ic74267ec80b0a8c6af502a445d355f0420d8f569
2023-08-02 17:20:03 +01:00
Ats Jenk
7313bc7800 Use window corner radius for desktop task snapshots
Desktop task snapshots are shown inside the desktop tile in overview.
They use the window corner radius, when shown on the desktop. Keep the
same radius for the snapshots in overview. Only the desktop tile
background should use the task corner radius.

Bug: 280827930
Flag: persist.wm.debug.desktop_mode_2
Test: open some apps on desktop, swipe up for overview, observe the
      desktop task corner radius remains the same as when on desktop
Change-Id: I55ced9f704b83a6c7619508aa3e7a8080ccc5c35
2023-08-01 14:28:06 -07:00
Tracy Zhou
a6bf4c25c8 Update nav button color when nav button layout changes
Bug: 288311605
Test: Rotate the screen in small screen, make sure the button colors are correct
Change-Id: I36ae980fbe239ea4e1ebb63200ee876b690cf218
2023-08-01 11:14:27 -07:00
Ats Jenk
97c6160359 Merge "Fix tap on navbar handle when on desktop" into udc-qpr-dev 2023-08-01 17:28:57 +00:00
Ats Jenk
342d6b9bf2 Merge "Flag stashing desktop when going home" into udc-qpr-dev 2023-08-01 17:16:03 +00:00
Pat Manning
bd83b29883 Merge "Set taskbar to fullscreen for tooltip only once it is shown." into udc-qpr-dev 2023-08-01 14:55:34 +00:00
Pat Manning
a3d564ce34 Set taskbar to fullscreen for tooltip only once it is shown.
Fix: 293490434
Test: TaskbarHoverToolTipControllerTest
Change-Id: Iba59ce241933a52e7f49036188660bef93ea6dcb
2023-08-01 14:33:59 +01:00
Pat Manning
0baeedbc75 Merge "Prevent showing action button edu tooltip in grid only overview." into udc-qpr-dev 2023-08-01 11:39:38 +00:00
Brian Isganitis
d280c2f946 Back open-close animation with an AnimatorSet.
Subclasses can add more animations to the set to animate other
components in sync with themselves.

Test: Manual
Bug: 289290185
Flag: No
Change-Id: I96d9afe166e243bb0d2a9cecb8158e2e7d431a6c
2023-07-31 19:47:26 +00:00
Andy Wickham
ea12dd4e39 Merge "Make some things public for reuse." into udc-qpr-dev 2023-07-31 18:19:22 +00:00
Vinit Nayak
89976ecae4 Merge "Remove split instructions view on split launch success" into udc-qpr-dev 2023-07-31 18:13:12 +00:00
Ivan Tkachenko
2de68329fd Merge "Bubble bar dismiss interaction" into udc-qpr-dev 2023-07-31 17:54:43 +00:00
Ivan Tkachenko
8d25d999e7 Merge "Bubble bar dismiss" into udc-qpr-dev 2023-07-31 17:54:17 +00:00
Johannes Gallmann
19721d5e28 Merge "Extract Launcher resource interpolators to Animation Library" into udc-qpr-dev 2023-07-31 12:36:43 +00:00
Ats Jenk
7d72bcd46e Fix tap on navbar handle when on desktop
Tapping on navbar handle was hiding the stashed taskbar handle.
When tappin on navbar handle, it starts the recents animation. Which
gets cancelled. Normally, the fullscreen app being visible, it means
launcher activity will be paused after. But when on desktop, launcher is
visible in the background and we need to manually set it to paused
state.
When recents gesture is cancelled after navbar handle tap, the gesture
end state is null. Detect this in DesktopVisibiltyController and mark
launcher as paused in this case.

Bug: 286140120
Flag: persist.wm.debug.desktop_mode_2
Test: open an app on desktop, tap on navbar, observe that user remains
      on desktop
Change-Id: Iee915026265721d42a0b722d6b1595521f20a59a
2023-07-28 17:33:00 -07:00
Andy Wickham
2f72b2efb8 Make some things public for reuse.
Test: With sister change.
Flag: N/A
Bug: 292000892
Change-Id: I8a20b9d4d5df748f90d907a10fe99d066d700170
2023-07-28 16:15:20 -07:00
Andy Wickham
fd35baa3f8 Merge "Revert^2 "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-28 21:57:54 +00:00
Liran Binyamin
43e67c277b Merge "Set the stash handle bounds deterministically" into udc-qpr-dev 2023-07-28 19:54:42 +00:00
Liran Binyamin
5c936d6246 Merge "Don't animate in the bubble bar unless there are bubbles" into udc-qpr-dev 2023-07-28 19:54:29 +00:00
fbaron
bac2cb6149 Add logs around BaseDepthController to investigate b/291401432
Bug: 291401432
Flag: no flag
Test: n/a
Change-Id: I9d2d3c6683c717a4c8373d4241424765de46bb60
2023-07-28 12:03:29 -07:00
Ivan Tkachenko
90a769d1d3 Bubble bar dismiss interaction
A single bubble and the bubble stack dismiss functionality is implemented using `BubbleDragController`. It attaches a touch listener to the corresponding views and handles gesture interactions.
* When the view is long clicked the dragging to dismiss interaction starts. It scales up the dragged view and presents the dismiss view in the bottom of the window.
* When the bubble or the bubble stack is dragged close to the dismiss target area, it gets pulled towards it and sticks to it. The `MagnetizedObject` and `MagneticTarget` classes are used for it.
* When the dragged view is released outside of the dismiss area, it moves back to the initial position with animation.
* When the dragged bubble is released inside of the dismiss area, it will dismiss the bubble with animation and remove it from the stack.
* When the dragged bubble bar stack is released inside the dismiss area, all the bubbles will get dismissed and the bubble bar will dissapear.

Bug: 271466616
Test: manual, TBD
Flag: WM_BUBBLE_BAR
Change-Id: I83393898be61ec522db92688ac2e111ef7d72fe6
2023-07-28 18:17:09 +00:00
Ivan Tkachenko
18373d2a54 Bubble bar dismiss
* Added WMShell related proxy methods.
* Added DismissView dimensions and drawable resources.
* Added DismissView extension file to set it up with dimen and drawable resource ids.

Bug: 271466616
Test: manual, TBD
Flag: WM_BUBBLE_BAR
Change-Id: Iddac977a9c8a63facee45e9dd2eb234bb18d030b
2023-07-28 17:13:09 +00:00
Vinit Nayak
a1d0d8269c Remove split instructions view on split launch success
* We weren't removing the instance of the view
that is created when split initiated from workspace
* Fewer bugs like this once RecentsView + workspace
instructions view are consolidated

Bug: 292590703
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Test: Swiping to home after split apps launch
hides the view

Change-Id: I6b5037c024e6e0c456b687bc802076f691a955b2
2023-07-27 14:11:27 -07:00
Treehugger Robot
42b5cf6ee6 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-07-27 19:23:44 +00:00
Luca Zuccarini
cf5703f614 Merge "Animate depth from the right value on Taskbar All Apps launches." into udc-qpr-dev 2023-07-27 09:58:26 +00:00
Andy Wickham
be8981442a Revert^2 "Change Overview Actions to round buttons."
f849f2856f

Fix: 293081298

Change-Id: Iaf1553770329ec3a6c6d8a2d9d81b60203e79ed8
2023-07-26 20:56:05 +00:00
Bill Yi
ca00f219c2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I129f717c91f3f0cce914a9e6c0a0315ef3720cac
2023-07-26 13:41:04 -07:00
Liran Binyamin
f172c0b3b5 Set the stash handle bounds deterministically
The bounds of the bubble stash handle is calculated based on the bounds of
the bubble bar. The problem is that the bubble bar could be invisible, which
results in incorrect bounds set for the handle.

This change sets the bounds for the handle based on the width of the screen.

Fixes: 290992144
Test: Manual
        - Remove bubbles
        - Restart Launcher
        - Open the bubble test app and double tap on a chat
        - Observe that the handle animates in
Change-Id: Ida260014d59b88387de010891c18057f3b091e93
2023-07-26 15:38:58 -04:00
Liran Binyamin
95d84f5e06 Don't animate in the bubble bar unless there are bubbles
Fixes: 290608658
Test: Manual:
      - Remove all bubbles
      - Lock and unlock device
      - Observe that bubble bar is not displayed

      - Remove all bubbles
      - Restart launcher process
      - Observe that bubble bar is not displayed

Change-Id: I850d307394230968f86abc23ba0b4e94f55e10f0
2023-07-26 15:38:47 -04:00
Treehugger Robot
17988825f2 Merge changes I45b6f858,I28120248 into udc-qpr-dev
* changes:
  Verifying that ViewCapture data is not empty
  Restoring starting capturing existing activity.
2023-07-26 18:33:07 +00:00
Ats Jenk
38a7faf04e Merge "Use hasBeenResumed() for checking if launcher is resumed" into udc-qpr-dev 2023-07-26 18:18:11 +00:00
Treehugger Robot
46c1b631d6 Merge "Add jank monitor for CUJ_QUICK_SWITCH from home screen" into udc-qpr-dev 2023-07-26 16:16:47 +00:00
Luca Zuccarini
627d67549f Animate depth from the right value on Taskbar All Apps launches.
`MyDepthController` in `QuickstepTransitionLauncher` assumes that we
want the background to always animate the same way, matching the rest
state of the workspace (depth == 0). However, in Taskbar All Apps the
background is visible, and depth != 0. We now initialize the one-off
`DepthController` for launches to take into account the latest depth set
by the top level `DepthController`, so there is no jumpcut at the
beginning of the animation.

Note that in my opinion we should use the same `DepthController` for all
cases, rather than having this one-off. I'm looking into the feasibility
of that change, but for now this fixes the issue at hand.

Fix: 292959100
Flag: N/A
Test: manual, see videos in the bug

Change-Id: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
2023-07-26 15:37:44 +00:00
Ats Jenk
cf25610a28 Flag stashing desktop when going home
Put logic to stash desktop apps behind a flag. Turn it off by default.

Bug: 292109910
Flag: persist.wm.debug.desktop_stashing
Test: turn off the flag, open an app on the desktop and go home
      observe that user is taken to home screen and subsequent launches
      are in full screen
      turn on the flag, open app on the desktop and go home
      observe that there is a toast shown for desktop and next app is
      launched to desktop
Change-Id: Ic6f9a3644bb09d4fb877f4694843a7c20969f925
2023-07-25 14:20:00 -07:00