Commit Graph

17488 Commits

Author SHA1 Message Date
Sergey Pinkevich
ead5259f9a Show split screen action for each task
Remove previous condition:
1. `taskView.containsMultipleTasks()` - there is already a check to filter out "Split screen" item: https://googleplex-android.googlesource.com/platform/packages/apps/Launcher3/+/refs/heads/main/quickstep/src/com/android/quickstep/TaskOverlayFactory.java#68

Edit previous condition:
2. `notEnoughTasksToSplit` - condition saying if there is less than 2 recent tasks. We still should give the possibility to split the screen if Taskbar is not presented

Bug: 305958994
Flag: NONE
Test: manual - took a photo (https://screenshot.googleplex.com/7doU5z9AjxxETUo)

Change-Id: I3fdfea987c426d557a91b0a25af368069e8af3f8
2023-11-15 15:14:50 +00:00
Andreas Agvard
0ddc984353 Merge "NavHandleLongPressInputConsumer now cancels long press detection on intercept." into main 2023-11-06 08:43:28 +00:00
Andy Wickham
402ca3e3e5 Merge "Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag" into main 2023-11-04 19:57:39 +00:00
Fengjiang Li
7bfdf5048a Merge "Move android.view.IWindowManager#registerSystemGestureExclusionListener to background thread and inline SystemGestureExclusionListenerCompat in RecentsAnimationDeviceStatet" into main 2023-11-04 06:34:39 +00:00
Treehugger Robot
45d5589336 Merge "Move the "IntFlag:" dump under "DeviceFlag:" section" into main 2023-11-04 00:22:33 +00:00
Priyanka Advani
ebc9a3b5e1 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-11-03 22:10:27 +00:00
Anushree Ganjam
8e2a62e6a9 Move the "IntFlag:" dump under "DeviceFlag:" section
Bug: 309033453
Test: Manual by capturing bug report.
https://screenshot.googleplex.com/5q7fHrxEhC8zZxY.png

Flag: None, adding more print to appear in bug report

Change-Id: I18244d4fcf85fbae0e3f48082606c7d46166c311
2023-11-03 15:00:46 -07:00
Priyanka Advani
9aed56096c Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Reason for revert: Likely culprit for b/309158105

Reverted changes: /q/submissionid:24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Change-Id: I8ee560f7e599bcfde09eff53f049309ba25ce77f
2023-11-03 21:31:45 +00:00
Anushree Ganjam
df9d94a97c Merge "Add the IntFlags too in bugreport in dump() method." into main 2023-11-03 20:14:45 +00:00
Tony Wickham
075a67da15 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-11-03 18:35:54 +00:00
Schneider Victor-tulias
3baa1e0905 Merge "Fix unresponsive swipe up after launching the running app from live tile overview" into main 2023-11-03 15:45:58 +00:00
Andreas Agvard
1fff24df5f NavHandleLongPressInputConsumer now cancels long press detection on intercept.
Before handling a touch event NavHandleLongPressInputConsumer now checks
mDelegate.allowInterceptByParent() to ensure a parent has not intercepted the
touch event.

Flag: LEGACY ENABLE_LONG_PRESS_NAV_HANDLE DISABLED
Bug: 305924072
Test: Manual
Change-Id: I0d7bcceba881a21ad00e56c3e18b4ebde878ee89
2023-11-03 13:29:57 +01:00
Jagrut Desai
2d9f2c1cec Merge "Animate aways Notification Dots for Taskbar Pinning Annimation" into main 2023-11-03 02:02:49 +00:00
Jagrut Desai
61526a7413 Merge "Improvements to TaskbarDividerPopupView" into main 2023-11-03 02:02:28 +00:00
Fengjiang Li
db3d98ae23 Move android.view.IWindowManager#registerSystemGestureExclusionListener to background thread and inline SystemGestureExclusionListenerCompat in RecentsAnimationDeviceStatet
The P99 latency is 30ms, which is very slow. Moving the binder call to BG thread should avoid the jank.

Fix: 299466828
Flag: N/A
Test: test device boot without issue
Change-Id: Ib24584a2608b11f02589d4ea4515a6c91c354351
2023-11-03 10:00:28 +08:00
Anushree Ganjam
7da01ae5a4 Add the IntFlags too in bugreport in dump() method.
Bug: 309033453
Test: Manual
Flag: None, adding more print to appear in bug report
Change-Id: I6fa3ac98820b3ab0c7ef93a6eb4564efae6191d5
2023-11-02 18:26:03 -07:00
Alex Chau
0531f1f624 Merge "Re-land "Update Tapl tests for enable_grid_only_overview"" into main 2023-11-03 01:22:04 +00:00
Jagrut Desai
47bf322e21 Animate aways Notification Dots for Taskbar Pinning Annimation
Test: Manual
Bug: 308460959
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: Ic16881c05c70ed717dc63131d94ece805c39f6fc
2023-11-02 17:39:37 -07:00
Jagrut Desai
9af2084a56 Improvements to TaskbarDividerPopupView
- Close Animation improvement for popup.
- Popup location changed to  16dp above the taskbar view.
- Support for disabled state when user is in 3-button mode. (design changes to come in separate cl)

Test: Manual
Bug: 265170176
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: I9c91e6eb2b29c85433ba1c3d34505f0519448a6f
2023-11-02 17:24:50 -07:00
Jagrut Desai
29ac20ba6a Merge "Fix TaskbarDividerPopupMenu Switch Style" into main 2023-11-02 22:52:19 +00:00
Alex Chau
9c07fc1350 Re-land "Update Tapl tests for enable_grid_only_overview"
- Fix getCurrentTask() to correctly get the top-right tasks in grid only overview. It'll first get the widest task, and then top, and then rightmost task
- Fix scrollLeftByDistance() to correctly account for leftGestureMargin to make sure it scroll by distance provided
- Fix scrollCurrentTaskOffScreen() to actually scroll the task off screen
- Fix createAndLaunchASplitPair() to use Task menu instead of Overview actions for grid only overview
- Skip testOverviewActions() in grid only overview, where Overview actions isn't available
- Fix testOverivewForTablet to expect the correct task in grid only overview; also disabled part of a test due to an animation bug in Overview
- Fix dismissBySwipingUp() to swipe from bottom of task, which is required to effectively dismiss top row tasks
- Also fixed OverviewTask to correctly get objects in FallbackOverview
- Fix touchOutsideContainer() to calcualte y base on container's middle correctly

Bug: 283246928
Test: presubmit
Flag: None
Change-Id: I77e91dcc1a404ade356b29fba6cf967c534c08f4
2023-11-02 22:37:26 +00:00
Jagrut Desai
c554d5fa46 Fix TaskbarDividerPopupMenu Switch Style
we recently added support for settings app style switches to Launcher. Use that style for TaskbarDividerPopupMenu Switch

Test: Manual
Bug: 308682758
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: If61a426e4051ebce67601055942667ed93928d15
2023-11-02 14:23:48 -07:00
Jagrut Desai
52c9160b0d Merge "Close Taskbar All Apps when Taskbar Pinning is animating" into main 2023-11-02 21:18:44 +00:00
Winson Chung
706c34f2df Merge "Add logs & dump for SysUI/Shell interfaces" into main 2023-11-02 20:46:16 +00:00
Tony Wickham
17c62edb71 Merge "Fix 3 button mode issues in AllSetActivity" into udc-qpr-dev am: 7738b6e943 am: 0eba94ad73
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25240828

Change-Id: Id0fde9bc3939be62aaa97714956607cfee6a93f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-02 19:57:26 +00:00
Tony Wickham
0eba94ad73 Merge "Fix 3 button mode issues in AllSetActivity" into udc-qpr-dev am: 7738b6e943
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25240828

Change-Id: Id88a7d427a8a436c2dc7bac2c7dc882d4b56a0cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-02 19:21:22 +00:00
Schneider Victor-tulias
f7e20960e0 Fix unresponsive swipe up after launching the running app from live tile overview
Flag: NONE
Fixes: 245736607
Test: quickly swipe to home after tapping the currently-running task in live tile mode from overview

Change-Id: I3b47ee3645db88bf20e58e673abde7a3b92cef9b
2023-11-02 19:18:11 +00:00
Winson Chung
549eba2c99 Add logs & dump for SysUI/Shell interfaces
- This helps us know if the interfaces are set correctly during a gesture

Bug: 286805673
Test: dumpsys activity service TouchInteractionService
Change-Id: Icebc3d49d299495beb3880eaa591d6e96fdcd27f
2023-11-02 19:16:00 +00:00
Tony Wickham
7738b6e943 Merge "Fix 3 button mode issues in AllSetActivity" into udc-qpr-dev 2023-11-02 18:50:49 +00:00
Pat Manning
8a01ea889f Merge "Shorten app title in overview icon app chip menu." into main 2023-11-02 18:32:53 +00:00
Winson Chung
3e113fef7f Merge "Add logs for starting the home activity directly" into main 2023-11-02 18:18:00 +00:00
Tracy Zhou
109b442a83 Merge "Do not animate icon alignment in phone mode" into main 2023-11-02 16:23:39 +00:00
Pat Manning
616a250b62 Shorten app title in overview icon app chip menu.
- Do not show "work" at the beginning of work apps.
- Do not use the top component name in case any dialogs are on top of app.

Fix: 305988810
Fix: 305983272
Fix: 307231916
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT
Change-Id: I4ce741529c975db778abc540e6c353ea4c76bf11
2023-11-02 14:15:54 +00:00
Alex Chau
39c548bd03 Merge "Revert "Update Tapl tests for enable_grid_only_overview"" into main 2023-11-02 13:36:34 +00:00
Sam Dubey
0552d37f34 Revert "Update Tapl tests for enable_grid_only_overview"
Revert submission 25220083-b/283246928

Reason for revert: b/308930958

Reverted changes: /q/submissionid:25220083-b/283246928

Bug: 283246928
Change-Id: I69ce128061f7ffad213f8f193122b18e5ee9378d
2023-11-02 13:33:55 +00:00
Alex Chau
c543b46070 Merge "Fix TaskViewSimulatorTest to be independent of device it runs on" into main 2023-11-02 11:13:20 +00:00
Alex Chau
25cd358a27 Merge "Update Tapl tests for enable_grid_only_overview" into main 2023-11-02 11:06:03 +00:00
Treehugger Robot
24bb5d95dd Merge "Fix Insets override types can not be changed after the window is added" into main 2023-11-02 03:19:38 +00:00
Tony Wickham
eccf070bae Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: Ib6e592a31a55a912a7ea991a421a9c60bca51c80
2023-11-01 23:16:10 +00:00
Vinit Nayak
a0ed884dfd Merge "Add logs when sysuiProxy clears binder refs" into main 2023-11-01 22:49:17 +00:00
Tracy Zhou
b3fdfc650a Fix Insets override types can not be changed after the window is added
insetsSizeOverrides must have the same length and types according to WindowManagerService#relayoutWindow

Bug: 308441430
Test: manual
Change-Id: I7416a5302c90652e1fa266cc98e3c7825fa17e64
2023-11-01 15:36:45 -07:00
Jagrut Desai
eaef199883 Close Taskbar All Apps when Taskbar Pinning is animating
Test: Manual
Bug: 308488799
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: Iec33ba1acb840bb1cd05c440daab4508e91f2bfc
2023-11-01 15:34:18 -07:00
Alex Chau
3029b8314e Update Tapl tests for enable_grid_only_overview
- Add "task" as id for TaskView, and use it instead of "snapshot" when creating OverviewTask, so that for split tasks are caputred as a whole in getCurrentTask and getTasks
- Fix getCurrentTask() to correctly get the top-right tasks in grid only overview. It'll first get the widest task, and then top, and then rightmost task
- Fix scrollLeftByDistance() to correctly account for leftGestureMargin to make sure it scroll by distance provided
- Fix scrollCurrentTaskOffScreen() to actually scroll the task off screen
- Fix createAndLaunchASplitPair() to use Task menu instead of Overview actions for grid only overview
- Skip testOverviewActions() in grid only overview, where Overview actions isn't available
- Fix testOverivewForTablet to expect the correct task in grid only overview; also disabled part of a test due to an animation bug in Overview
- Fix dismissBySwipingUp() to swipe from bottom of task, which is required to effectively dismiss top row tasks
- Also fixed OverviewTask to correctly get objects in FallbackOverview

Bug: 283246928
Test: presubmit
Flag: None
Change-Id: I5dd39b1779ea02738556f921169dbe38aa4cba8c
2023-11-01 22:15:12 +00:00
Jagrut Desai
524e05b921 Merge "Fix Taskabr Divider Line traveling too far" into main 2023-11-01 22:06:16 +00:00
Winson Chung
642559bbf3 Add logs for starting the home activity directly
- We need to narrow down how home is being started after a recents
  transition

Bug: 285636175
Test: dumpsys activity service TouchInteractionService
Change-Id: I527a69cb045d426f820cfb5c8ba3c95eeff92889
2023-11-01 20:28:49 +00:00
Alex Chau
382e1868c7 Fix TaskViewSimulatorTest to be independent of device it runs on
- Fix TaskViewSimulatorTest to properly set up densityDpi, so the test result is consistent regardless of the device it runs on. Also used SandboxContedxt's putObject() to avoid using reflection

Bug: 283246928
Test: TaskViewSimulatorTest
Flag: None
Change-Id: I926459fa97dd09a266cd017e4a0fb8e658a3509c
2023-11-01 19:51:37 +00:00
Tony Wickham
286fc215e6 Fix 3 button mode issues in AllSetActivity
- Set system bars appearance to light/dark depending on device
  theme to ensure visibility
- Also fix issue where taskbar icons would appear partially
  offscreen and prevent pressing nav buttons if you rotated

Fixes: 293438087
Test: adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
  - Skip to the end (AllSetActivity), and ensure 3 buttons are visible
  - Rotate device and ensure 3 buttons are still visible and functional
  - Will also flash / wipe to the build once it's created
Flag: None
Change-Id: Ie2d9bf1e1d95a6ccbd1f9c592adb51390b21ad85
2023-11-01 17:08:29 +00:00
Thales Lima
9623aaa470 Merge "Change AllApps padding to use a Rect" into main 2023-11-01 12:21:53 +00:00
Andy Wickham
24a50df135 Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag
Bug: 306400785
Bug: 308693847
Test: Manual
Flag: LEGACY ANIMATE_LPNH TEAMFOOD
Change-Id: I996c923e5a1949e6219f900da12e2b5091597750
2023-10-31 23:45:12 -07:00
Bill Yi
8862d8f04d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-10-31 17:46:17 +00:00