Commit Graph

1895 Commits

Author SHA1 Message Date
Shamali Patwa
bb28770a01 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211 am: 962f362912
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: I82c1df4c6ad2a4fa09f700f8f3d73f5fb671141d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:45:06 +00:00
Shamali Patwa
962f362912 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: Ic9b3be62af2271286292cfaf30bda03351c1aaf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:05:01 +00:00
Shamali Patwa
d3f5010ac5 Merge changes from topic "categories" into main
* changes:
  Add a default widget category provider that uses application category.
  Add a feature flag for displaying categorized widget recommendations.
2024-01-31 02:24:05 +00:00
Shamali P
c5fbb42dcb Add a default widget category provider that uses application category.
The category provider can be customized by any launcher via resource
override. For instance, one can override it to provide custom categories
using an allowlist or use a different mechanism such as query play
services.

We still need to get proper strings for categories from UX writer.

Bug: 318410881
Test: WidgetRecommendationCategoryProviderTest
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: I5c4e0d22eaffc8254ddd54356f8c62f00e22a3c4
2024-01-31 00:43:22 +00:00
Shamali P
6a9d114d40 Update OWNERS for picker directory to include new owners.
There are some more files relevant to picker, but this CL covers
directory with the primary picker UI.

Change-Id: I53e174d9cd20396b4f56acb5d9e3cc07ec475ea8
2024-01-30 20:10:24 +00:00
Sebastián Franco
ea73bf5d77 Merge "Removing the Worskapce as a dependency of CellLayout" into main 2024-01-30 02:19:19 +00:00
Shamali Patwa
279544e718 Merge "Add the testDragCustomShortcut back for phones." into main 2024-01-29 20:52:49 +00:00
Charlie Anderson
9147575693 Merge "Add unit tests to WorkspaceItemProcessor for processing apps" into main 2024-01-29 20:27:13 +00:00
Federico Baron
8960937d47 Merge "Fix testDragToFolder test" into main 2024-01-29 19:27:24 +00:00
Shamali P
458825a3fc Add the testDragCustomShortcut back for phones.
testDragCustomShortcut was ignored, but as discussed, enabling it for
phones - where the layout of picker is unchanged.

Bug: 322820039
Test: Un-ignoring the test
Flag: N/A
Change-Id: I3607812befc58c8a46b49a2587dfa6a1b572cd5b
2024-01-29 19:07:03 +00:00
Himanshu Gupta
ea9522eee5 Merge "Adding Test Parameters to Asserts." into main 2024-01-27 04:39:08 +00:00
Charlie Anderson
ca6f66cd88 Add unit tests to WorkspaceItemProcessor for processing apps
- also slightly improve some log messages and simplify some code

Test: presubmit / unit tests
Flag: None
Bug: 294386159
Change-Id: I6f75c0d34bf475d4e20d6250f67a56d5394b9c4e
2024-01-26 15:42:51 -06:00
Sebastian Franco
2986e0b4d1 Removing the Worskapce as a dependency of CellLayout
This will make it easier to test CellLayout, also we should avoid
circular dependencies as much as poisble.

This also allows the CellLayout to be created in other containers
that are not workspace.

Bug: 318417510
Test: creating HotseatReorderUnitTest in follow up cl
Test: TaplReorderWidgets
Test: ReorderAlgorithmUnitTest
Flag: NA
Change-Id: Ic45029a244cb11f8d6775c50b90af9c56f01eaa3
2024-01-26 09:28:57 -08:00
Himanshu Gupta
39d87bf229 Adding Test Parameters to Asserts.
Bug: 320703862
Flag: NA
Test: NA
Change-Id: I1dba86e3a24dc5b67c754087deca8794a38d83a0
2024-01-26 20:23:42 +05:30
Himanshu Gupta
eaeb666e43 Merge "Separating system and user-installed apps in PS container." into main 2024-01-26 14:22:19 +00:00
Jakob Schneider
fc433dd84d Merge "Test Fix: Move UnarchiveBroadcastReceiver to AndroidManifest-common to also support NexusLauncher tests." into main 2024-01-26 10:48:09 +00:00
Himanshu Gupta
0cc11dbcac Separating system and user-installed apps in PS container.
We add a horizontal line separator in PS container which demarcates
user-installed vs system installed apps in private space.
User-installed are shown above the separator, system ones below.

UX Mock: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?node-id=11546%3A310574&mode=dev
Mock Image: https://photos.app.goo.gl/Wj8sJkS7P7bRbovg8
Demo video: https://photos.app.goo.gl/MBw6HpDnf6PJqUfs8

Bug: 308054233
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Test: AlphabeticalAppsListTest
Change-Id: Iad8e289c49a05ac7ef1978bd8e4ebe7aa0add0ca
2024-01-26 11:04:13 +05:30
Rohit Goyal
9977121e8e Test Fix: Move UnarchiveBroadcastReceiver to AndroidManifest-common to also support NexusLauncher tests.
* Currently unarchival tests only pass for Launcher3. We extend the broadcast receiver to AndroidManifest-common to also support NexusLauncher tests.

Test: atest TaplPromiseIconUiTest.java
Bug: 319240622
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I9be459a2a0648063d62538eed20c0a6e7644ad44
2024-01-26 00:40:17 +05:30
fbaron
9a16ca5215 Fix testDragToFolder test
The issue seems to be that when we begin drag we enter spring loaded mode which triggers the 'app swap' interaction, leading us to getting the wrong position for the app icon we're trying to drag into. Using photos app instead of gmail should make it so that we don't enter the app swap operation with playstore, meaning we would get the correct position for play store and we will drag the app there

Fix: 320484402
Flag: NONE
Test: TaplDragTest#testDragToFolder
Change-Id: Id6f09be997046e7c450a2760ee95cc5735ad5673
2024-01-25 10:55:27 -08:00
Sebastián Franco
a808e7ea98 Merge "Moving ReorderPreviewAnimation into it's own file and rewrite to Kotlin." into main 2024-01-25 17:16:25 +00:00
Himanshu Gupta
f591ce5f17 Restricting Accessibility flows for Private Profile.
Adding PS apps to the home screen is restricted.
This CL prevents the same from accessibility drags.

Bug: 289223923
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_accessibility_drag DEVELOPEMENT
Test: Ran Launcher3 Tests.
Change-Id: I3e2b7b196b96a4d2ba34d8ece5fd6e0463f17253
2024-01-25 04:19:20 +00:00
Sebastian Franco
f7654252b1 Moving ReorderPreviewAnimation into it's own file and rewrite to Kotlin.
This will make it easier to write unit testing.

Fix: 294473336
Test: manual testing
Flag: NA
Change-Id: I2d6cfd8110c5c2ef09c49150a0bd071bc948995c
2024-01-24 14:04:48 -08:00
Uwais Ashraf
77b97c0729 Replace existing Robolectric test task with functioning one.
This CL does the following:
- Creates a dir for multivalentTests
- Creates symlinks for the dir to keep Android Studio happy
- Moves many files to the multivalentTests dir
- Adjusts gradle and soong build files to use the new dir as part of
their source sets.

Test: ./gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Fix: 316553886
Bug: 316553889
Flag: NA
Change-Id: Iae28fd0c0191b3ecf9bd2950800875950cca2622
2024-01-19 21:39:23 +00:00
Vadim Tryshev
82bf25b017 Merge "Adding TestStabiility so that demoting transitioningToUnlocked_resetCallsPendingRunnable from presubmit works" into main 2024-01-19 21:14:20 +00:00
Fengjiang Li
a6142fff95 Merge "Fix flaky ExecutorRunnableTest" into main 2024-01-19 21:05:23 +00:00
Fengjiang Li
8e2797c52e Fix flaky ExecutorRunnableTest
Use lock to pause/resume execution of Executor

Fix: 316588649
Test: Unit test
Flag: NONE
Change-Id: I5a3c5dece279c6bdaaba579754678108b4bf75b8
2024-01-19 11:44:17 -08:00
Vadim Tryshev
840a97d7ff Adding TestStabiility so that demoting transitioningToUnlocked_resetCallsPendingRunnable from presubmit works
Bug: 320703862
Test: presubmit
Flag: N/A
Change-Id: Ie0e49ffb4d1efabe1c79fac9342f186f15f8cf23
2024-01-19 18:28:05 +00:00
Vadim Tryshev
a3e2c59716 Merge "Demoting unstable transitioningToUnlocked_resetCallsPendingRunnable from presubmit" into main 2024-01-18 18:14:11 +00:00
Rohit Goyal
d16a574524 Merge "Add support for progress bar for archived apps in AllApps view." into main 2024-01-18 17:56:04 +00:00
Sunny Goyal
7c44333f0e Merge "Using WidgetInflater in loader task" into main 2024-01-17 19:21:31 +00:00
Vadim Tryshev
5952119e94 Demoting unstable transitioningToUnlocked_resetCallsPendingRunnable from presubmit
Bug: 320703862
Test: presubmit
Flag: N/A
Change-Id: Ic4de468540a02c316a60a30ae73fe2de7bf51933
2024-01-17 10:24:04 -08:00
Rohit Goyal
04fe042e83 Add support for progress bar for archived apps in AllApps view.
Working Video: https://drive.google.com/file/d/1-cSD63FQLmqyeTkUuXqcSsjb03m31ULO/view?usp=sharing

Test: TaplPromiseIconUiTest
Bug: 302115555
Bug: 317108448
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iebaa338789430c5e0a004bd8b05bdbda87cd986e
2024-01-17 22:49:08 +05:30
Himanshu Gupta
ce495f13e3 Adding suport for Private Space QsTile fulfillment.
Adding logic to unlock private space and
scroll to the container after unlock event
is received by Launcher.

This change also moves pieces of Private Space
Animation to different classes, in order to make
it more robust.

Bug: 289024009
Test: atest PrivateProfileManagerTest
Flag: ACONFIG com.google.android.apps.nexuslauncher.inject_private_space_tile TEAMFOOD
Change-Id: Ica2fbc00ff3516ed5aca7fbbfc0bd2aa036a4cee
2024-01-15 18:43:27 +05:30
Sunny Goyal
d24d33925a Using WidgetInflater in loader task
This removes duplicate logic for widget inflation.
Since the widget inflation can now happen during loader,
the restore logging can also be moved completely to the loader

Bug: 318539160
Test: atest TaplBinderTests
Flag: None
Change-Id: If9f336e7bf49ee7df121d7d9852b674d98124895
2024-01-14 00:56:51 -08:00
Sunny Goyal
6449a21062 Fixing some launcher model tests
> Removing static mocks and using Sandbox context instead
> Removing inheritence in LauncherModel and converting LauncherApps.Callbacks
  to a separate class. decMaker sometimes fails because of API changes in
  LauncherApps.Callbacks

Bug: 319877828
Test: atest LoaderTaskTest
Flag: N/A
Change-Id: If78b5d83595627a355b284f52d887d75fef53014
2024-01-12 12:30:52 -08:00
Vadim Tryshev
6cdb1de48d Merge "Making testAllAppsFromHome platinum" into main 2024-01-12 01:25:48 +00:00
Vadim Tryshev
04947de324 Merge "Re-promoting testDragToFolder to postsubmit" into main 2024-01-11 19:21:43 +00:00
Federico Baron
50af953c6b Merge "Add PreviewItemManager unit test to check if icons are themed when they shoudl be in folder previews" into main 2024-01-09 23:30:13 +00:00
Vadim Tryshev
0df6404e6e Re-promoting testDragToFolder to postsubmit
Also fixing it. When tapping outside of the folder to close it, avoiding touching the gesture area.

Bug: 187761685, 233075289
Test: presubmit, abtd
Flag: N/A
Change-Id: I99ada9e3d681f93a6d079827f1d4c5451a562266
2024-01-09 21:38:52 +00:00
Jordan Silva
07af3b06ac Merge "Update responsive grid spec cell size remainderSpace logic" into main 2024-01-09 12:52:10 +00:00
Sunny Goyal
3c52d93131 Merge "Fixing broken build" into main 2024-01-08 23:48:52 +00:00
Jordan Silva
2de6a277b7 Update responsive grid spec cell size remainderSpace logic
Refactoring the cellSize spec of responsive grid to divide the remainder space in code instead of dividing by cols/rows in the spec definition. For example, instead of using 0.2 in the spec for 5x5 grid (1 / number of rows), it is going to use 1 (100% of the remainder space) and divide the percentage by the number of cols or rows in code.

Fix: 313621277
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: NexusLauncherImageTests
Test: CalculatedWorkspaceSpecTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: Ifaec838ac9751562ecedc1fe39b966ee3d092de3
2024-01-08 19:40:01 -03:00
Vadim Tryshev
0896b68cb5 Merge "Removing dependency of All Apps test from 1P apps" into main 2024-01-08 20:39:45 +00:00
Sunny Goyal
87ad18b667 Fixing broken build
Bug: 319078785
Test: atest TaplPromiseIconUiTest
Flag: N/A
Change-Id: Ie8a11c4928f4b33a631de951e7cc62b5511e2e98
2024-01-08 09:04:10 -08:00
Vadim Tryshev
38d395be3e Removing dependency of All Apps test from 1P apps
Test: presubmit
Flag: N/A
Bug: 187761685
Change-Id: I8b3894a383416cea08c56c8874e6974323ffdc3a
2024-01-05 19:02:30 -08:00
Brandon Dayauon
8b35defbaf Merge "Fix right-bottom corner edge to curve in PS container." into main 2024-01-06 01:20:04 +00:00
fbaron
0f2ca91b8b Add PreviewItemManager unit test to check if icons are themed when they shoudl be in folder previews
Fix: 317417863
Test: PreviewItemManagerTest
Flag: NONE
Change-Id: I067a8d9d2ef4890e816d44ee62f7f5c1119cdd83
2024-01-05 16:01:58 -08:00
Jagrut Desai
ec88372892 Merge "Fixing com.android.launcher3.ui.widget.TaplAddWidgetTest#testDragIcon" into main 2024-01-05 23:34:27 +00:00
Brandon Dayauon
17477dbf42 Fix right-bottom corner edge to curve in PS container.
This happens when there isn't enough apps to fill in the private space container.

* Added test to check the correct regions are being set depending on the apps in the list.
* Need to set ROUND_BOTTOM_RIGHT to the last app item and the decorator would take care of it.
* Changed to use mNumAppsPerRowAllApps that is already set in ctor.

bug: 316116551
Test: manual/presubmit/photos:
before: https://screenshot.googleplex.com/4Uo5Vtu3a6MDuGa
after: https://screenshot.googleplex.com/878g8yv5LgPsHaL
Flag: None
Change-Id: Ic481628b824c75e5578f3129e3a48f575c6a3655
2024-01-05 13:54:46 -08:00
Jagrut Desai
a7cf2ac11b Fixing com.android.launcher3.ui.widget.TaplAddWidgetTest#testDragIcon
Test: Presubmit
Bug: 316910614
Flag: NONE
Change-Id: I7728664ddae5538dabaa8a78de6c4c3b84e3c2d6
2024-01-05 10:00:22 -08:00