Commit Graph

14505 Commits

Author SHA1 Message Date
Toni Barzic
e5fc903495 Disable pinning popup when transient taskbar is disabled
On freeform displays where taskbar is always pinned, toggling "Always
show taskbar" option is no-op, as the taskbar won't transition to
transient taskbar.
Left a TODO to reevaluate behavior once desktop taskbar transient
behavior gets updated.

Bug: 390665752
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: Manual.

Change-Id: Icfe7cd26e77de48ab34bfe4932bfedfe21923ef1
2025-04-18 22:59:55 +00:00
Charlie Anderson
8ec6581db0 Merge "Update system shortcut icons to filled GM3 versions" into main 2025-04-18 13:20:51 -07:00
Mykola Podolian
93a7212f7e Merge "Fix bubble bar drag-to-dismiss target over the taskbar interruption" into main 2025-04-18 10:43:22 -07:00
Surbhi Kadam
77dadc1fc5 Merge "Launcher3: send token with early wakeup request to SurfaceFlinger" into main 2025-04-18 09:48:11 -07:00
Treehugger Robot
c562b3ce4e Merge "Fix a crash on null getLegacyBaseTask" into main 2025-04-17 21:51:27 -07:00
Jagrut Desai
a0fc328fa2 Merge "Fix Taskbar issue with Multi Desks" into main 2025-04-17 20:15:35 -07:00
Jagrut Desai
120250f0db Merge "Fix pinned Taksbar in Overview Modal Launcher state." into main 2025-04-17 16:54:14 -07:00
Jagrut Desai
9205db6d36 Fix Taskbar issue with Multi Desks
Test: Manual, Presubmit
Bug: 408236390
Bug: 408059650
Flag: EXEMPT bugfix
Change-Id: Iadd79fb1504e2183fee52cc0871fc27613482e2a
2025-04-17 15:02:27 -07:00
Treehugger Robot
efd9b79a4c Merge "Remove feature flag for OverviewCommandHelper timeout" into main 2025-04-17 14:33:39 -07:00
Fengjiang Li
dda14192b7 Merge "[Taskbar] Add taskbar root view on per-window-thread" into main 2025-04-17 12:51:01 -07:00
Jagrut Desai
51be868783 Fix pinned Taksbar in Overview Modal Launcher state.
Test: Manual
Bug: 406681846
Flag: EXEMPT bugfix
Change-Id: Icaf4fefdc6e1085b865a438817f5c62d473c6edd
2025-04-17 11:12:50 -07:00
minch
95922915a1 Fix a crash on null getLegacyBaseTask
Bug: 410090695
Test: m
Flag: EXEMPT crash fix
Change-Id: I4b198764f182bf31769860619842feeb2191e583
2025-04-17 16:52:15 +00:00
Jordan Silva
612b58b344 Merge "Fix Drag to launch desktop still shows app chip" into main 2025-04-17 08:36:33 -07:00
Jordan Silva
5713bf2ef0 Remove feature flag for OverviewCommandHelper timeout
Fix: 409608875
Flag: EXEMPT Flag removal.
Test: OverviewCommandHelperTest.kt
Change-Id: I094eed94620665b8b089716b2cfe15773243e573
2025-04-17 08:36:06 -07:00
Alex Chau
bb5958ec48 Merge "Clean-up enableDesktopWindowingCarouselDetach and refactor detachDesktopCarousel" into main 2025-04-17 07:04:21 -07:00
Alex Chau
e4413f929d Clean-up enableDesktopWindowingCarouselDetach and refactor detachDesktopCarousel
- Removed enableDesktopWindowingCarouselDetach flag
- detachDesktopCarousel is now always false, except in home quick switch (QuickSwitchState)
- Updated home quick switch controller NoButtonQuickSwitchTouchController to apply DESKTOP_CAROUSEL_DETACH_PROGRESS

Fix: 411127271
Test: manual
Flag: EXEMPT flag cleanup and refactor
Change-Id: I1cbf0987b111d0111cb8b9b6c7994f4494780e1a
2025-04-17 05:08:41 -07:00
Jordan Silva
46cb63d619 Fix Drag to launch desktop still shows app chip
Extract logic for `settledProgressFullscreen` to `TaskView` to reuse it in subclasses.
`DesktopTaskView` now uses `updateSettledProgressFullscreen` instead of updating `settledProgressFullscreen` directly.

Fix: 406236028
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual. Drag a Desktop tile to launch.
Change-Id: I31bab76e44dbe5219c65b9dc3654e0988bf77fef
2025-04-17 10:31:54 +01:00
Alex Chau
5951ff0bcd Merge "Recents keyboard switch on focused display" into main 2025-04-17 01:51:29 -07:00
Treehugger Robot
1205b1da1c Merge "Remove AllAppsState history override." into main 2025-04-16 22:38:40 -07:00
Treehugger Robot
73779be7cd Merge "Change the handling of shouldBlurWorkspace in LauncherState." into main 2025-04-16 22:09:21 -07:00
Treehugger Robot
5d21ff5374 Merge "Get the animation duration from the res file" into main 2025-04-16 21:02:20 -07:00
Andy Wickham
bebe570201 Remove AllAppsState history override.
This was introduced with the Rocket Gesture but causes a weird
transition when quickly going from an app to All Apps and invoking
Back, because it thought the previous state was BACKGROUND_APP.

The default just treats the previous state as NORMAL, which is
correct for All Apps. The OVERVIEW case was also an even older
path when you could access All Apps from Overview.

Bug: Can't find it right now.
Test: Open app, quickly go home and to all apps, invoke back.
Flag: EXEMPT bugfix
Change-Id: I76cad48abdba9b621e80d2f0cc0414b59fa35725
2025-04-17 02:41:51 +00:00
Andy Wickham
e3371d32f5 Change the handling of shouldBlurWorkspace in LauncherState.
Previously: blur if previous and next state want it blurred.
New: blur if previous OR next state want it blurred.

As part of this, change the default from true to false. Only All
Apps currently sets it to true, meaning we blur workspace only
going to or from All Apps.

Fix: 405836159
Test: Launch app, quickly go home and to All Apps
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic52c5aa2dce7e1e107418952031574bc2e47e585
2025-04-17 02:31:50 +00:00
Fengjiang Li
d952514e04 [Taskbar] Add taskbar root view on per-window-thread
1. Add LooperExecutor in TaskbarManager
2. Add taskbar root view to window in that LooperThread if flag is on

Bug: 404636836
Test: presubmit
Flag: com.android.launcher3.enable_taskbar_ui_thread
Change-Id: I45c6db760b1aafbd186d433ae6f15292f7fe5b43
2025-04-16 19:03:53 -07:00
Treehugger Robot
dfda4408cf Merge "Cleaning up useActivityOverlay flag" into main 2025-04-16 19:00:18 -07:00
Treehugger Robot
2711f8d0d9 Merge "Removing flag enable_smartspace_removal_toggle" into main 2025-04-16 18:57:40 -07:00
mpodolian
eeaa58556b Fix bubble bar drag-to-dismiss target over the taskbar interruption
Added an additional check for BubbleDragController drag state
to the TaskbarStashViaTouchController. T

Bug: 410908600
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual.
  1. Go to overview screen with a transient taskbar.
  2. Create any bubble.
  3. Collapse the bubble bar.
  4. Drag the collapsed bar towards the dismiss target location
     (usually bottom center) ensuring the drag path crosses
     the taskbar area. Verify dismissal works correctly without
     interference from the taskbar touch handling.
Change-Id: I8c58135359dc6ea30479a778caa8e7b6eebc9c80
2025-04-16 18:18:56 -07:00
Mykola Podolian
5373ecfe4f Merge "Revert^2 "Maximised the taskbar window to the default size"" into main 2025-04-16 17:20:13 -07:00
Treehugger Robot
8a45dc2cd1 Merge "Make static DisplayController methods respect display id" into main 2025-04-16 17:10:04 -07:00
Anushree Ganjam
ac37e33a17 Merge "Remove flag "enable_shortcut_dont_suggest_app" since it's eligible to be removed." into main 2025-04-16 16:34:58 -07:00
mpodolian
de74f01f01 Revert^2 "Maximised the taskbar window to the default size"
This reverts commit 28f664a3cb.

Reason for revert: Check if the presubmit passes

Change-Id: Ic1336d8620916b98eaca3656ed844e1d5f181254
2025-04-16 14:31:12 -07:00
Brian Isganitis
793fbd17b0 Merge "Defer updating alignment when LayoutTransition is running." into main 2025-04-16 13:21:23 -07:00
Alex Chau
baa84629ce Merge "Log LAUNCHER_OVERVIEW_ACTIONS_SCREENSHOT/SELECT with ItemInfo" into main 2025-04-16 12:21:59 -07:00
Anushree Ganjam
f6d039c9ab Remove flag "enable_shortcut_dont_suggest_app" since it's eligible to be removed.
Bug: 409611054
Test: Presubmit, Verified "Don't suggest app" shortcut works fine for predicted apps.
Flag: EXEMPT Flag removal
Change-Id: Icb92f3519760ad0dc27e10d9690505c737b9dd25
2025-04-16 18:16:39 +00:00
minch
c2b0c5465a Get the animation duration from the res file
Bug: 408060477
Test: m
Flag: EXEMPT refactor
Change-Id: I7e3f4240f515bd8f5e7737218299a7b34be5b532
2025-04-16 17:57:56 +00:00
Treehugger Robot
3a245f5fc2 Merge "Consolidate how we're cleaning up from split in recents" into main 2025-04-16 10:55:59 -07:00
Sunny Goyal
613db2b609 Removing flag enable_smartspace_removal_toggle
Test: Presubmit
Flag: EXEMPT cleanup
Bug: 303471576
Change-Id: Iae8cc3afbf15c66612589fd1e19377e4339af7fc
2025-04-16 10:54:45 -07:00
Treehugger Robot
a9bb3b53a5 Merge "Adds Blur and BlurFallback styles for All Apps." into main 2025-04-16 10:21:48 -07:00
Liana Kazanova (xWF)
5f8e946293 Merge "Revert "Maximised the taskbar window to the default size"" into main 2025-04-16 10:08:52 -07:00
Sunny Goyal
0b22c5d9ee Cleaning up useActivityOverlay flag
Bug: 409606388
Test: Presubmit
Flag: EXEMPT cleanup
Change-Id: I0c9b4885dc6d8678b85443571d4714921825c1eb
2025-04-16 08:36:50 -07:00
Vinit Nayak
ac743912a0 Merge "Pass split info to PreviewPositionHelper" into main 2025-04-16 08:11:28 -07:00
Will Osborn
135e6f999f Recents keyboard switch on focused display
Use the focused display for overview show and toggle commands from keyboard events

Bug: 404854138
Test: local + presubmits
Flag: com.android.launcher3.enable_overview_on_connected_displays

Change-Id: I0e88a4312c3157e318fe2629c9fc27fe9e582351
2025-04-16 14:56:55 +00:00
Treehugger Robot
ab20ede66c Merge "Fix gesture distance for quick switch home with multiple desks" into main 2025-04-16 07:56:22 -07:00
Treehugger Robot
50e28c7f72 Merge changes I8f716461,I2be3b8c8 into main
* changes:
  [Taskbar] Make TaskbarManager.mTaskbars thread safe
  [Taskbar] Declear aconfig flag to render taskbar on per-window ui thread
2025-04-16 06:51:06 -07:00
Will Osborn
7efffe621a Make static DisplayController methods respect display id
Bug: 404854138
Test: local + presubmits
Flag: com.android.launcher3.enable_overview_on_connected_displays
Change-Id: Ica46a400101b1b0126355ef842ca5d8b9be20306
2025-04-16 13:45:29 +00:00
Treehugger Robot
71981575d0 Merge "Remove flag private_space_app_installer_button." into main 2025-04-16 02:12:23 -07:00
Holly Sun
bd5c455302 Remove flag private_space_app_installer_button.
Bug: 409610010
Test: verified PS app install button stills works
Flag: EXEMPT flag removal
Change-Id: I7fd606ab0fd939bcb1202861d89c3996b241c105
2025-04-15 20:45:59 -07:00
Brian Isganitis
6b4b65f42b Defer updating alignment when LayoutTransition is running.
This fixes a problem of 3-button variant of pinned taskbar. The code for updating the alignment (taskbar to hotseat) animation clashes with LayoutTransition, leading to weird icon states. This change coordinates these two animation systems.

Fix: 409442851
Test: ABTD cherrypick to Q2 release candidate (manual)
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Change-Id: Ifa80c384500a9cd3e65090ee39487977a2ac3b5d
2025-04-15 23:26:21 -04:00
Fengjiang Li
f33545b864 [Taskbar] Make TaskbarManager.mTaskbars thread safe
Convert SparseArray<TaskbarActivityContext> into Map<Integer, TaskbarActivityContext>
And use ConcurrentHashMap if flag is on, otherwise HashMap

Bug: 404636836
Test: presubmit
Flag: com.android.launcher3.enable_taskbar_ui_thread
Change-Id: I8f7164616f205d789f60da50d64ce05ae25d9735
2025-04-15 19:33:05 -07:00
Surbhi Kadam
301befd012 Launcher3: send token with early wakeup request to SurfaceFlinger
Passes a binder token to SurfaceFlinger and adds tracing for debugging

Bug: 323292798
Test: presubmit
Flag: EXEMPT log only update; bugfix

Change-Id: I7875bd6a2498a938af236ffda783f7c265cdd874
2025-04-16 00:03:58 +00:00