Commit Graph

61 Commits

Author SHA1 Message Date
Vadim Tryshev
684233e257 resolve merge conflicts of 6df1743d23 to main
Test: I solemnly swear I tested this conflict resolution.
Bug: None
Change-Id: I92c19785709187592c5aaa9f5ee8141d3af0e194
2025-02-26 11:08:36 -08:00
Owner Cleanup Bot
cd33516a5c [owners] Remove mateuszc@google.com from tests/multivalentTests/shared/com/android/launcher3/testing/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.

Please approve this change and vote the highest CR. This will keep the OWNERs
file tidy.  We ask that you do not ignore this change and approve it
unless you know a reason the OWNER should remain.  It can always be
reverted if needed.

If this change is in error, vote the lowest CR value (i.e. reject the CL)
and the bot will abandon it.

See the owner's recent review activity for context:
https://android-review.googlesource.com/q/mateuszc@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: Ib310e8949235516783ea820d35fa113e06cd34c3
2025-02-26 09:44:59 -08:00
Sunny Goyal
a39a09ba6a Replacing custom parcelables with platform types for test APIs
Bug: 377772352
Flag: EXEMPT test only
Test: Presubmit
Change-Id: Ie464c67adf6502aee1fe65ef643e1a67260b820f
2024-12-26 17:19:15 -08:00
Sukesh Ram
fc6cc4e409 Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 324419890
Test: Manual
Change-Id: I54145d07f0699f68c44aaa34e1692c8fe2f7b780
2024-10-16 16:55:45 -07:00
Jagrut Desai
85a8898402 Remove unused TestProtocol
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: Ibe261ec8820f5d6e8415f5085c21a0adfef37462
2024-10-01 09:24:38 -07:00
Sukesh Ram
e297bc0c0e Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 326908466
Test: Manual
Change-Id: I01dadc884929a8946f408997ddbcbd0ac4c820ec
2024-09-26 19:44:55 +00:00
Alex Chau
03aa04d45b Revert "Adds new log constant to track overview select tooltip misalignment"
This reverts commit cbc8bf0443.

Reason for revert: b/332485341 is fixed, revert logging constant previous added

Change-Id: I970a3af9905037a51bd9748324f35ac80de9b06b
2024-09-16 10:37:50 +00:00
Alex Chau
fdbfd3410b Clean-up debug logs
Fix: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ie66a34134881e4333f610d8979b2ac443d54a1cb
2024-08-20 19:01:19 +01:00
Alex Chau
6d00b4b014 Read task size info from RecentsView directly
- Automatically determine the Overivew component to use the correct RecentsViewContainer
- Also added log on both pre-computed taskSize and newly calculated task size

Bug: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ic0adfba35af513e731007241416fc85760135f07
2024-08-20 10:56:52 +01:00
Alex Chau
d326e17fe2 Add logs for getFocusedTaskHeightForTablet
Bug: 336660988
Bug: 360724626
Test: presubmit
Flag: TEST_ONLY
Change-Id: I67d4fc8211f24b77566bd24525d23054dfdded6e
2024-08-19 20:39:41 +01:00
Anushree Ganjam
5c4ea5b0ca Remove debug logs
Bug: 339737008
Test: Manual
Flag: TEST_ONLY
Change-Id: I8177fc721f330267bc20abf6e7d587289e45477b
2024-08-07 14:08:10 -07:00
Andrew Cole
940917b92e Merge "Test Week - Deleting NexusTestInformationHandler" into main 2024-07-17 22:33:47 +00:00
Andrew Cole
d798e6d1f9 Test Week - Deleting NexusTestInformationHandler
NexusTestInformationHandler only relied on one boolean switch that is not currently used so I am deleting it.

Bug: 353303621
Test: TAPL
Flag: TEST_ONLY
Change-Id: I6181d47561b318d1eb1bd632d4ae042e126cfdb9
2024-07-15 11:57:47 -07:00
Anushree Ganjam
f828683fa8 Add debug logs to print stack trace for Private space flaky test.
From the failure test videos, it looks like scrollToTop gets called https://b.corp.google.com/issues/339737008#comment15.

Bug: 339737008
Test: Manual
Flag: TEST_ONLY
Change-Id: I61a95ff45fa4409f8f1b243ac435002556a16677
2024-07-10 13:44:11 -07:00
Schneider Victor-tulias
38b9e1438e Merge "Clean up unused debug logs for b/319168409" into main 2024-06-03 20:31:42 +00:00
Schneider Victor-tulias
43592a83c8 Clean up unused debug logs for b/319168409
Flag: NONE removing debug logs
Fixes: 319168409
Test: TaplDragTest#testDragAppIcon
Change-Id: I73208b042248df04281d52eaf3ed6832abbfc144
2024-06-03 12:05:40 -04:00
Jagrut Desai
98eac2c1b2 Merge "Removing TWO_NEXUS_LAUNCHER_ACTIVITY_WHILE_UNLOCKING" into main 2024-05-31 20:40:54 +00:00
Jagrut Desai
1eb576905a Removing TWO_NEXUS_LAUNCHER_ACTIVITY_WHILE_UNLOCKING
Test: Presubmit
Bug: 273347463
Flag: TEST_ONLY
Change-Id: Idcd49b857e6f6c2832211306c90a19c88fb2a224
2024-05-31 11:01:50 -07:00
Tracy Zhou
acb4a3d1e8 Support trackpad tapl tests in 3-button mode
Currently we have logic to only enable input monitor when a trackpad is connected. Tapl tests need to have infrastructure to override that logic

Bug: 335146977
Test: presubmit
Change-Id: Ib7f80c828760f8b5abd7ed2788b246e47fca6e34
2024-05-29 21:58:20 -07:00
Vadim Tryshev
575d15f231 Cleaning up TestProtocol
Bug: 262282528, 279059025, 322823209
Test: presubmit
Flag: N/A
Change-Id: I9af6e3f1fc49b2ebf0d99df8c4514de0bddee8f2
2024-05-10 11:03:24 -07:00
Sukesh Ram
60cab37a23 Remove Logs for TaplOverviewIconTest#testOverviewActionsMenu
Remove logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: Ie19cdb10234fd50fc64f259b5dafe9881162e23d
2024-05-08 22:29:48 +00:00
Schneider Victor-tulias
8288819aa6 Add debug logs for b/319168409
Flag: N/A
Bug: 319168409
Test: TaplDragTest#testDragAppIcon

Change-Id: I96d26cc78af0a3f4145fc3486c4b6adfbd110c9e
2024-05-06 16:22:03 +00:00
Sukesh Ram
05d48b3986 Debug TaplAddConfigWidgetTest test
Flag: NONE
Bug: 324419890
Test: Check logs when flake is reproduced
Change-Id: I90b419aa300df53247fc07e00aabe575a33fb95f
2024-05-02 20:32:09 +00:00
Treehugger Robot
9960f43a5c Merge "Adds new log constant to track overview select tooltip misalignment" into main 2024-04-22 20:24:28 +00:00
Jordan Silva
cbc8bf0443 Adds new log constant to track overview select tooltip misalignment
Bug: 332485341
Flag: N/A
Test: atest OverviewSelectTooltipImageTest
Change-Id: Ic1a9ad4e1e9e9b95774a4a1edac92ea79c75cec6
2024-04-22 17:39:31 +01:00
Schneider Victor-tulias
abf9f308a5 Remove debug tracing for b/332386996
Flag: N/A
Fixes: 332386996
Test: TaplTestsQuickstep
Change-Id: I0d0aa5d5654dbf391269333eb4808d36f5e645ed
2024-04-22 16:16:42 +00:00
Schneider Victor-tulias
3f8eea99e3 Remove debug tracing for b/321775748
Flag: N/A
Fixes: 321775748
Test: FallbackRecentsTest
Change-Id: I1f746bf43025e093e94e60f8a1561f4f6a0f9b22
2024-04-22 09:55:49 -04:00
Priyanka Advani
4e97c94559 Revert^3 "Wait for LauncherModel loaded in waitForLauncherInitialized"
This reverts commit 503ce966ef.

Reason for revert: Culprit for test breakages in b/334995023. Will be verifying through ABTD for confirmation and before submitting the revert.

Change-Id: Id8707cb2074b4f00ec332ebb14deb7d143ff1bbb
2024-04-15 22:18:31 +00:00
Schneider Victor-tulias
503ce966ef Revert^2 "Wait for LauncherModel loaded in waitForLauncherInitialized"
This reverts commit b80c6c347a.

Reason for revert: The original change was not the cause for the test failures

Change-Id: Icfe0da43a96f5471076554c4dd25eae649bee81e
2024-04-15 15:58:19 +00:00
Liana Kazanova
b80c6c347a Revert "Wait for LauncherModel loaded in waitForLauncherInitialized"
This reverts commit f8f00f4233.

Reason for revert: DroidMonitor: Potential culprit for http://b/334162623.  verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Id165df41a87af4757abd3266b8643949ce012a08
2024-04-12 21:30:50 +00:00
Schneider Victor-tulias
f8f00f4233 Wait for LauncherModel loaded in waitForLauncherInitialized
Flag: N/A
Fixes: 326737440
Test: Launcher TAPL tests
Change-Id: I631b370198c393ad84419930c026b6a0ce63ec2b
2024-04-12 12:48:48 -04:00
Schneider Victor-tulias
d3b014ea91 Add debug logs for b/321775748
Flag: N/A
Bug: 321775748
Test: FallbackRecentsTest
Change-Id: I0dde08c4e6b2942713274d2ae29e52d5504ea25d
2024-03-25 14:24:35 -04:00
Fengjiang Li
e90f098d4f Enable predictive back in TAPL tests
With ag/26349940 we have fixed the bug where back swipe is not working

Fix: 326118348
Test: this is the test
Flag: NONE
Change-Id: I7e826f6ba3022a04d016d4a0a2134e287d85e8be
2024-03-15 00:00:37 -07:00
Sukesh Ram
73b07daab3 Add logs for TaplAddConfigWidgetTest test
Flag: NONE
Bug: 324419890
Test: Check logs when flake is reproduced
Change-Id: I2fdb1e4f96c8095a387280c79e074ee42eb0010c
2024-03-07 18:53:15 +00:00
Vinit Nayak
91b06fb4ac Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-04 12:26:23 -08:00
PODISHETTY KUMAR
b588e4618b Merge "Revert "Implements the "Save App Pair" button in Overview Actions"" into main 2024-03-01 09:27:08 +00:00
Vinit Nayak
5c8978c4db Revert "Implements the "Save App Pair" button in Overview Actions"
Revert submission 26391074-save-app-pair-button

Reason for revert: breaks image comparison tests b/327665771
Reverted changes: /q/submissionid:26391074-save-app-pair-button

Change-Id: Ic4580fc39d8394771551f100932157e6ef35c4b7
2024-03-01 01:02:35 +00:00
Jeremy Sim
8c383aceda Merge "Implements the "Save App Pair" button in Overview Actions" into main 2024-02-29 19:47:20 +00:00
Vadim Tryshev
0fa523bb32 Merge "Removing logging for verifying internal Launcher state from tests" into main 2024-02-29 19:18:04 +00:00
Jeremy Sim
41d8ae8a7a Implements the "Save App Pair" button in Overview Actions
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!

This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.

Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
2024-02-28 19:39:04 -08:00
Sukesh Ram
872b9f9a61 Debugging Logs for TaplDragTest#testDragAppIconToMultipleWorkspaceCells
Add logging for TaplDragTest#testDragAppIconToMultipleWorkspaceCells.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326908466
Change-Id: Icb3262d6af66c9b947cb0cc92c1c67556fba315f
2024-02-28 19:28:07 +00:00
Sukesh Ram
1909570ed3 Debugging Logs for TaplOverviewIconTest#testOverviewActionsMenu
Add logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: I5f08192bb1143c1d23f8884bb207ce69c5830a41
2024-02-28 01:06:14 +00:00
Treehugger Robot
90182bffc1 Merge "Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-02-28 00:02:38 +00:00
Vadim Tryshev
dae8b65dea Removing logging for verifying internal Launcher state from tests
Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: I25afcc30446d429171445f8e1b6033b277166725
2024-02-27 20:23:49 +00:00
Sukesh Ram
41c2a9a900 Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: I1309e8c1b2ce7b6c06cb520818ef109bbf2f2d23
2024-02-27 19:36:55 +00:00
Helen Cheuk
96fd73ed84 Merge "Stash taskbar when software keyboard is docked" into main 2024-02-27 10:40:07 +00:00
Vadim Tryshev
c94b2a7045 Add tracing for a bug where current RecentsActivity is null
Bug: 321775748
Test: presubmit
Flag: N/A
Change-Id: I46fde7a73a3bfe02ed6276b4ac5f3e6c33bda387
2024-02-22 16:19:16 -08:00
helencheuk
00ddb5e3a9 Stash taskbar when software keyboard is docked
Stash taskbar when
1) Software keybaord is docked
2) Input toolbar is placed at the taskbar area (stash so toolbar and taskbar would not overlap)

Testing result:
https://drive.google.com/file/d/1NMDexHl0FgyHFaOUh_GSEEUU2k08STJH/view?usp=sharing

Bug: 317251202
Test: TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet
Flag: N/A

Change-Id: I90662bc6e68f644e919f5c702059476b02519ed6
2024-02-21 23:03:03 +00:00
Tracy Zhou
0c801cbd20 Merge "Guard taskbar / navbar unification logic with whether the device is a phone on top of the flag" into main 2024-02-16 17:51:03 +00:00
Tracy Zhou
89f72882ce Guard taskbar / navbar unification logic with whether the device is a phone on top of the flag
Test: Rerun the tapl tests
Bug: 325162802
Change-Id: Iffeeb0a60b634e66bc80e4ba45db816cdc8ba564
2024-02-15 22:06:33 -08:00