Commit Graph

1028 Commits

Author SHA1 Message Date
Helen Cheuk
e07207678b Merge "Fix performance issue caused by triggering hover focus animation accidentally" into main 2024-05-01 21:56:26 +00:00
Vinit Nayak
4cb712b8d6 Merge "Allow single root candidate for app pair launch for pip edge case" into main 2024-05-01 18:43:59 +00:00
helencheuk
ef31d0a35e Fix performance issue caused by triggering hover focus animation accidentally
HoverAnimator and FocusAnimator are triggered unexpectedly on state transition. When it is already disabled, it is disabled again when user swipes to All Apps and triggers animators. Add checking to not trigger animator when the new enable status is the same as the current one.

Bug: 333688227
Test: Ran v2/android-crystalball-eng/health/microbench/systemui/main/systemui-misc-1-jank-suite in ab/
Flag: N/A
Change-Id: I090490f1c78a3427225c24bc536e1767700ec6c3
2024-05-01 17:15:12 +01:00
Gustav Sennton
f74d8b7264 Re-fetch DesktopVisibilityController when needed instead of just once
When creating DesktopTaskbarRunningAppsController the Quickstep Launcher
might not be available, meaning we pass a null
DesktopVisibilityController to DesktopTaskbarRunningAppsController.
With this CL we refetch DesktopVisibilityController whenever needed.

Bug: 338035946
Test: manual, and DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT
Change-Id: I8b806e2d0addbf8fb5ab6a3d419a4691c445f223
2024-04-30 16:07:13 +00:00
Gustav Sennton
0eaf9ebdaa Remove references to FEATURE_PC and related Desktop classes in Launcher
Also clean up TaskbarRecentAppsController APIs

Flag: NA
Test: DesktopTaskbarRunningAppsControllerTest
Bug: 330551930
Change-Id: Ibd9c3d6aa1d5423b51a48ed0a972196752d5199a
2024-04-30 13:15:28 +00:00
Vinit Nayak
23b85ffdba Allow single root candidate for app pair launch for pip edge case
* Shell will launch single task if requested split apps have one of them
already in Pip
* Create a separate method to set animation for launching from the
appPair icon on workspace
* Reuse the animation method for launching an AppPair icon from taskbar
by specifying which windowing mode to look for if we're launching the
actual split pair vs just one in fullscreen

Bug: 323089902
Test: Launches fine visually
Change-Id: I415343a48e980afd7f4e511558d350cf15b97ca1
2024-04-29 18:52:58 -07:00
Vadim Tryshev
edfa8480a9 Merge "Saving test artifacts in TAPL when the failure is diagnosed" into main 2024-04-29 20:49:15 +00:00
Federico Baron
f22abdb2ec Merge "Revert "Add screenrecord to test with "Only System UI views are visible" message"" into main 2024-04-29 19:50:14 +00:00
Vadim Tryshev
7a4d696bbb Saving test artifacts in TAPL when the failure is diagnosed
Not waiting for FailureWatcher to catch the exception and save
artifacts. This will help to save test artifacts before potential
deinitialization in the test which may change the screen contents.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I7aa95028acfae3fe0895fc5df4ea6f6912fcda52
2024-04-29 11:53:08 -07:00
Federico Baron
d77a57178e Revert "Add screenrecord to test with "Only System UI views are visible" message"
This reverts commit 3f58b471af.

Reason for revert: issue resolved

Change-Id: Ifa8806b6460f4243c9e38e2e6c63ec22dcc7d8f6
2024-04-29 16:47:38 +00:00
Gustav Sennton
56f9df0620 Merge "[Desktop Mode] Show indicators under Taskbar app icons for running apps" into main 2024-04-29 08:28:28 +00:00
Treehugger Robot
1b21277b1d Merge "Add TAPL tests for PredictionRow." into main 2024-04-27 01:13:02 +00:00
Anushree Ganjam
5a2b0ff434 Add TAPL tests for PredictionRow.
This will help us catch and debug following issues
* Prediction row view is missing
* Prediction row view doesn't contain enough apps

Bug: 332171918
Test: Manual
Flag: NA

Change-Id: I11035997afb26799a2c3b69d5139b4f3c28fc405
2024-04-26 16:27:41 -07:00
Gustav Sennton
52a8b7e24b [Desktop Mode] Show indicators under Taskbar app icons for running apps
In Desktop Mode we show running Desktop apps in the Taskbar. With this
change we also show an indicator under the app icon for each such
running app.

Bug: 332504528
Test: manual
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT
Change-Id: If0906dab8ad0bd8a78d93a4e99db47550e763bed
2024-04-26 15:29:00 +00:00
Anushree Ganjam
1c7ca89191 Merge "Add Uninstall App test for private space apps." into main 2024-04-26 02:54:33 +00:00
Anushree Ganjam
7690f8744e Add Uninstall App test for private space apps.
Doc: go/private-space-tapl

Bug: 322882655
Test: Manual, TAPL
Flag: NA

Change-Id: I96598ad2d78e68ea0ac3bd7872243c231810023b
2024-04-25 16:28:19 -07:00
Daniel Akinola
e91b4b52ee Merge "Revert "Force calculator to launch in fullscreen for taskbar tests"" into main 2024-04-25 17:56:47 +00:00
Daniel Akinola
2a19774bbe Merge "Revert "Force calculator to launch in fullscreen for quickswitch tests"" into main 2024-04-25 17:56:47 +00:00
Daniel Akinola
56ccf74899 Revert "Force calculator to launch in fullscreen for taskbar tests"
This reverts commit 8771dfe3dd.

Reason for revert: was only a temporary fix while investigating issue, should be unnecessary after ag/27089675 is landed.

Change-Id: I5963dc77f31eb45c1cdd100788b045891de2d716
2024-04-25 15:49:06 +00:00
Daniel Akinola
4e955ed606 Revert "Force calculator to launch in fullscreen for quickswitch tests"
This reverts commit 41fcfc1f72.

Reason for revert: was only a temporary fix while investigating issue, should be unnecessary after ag/27089675 is landed.

Change-Id: Ic1ab614cfc0e7bf4b82c8d0eaa1662fd4129932a
2024-04-25 15:47:57 +00:00
Jagrut Desai
52442466e8 Merge "Promote TaplTestsPersistentTaskbar to Presubmit" into main 2024-04-25 00:55:07 +00:00
Jagrut Desai
884dbdac37 Promote TaplTestsPersistentTaskbar to Presubmit
Test: Presubmit
Bug: 320490387
Flag: NONE
Change-Id: Ib09ac5d3e909864b9ef2c20a6dda79e4ed857227
2024-04-24 16:12:56 -07:00
Jordan Silva
d889ee37c9 Merge "Add a refactored TaskThumbnailView" into main 2024-04-24 11:53:17 +00:00
Himanshu Gupta
6fc5e7a010 Merge "Adding Tapl tests for User Installed App in PS." into main 2024-04-24 09:25:28 +00:00
Daniel Akinola
a0ce634e2c Merge "Force calculator to launch in fullscreen for quickswitch tests" into main 2024-04-23 22:33:50 +00:00
Uwais Ashraf
e21525da40 Add a refactored TaskThumbnailView
- Live Tile, swipe (left+right) and dismiss working
- Tests of ViewModel state transitions
- Deprecate the old TaskThumbnailView
- Renaming TaskThumbnailView to TaskThumbnailViewDeprecated

Fix: 335440878
Fix: 331754672
Bug: 331753115
Test: TaskThumbnailViewModelTest
Test: Attached video on bug
Flag: ACONFIG com.android.launcher3.enable_refactor_task_thumbnail DEVELOPMENT
Change-Id: I063b957fe6e56960970dcaadc641848fbd73251c
2024-04-23 23:05:14 +01:00
Sunny Goyal
edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
dakinola
41fcfc1f72 Force calculator to launch in fullscreen for quickswitch tests
Follow on to ag/27050655 to fix last flaking test suite, while investigating proper fix

Bug: 333446588
Bug: 333446588
Flag: None
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsKeyboardQuickSwitch
Test: forrest build with CL (https://android-build.corp.google.com/builds/abtd/run/L47500030003265061)
Change-Id: I28df139779af49b7bc8da567cfe67e5d43b224e9
2024-04-23 16:49:23 +00:00
Himanshu Gupta
102b723d63 Adding Tapl tests for User Installed App in PS.
This test verifies that a user installed app
is shown above the sys apps divider, within the
Private Space container.

Bug: 322882655
Test: atest NexusLauncherTests:com.android.quickstep.TaplPrivateSpaceTest
Flag: NA
Change-Id: Id85105339ae45c263d9ef52a3bb55784587e887d
2024-04-23 15:22:43 +01:00
Gustav Sennton
568e0bff90 Merge "Show running apps in Taskbar when in Desktop Mode" into main 2024-04-23 14:02:11 +00:00
Gustav Sennton
0b33b172fb Show running apps in Taskbar when in Desktop Mode
In Desktop Mode: show currently running (Desktop) apps in Taskbar

Bug: 332504528
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT

Change-Id: I10dec022f4b16562e81d7cbd5f9ce835474e9d20
2024-04-23 10:43:27 +00:00
Sunny Goyal
10fa016352 Fixing MainThreadInitializedObject
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
2024-04-22 17:04:33 -07:00
dakinola
8771dfe3dd Force calculator to launch in fullscreen for taskbar tests
Taskbar tests are flaking when desktop windowing is enabled due to calculator app being launched in splitscreen unexpectedly during test setup (due to unexpected effect of DesktopModeLaunchParamsModifier on activity launch.) While looking into root cause, this temporary fix to address the test failures ensures that calculator app is always launched in fullscreen, by enforcing it with ActivityOptions.

Bug: 333446588
Bug: 333446588
Flag: None
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
Test: forrest build with CL (https://android-build.corp.google.com/builds/abtd/run/L47500030003265061)
Change-Id: If12e8490214aa1dd5de89ff8535495c2a0c1fe82
2024-04-22 21:42:09 +00:00
Federico Baron
e419495cc9 Merge "Add screenrecord for TaplPrivateSpaceTest#testPrivateContainerIsPresent" into main 2024-04-22 21:05:47 +00:00
Federico Baron
9a5bdb3b3f Merge "Add screenrecord to test with "Only System UI views are visible" message" into main 2024-04-22 20:28:27 +00:00
fbaron
3f58b471af Add screenrecord to test with "Only System UI views are visible" message
Flag: none
Test: TaplTestsTrackpad#switchToOverview
Bug: 335674307
Change-Id: Icabc13814163deaecaa14dd12bbd41f62074b4d5
2024-04-22 11:28:25 -07:00
fbaron
4f836430a7 Add screenrecord for TaplPrivateSpaceTest#testPrivateContainerIsPresent
Bug: 334946529
Test: TaplPrivateSpaceTest#testPrivateContainerIsPresent
Flag: none
Change-Id: I8f2d97c4d29d91389c3d20558ea6e3977deb322c
2024-04-22 09:58:53 -07:00
Treehugger Robot
774d05e970 Merge "Remove debug tracing for b/321775748" into main 2024-04-22 16:35:32 +00:00
Schneider Victor-tulias
3f8eea99e3 Remove debug tracing for b/321775748
Flag: N/A
Fixes: 321775748
Test: FallbackRecentsTest
Change-Id: I1f746bf43025e093e94e60f8a1561f4f6a0f9b22
2024-04-22 09:55:49 -04:00
Liran Binyamin
4d91e16589 Merge "Give bubble team owners on launcher bubble dirs" into main 2024-04-18 18:45:54 +00:00
Liran Binyamin
b8ae441c10 Give bubble team owners on launcher bubble dirs
Flag: N/A
Test: treehugger
Bug: none
Change-Id: Ic5f69f34a1561ffb5a879a88b1532754e4b38f42
2024-04-18 12:18:21 -04:00
Eghosa Ewansiha-Vlachavas
f6ea0a3a2b Merge "Gate new desktop task menu button with device config check" into main 2024-04-18 15:02:52 +00:00
Eghosa Ewansiha-Vlachavas
e885e54d90 Gate new desktop task menu button with device config check
Desktop windowing is enabled only when the desktop windowing flag is
enabled and the device is supported through setting a device config
flag. Add this device config check to the desktop task menu button so it
does not appear if the device is not compatible.

Flag: NONE
Fixes: 335178869
Test: atest -c NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest
Change-Id: Ia2559c1ff57bb7921867e69a47d868c03eae57e7
2024-04-18 11:47:55 +00:00
Treehugger Robot
d955d23028 Merge "Fix KQS first task focux when there is only one recent task" into main 2024-04-16 20:53:34 +00:00
Schneider Victor-tulias
3b6e45d095 Fix KQS first task focux when there is only one recent task
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 335257398
Test: TaplTestsKeyboardQuickSwitch#testLaunchSingleRecentTask
Change-Id: Ibf1514394c29c33ea1dde9e3704af231e2d039f2
2024-04-16 15:08:31 -04:00
Federico Baron
6188ec4157 Merge "Make hotseat column span responsive" into main 2024-04-16 17:17:55 +00:00
fbaron
e4b0b71faa Make hotseat column span responsive
Flag: NONE
Test: DeviceProfileDumpTest, DeviceProfileAlternativeDumpTest, HomeScreenImageTest
Bug: 325084912
Change-Id: Ifa9e8066662a1ab053f66b8800b739d813d2dab8
2024-04-16 06:19:16 +00:00
Jagrut Desai
7a6036516c Merge "Remove PortraitLandscape from the TaplTestsTransientTaskbar" into main 2024-04-15 18:51:18 +00:00
Vadim Tryshev
bb760dbbbd Merge "Promote goToOverviewFromApp to presubmit" into main 2024-04-13 01:12:04 +00:00
Vadim Tryshev
a46a55ed05 Promote goToOverviewFromApp to presubmit
It's stable now:
https://android-build.corp.google.com/test_hub/search/?filter=&invfilter=unhealthyInvocations&invfilter=staleInvocations&tab=tests&query=branch%3agit_main%20target%3a%28cf_x86_64_phone-trunk_staging-userdebug%7ccf_x86_64_tablet-trunk_staging-userdebug%7ccf_x86_64_foldable-trunk_staging-userdebug%29%20config%3a%28v2%2fgnl-eng%2funbundled%2flauncher%2fnexus_unit_test_multi_device_platform%7cv2%2fgnl-eng%2funbundled%2flauncher%2fnexus_oop_test_multi_device_platform%7cv2%2fgnl-eng%2funbundled%2flauncher%2flauncher3_test_platform%29%20test%3a%22com.android.quickstep.FallbackRecentsTest%23goToOverviewFromApp%22

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I9c8777b976e2683aecdfa7f97950dee4c5661a11
2024-04-11 20:14:07 +00:00