Commit Graph

12244 Commits

Author SHA1 Message Date
Ats Jenk
dff855e702 Merge "Update bubble bar stash and unstash animation" into main 2024-08-30 19:30:14 +00:00
Mady Mellor
669445f707 Merge "Don't show the app badge on app bubbles" into main 2024-08-30 19:08:24 +00:00
Mady Mellor
3808adc58c Don't show the app badge on app bubbles
Flag: com.android.wm.shell.enable_bubble_anything
Test: manual - add an app bubble to bubble bar, observe it's not
               badged (with sysui CL)
Bug: 342245211
Change-Id: I768fa9bb478eeaba587b90d478f32f8c2ee88be1
2024-08-30 09:52:45 -07:00
Mady Mellor
c4c5057c08 Merge "Follow RegionSamplingHelper being moved into shell" into main 2024-08-30 16:49:32 +00:00
Treehugger Robot
5b0e061b4e Merge "Only refresh TaskThumbnailViewDeprecated if runningTaskShowScreenshot has changed" into main 2024-08-30 15:46:20 +00:00
Schneider Victor-tulias
211751676c Merge changes I3e97ec83,Ib47a8a7f into main
* changes:
  Update KQS UX to better support square aspect ratio devices
  Update KQS recents apps and desktop mode launching UX
2024-08-30 13:48:05 +00:00
Schneider Victor-tulias
f0a6d1df57 Update KQS UX to better support square aspect ratio devices
Flag: EXEMPT ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 357512178
Test: Used KQS on a square device
Change-Id: I3e97ec834512521b417f2e707a6838c96bef5752
2024-08-30 13:47:38 +00:00
Schneider Victor-tulias
55c0c5e75d Update KQS recents apps and desktop mode launching UX
- Updated recent apps KQS task view
- Added a desktop mode KQS task view
- Did some code cleanup to support this more cleanly

Flag: EXEMPT ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 357512178
Test: Used KQS with and without desktop mode; opened recent apps and desktop mode
Change-Id: Ib47a8a7f41b56af1ba9d0cbec65ababf8aad7881
2024-08-30 13:46:23 +00:00
Alex Chau
31d465937b Only refresh TaskThumbnailViewDeprecated if runningTaskShowScreenshot has changed
- This is a follow-up of ag/28922223, which caused a RECENTS_SCROLLING jank regression
- The regression is probably caused by TaskThumbnailViewDeprecated unnecessarily redrawing, the fix is to only redraw when needed
- Also combined setShouldShowScreenshot and refreshThumbnails into a single method, so we can easily check inside TaskView if a refresh is necessary
- Centralize screenshotTasks logic into RecentsViewUtils, and centralize thumbnailView refreshing inside TaksView.setShouldShowScreenshot

Fix: 362294538
Test: Invoke Omnient or Screenshot hardware button on live tile, verify running task switches to screenshot after overlay closes
Test: Select/Screenshot swithces to screenshot normally
Flag: EXEMPT BUG_FIX
Change-Id: I7c6e73e52ebf18e7c59bb9afea029246b92681d2
2024-08-30 14:46:22 +01:00
Treehugger Robot
8da23e8c91 Merge "Refactoring OverviewCommandHelper (2/3)" into main 2024-08-30 13:31:58 +00:00
Treehugger Robot
09398bf183 Merge "Refactoring OverviewCommandHelper (1/3)" into main 2024-08-30 12:44:26 +00:00
Jordan Silva
ebfae18529 Refactoring OverviewCommandHelper (2/3)
This CL should not affect the behavior of OverviewCommandHelper.
- It splits executeCommand into smaller functions
- Rearrange public/private functions
- Adds extra logs.

Bug: 352046797
Bug: 351122926
Flag: EXEMPT bugfix.
Test: Manual.
Change-Id: I283f179794af812973a559db6291febe19e3c6d7
2024-08-30 12:30:54 +01:00
Ats Jenk
9ab2b8c785 Update bubble bar stash and unstash animation
Bubble bar should stash and unstash from the handle.
Update the animation to match what is used for the taskbar animation.
Fix the stash handle reveal animation to animate the stash bounds to
bubble bar bounds and back.
This gives the effect of the handle morphing into the bubble bar and
bubble bar morphing back into the handle.

Bug: 345680453
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest TransientBubbleStashControllerTest
Test: have bubbles in bubble bar and be in app, swipe up for taskbar and
  observe the bubble bar handle transforming into the bubble bar
Test: with taskbar and bubbles expanded, check that bubble bar
  transforms into the handle
Change-Id: I8508e9207092774cbdb990e65f7f84e56a924d0c
2024-08-29 22:34:19 -07:00
Winson Chung
380f11e9d5 Merge "5/ Remove unused recents code" into main 2024-08-30 03:00:49 +00:00
Treehugger Robot
5cfb887b68 Merge "Fix bug where PredictedIcon circle/dot flicker." into main 2024-08-30 01:02:19 +00:00
Treehugger Robot
e7efecc52c Merge "Add some info about the overflow in bubble bar dump" into main 2024-08-30 00:24:53 +00:00
Winson Chung
d159e61166 5/ Remove unused recents code
- The shell transit flag is already hardcoded to true in Launcher
  so we can remove the non-shell transit paths
- The minimized split was from legacy splitscreen where launcher would
  show in a minimized state, which is no longer the case

Flag: EXEMPT bugfix
Bug: 359608026
Test: atest NexusLauncherTests
Change-Id: Idea46fc065485233b9e508dae3ebc4ee87c29ba6
Signed-off-by: Winson Chung <winsonc@google.com>
2024-08-29 23:17:23 +00:00
Treehugger Robot
313b559076 Merge "[Predictive Back] Clean up flags" into main 2024-08-29 22:46:13 +00:00
Treehugger Robot
03cace2e6b Merge "Only handle taps on bubble bar when it was collapsed/stashed on down" into main 2024-08-29 22:37:49 +00:00
Jagrut Desai
9657710f29 Merge "Refactor TaskbarIconSpecs and TaskbarSpecsEvaluator" into main 2024-08-29 21:44:04 +00:00
Jagrut Desai
bc98db6820 Merge "Use TaskbarAllAppsButtonContainer and TaskbarDividerContainer in TaskbarView" into main 2024-08-29 21:44:04 +00:00
Mady Mellor
cc843823a6 Add some info about the overflow in bubble bar dump
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - add some bubbles to bubble bar, take a BR and look
               at the dump
Bug: 358304168
Change-Id: I91e50591df166e928d06ba9a29f69f923218de71
2024-08-29 14:20:38 -07:00
Treehugger Robot
9025fe918b Merge "FloatingWidgetView - avoid calling position callback when nothing changes." into main 2024-08-29 21:02:17 +00:00
Fengjiang Li
1f25f6405c [Predictive Back] Clean up flags
Fix: 270614790
Flag: NONE - clean up flag
Test: presubmit
Change-Id: I956ce6067dca5d2517b45046ae8a392df1023e49
2024-08-29 13:38:05 -07:00
Mady Mellor
4290d3cab1 Only handle taps on bubble bar when it was collapsed/stashed on down
When bubbles are expanded and you tap on the currently opened
bubble, the stack collapses. In the input consumer code, we also
get that tap & we handle it because at the "up" event at that time,
we're collapsed (or stashed in some cases). To fix this, only handle
the "up" event for the bar being collapsed / stashed, if it was in
that state when the gesture started (i.e. on down)

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 362165243
Test: manual - expand bubble bar in home / overview
             - tap on the currently expanded bubble
             => observe the animation is smooth
             - expand bubble bar in app
             - tap on currently expanded bubble
             => observe the animation is smooth
Change-Id: I1861af15c88bc0cbf2514faac7464de2f85aad1e
2024-08-29 11:39:40 -07:00
Mady Mellor
8104ad3321 Follow RegionSamplingHelper being moved into shell
- update imports for usages in launcher

Flag: EXEMPT updating imports & bp file for class moving to sysui
Test: make; gradle build for launcher; treehugger
Bug: 353160491
Change-Id: I6d9d004e8ab6f67f494927424d2651c5b848e967
2024-08-29 11:17:04 -07:00
Jagrut Desai
6060db4970 Use TaskbarAllAppsButtonContainer and TaskbarDividerContainer in TaskbarView
This cl includes
	- Usage of TaskbarAllAppsButtonContainer and TaskbarDividerContainer in TaskbarView. This can be seen as a refactor.
	- Animation refactor related to all apps button container refactor

Test: Presubmit
Bug: 356465292
Flag: com.android.launcher3.enable_taskbar_customization

Change-Id: I5b7c4f56aacac18fc6872f77b15e2e9ae896799e
2024-08-29 11:11:35 -07:00
Vinay Joglekar
858b76e7ed Merge "(1/2) Fix NPE for title description broken by ag/28991306. It can be nullable initially before its set." into main 2024-08-29 10:58:10 +00:00
Anushree Ganjam
7310809645 Merge "Setup Dagger for Launcher (1/n)" into main 2024-08-28 23:38:33 +00:00
Jagrut Desai
62fb48d247 Merge "Extend DesktopVisibilityController Funcationality to handle taskbar corner radius in desktop windowing mode" into main 2024-08-28 23:36:08 +00:00
Zak Cohen
7f9985af96 FloatingWidgetView - avoid calling position callback when nothing changes.
Previously, the position changed callback for the transition animation
was called on every layout change, whether or not the position has changed.

Now only call the callback and the layout changes if the targets don't
match the current state.

Bug: 327696338
Flag: EXEMPT bug fix
Test: manual
Change-Id: I3007a1c8d0a869866c66eb14d75f5b48d977f863
2024-08-28 16:33:03 -07:00
Treehugger Robot
f73bca7a2c Merge "Make TasksRepository listen to changes in task visuals and update" into main 2024-08-28 22:31:22 +00:00
Treehugger Robot
cf4666fbad Merge "Honors three_button_corner_swipe flag." into main 2024-08-28 21:25:45 +00:00
Anushree Ganjam
bd8633133f Setup Dagger for Launcher (1/n)
Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration
Change-Id: Idbe19f1aa747f519417e21fe8a23a41c52ececc1
2024-08-28 12:11:47 -07:00
Uwais Ashraf
7640d97421 Make TasksRepository listen to changes in task visuals and update
To do this TaskVisualsChangedDelegate was added which multiplexes two listeners that are closely related.

Thumbnail overriding capabilities were also removed.

Fix: 342560598
Test: TaskVisualsChangedDelegateTest, TasksRepositoryTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: If065e4179cd1f15fe2cdf9b6bae51afcb57abcc6
2024-08-28 18:18:31 +00:00
Liam, Lee Pong Lam
60dfc4375e Ignore three finger trackpad for nav handle long press
To disable Omient trigger by three finger trackpad

Bug: 342143522
Flag: com.android.launcher3.ignore_three_finger_trackpad_for_nav_handle_long_press
Test: Manual

Change-Id: Ic283a4a376a6e628d6c16d6fd4088a9f5e10a0c5
# Conflicts:
#	aconfig/launcher.aconfig
2024-08-28 17:48:28 +00:00
Jagrut Desai
dd737b590c Refactor TaskbarIconSpecs and TaskbarSpecsEvaluator
This cl includes
	- Because of IconNormalizer bug we are inflating iconsizes to match the specs.
	- specs changed from row x column to column X row.

Test: Presubmit
Bug: 356465292
Flag: com.android.launcher3.enable_taskbar_customization
Change-Id: I4b4856da92053149267e66a187f744c9c00ea3d9
2024-08-28 09:58:33 -07:00
Tracy Zhou
9c12d8ff41 Merge "Skip nav button animation in gesture nav mode" into main 2024-08-28 16:34:45 +00:00
Jordan Silva
e7ae4e31ae Refactoring OverviewCommandHelper (1/3)
- Updates pendingCommands to be a ConcurrentLinkedDeque and make the list safe across multiple threads.
- Introduces CommandStatus to clear only IDLE and COMPLETED commands.
- Adds CommandType enum to prevent adding an invalid command value into the queue and having an unexpected behavior.
- Log messages improved

Bug: 352046797
Bug: 351122926
Flag: EXEMPT bugfix.
Test: Manual.
Change-Id: I80705dca0be579e62cb9e2bd923808dd33c4d633
2024-08-28 17:09:29 +01:00
Jon Miranda
9bcdb1cbe9 Fix bug where PredictedIcon circle/dot flicker.
The issue is that the PredictedIcon in the Taskbar would draw
right before we swap to the matching icon in the Hotseat.

Fixes: 362677520
Test: launch predicted app icon from hotseat, swipe to go home
Flag: EXEMPT bugfix
Change-Id: Iab8b707edf846b257c7fb7cacc9008e5c66353a7
2024-08-28 08:35:14 -07:00
Vinay Joglekar
c41fb6baf3 (1/2) Fix NPE for title description broken by ag/28991306. It can be nullable initially before its set.
Test: Manual
Bug: 345789862
Flag: EXEMPT bugfix
Change-Id: I6c26d10a142e8a5f132d47c0559e6b23a1968bd2
2024-08-28 15:04:19 +00:00
Treehugger Robot
4fd9449d64 Merge "Convert DigitalWellBeingToast to Kotlin" into main 2024-08-28 12:22:03 +00:00
Pat Manning
632444a266 Merge "Add 4dp vertical offset to taskbar hover tooltip." into main 2024-08-28 11:07:25 +00:00
Alex Chau
141a4c9857 Convert DigitalWellBeingToast to Kotlin
Bug: DigitalWellBeingToast
Test: manual
Flag: EXEMPT refactor
Change-Id: I9998269b32e89725e311c3ca88e924a55c196412
2024-08-28 11:46:15 +01:00
Tracy Zhou
4cbceb1208 Skip nav button animation in gesture nav mode
- Also removed unused rotation button code
- Skip adding certain property holders in phone mode
- Update FLAG_SMALL_SCREEN value from isPhoneButtonNavMode to isPhoneMode, so that it's more aligned with what the name suggests (it shouldn't affect the functionality regardless as the view is invisible in small screen)

Based on https://b.corp.google.com/issues/361593564#comment4

Bug: 361593564
Test: manual
Flag: EXEMPT bugfix
Change-Id: I1de7fa061a6c6aba9f949a0bcf8cfced84273e3f
2024-08-27 21:15:55 -07:00
Tracy Zhou
59a4dfdcd8 Merge "Skip taskbar animations from launcher state changes in phone mode" into main 2024-08-28 00:19:54 +00:00
Treehugger Robot
4503c2c60c Merge "Polish transition between desktop mode and overview" into main 2024-08-27 23:57:21 +00:00
Tracy Zhou
65eaea39cc Merge "Skip animating stashed handle color based on color sampling if it's the same" into main 2024-08-27 18:41:43 +00:00
Schneider Victor-tulias
51433debcd Polish transition between desktop mode and overview
Fixing desktop task in place along the x-axis and animating its background's alpha to more smoothly handle the transition.

Flag: com.android.launcher3.enable_desktop_task_alpha_animation
Fixes: 320307666
Test: swiped to and from desktop mode and overview
Change-Id: I38d62d0c966733f96c2f4d4ecfa4a9418039fd48
2024-08-27 18:15:06 +00:00
Tracy Zhou
111d05c913 Skip taskbar animations from launcher state changes in phone mode
Based on https://b.corp.google.com/issues/361593564#comment4

Bug: 361593564
Test: manual
Flag: EXEMPT bugfix
Change-Id: I93d1cfc3b0eaec6b9496d13acc14d20c4de6d3b1
2024-08-27 09:33:05 -07:00