Commit Graph

2763 Commits

Author SHA1 Message Date
Sunny Goyal
dfc22b8ff1 Fixing recents command not working properly in gesture mode
Bug: 185445289
Test: Manual
Change-Id: I233ee493ea0d42bbfca14b17e921d907cc65da53
2021-04-16 12:13:31 -07:00
TreeHugger Robot
c874ccc163 Merge "Fix regression where StaggeredWorkspaceAnim didn't respect animateScrim" into sc-dev 2021-04-15 17:39:01 +00:00
Vinit Nayak
0a19747cae Merge "Revert "Make RotationTouchHelper singleton to report single rotation state"" into sc-dev 2021-04-15 05:38:18 +00:00
Vinit Nayak
08f3d4d675 Revert "Make RotationTouchHelper singleton to report single rotation state"
This reverts commit d8ad6b25f4.

Reason for revert: b/185382799, b/185383656

Change-Id: Ie500fd5c4f2937df56fbd8afe5556f1a71b90d87
2021-04-15 01:50:02 +00:00
Tony Wickham
01320be908 Fix regression where StaggeredWorkspaceAnim didn't respect animateScrim
Before, this happened to work because we skipped setting the scrim when
doing an atomic animation, but the atomic animation code has been
removed. Add an explicit SKIP_SCRIM config flag instead.

Test: swipe up from overview to home, ensure scrim animates nicely

Bug: 185411781
Change-Id: I7bc14a11d9d416cc7336ea29d21107dcdbdbf782
2021-04-14 14:54:44 -07:00
TreeHugger Robot
9a7281c51e Merge "Add logs to help debug TwoButtonNavBarTouchController" into sc-dev 2021-04-14 19:40:54 +00:00
Andy Wickham
3aea671e4f Merge "Updates quickswitch animation from Launcher." into sc-dev 2021-04-14 01:56:36 +00:00
TreeHugger Robot
047f2ed9b8 Merge "Remove SystemUiProxy#monitorGestureInput() as it's no longer used" into sc-dev 2021-04-14 00:14:36 +00:00
TreeHugger Robot
cc339a5587 Merge "Fixing race condition when an apk is removed." into sc-dev 2021-04-14 00:04:48 +00:00
Tony Wickham
7b2e3df2d7 Add logs to help debug TwoButtonNavBarTouchController
Test: TaplTestsQuickstep#testSwitchToOverview()

Bug: 13714484
Change-Id: I21740ac0fd6ddf2923fd081a00c84a463f13673b
2021-04-13 16:45:41 -07:00
Vinit Nayak
91b83064e1 Merge "Make RotationTouchHelper singleton to report single rotation state" into sc-dev 2021-04-13 22:43:07 +00:00
Andy Wickham
18694a2545 Updates quickswitch animation from Launcher.
- Workspace/All Apps/Hotseat no longer translate down
 - Fading of these elements and scaling of Workspace are tied to the
   wallpaper depth animation
 - At any point in the drag, you can still swipe up to enter Overview

This makes it feel like the apps are tied to the wallpaper and avoids
moving them orthogonally to the finger.

It also makes the "No recent items" animation more elegant.

Demo: https://drive.google.com/file/d/1phuRCqb69vuMp3ijS6PR5lTEcBHScjie/view?usp=sharing&resourcekey=0-2HXtMLUhQ-YU53hYlYV-fQ
Demo with no recent apps: https://drive.google.com/file/d/1wjexqznxs9ZhiUtCDW4-ZK6c7hKDRaXn/view?usp=sharing&resourcekey=0-GugbpJK8_cnFbUBB2Ar30w

Fixes: 174228745
Test: Manual
Change-Id: I1574ff89a0f382b7e63bf03cf4300ec7c695cfec
2021-04-13 15:35:46 -07:00
Tony Wickham
9ac8b781b9 Remove SystemUiProxy#monitorGestureInput() as it's no longer used
Test: compiles and runs locally
Bug: 185266621
Change-Id: I4d40de269007178550cf1a9e9e906018badc6f74
2021-04-13 14:29:19 -07:00
Tony Wickham
a5788cc24f Merge "Move taskbar to be closer to QSB" into sc-dev 2021-04-13 21:12:49 +00:00
Sunny Goyal
79ee3f6310 Fixing race condition when an apk is removed.
Since the check was happening on a different thread, the view might have change by the time
the callback comes back on UI thread.

Bug: 185100744
Test: Manual
Change-Id: I1347819bee71ed9d7ba6aa676f4318ea03316ea2
2021-04-13 13:43:25 -07:00
Rob Carr
a3ba0f9f6d Merge "Launcher3: Port SurfaceTransactionApplier to BLAST" into sc-dev 2021-04-13 19:47:25 +00:00
Tony Wickham
5df03e1585 Merge changes from topic "taskbar-hotseat" into sc-dev
* changes:
  Update taskbar to add extra hotseat items instead of recent apps
  Add support for having more hotseat icons in the DB than we show
2021-04-13 18:41:47 +00:00
Tony Wickham
81f8175ab1 Move taskbar to be closer to QSB
- Offset taskbar to be halfway between QSB and bottom of the screen.
- Add taskbar translationY state property to animate when going
  between launcher and an app.
- Draw the taskbar background in TaskbarContainerView instead of
  TaskbarView so it stays pinned to the bottom as TaskbarView
  translates up. If we want to have a background behind the
  taskbar on home, this should move back to TaskbarView so that
  the drawing can be shared by mTaskbarViewOnHome.

Test: visually on home screen, translates when entering and
exiting an app

Bug: 182981881
Bug: 171917176
Change-Id: I44f8b2c770074f7f015dcccbc2befd3453811193
2021-04-13 10:10:54 -07:00
Vinit Nayak
d8ad6b25f4 Make RotationTouchHelper singleton to report single rotation state
Multiple instances of RotationTouchHelper were being
created and reporting conflicting and incorrect information
to sysui for current quickswitch state.

Bug: 183897242
Test: Ensure quickswitch gestures work as expected.
Change-Id: Ia8716f2b597033e9e81291e0b4490119c30ad972
2021-04-13 09:35:23 -07:00
Tony Wickham
be282e9bc8 Update taskbar to add extra hotseat items instead of recent apps
Removes recents-related code including the divider between it and
hotseat.

Test: manually on device

Fixes: 184366189
Bug: 184789479
Bug: 171917176
Change-Id: I7776c98659ded70f53a49befddcd23c8353c6440
2021-04-12 16:20:18 -07:00
Tony Wickham
b87f3cdc1c Add support for having more hotseat icons in the DB than we show
Split InvariantDeviceProfile#numHotseatIcons into two variables:
numDatabaseHotseatIcons and numShownHotseatIcons. These are generally
the same, but different DisplayOptions within the same GridOption
can choose to show different numbers of hotseat icons while sharing
the same database.

numDatabaseHotseatIcons is used for all reading/writing/migrating
purposes, while numShownHotseatIcons determines how many Hotseat
icons to show in the UI.

Test: Existing tests pass, added two new migration tests
Bug: 184789479
Bug: 171917176

Change-Id: I54583504f61a47a4444b6a637ebb7e3ab31528b7
2021-04-12 16:08:15 -07:00
TreeHugger Robot
9bb040ec6d Merge "Handle transitining out of overview more gracefully for 3P launchers" into sc-dev 2021-04-12 22:41:36 +00:00
Vinit Nayak
58dfd4d209 Handle transitining out of overview more gracefully for 3P launchers
Bug: 183897242
Test: Tested with Pixel Custom Launcher, as suggested on the bug
Change-Id: I46ceddb9f5eed6b16b7e66406dd68d94e7a30aee
2021-04-12 10:21:14 -07:00
Vinit Nayak
b1bbc0f78d Changes to use new startTasks API
When shell transitions is enabled, this will use the
newer multi-task-launch api and control the animation.

There is no actual animation yet, this just adds the
infrastructure.

Bug: 182002789
Test: enable developer option and enter split via recents
Change-Id: If5be104a86e7b5f743f85efed20b0d2bf1b8bfd1
2021-04-09 12:09:28 -07:00
Vinit Nayak
34148dc6b4 Merge "Iterate over all swipeable regions when calculating quickswitch gesture bounds" into sc-dev 2021-04-09 17:31:26 +00:00
Vinit Nayak
84b3ee4f28 Iterate over all swipeable regions when calculating quickswitch gesture bounds
Previously when creating a new CurrentDisplay, we would
never get the correct OrientationRectF from the hashmap
because the size field of CurrentDisplay would be incorrect
for a given rotation.
Ex. Rotation 0 and Rotation 1 would have inverted display sizes
Thus hashcode would return different values and we would only
ever see if a point is contained in the current rotation's
OrientationRectF.

Bug: 183897242
Test: Tested swiping from portrait to landscape app, was
able to swipe continuously

Change-Id: I6de625389956f55cfc2142dcb7aeef2e90c157ac
2021-04-09 17:31:15 +00:00
shawnlin
ffb976c404 Attached the navigation bar to app for launching from Launcher
- Play the nav bar fade-out animation at the same time when the app
  launching animation starts and make the fade-in animation ends at the
  same time when app launching animation ends.
- To make the nav bar fade-in animation looks like it's attached to the
  app, apply crop rect and translation that the app targets apply to the
  nav target.

Bug: 181638132
Test: manual: click app icon on launcher to launch an activity and
observe the navigation bar animation.

Change-Id: If7e610eca5fccbb747a76c87335a600b018195a6
2021-04-09 04:04:42 +00:00
Alex Chau
21784eaf08 Merge "Calculate ClearAllButton's scroll offset after it's laid out" into sc-dev 2021-04-08 20:44:45 +00:00
Alex Chau
5fee81233b Calculate ClearAllButton's scroll offset after it's laid out
- ClearAllButton's width is 0 before it's laid out, making the calcualtion incorrect

Bug: 184570027
Test: Restart device or change screen size, ClearAllButton is in correct position
Change-Id: I2cefccbe18925cb3d9dac705b333400639b7049e
2021-04-08 17:22:12 +00:00
Alex Chau
f7df816a8a Check showAsGrid when applying secondary translate on TaskViewSimulator
Bug: 184566209
Test: manual
Change-Id: I53d78553a67c8cd056a9cafad0f163e2c6401550
2021-04-08 17:21:58 +00:00
Winson Chung
01b5d5e332 Merge "Reset force-minimized split state when in live tile mode" into sc-dev 2021-04-08 16:30:28 +00:00
TreeHugger Robot
63c169561c Merge "Some cleanup in RecentsView" into sc-dev 2021-04-07 21:06:55 +00:00
Sunny Goyal
c82916fecb Some cleanup in RecentsView
> Merging overview and all-apps scrims into a single View
> Decoupling TaskMenuView from taskView

Bug: 184676497
Test: Manual

Change-Id: I49f7249eaa2a800054385ab8e73a441d6a1b5e16
2021-04-06 15:47:33 -07:00
Winson Chung
7cf7c31e46 Merge "Fix noisy log from sysui flag changes" into sc-dev 2021-04-06 21:48:43 +00:00
Tony Wickham
029e930751 Merge "Consolidate two different onTransitionCancelled implementations" into sc-dev 2021-04-06 21:44:53 +00:00
TreeHugger Robot
c07ad47255 Merge "Fix HINT_STATE not tracking the entire height of the screen" into sc-dev 2021-04-06 20:58:26 +00:00
Tony Wickham
fc3bc6098f Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev 2021-04-06 19:37:18 +00:00
Tony Wickham
0b0c173ec0 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev 2021-04-06 19:35:38 +00:00
Tony Wickham
b77fa8da52 Consolidate two different onTransitionCancelled implementations
There was previously two different onTransitionCancelled(), one in
BaseActivityInterface and one in AnimationFactory. They are pretty
similar and the differences seem subtle and not necessary. In this
bug, the AnimationFactory version was going to mStartState instead
of StateManager#getRestState() (which is the same, unless mStartState
disables restore). Instead, always use the mActivityInterface
implemenation, which seems more robust.

Test: Open app A, open app B, quick switch from B to A, swipe home
during that transition, then touch nav region during home transtion;
ensure we don't goToState(BACKGROUND_APP) in the subsequent
onTransitionCanceled().

Fixes: 184583037

Change-Id: I315a5087b12413d88c3ccc1e3245a55a76a73e62
2021-04-06 12:16:00 -07:00
Tony Wickham
c9846dc6e7 Merge "Cleanup taskbar touchableInsets" into sc-dev 2021-04-06 18:36:05 +00:00
Samuel Fufa
50c6a37ea9 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev 2021-04-06 17:56:51 +00:00
Zak Cohen
fd9af2f017 Merge "Overview - update Clear All and Empty message drawing" into sc-dev 2021-04-06 17:42:05 +00:00
Tony Wickham
fbdb50aa48 Fix HINT_STATE not tracking the entire height of the screen
Explicitly use DeviceProfile#heightPx instead of getShiftRange(),
which might be less depending on AllAppsTransitionController

Test: swipe up from bottom on home, ensure workspace scales down
as the gesture goes all the way to the top of the screen

Change-Id: I9c2988d361c22d437c7eb9bea8ed715d06054c59
2021-04-06 10:09:44 -07:00
Samuel Fufa
5461089baa [Search][Layout] Fix blank space when predictions are disabled
This regression is caused due to getExpectedHeight relying on view visibility state while AlphaUpdateListener.updateVisibility was reseting the views visibility.

Bug: 184211402
Test: local
Change-Id: Ib756f5eb8f6356a18a025626008b97fd7c77fec9
2021-04-06 04:05:20 -05:00
TreeHugger Robot
ce271c1067 Merge "[Hotseat] Don't show hotseat edu in tests" into sc-dev 2021-04-06 06:18:56 +00:00
Winson Chung
7700bffc47 Fix noisy log from sysui flag changes
Bug: 144854916
Test: Logcat after sysui flag changes, ensure no tracing change logs
Change-Id: I36b6b71bae08303787508ab6eb63ca989866370c
2021-04-06 04:38:03 +00:00
Winson Chung
27d9a92a44 Reset force-minimized split state when in live tile mode
Bug: 184233556
Test: Enter split, go home, launch same task by tapping or swiping
Change-Id: Ied2d56f087e5c05f5f7c4b19428f8088edf4e599
2021-04-05 21:19:25 -07:00
TreeHugger Robot
e77fc9cc25 Merge "Add split placeholder view above OverviewScrim" into sc-dev 2021-04-06 02:34:19 +00:00
Tony Wickham
9f436dfe8e Ensure taskbar animation ends when running window animation does
- Store the possible parallel animation to cancel/end in
  AbsSwipeUpHandler#endRunningWindowAnim()

Test: 1. remove taskbar during transition, ensure cleaned up properly
2. open a second app during transition to home, ensure taskbar
maintains correct visibility
Bug: 182512211

Change-Id: I71a6b6ce624113d43ad5a599cb5cfec28a555310
2021-04-05 17:52:38 -07:00
Tony Wickham
e13a4a4475 Cleanup taskbar touchableInsets
- Remove obsolete visibleInsets hack and isDraggingItem() check
- Have TaskbarController determine whether taskbar is touchable,
  rather than TaskbarContainerView.
- Disallow touches during transition to home (can potentially
  improve this later)

Test: Swupe home, tap taskbar folder during transition, ensure
don't end up in broken state with the uninteractable folder open
Bug: 182512211

Change-Id: Id625ce8b9b876a8a1b450b7d6fb771540e23bc08
2021-04-05 17:33:44 -07:00