-AddWorkspaceItemsTask can add multiple items to the same position, we
avoid that here by adding each item to the database before processing
the next item.
-We add more logs to InstallSessionHelper to be able to check who the
installer is
Bug: 432237485, 425754534
Test: AddWorkspaceItemsTaskTest
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4b439e999734852a017ce662543b4789b36e0e3b)
Merged-In: I2d238f3eb27734ab9cb723e2fe9d6752c5921dd1
Change-Id: I2d238f3eb27734ab9cb723e2fe9d6752c5921dd1
When cleaning the code for ag/34436200 I accidentally removed
the fixing line which was removing the old setLayoutParams
for the new one.
Fix: 431696619
Fix: 429081966
Test: Manul test
Flag: EXEMPT bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:fa233150bace5dc6a23272301065d0b35080c215)
Merged-In: I2cca194064b30a61eeacb6a376989c71b3522e87
Change-Id: I2cca194064b30a61eeacb6a376989c71b3522e87
We didn't bother to center the view because it just one view that
matches the parent view, the problem is that the peview view is
bigger than it's parent, this is by design so that the preview
matches the full screen and looks the same as the real Launcher.
We then scale the preview view to match the visualization space.
The problem is that the logic that position a view in FrameLayot
doesn't account for children views bigger than itself so in
RTL the view is not "centered" or it doesn't start where we expect
it to start. By using gravity = CENTER it does account correclty
for bigger views.
Fix: 429081966
Test: GridPreviewTest
Flag: EXEMPT bug fix
(cherry picked from commit 6624691c50)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e5e32f0ef771417b9bf29a71d6d7fd7b47067dd1)
Merged-In: I1e75087ca68dd3180b0a9f11d9403eafb892391a
Change-Id: I1e75087ca68dd3180b0a9f11d9403eafb892391a
This was causing a bug where simple mode would trigger loadertask to
run, which then led to other errors since it ran prematurely
Bug: 417395120
Test: Manual
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c98d20425bf1c4e5d3a1935f11802a16e2d0aa6f)
Merged-In: Ib73e3d7849c5b3d887cbca0fbc8a386ed553f751
Change-Id: Ib73e3d7849c5b3d887cbca0fbc8a386ed553f751
Previously broken flow:
- Open All Apps on inner screen
- Drawing controller is set to the AllApps container
- Close All Apps (resting state becomes NORMAL)
- Fold, unlock
- Because we are still in NORMAL, the drawing controller was not
updated. Therefore when the ScrimView draws (alongside all other
views due to Launcher starting), it asks the inner screen's All
Apps container to render its panel on the scrim.
The fix is to remove the drawing controller when All Apps resets,
thereby avoiding trying to draw on the scrim in the first place. The
drawing controller is updated upon the next transition to All Apps,
as usual.
Bug: 426397329
Test: Manual: https://drive.google.com/file/d/1l9qAIkrgFalcO5DABOEIRX1Po3POYzab/view?usp=sharing&resourcekey=0-ccU6q2fbYE6y87ehIKdbEQ
Flag: com.android.launcher3.all_apps_sheet_for_handheld
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:288006fe11bdaec4bd229999619dd7097806620a)
Merged-In: I0a4872e6bd668583d08848a8b9c5f0f1389c4f0f
Change-Id: I0a4872e6bd668583d08848a8b9c5f0f1389c4f0f
> Previously the old renderer was destroed but was still being used until the new renderer was loading
Bug: 426034253
Flag: EXEMPT bugfix
Test: Manually using profiler, Presubmit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:67fd6c8e17ae7df3b60a092de63b0ef1eb0ba9b1)
Merged-In: I291ea6737d4ed072eb04d007438709f9081f4075
Change-Id: I291ea6737d4ed072eb04d007438709f9081f4075
This is a forward fix of ag/33841218.
IllegalStateException is thrown because getResources() has already been
called in ContextThemeWrapper.applyOverrideConfiguration().
We should avoid getting configuration from ContextThemeWrapper, which
will generate ContextThemeWrapper#mResources and trigger
IllegalStateException from subsequent
ContextThemeWrapper#applyOverrideConfiguration().
Instead, we should get configuration from mPreviewContext which is
ContextWrapper.
Fix: 423802089
Flag: NONE - released code
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0c218842940c0920b88c9eb2ac30ef76a16edf08)
Merged-In: Ic3d29d7bb2cbf3483e757e5a90ac8d8989adc613
Change-Id: Ic3d29d7bb2cbf3483e757e5a90ac8d8989adc613
* changes:
Widget Picker: Update the launcher integration to support shortcuts
Widget Picker: Update UI layer to support shortcuts
Widget Picker: Update data layer to support shortcuts
Updates drag and drop, tap to add and preview related code.
Bug: 370950552
Flag: com.android.launcher3.enable_widget_picker_refactor
Test: Drag and drop shortcuts on home screen
Change-Id: Iccfe329296dbf4b0770628e77df5cd9b42ac9b21
Adds sealed class for widget info that can contain either appwidget info
or shortcut info.
Also kept the aosp config.xml empty to keep everything eligible for
featured
Bug: 370950552
Flag: com.android.launcher3.enable_widget_picker_refactor
Test: Open picker for homescreen and lockscreen hosts
Change-Id: Iceafc2c1234063b16421f90bf00cf96114e9870c
This change removes the talkback announcement for the background app LauncherState, which defaulted to "Recent apps".
Flag: EXEMPT bug fix
Fixes: 418854152
Test: attempted home/overview/quick switch gestures from home and app
Change-Id: I1f390902dfddd2e8576743dbbddce65121690f14
This CL prevents taskbar from forcefully moving the existing fullscreen
task to desktop on desktop-first display.
On desktop-first displays, we want to keep the current windowing mode
when its taskbar app icon is clicked.
Flag: com.android.window.flags.enable_desktop_first_fullscreen_refocus_bugfix
Bug: 420499923
Test: TaskbarRecentAppsControllerTest
Change-Id: I5e5c950d2e7bd25762eaddad94c57a4bf29ee800
When selecting grid size to use for desktop, size breakpoints are
compared to the display dimensions with "stable" device density.
Expose the scale factor that needs to be applied to dimensions
provided in spec via DisplayController::Info, so it can be more easily
faked in tests.
Bug: 375643744
Test: atest DeviceProfileDumpTest
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Change-Id: I836430cc052f72c0f89b6cdd5ab5309a3482d94e
This will let it settle correctly if opening the all apps page during a
swipe or snap.
Bug: 415773533
Test: Verified that this works well locally. This is easy to reproduce.
Flag: EXEMPT bug fix
Change-Id: I74131b8d65cbc4466de4fed8638f8da7347aef49
LauncherPrefs wrapper adds a backup when using backedUpItem for promise icon ids.
Disable backup and restore for this preference as it could cause unwanted situations
Bug: 419426642
Test: None yet
Flag: EXEMPT Bug fix
Change-Id: I4cfef8c587b951ee6b4753e5f2e2a45409294ef3
If the install session comes back as invalid, we can fail to add
a promise icon which leads to icons not showing up on the workspace.
Bug: 419426642
Test: None yet
Flag: EXEMPT Bug fix
Change-Id: I592948eb2b60c2249bb5b141d499d1d5ea01aebc
> Reusing the model binding system instead of using a custom implementation
> Reusing the existing grid update API for previews instead of custom implementation
> Any new functionality is protected via the same flag as the grid update path
Bug: 420997234
Bug: 397782741
Flag: EXEMPT refactor
Test: atest GridPreviewTest
Change-Id: Iaf8f34568618f98cc11138ce3fa327707c5f6f1a
When an emtpy area of the workspace is tapped/clicked, and tasks are
shown on top of the home screen, launch an Intent to bring the Home
activity to the front. This behavior is intended for the desktop form
factor.
Bug: 419565810
Test: Manual and onWorkspaceTouch_whenHomeBehindDesktop_launchesHomeIntent
Flag: com.android.window.flags.show_home_behind_desktop
Change-Id: Id66e7700873db8d11addf2b5283b4ac126acde5f
These handle those two operations for home screen when widget picker is
opened as a separate activity.
Bug: 408283627
Flag: com.android.launcher3.enable_widget_picker_refactor
Test: Not applicable.
Test: See demo in comments
Change-Id: I37f626b57610379a8af4e7a229406ed0656806c2
> Moving classes to a separate package
> Extracting PreviewContext outside of renderer
> Always loading the sandbox instead of loading real model followed by a sandbox
> Binding LoaderTask using params so that it can be customized
Bug: 420997234
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Idf45eaba9d8309cb55b47847d8e3686cbb6c0a8e
This was inadvertently reverted in ag/33712864.
Bug: 415247657
Test: Manual
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Change-Id: Iac3be94342e7def142e31bac34ab9043e870c305
