Commit Graph

2322 Commits

Author SHA1 Message Date
Sunny Goyal
3425e350ac Merge "Using DiffUtil for calculating widget diff instead of a custom implementation" into tm-qpr-dev am: cc10ed5532 am: 75db2c1f59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21381953

Change-Id: I5dee1553d80878417ef18425e5ff626fc80326e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-17 06:26:58 +00:00
Sunny Goyal
75db2c1f59 Merge "Using DiffUtil for calculating widget diff instead of a custom implementation" into tm-qpr-dev am: cc10ed5532
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21381953

Change-Id: I42080a592bef63d0cb7e55189a1a6249f331220a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-17 00:02:41 +00:00
Sunny Goyal
cc10ed5532 Merge "Using DiffUtil for calculating widget diff instead of a custom implementation" into tm-qpr-dev 2023-02-16 23:28:19 +00:00
TreeHugger Robot
b0321f97b6 Merge "Making ReorderWidget test more reliable" into tm-qpr-dev am: 1b7a140693 am: f351bd7c6c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21091023

Change-Id: Iaeda98eb011c28cc9e682a6fc07fa64fb4028a15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 22:58:03 +00:00
Stefan Andonian
24cff2fa3e Merge "Refactor Workspace Loading / Processing code." into tm-qpr-dev am: 3a14f1331d am: 8775725e06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20544534

Change-Id: I41e7ca11f4462407f73ac6ec4dc16d9fa619a1ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 22:57:29 +00:00
TreeHugger Robot
f351bd7c6c Merge "Making ReorderWidget test more reliable" into tm-qpr-dev am: 1b7a140693
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21091023

Change-Id: I4d861e9c566303aa9fb41bebaccf6369ef1411df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 22:57:04 +00:00
Stefan Andonian
8775725e06 Merge "Refactor Workspace Loading / Processing code." into tm-qpr-dev am: 3a14f1331d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20544534

Change-Id: I9185bbd2b89d0f40ce85ae4e4b2843643d9ecce8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 22:54:49 +00:00
TreeHugger Robot
1b7a140693 Merge "Making ReorderWidget test more reliable" into tm-qpr-dev 2023-02-15 22:50:20 +00:00
Stefan Andonian
3a14f1331d Merge "Refactor Workspace Loading / Processing code." into tm-qpr-dev 2023-02-15 22:16:29 +00:00
Stefan Andonian
aa03be3a16 Merge "Migrate IDP_GRID_NAME usage to LauncherPrefs" into tm-qpr-dev am: 3788da6285 am: 844dc76a25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21359246

Change-Id: I77d01b752d13a823b6d41db0b52e62ef46985675
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 19:40:23 +00:00
Stefan Andonian
844dc76a25 Merge "Migrate IDP_GRID_NAME usage to LauncherPrefs" into tm-qpr-dev am: 3788da6285
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21359246

Change-Id: If917934e6739a9085ed893ca8d3ff49549f0c45e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 19:37:26 +00:00
Stefan Andonian
3788da6285 Merge "Migrate IDP_GRID_NAME usage to LauncherPrefs" into tm-qpr-dev 2023-02-15 18:58:41 +00:00
Stefan Andonian
05ca3a8089 Refactor Workspace Loading / Processing code.
There are no behavioral changes (other than we no longer are recycling
objects while processing workspace items), but this refactor will setup
the next change to load the first workspace page before other workspace
pages.

Bug: 251502424
Test: Workspace, app widgets, and containers loaded properly.
Change-Id: I437aab40000d841d7fcc4380d05ab4a8f5d5c2ad
2023-02-15 17:36:27 +00:00
Thales Lima
0eaaddc6c9 Merge "Create a DeviceProfileDumpTest for nonquickstep" into tm-qpr-dev am: 0af71f85dd am: 42c28e7bfe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20960103

Change-Id: I52af02a531bd19141e29e2945ac960018ad5773f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 11:05:59 +00:00
Thales Lima
42c28e7bfe Merge "Create a DeviceProfileDumpTest for nonquickstep" into tm-qpr-dev am: 0af71f85dd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20960103

Change-Id: Ia14ebbc496ab0d30ead6771c291593e809f0aabd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 10:14:32 +00:00
Thales Lima
0af71f85dd Merge "Create a DeviceProfileDumpTest for nonquickstep" into tm-qpr-dev 2023-02-15 09:46:11 +00:00
Stefan Andonian
6f9a57186c Migrate IDP_GRID_NAME usage to LauncherPrefs
Bug: 251502424
Test: Grid functionality still worked just fine on device when I tested
it locally.

Change-Id: I23676572637f194e1f739e4b39159311870abc32
2023-02-15 06:01:47 +00:00
Sunny Goyal
892fab2c14 Using DiffUtil for calculating widget diff instead
of a custom implementation

This uses the same version as all-apps and avoids whole list refresh
when a widget entry is expanded for the first time

Removing tests which were essentially testing the diffing logic

Bug: 268646258
Test: Verified on device
Change-Id: I4799c66b4674e754547317317e7a63f098fce735
2023-02-14 20:59:29 +00:00
Sunny Goyal
591a128e57 Merge "Moving widget background to xml, so that the same constantstate is used for all entries" into tm-qpr-dev am: a75105ef03 am: 67e1e03913
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21381944

Change-Id: Icde51114b8f5655ea516b0ea8233c5f6734d2997
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 19:32:50 +00:00
Sebastian Franco
81b82720de Making ReorderWidget test more reliable
In some cases when starting to drag you can go to the next
CellLayout wich end in an error. Now the dragging functions
will move the item to the desired CellLayout no matter what
CellLayout you start in.

Fix: 266116487
Test: atest ReorderWidgets
Change-Id: Ie3ad2ff88f734856e2c66d5d51b7578482877b5a
2023-02-13 11:02:09 -08:00
Sunny Goyal
67e1e03913 Merge "Moving widget background to xml, so that the same constantstate is used for all entries" into tm-qpr-dev am: a75105ef03
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21381944

Change-Id: Icb8819fae2b4fd21f76faea78e3e341a32a9508f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 18:40:24 +00:00
Thales Lima
69166dd054 Create a DeviceProfileDumpTest for nonquickstep
This makes sure we are still testing non scalable grids as well

Bug: 241386436
Test: DeviceProfileDumpTest
Change-Id: I06b442cf1052a952ee834f98c5005ea8e950c2f0
2023-02-13 17:31:13 +00:00
Sunny Goyal
77e732a1c4 Moving widget background to xml, so that the same constantstate is
used for all entries

This helps reduce launcher memory by avoiding multuple duplicate
drawable generation

Bug: 268646258
Test: Verified on device
Change-Id: I829750f081cfce65063b35a614b903066d9a4bed
2023-02-13 05:49:31 +00:00
Sunny Goyal
71aa5d815b Merge "Removing unnecessary search header duplication" into tm-qpr-dev am: 290998522c am: 6f2c09f066
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21372949

Change-Id: Ic5fcaa632e2c1aa14d348e143fbf9dde886f4abe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-11 01:01:15 +00:00
Sunny Goyal
6f2c09f066 Merge "Removing unnecessary search header duplication" into tm-qpr-dev am: 290998522c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21372949

Change-Id: Icb3c70e8d9a59ef664dd1c1b70f151142dc4736d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-11 00:10:29 +00:00
Sunny Goyal
62a4932310 Removing unnecessary search header duplication
Bug: 268646258
Test: Verified on device
Change-Id: I33a7df6a523e5600dc6251c3d8feff1236362705
2023-02-10 11:26:05 -08:00
Federico Baron
df7066b782 Merge "Implement two pane widget picker" into tm-qpr-dev am: 740541e0a0 am: d36fa5e631
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20508230

Change-Id: I65049b8bb98e845c705e92e33e56a7b8955e3f79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-10 18:43:59 +00:00
Federico Baron
d36fa5e631 Merge "Implement two pane widget picker" into tm-qpr-dev am: 740541e0a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20508230

Change-Id: Id1c208c28b7f40eeb1b3446c0c4bf569eb791482
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-10 18:01:28 +00:00
Federico Baron
740541e0a0 Merge "Implement two pane widget picker" into tm-qpr-dev 2023-02-10 17:20:55 +00:00
Brandon Dayauon
1507785a36 Merge "Method to override feature flag" into tm-qpr-dev am: fb9c4d25c4 am: ebd8065f19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21306841

Change-Id: I6b442087c14ef91f3283c00fb85fd8d72a55aa27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-10 00:41:39 +00:00
Federico Baron
4b1a38bb7d Implement two pane widget picker
The widget picker design is currently not optimized for large screen form factor devices.
We resolve that by adding a two pane widget picker like that of the design in go/widget-picker-2023.

Bug: 256684299
Test: Make sure to be on a tablet in landscape mode.
        1.Turn on flag LARGE_SCREEN_WIDGET_PICKER.
        2. Press and hold on an empty spot in workspace until the popup menu appears.
        3. Click widgets.
        4. Notice the new two pane layout
Change-Id: Ia3ea17dc320f72f9bc5dea52399ff51d9161602b
2023-02-09 16:36:45 -08:00
Brandon Dayauon
ebd8065f19 Merge "Method to override feature flag" into tm-qpr-dev am: fb9c4d25c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21306841

Change-Id: Id86fb6421ae6bd3eb5bf020bf07fbe71107e54aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-09 23:59:14 +00:00
Brandon Dayauon
fb9c4d25c4 Merge "Method to override feature flag" into tm-qpr-dev 2023-02-09 23:31:47 +00:00
Thales Lima
bb056c6001 Merge "Create an XML parser for WorkspaceSpecs" into tm-qpr-dev am: 5d5aad3024 am: 0ebaf3a46c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20643018

Change-Id: I471bb3ccd04a0598a309e53038976fbccb638ce1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-09 13:01:28 +00:00
Thales Lima
0ebaf3a46c Merge "Create an XML parser for WorkspaceSpecs" into tm-qpr-dev am: 5d5aad3024
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20643018

Change-Id: I6a3f38e28b5a381bfa2ac42cdeba77c1527fb028
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-09 12:19:35 +00:00
Brandon Dayauon
533e4856b4 Method to override feature flag
- Replaced where it's used in GridSizeMigrationUtilTest.kt

bug: 268094298
test: manually/presubmit and GridSizeMigrationUtilTest photo: https://screenshot.googleplex.com/7cLtFSbBvxnYAFM
Change-Id: Id8e688b95b91b1b6a4962a4e092505cbb79603f7
2023-02-08 17:01:46 -08:00
Thales Lima
1a2d4bd6f4 Create an XML parser for WorkspaceSpecs
Extract DeviceProfileTest to Launcher3 so it can be used in other tests as well, and change name of previous base test to be more descriptive.

Bug: 241386436
Test: WorkspaceSpecsTest
Change-Id: I64613bb5a23c374ed15fb6d936192236a541ab9b
2023-02-08 11:20:14 +00:00
Thales Lima
a91f5251b6 Merge "Improvements for All Apps on different display sizes" into tm-qpr-dev am: fcb6a5fc06 am: f0c4b41bf1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21116563

Change-Id: Ifbf110cb76d348a8b6a3b3fdd0f47a4b10dcfe4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-08 11:05:07 +00:00
Thales Lima
f0c4b41bf1 Merge "Improvements for All Apps on different display sizes" into tm-qpr-dev am: fcb6a5fc06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21116563

Change-Id: I560692d70a2dc1c3dad6df6bfc179a04004f398c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-08 10:24:01 +00:00
Thales Lima
fcb6a5fc06 Merge "Improvements for All Apps on different display sizes" into tm-qpr-dev 2023-02-08 10:02:17 +00:00
Nicolo' Mazzucato
1fce0dfda4 Move Launcher classes shared between tests and prod in a separate lib am: e8ee34ad8a am: e4287dfd10
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21083963

Change-Id: I120d3625a9f96627f3565a207144c7888351acd6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-07 21:33:52 +00:00
Nicolo' Mazzucato
e4287dfd10 Move Launcher classes shared between tests and prod in a separate lib am: e8ee34ad8a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21083963

Change-Id: I458dcd290168c185fc9a7c6974529c6cb08bf81d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-07 20:53:27 +00:00
Nicolo' Mazzucato
e8ee34ad8a Move Launcher classes shared between tests and prod in a separate lib
This is necessary because otherwise those are included in several gradle projects. Gradle doesn't support the same files imported in different projects, and it removes them from a random one if it happens, resulting in missing symbols.

This extracts the shared files in a new target, and adds it as dep of the original target.

Test: Build launcher + execute a few tests manually with gradle + verify that Launcher.java can resolve all symbols with gradle config
Bug: 262267728
Change-Id: Ida5b25c45320d517603834112f4699e4d3344c03
2023-02-07 12:03:10 +00:00
TreeHugger Robot
b586d561cf Merge "Update tests to support floating search." into tm-qpr-dev am: 4a2bf3b131
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21225840

Change-Id: I6ed74047393038c4abf3ddaafc0e14b811de17dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-07 00:32:52 +00:00
TreeHugger Robot
4a2bf3b131 Merge "Update tests to support floating search." into tm-qpr-dev 2023-02-06 23:50:49 +00:00
Andy Wickham
8d004b0f49 Update tests to support floating search.
Tests need to be updated to account for the new placement of the
searchbar because it overlapped with touch events for scrolling:
 - Scroll back to top: Instead of scrolling from the top of the
   container which could overlap status bar in landscape, scroll
   from the bottom of the top-most visible app icon.
 - Scroll down: swipe up from bottom padding to top of top-most
   visible icon.
 - Close all apps: swipe down more quickly from top icon insetad
   of the search bar (more quickly helps it be detected as a
   fling on more cramped devices).

For Launcher3, the floating flag is not fully supported yet, so
there were some layout issues which are now resolved by ignoring
the flag if the searchbar is still at the top.

Fix: 268052768
Test: Ran tests, manual
Change-Id: If54717e2835c7cc4ed1368554bbc493193945c1d
Merged-In: I406fbcbe12acddb1dd4b862a380576a48cabbebc
2023-02-06 13:49:14 -08:00
TreeHugger Robot
005f29a7e2 Merge "Add instruction to put the device into test harness to error message" into tm-qpr-dev am: a3e61240b1 am: f9d6efc4fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21222958

Change-Id: I1349ce5537c3991d4e0381319417c3fc844f0e36
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-06 10:35:28 +00:00
TreeHugger Robot
f9d6efc4fa Merge "Add instruction to put the device into test harness to error message" into tm-qpr-dev am: a3e61240b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21222958

Change-Id: Id84490b396e80ea95b4c578e8a096f81f3d55438
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-06 10:05:47 +00:00
TreeHugger Robot
a3e61240b1 Merge "Add instruction to put the device into test harness to error message" into tm-qpr-dev 2023-02-06 09:52:06 +00:00
Andy Wickham
8353c38f92 Merge "[revert ^2] Enable Floating Search and update tests accordingly." 2023-02-04 09:19:18 +00:00