Commit Graph

793 Commits

Author SHA1 Message Date
Vadim Tryshev
7df94cca65 Disabling strict activity leak check
Started seeing presubmit blockers like:
https://android-build.corp.google.com/test_investigate/?invocationId=I51800010216065294&testResultId=TR60829041305611993

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ic88f67e54d2dec4b244784abd2a15fbdfdf9e711
2023-11-10 15:04:46 -08:00
Tracy Zhou
d66d114944 Merge "Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION" into main 2023-11-09 18:47:59 +00:00
Vadim Tryshev
fd13b2c650 Merge "Demoting a couple of flaking tests from presubmit" into main 2023-11-09 01:40:36 +00:00
Tracy Zhou
f2d7be1cec Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION
We want to turn on the flag when either of the dependent features is on

Bug: 299193589
Test: N/A
Change-Id: I7b48ff2be0cf9da3b6bc00d75370fa585ce4140d
2023-11-08 14:52:58 -08:00
Vadim Tryshev
1c8e30b54c Merge "Making keyguard dismissal a permanent solution" into main 2023-11-08 20:24:11 +00:00
Vadim Tryshev
e494c1b6e7 Demoting a couple of flaking tests from presubmit
Bug: 288939273, 309820115
Test: presubmit
Flag: N/A
Change-Id: Iea7dd435c4f6461ceb9e45ce6b3942ddc2d11347
2023-11-08 12:01:00 -08:00
Vadim Tryshev
e5a1b89220 Making keyguard dismissal a permanent solution
Before, it was considered to be a workaround while System UI has
keyguard bugs. But these bugs will happen in future, and they are
unlikely to be prevented by presubmit tests since they are usually flakes.

The solution that this CL makes permanent is: in presubmit attempt
to unlock SysUI if it's locked. In postsubmit, just make sure it's
unlocked. This way, in postsubmit, we'll know whether tere are active
keyguard bugs.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ia9602bc6e9cc8400e939051c45aba92bc197d428
2023-11-07 14:45:58 -08:00
Tracy Zhou
6fe69f5a2a Migrate HIDE_NAVBAR_WINDOW to aconfig and rename is to enable_taskbar_navbar_unification
Bug: 309671494
Test: N/A
Change-Id: If35d807c17351146029498a876a055384eff3c2f
2023-11-07 13:51:38 -08:00
Vinit Nayak
38dc539f84 Merge "Unignore split tests" into main 2023-11-07 18:19:11 +00:00
Vinit Nayak
8ef38b0f9e Unignore split tests
* With the fix of b/302551868, let's
see if that fixes this issue as well

Bug: 297135374
Change-Id: I817307dbb5e70d8c8534627499d429529e33de4a
2023-11-06 14:25:35 -08:00
Vadim Tryshev
8b1881223b Merge "Waiting for the setup wizard to go away" into main 2023-11-06 18:17:46 +00:00
Jagrut Desai
a0c9db6dce Merge "Remove TaplTestsQuickstep#testPressBack from PlatinumTest" into main 2023-11-06 17:32:43 +00:00
Vadim Tryshev
0fe753af2a Waiting for the setup wizard to go away
This is a workaround for b/309008042 where it appears that after being
dismissed by the test infra, setup wizard doesn't immediately go away.

This CL will wait 2 minutes for the dismissal, and provide a better
diags when the wizard doesn't go away after 2 min.

Bug: 309008042
Test: presubmit
Flag: N/A
Change-Id: I26eb2f202842702af08c424929d74fbd21eb872d
2023-11-04 21:37:25 -07:00
Priyanka Advani
ebc9a3b5e1 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-11-03 22:10:27 +00:00
Priyanka Advani
9aed56096c Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Reason for revert: Likely culprit for b/309158105

Reverted changes: /q/submissionid:24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Change-Id: I8ee560f7e599bcfde09eff53f049309ba25ce77f
2023-11-03 21:31:45 +00:00
Tony Wickham
075a67da15 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-11-03 18:35:54 +00:00
Alex Chau
9c07fc1350 Re-land "Update Tapl tests for enable_grid_only_overview"
- Fix getCurrentTask() to correctly get the top-right tasks in grid only overview. It'll first get the widest task, and then top, and then rightmost task
- Fix scrollLeftByDistance() to correctly account for leftGestureMargin to make sure it scroll by distance provided
- Fix scrollCurrentTaskOffScreen() to actually scroll the task off screen
- Fix createAndLaunchASplitPair() to use Task menu instead of Overview actions for grid only overview
- Skip testOverviewActions() in grid only overview, where Overview actions isn't available
- Fix testOverivewForTablet to expect the correct task in grid only overview; also disabled part of a test due to an animation bug in Overview
- Fix dismissBySwipingUp() to swipe from bottom of task, which is required to effectively dismiss top row tasks
- Also fixed OverviewTask to correctly get objects in FallbackOverview
- Fix touchOutsideContainer() to calcualte y base on container's middle correctly

Bug: 283246928
Test: presubmit
Flag: None
Change-Id: I77e91dcc1a404ade356b29fba6cf967c534c08f4
2023-11-02 22:37:26 +00:00
Jagrut Desai
755304d592 Remove TaplTestsQuickstep#testPressBack from PlatinumTest
Test: Presubmit
Bug: 303256981
Flag: NONE
Change-Id: I8e502449d03c9ca010fc05297f2edb255e1fa21e
2023-11-02 21:19:18 +00:00
Alex Chau
39c548bd03 Merge "Revert "Update Tapl tests for enable_grid_only_overview"" into main 2023-11-02 13:36:34 +00:00
Sam Dubey
0552d37f34 Revert "Update Tapl tests for enable_grid_only_overview"
Revert submission 25220083-b/283246928

Reason for revert: b/308930958

Reverted changes: /q/submissionid:25220083-b/283246928

Bug: 283246928
Change-Id: I69ce128061f7ffad213f8f193122b18e5ee9378d
2023-11-02 13:33:55 +00:00
Alex Chau
c543b46070 Merge "Fix TaskViewSimulatorTest to be independent of device it runs on" into main 2023-11-02 11:13:20 +00:00
Tony Wickham
eccf070bae Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: Ib6e592a31a55a912a7ea991a421a9c60bca51c80
2023-11-01 23:16:10 +00:00
Alex Chau
3029b8314e Update Tapl tests for enable_grid_only_overview
- Add "task" as id for TaskView, and use it instead of "snapshot" when creating OverviewTask, so that for split tasks are caputred as a whole in getCurrentTask and getTasks
- Fix getCurrentTask() to correctly get the top-right tasks in grid only overview. It'll first get the widest task, and then top, and then rightmost task
- Fix scrollLeftByDistance() to correctly account for leftGestureMargin to make sure it scroll by distance provided
- Fix scrollCurrentTaskOffScreen() to actually scroll the task off screen
- Fix createAndLaunchASplitPair() to use Task menu instead of Overview actions for grid only overview
- Skip testOverviewActions() in grid only overview, where Overview actions isn't available
- Fix testOverivewForTablet to expect the correct task in grid only overview; also disabled part of a test due to an animation bug in Overview
- Fix dismissBySwipingUp() to swipe from bottom of task, which is required to effectively dismiss top row tasks
- Also fixed OverviewTask to correctly get objects in FallbackOverview

Bug: 283246928
Test: presubmit
Flag: None
Change-Id: I5dd39b1779ea02738556f921169dbe38aa4cba8c
2023-11-01 22:15:12 +00:00
Alex Chau
382e1868c7 Fix TaskViewSimulatorTest to be independent of device it runs on
- Fix TaskViewSimulatorTest to properly set up densityDpi, so the test result is consistent regardless of the device it runs on. Also used SandboxContedxt's putObject() to avoid using reflection

Bug: 283246928
Test: TaskViewSimulatorTest
Flag: None
Change-Id: I926459fa97dd09a266cd017e4a0fb8e658a3509c
2023-11-01 19:51:37 +00:00
Jagrut Desai
24231d9994 Merge "Taskbar pinning animation with no recreate" into main 2023-10-26 21:33:41 +00:00
Jagrut Desai
631b284836 Taskbar pinning animation with no recreate
Test: Manual, Visual
Bug: 265436799
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED

Change-Id: I84a4d1efdb0bd4a0f856fa1f46b6489ef54a3841
2023-10-26 10:36:48 -07:00
Pat Manning
821bc0d034 Merge "Clean up overview icon menu flag after tests and refresh device profile." into main 2023-10-26 16:00:48 +00:00
Pat Manning
999af9cab9 Clean up overview icon menu flag after tests and refresh device profile.
Fix: 306089019
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TRUNKFOOD
Change-Id: I04335967e6bfa52d143a399859e2e745d428ab30
2023-10-26 12:02:40 +01:00
Pat Manning
3a2fde4db4 Go home before getting overview in test to ensure overview will exist.
Also when opening settings, do not wait for A11Y event which never fires. (added in ag/24777489, but seems to fail as mentioned here b/303329286#comment2 and tracked here b/298114205)

Fix: 307379525
Fix: 307397957
Bug: 298114205
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TRUNKFOOD
Test: TaplOverviewIconTest
Change-Id: Icd8a47b47d22ddb32db7df6882ec655f0e6f54c1
2023-10-24 14:43:11 +00:00
Pat Manning
1f5d5be70d Merge "Move overview tests to quickstep package." into main 2023-10-23 18:26:38 +00:00
Pat Manning
1eb8bd8735 Merge "Increase pinned taskbar height to fit tooltips." into main 2023-10-23 16:13:03 +00:00
Pat Manning
954e3b8dee Move overview tests to quickstep package.
Fix: 305394234
Test: TaplOverviewIconAppChipMenuTest, TaplOverviewIconTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT
Change-Id: Ib39e2ec7f53de0c4b557558776c7ad428e4cab22
2023-10-23 16:15:33 +01:00
Pat Manning
5643e7c047 Increase pinned taskbar height to fit tooltips.
Fix: 305706286
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states TRUNKFOOD
Test: TaskbarHoverToolTipControllerTest

Change-Id: I767947a752eae7a928d59fe332bc62b9fd5b5f37
2023-10-23 15:52:48 +01:00
Jagrut Desai
2e53885e86 Merge "Adding screen record TaplTestsQuickStep#testOverviewForTablet" into main 2023-10-20 20:23:16 +00:00
Pat Manning
4c27e8c6f0 Migrate cursor feature flag to trunk stable flag.
Fix: 300054410
Test: TaplTestsTransientTaskbar, TaplTestsQuickstep
Flag: enableCursorHoverStates
Change-Id: I5c320e0fd2bdd2ed39b00b62b1399e163c3384e7
2023-10-20 12:17:36 +01:00
Jagrut Desai
caf5c815f3 Adding screen record TaplTestsQuickStep#testOverviewForTablet
Test: Presubmit
Bug: 306089019
Flag: NONE
Change-Id: I1e7474fe5f32e895859ca726fc63f40833ada118
2023-10-20 00:38:14 +00:00
Pat Manning
df72740384 Merge "Revert "Revert "Combine icon app tests to allow overriding flag ..."" into main 2023-10-17 17:28:24 +00:00
Pat Manning
24cec69361 Revert "Revert "Combine icon app tests to allow overriding flag ..."
Revert submission 25032768-revert-25007147-tapl-flag-SBORVHYDTI

Reason for revert: Resubmitting for b/304470271

Reverted changes: /q/submissionid:25032768-revert-25007147-tapl-flag-SBORVHYDTI

Change-Id: Ib0bd13a5c2a366160b185a2c6409c607ed7525a1
2023-10-17 15:56:48 +00:00
Anushree Ganjam
6ee3a32b12 [Trunk Stable] Use SetFlagsRule.initAllFlagsToReleaseConfigDefault instead of disabling all flags in setUp.
Bug: 294913042
Flag: NA
Test: Unit tests
Change-Id: Ib570ce67f53d4af7407b36f6fee1a3517800155f
2023-10-17 10:27:54 +00:00
Sebastián Franco
87d482cd3e Merge "Unifying constant app names used in Tests" into main 2023-10-13 18:28:38 +00:00
Jeremy Sim
7dc3bdcd85 Migrate ENABLE_APP_PAIRS flag to aconfig
Fixes: 303323964
Flag: com.android.wm.shell.Flags.FLAG_ENABLE_APP_PAIRS
Test: Unit tests still run correctly
Change-Id: I617c699746492c9c0d131a28791d984afbbdda4d
2023-10-12 15:06:32 -07:00
Tyler Freeman
22781d97d9 Merge "Revert "Combine icon app tests to allow overriding flag for new ..."" into main 2023-10-12 20:06:56 +00:00
Tyler Freeman
1468467706 Revert "Combine icon app tests to allow overriding flag for new ..."
Revert submission 25007147-tapl-flag

Reason for revert: Breaks build: https://b.corp.google.com/issues/305033049

Reverted changes: /q/submissionid:25007147-tapl-flag

Change-Id: I99b5883e64ae25476394a4207c5d6a4d22fc27dc
2023-10-12 18:04:05 +00:00
Pat Manning
654c05837e Merge "Combine icon app tests to allow overriding flag for new icon app chip menu testing as well." into main 2023-10-12 15:59:17 +00:00
Pat Manning
236e738907 Combine icon app tests to allow overriding flag for new icon app chip menu testing as well.
Platinum exlude cl update: cl/572225659

Test: TaplOverviewAppIconMenuTest
Test: TaplAppIconAppChipMenuTest
Bug: 303329286
Bug: 303266562
Fix: 304470271
Change-Id: I4ca163401d6a42961e8955e06c164af0254b1231
2023-10-12 14:53:08 +01:00
Treehugger Robot
bcd5555863 Merge "Adding Mateusz as an OWNER for Launcher tests" into main 2023-10-11 21:53:30 +00:00
Vadim Tryshev
e86761a225 Adding Mateusz as an OWNER for Launcher tests
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I07a891fe766549208e4402726ee66998db22956d
2023-10-11 14:48:17 -07:00
Vadim Tryshev
f782eaba73 Improving diagnostics from fallback recents tests when phone is not unlocked
Failing earlier so that we don't get strange messages from the middle of the test.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1e3c70623e6f907bcc6bd0486b6c75afecb610e3
2023-10-10 19:18:22 -07:00
Federico Baron
ca39bd99cc Merge "Add screenrecord to testOverviewActionsMenu_iconAppChipMenu" into main 2023-10-09 21:29:11 +00:00
Sebastian Franco
02a4fb41c7 Unifying constant app names used in Tests
Bug: 298234173
Test: No-op changes, all test should pass
Change-Id: I3cd4854b150d827393bff6eada7aa9a9201dadaa
2023-10-09 14:25:49 -07:00