Commit Graph

3716 Commits

Author SHA1 Message Date
Anushree Ganjam
6642ea0d48 Merge "Add new class for SetPropRule and move outside ShellCommandRule." into main 2024-04-15 17:41:15 +00:00
Jagrut Desai
83fef2d60d Merge "Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon test" into main 2024-04-15 16:41:46 +00:00
Anushree Ganjam
8cac99a8dc Add new class for SetPropRule and move outside ShellCommandRule.
Clean up the mEnableInputTransportPublisherRule from TaplWidgetPickerTest since b/325377690 is fixed now.

This is follow up for ag/26419353.

Bug: 325377690
Test: Manual
Flag: NA
Change-Id: Id55000ac3cb4b88097ad00b97773c39a725711b8
2024-04-12 16:45:18 -07:00
Liana Kazanova
1c0b61377d Merge "Revert "Wait for LauncherModel loaded in waitForLauncherInitialized"" into main 2024-04-12 22:29:53 +00:00
Liana Kazanova
b80c6c347a Revert "Wait for LauncherModel loaded in waitForLauncherInitialized"
This reverts commit f8f00f4233.

Reason for revert: DroidMonitor: Potential culprit for http://b/334162623.  verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Id165df41a87af4757abd3266b8643949ce012a08
2024-04-12 21:30:50 +00:00
Sunny Goyal
4396a935c2 Merge "Using resource overrides for PluginManager instead of code-swap" into main 2024-04-12 20:29:36 +00:00
Schneider Victor-tulias
aec9ae92ea Merge "Wait for LauncherModel loaded in waitForLauncherInitialized" into main 2024-04-12 18:49:52 +00:00
Sunny Goyal
4a22ed81ea Using resource overrides for PluginManager instead of code-swap
Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: Ib1cd50f95873928b9ce104e8e95d21f1dca9c6e3
2024-04-12 11:38:32 -07:00
Jagrut Desai
49d4429881 Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon test
Test: Presubmit
Bug: 319501259
Flag: NONE
Change-Id: I9566b947bc7d5d64953a8c637fefd4fa37cca87c
2024-04-12 11:37:27 -07:00
Vadim Tryshev
2a6ce15290 Merge "Removing users synchronously" into main 2024-04-12 17:19:36 +00:00
Brandon Dayauon
c1de065650 Merge "Fix stale header height being used in scroll to header calculation" into main 2024-04-12 17:00:40 +00:00
Schneider Victor-tulias
f8f00f4233 Wait for LauncherModel loaded in waitForLauncherInitialized
Flag: N/A
Fixes: 326737440
Test: Launcher TAPL tests
Change-Id: I631b370198c393ad84419930c026b6a0ce63ec2b
2024-04-12 12:48:48 -04:00
Brandon Dayauon
5da04b231f Fix stale header height being used in scroll to header calculation
- This fixes the inconsistency of how far down is needed to scroll to since
the values used to calculate the header during drawOnScrimWithScaleAndBottomOffset() is faulty.
- Tweaked the row to scroll to when there are tabs vs no tabs. When there are no tabs, its possible the
header gets cut off most of the time hence subtracting by 1 will help this problem.

bug:332543940
Test locally: https://screenshot.googleplex.com/5y4vYiQcnSMKcA6
manual - before: https://drive.google.com/file/d/14Zj_FyO-3bVfXwuxaqgG_DXMELYS5bQn/view?usp=sharing
after with tabs:
after 5x5: https://drive.google.com/file/d/16rjaut6VqBMxG6uLQSnVTLRhUQnAANZ5/view?usp=sharing
after 4x5: https://drive.google.com/file/d/16jCPN8BewwuIQobt0t6tdVouUKpp1CdI/view?usp=sharing
after 4x4: https://drive.google.com/file/d/16VFQb5s6IfrpjRU9PmLlAJWjh1zIo77o/view?usp=sharing
after 3x3: https://drive.google.com/file/d/16VFQb5s6IfrpjRU9PmLlAJWjh1zIo77o/view?usp=sharing
after 2x2: https://drive.google.com/file/d/16N6Myuv9VtXgI1p4sIuV23iupea7jYLQ/view?usp=sharing

after no tabs:
after 5x5: https://drive.google.com/file/d/17H1oF_9fJnrtSqmJJqQyyn4upuM2CsoG/view?usp=sharing
after 4x5: https://drive.google.com/file/d/178Vu3SvnvSPODIfaR0oz6-jPVYDDNMaA/view?usp=sharing
after 4x4: https://drive.google.com/file/d/16yt_5ePPR7kwSrZlo5Sj3x0DqHoQKqYP/view?usp=sharing
after 3x3: https://drive.google.com/file/d/17HqebtHWcEHg-i9AfqHEVdl4YnQhX06P/view?usp=sharing
after 2x2: https://drive.google.com/file/d/17HqebtHWcEHg-i9AfqHEVdl4YnQhX06P/view?usp=sharing

after tablet:
landscape: https://drive.google.com/file/d/16JQGs0A3ifKpgqrpQwIzssrXbH-OC0Ej/view?usp=sharing
portrait: https://drive.google.com/file/d/16LmLnOEB6XkuAkAcgvP2mKHe5QQqG1oh/view?usp=sharing

Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD

Change-Id: If8a70cc71e9cff4a7f8d3b648e3e59c414e40ee5
2024-04-11 16:22:11 -07:00
Vadim Tryshev
2c72271915 Removing users synchronously
Bug: 302400996
Test: presubmit
Flag: N/A
Change-Id: Iac1863039cbb9d612abe416b7aee135eec25f223
2024-04-11 15:59:41 -07:00
Randy Pfohl
c21b0000b5 Revert^2 "fixing tests to match new abstraction"
8e4c0b7afb

Change-Id: I9875d6f9c16f1406d0818164a98e790c2b101650
2024-04-11 08:58:22 -07:00
Priyanka Advani
1d6851083b Merge changes from topic "revert-26414135-RecentsViewContainer-MEROZZOKJQ" into main
* changes:
  Revert "abtracting Activity from recentsView through recentsview..."
  Revert "fixing tests to match new abstraction"
2024-04-10 23:58:09 +00:00
Sunny Goyal
63bf93cf65 Merge "Freezing legacy feature flags" into main 2024-04-10 22:29:24 +00:00
Priyanka Advani
8e4c0b7afb Revert "fixing tests to match new abstraction"
Revert submission 26414135-RecentsViewContainer

Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.

Reverted changes: /q/submissionid:26414135-RecentsViewContainer

Change-Id: Ibafc66cf3677d24e7912d55cb45c948cb6519df7
2024-04-10 21:31:14 +00:00
randypfohl
f75709e78b fixing tests to match new abstraction
This change will let us move from activity to other parent views for recent viewss

Change-Id: I2424d94f799f87b2d2262da96b289aac6dfadee9
2024-04-10 09:14:38 -07:00
Treehugger Robot
42d496d163 Merge "Fixing null check causing test breakage" into main 2024-04-10 02:03:31 +00:00
Sunny Goyal
efc3c46419 Fixing null check causing test breakage
Bug: 333609600
Test: Presubmit
Flag: None
Change-Id: Ic44df00ba945c79010c2cf99a034cca2b5d6c161
2024-04-09 17:04:46 -07:00
Sunny Goyal
8049369af8 Freezing legacy feature flags
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags

Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
2024-04-09 15:26:07 -07:00
Himanshu Gupta
6c089d7ac1 Merge "Adding TAPL tests for Private Space in Quickstep." into main 2024-04-09 21:12:09 +00:00
Sunny Goyal
3b00e7909a Merge "Using resource override instead of code-swap for ApiWrapper" into main 2024-04-09 20:33:20 +00:00
Alex Chau
55ef24c229 Merge "Add task menu item to move task to Desktop" into main 2024-04-09 20:31:47 +00:00
Himanshu Gupta
0d400993a9 Adding TAPL tests for Private Space in Quickstep.
This CL adds an initial test, that creates
private profile and verifies the elements
present in unlocked state.

More tests will be followed in next CL.

Doc: go/private-space-tapl

Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: NA
Change-Id: I6032f4531818031991a5d51e23cfad22518250e6
2024-04-09 20:30:31 +01:00
Sunny Goyal
11117d9b2a Using resource override instead of code-swap for ApiWrapper
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Iac19f32e64d2c76ed5b4f8592943ee4ae7af51b5
2024-04-09 11:14:44 -07:00
Vadim Tryshev
5940c59a2c Merge "Honoring @PortraitLandscape annotation in presubmit" into main 2024-04-09 16:26:14 +00:00
Alex Chau
3c0729c462 Add task menu item to move task to Desktop
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing

Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
2024-04-09 16:35:55 +01:00
Sunny Goyal
8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Uwais Ashraf
fe1a9c36b7 Merge "Use script to auto-enable all tests that are currently working" into main 2024-04-09 00:01:05 +00:00
Sunny Goyal
89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Vadim Tryshev
47f192f3be Merge "Restoring the full set of combinations in testDragShortcutToMultipleWorkspaceCells in presubmit" into main 2024-04-08 23:02:42 +00:00
Jordan Silva
65972d5ba4 Merge "Update save app pair test to validate when icon chip menu is disabled" into main 2024-04-08 22:08:49 +00:00
Uwais Ashraf
7a0150d02e Use script to auto-enable all tests that are currently working
Fix: 325088906
Test: presubmits passing, gradle robo run passing locally
Flag: NA
Change-Id: I481bfe9caeb8cc18b3e01ec8b7a58fb0eb36fdaa
2024-04-08 20:59:23 +00:00
Jordan Silva
a3eff1fe96 Update save app pair test to validate when icon chip menu is disabled
This CL adds a validation in the test to check if save app pair action is available in the overview actions. Kept the validation to check if save app pair is available in the menu only for overview icon menu flag enabled.

Bug: 330515672
Flag: N/A
Test: TaplTestsSplitscreen
Change-Id: I3097180a24b430f2310d11ddec36e6d6cf4982fb
2024-04-08 12:30:51 -07:00
Treehugger Robot
adbdfe2ac7 Merge "Fix failing LauncherIntentTest." into main 2024-04-08 16:43:28 +00:00
Sebastián Franco
5ccac93d0a Merge "Adding even more tracing for the tests" into main 2024-04-05 18:26:54 +00:00
Himanshu Gupta
b04262784d Fix failing LauncherIntentTest.
Bug: 332894108
Test: atest Launcher3Tests
Flag: NA
Change-Id: I654a45d5a9371aa9da74ae89a0513bf203e27981
2024-04-05 18:11:06 +01:00
Brandon Dayauon
bcb6a62297 Merge "Apply icon alpha animation to expand/collapse private space." into main 2024-04-05 04:18:48 +00:00
Brandon Dayauon
5cbe7605f6 Apply icon alpha animation to expand/collapse private space.
This change is more so to the Alt 3 motion spec:
https://docs.google.com/presentation/d/1zRwJ8cZbwMleXHfC2hX4CJJMGSI954FK0V3ksXl7fyE/edit#slide=id.g2baced0bfd0_1_25

bug: 299294792
bug: 325455879
Test: locally: https://screenshot.googleplex.com/BYCwSH3yRvkkZ3v and https://screenshot.googleplex.com/44byrRx5GUQkncw
manual video:
expand and collapse from header: https://drive.google.com/file/d/1-qRdcbo6lNvUPOx4QWL6wVhTRzl2TVtE/view?usp=sharing
from toast and close container after locking: https://drive.google.com/file/d/1-ix4CcOIzMhsJH3uZdJA1vcV8BvY91T9/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD

Change-Id: I4cde4b8626cf3271880fee697f2fb6bc780eab60
2024-04-04 14:54:28 -07:00
Vinit Nayak
247c6ac8ec Merge "Allow app pairs in folders" into main 2024-04-04 17:55:34 +00:00
Alex Chau
312dd2f5bb Merge "Reland "Update Split button visibility based on DeviceProfile change"" into main 2024-04-04 12:17:38 +00:00
Treehugger Robot
14381e119d Merge "Fix failing test." into main 2024-04-04 11:18:25 +00:00
Alex Chau
7d0edb46ac Reland "Update Split button visibility based on DeviceProfile change"
This reverts commit 38bc885de9.

- Always request layout of action_buttons after changing visibility of its children
- Update Split button visibility based on DeviceProfile change in updateDimension() only
- Update Split button visibility based on 3P launcher in initialization only
- Also simplified action_buttons to wrap_content and layout in middle of parent
- Also removed the space between buttons and use marginStart
- Fixed TAPL to not expect save app pair button on phone. Before this CL actions_buttons are still on view hierarchy despite they're not visible on screen.

Fix: 321291049
Fix: 329255757
Test: Clear all tasks, fold, launch app, swipe up to Overivew; repeat in RTL
Test: OverviewImageTest
Flag: None
Change-Id: I9ecf872279f6f07d2d9bc33fb09031568023cb77
2024-04-04 11:58:35 +01:00
Jeremy Sim
a596f589c4 Allow app pairs in folders
This CL substantially refactors folders to be able to take contents of type AppPairInfo. App pairs can now be moved in and out of folders, and launch from folders.

This CL contains only logic and model changes; animation and style changes (for dropping items into folders, color changes to app pair surfaces, etc.) will be in a following CL. Another CL (hopefully) will contain tests. I'm planning to submit them together, but this patch should also be able to stand alone with no issues (except janky transitions).

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, more to follow in another CL.
Change-Id: I73732fcaefbdc61bf6e02a5be365962b8bbc3e41
2024-04-03 16:47:42 -07:00
Himanshu Gupta
2cf24c84bf Fix failing test.
Moving to All Apps view is not required as we are
already on the same view during `moveToSearchView`
invocation.

Bug: 329152799
Test: LauncherIntentTest#testAllAppsIntent
Flag: NA
Change-Id: Ia618eaa1999a9db663dd09bb7c150b5a51dedc36
2024-04-03 18:51:33 +01:00
Sebastián Franco
0e0a7ed6ba Merge "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty" into main 2024-04-03 15:26:31 +00:00
Sebastián Franco
966156e363 Merge "Fix widget dissapearing because of change of appWidgetId" into main 2024-04-02 18:52:21 +00:00
Sebastian Franco
2b724ec00d Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Bug: 329935119
Test: NA
Flag: NA
Change-Id: I86c0620d6207b09f04c8038932ed34f4444a6626
2024-04-02 11:42:17 -07:00