Commit Graph

11392 Commits

Author SHA1 Message Date
Alex Chau
44dd5b7b28 Merge "Only skip stash animation when going to/from Launcher" into tm-qpr-dev 2022-12-20 09:32:04 +00:00
Bill Yi
c326b7849f Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-20 06:00:39 +00:00
Sihua Ma
04c89fe38e Merge "Add QuickstepWidgetHolder for widget handling" into tm-qpr-dev 2022-12-19 18:22:38 +00:00
Alex Chau
bd535c46d7 Only skip stash animation when going to/from Launcher
- Added a cehck on chagnedFlags before skipping stash animation, in additional to !isHotseatIconOnTopWhenAligned check

Fix: 262835548
Test: manual
Change-Id: I5a90213bc0b3f34609a074ba887adbf113e04120
2022-12-19 17:16:08 +00:00
Alex Chau
4537638dfd Merge "Polish hotseat and taskbar with 3 buttons" into tm-qpr-dev 2022-12-19 11:37:39 +00:00
Luca Zuccarini
49d07b1688 Merge "Update timings for the Home <> All Apps transition." into tm-qpr-dev 2022-12-19 11:10:14 +00:00
Bill Yi
10d62429ab Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I29e6fce19e6e759d5d837d28c77a1adb282588eb
2022-12-19 01:42:12 -08:00
Brian Isganitis
0f33761d1d Merge "Add ACCESS_SHORTCUTS to quickstep manifest." into tm-qpr-dev 2022-12-19 03:45:19 +00:00
Brian Isganitis
a1808c3e49 Merge "Delay hiding Taskbar EDU until entering home or overview." into tm-qpr-dev 2022-12-18 22:48:39 +00:00
Thales Lima
6a59006592 Polish hotseat and taskbar with 3 buttons
Change margin spaces and logic of how many items the hotseat and taskbar should show.

Fix: 246424857
Test: DeviceProfileDumpTest
Test: HotseatWidthCalculationTest
Change-Id: I8ec71c56a0aa362483c43d6400c762d12cf45f5b
2022-12-17 11:20:21 +00:00
Bill Yi
fe1df2a780 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-17 01:38:47 +00:00
Sihua Ma
1db8bc2467 Add QuickstepWidgetHolder for widget handling
Fix: 235358918
Test: Manual
1. Rebooted the device and verified that widgets are still updating properly
2. Changed the theme from dark to daylight, then from daylight back to dark and verified that widgets are working
3. Kept the device on for several days and verified that widgets are still updating
4. Turn on auto-rotate for the launcher, open any app then exit, verified that widgets will not vanish and reappear
5. Add & remove widgets from the screen, added widgets are still updating

Change-Id: I98ee902f7d16b47bd77626201a4fefc897ba17a0
2022-12-16 11:56:36 -08:00
Alex Chau
2f581b799b Merge "TaskbarViewController should only translate on rotation if icon is aligned with hotseat" into tm-qpr-dev 2022-12-16 19:06:25 +00:00
Jeremy Sim
e8eb4a3c48 Merge "Fix bug with Taskbar second-app-selection animation" into tm-qpr-dev 2022-12-16 18:30:38 +00:00
Alex Chau
98d33cdff9 Merge "Set iconsSizePx of Taskbar's DeviceProfile directly" into tm-qpr-dev 2022-12-16 16:45:21 +00:00
Bill Yi
1885c489fc Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib1739767f90d758017acc10481fcac0bb0fffcc9
2022-12-16 04:45:21 -08:00
Alex Chau
adbbc2f7fa TaskbarViewController should only translate on rotation if icon is aligned with hotseat
Fix: 254191175
Test: With 3 button, rotate at home and overview, nav button are at expected position. Repeat with TASKBAR_IN_OVERVIEW flag off.
Change-Id: I1e629e6be92c4793d3dfdb0dac60c3bfce886e7a
2022-12-15 22:04:16 +00:00
Alex Chau
a68164d89e Set iconsSizePx of Taskbar's DeviceProfile directly
- After ag/20691430, iconScale no longer scale app icons (I should rename it later, after QPR2), so we'll need to set the desired iconSize directly for Taskbar's DeviceProfile
- Extracted setting iconSizePx and testSizePx out of updateIconSize, as they are no longer affected by scaling. This allows TaskbarActivityContext to set desired iconsize and then call updateIconSize

Bug: 256976071
Test: Test Taskbar icon size in different density
Change-Id: I741c178b59e0d8ecb4c63689e68767622329379c
2022-12-15 17:05:12 +00:00
Sunny Goyal
09fab7ee7d Merge "Unifying multiple all-apps implementations" into tm-qpr-dev 2022-12-15 17:03:05 +00:00
Bill Yi
ac3930bede Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-15 14:08:52 +00:00
Schneider Victor-tulias
85127b4f47 Merge "[DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds." into tm-qpr-dev 2022-12-15 09:42:15 +00:00
Jeremy Sim
768e9ec8c0 Fix bug with Taskbar second-app-selection animation
This patch makes it so that the correct animation will play when the user selects a second app from the Taskbar.

Previously, when the user selected a second app from the Taskbar, an animation would play showing the expansion of the app -- but it would come from the wrong place. The error occurred because when we calculate the animation start position, we assume that the starting view is located in the DragLayer, which fills the whole screen. But in cases where the starting view is located in the Taskbar, the root view is actually the TaskbarDragLayer, which only fills an area on the bottom part of the screen.

Fixed by adding a check to see if the starting view is part of the TaskbarActivityContext, and if so, adding an offset to calculate the correct DragLayer coordinates.

Fixes: 258692761
Test: Manual
Change-Id: I4026676fefe1e4c5cdf9d9a47d95c0d6e64672e8
2022-12-14 17:48:14 -08:00
Bill Yi
78ea5bd253 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie78d4416033cc14e78a40771e66524517e2e7d28
2022-12-14 14:15:06 -08:00
Brian Isganitis
f5c099b528 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev 2022-12-14 20:25:21 +00:00
Sunny Goyal
adb364a104 Unifying multiple all-apps implementations
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher

Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
2022-12-14 11:27:12 -08:00
Jon Miranda
a0743cf62c Merge "Taskbar All Apps button visual updates" into tm-qpr-dev 2022-12-14 19:00:18 +00:00
Brian Isganitis
8216a26bfe Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev 2022-12-14 18:54:42 +00:00
Alex Chau
5c1eb61391 Merge "Don't scale iconSize and textSize in non-default display size" into tm-qpr-dev 2022-12-14 17:15:21 +00:00
Brian Isganitis
338fa3e9ab Delay hiding Taskbar EDU until entering home or overview.
EDU will now end up hiding due to
TaskbarLauncherStateController#onStateChangeApplied closing all AFVs if
we are going to home or overview.

This is a quickfix to make it harder to accidentally close the EDU when
testing out the transient taskbar. We will eventually be moving to a
lighter EDU UI where having gestures occuring behind it will be less
awkward.

Test: Manual
Bug: 260769010
Change-Id: I477abe9339ed10cb3aed8d1a0fbe0e22ac14c7ab
2022-12-13 20:16:29 -05:00
Jon Miranda
e7417ce2ae Taskbar All Apps button visual updates
- Moved to new position
- Using 3x3 icon
- New Colors

Checked with visd that this half is good to go,
will follow up with positioning of the 3x3 icon within
its container.

Bug: 259712417
Test: manual, LTR/RTL modes, transient/persisent models

Change-Id: I298b6dbca004cdb8920e6533fffc8ca83e0197f9
2022-12-13 15:16:01 -08:00
Brian Isganitis
47da4167ea Assign taskbar EDU same interpolator as all apps.
This polishes closing both at the same time when they are on top of each
other.

Test: Manual
Bug: 217261955
Change-Id: Iecb8658b98debb0225d3b59da99ecb34d008971a
2022-12-13 16:43:36 -05:00
Brian Isganitis
2a2f1b6cd3 Polish all apps taskbar unstash behavior for transient and persistent.
- During gestures from taskbar all apps, unstash immediately in
  transient.
- Overlay closes sooner if all apps is open (still done later for EDU).
- Taskbar stashes in overview when All Apps is opened.
- Transient app-window threshold is ignored if All Apps is opened.

Test: Manual
Fix: 262076812
Change-Id: I46b2dcdc75ee0cc15c1b47da2139ff8c20cf618a
2022-12-13 16:24:35 -05:00
TreeHugger Robot
e6cb5467c8 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-13 19:49:16 +00:00
Pat Manning
59c4fff67c Merge "Include taskbar cropped insets in thumbnail aspect ratio difference calculation." into tm-qpr-dev 2022-12-13 18:29:27 +00:00
Jeremy Sim
538281db37 Merge "Use already-running app instances when splitting" into tm-qpr-dev 2022-12-13 18:21:12 +00:00
Brian Isganitis
97db609701 Merge "Move forward initial frame for suggestions asset." into tm-qpr-dev 2022-12-13 17:36:49 +00:00
Alex Chau
be753137a2 Don't scale iconSize and textSize in non-default display size
- Cells should get extra space by reducing borderSpace. If that's still not enough, use 0 borderSpace and distribute the space

Fix: 256976071
Fix: 248348171
Test: manual
Change-Id: I067c1aaa553d7a84caeeb9ce21e80cfaf86a3bed
2022-12-13 16:30:14 +00:00
Pat Manning
0333ec1d21 Include taskbar cropped insets in thumbnail aspect ratio difference calculation.
Bug: 260861673
Test: manual.
Change-Id: I3abed4dfab5dccf99ae81e0f2d0ae840a3aabed5
2022-12-13 11:45:05 +00:00
Brian Isganitis
3ac3a8a3b4 Move forward initial frame for suggestions asset.
The assets were starting with remnants of the previous step.

Bug: 217261955
Test: Manual
Change-Id: Ibf9194afba97def051334a85d172396fb6659213
2022-12-12 14:30:25 -05:00
Andy Wickham
29b95b58ba Merge "Adds header protection on tablet all apps panel." into tm-qpr-dev 2022-12-12 19:08:37 +00:00
Bill Yi
b0c55e8ca3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I43015720f42267d1028be4592081997d9798d7c6
2022-12-12 08:40:40 -08:00
Jon Miranda
a76222d209 Merge "Better support transient and persistent taskbar in taskbar's overlays." into tm-qpr-dev 2022-12-10 02:02:54 +00:00
Brian Isganitis
570c5146d3 Merge "Add logging to investigate updateOverviewTargets state." into tm-qpr-dev 2022-12-10 01:22:13 +00:00
Brian Isganitis
209f10c225 Add ACCESS_SHORTCUTS to quickstep manifest.
Bug: 259601472
Test: Manual, can drag-n-drop shortcuts from taskbar when 3p launcher is
default.

Change-Id: I7b9ed4d16a0b3a17387bf8a39f1ae9bf54767e8e
2022-12-09 19:49:33 -05:00
Federico Baron
9a6a2c8a2d Merge "Move AnimatedFloat from quickstep to launcher" into tm-qpr-dev 2022-12-09 23:33:17 +00:00
TreeHugger Robot
08e1f9f7c4 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-09 23:20:31 +00:00
Brian Isganitis
85ccf120f2 Better support transient and persistent taskbar in taskbar's overlays.
- Transient taskbar nav threshold now works in overlays.
- Delay closing overlay to transient app-window threshold if necessary.
- Persistent taskbar no longer stashes for EDU overlay.
- EDU overlay provides enough bottom padding for transient and
  persistent taskbar.

Test: Manual
Bug: 217261955
Change-Id: I2ae5612ef70a6d09e22f83f8117cdbf2a0a053b8
Fix: 260769010
2022-12-09 11:24:27 -08:00
Sunny Goyal
d31c8baef1 Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev 2022-12-09 15:35:59 +00:00
Ats Jenk
e8c57e94e7 Merge "Check for both proto flags for common logic" into tm-qpr-dev 2022-12-09 00:43:04 +00:00
Brian Isganitis
ddc7ef2eb1 Merge "Add EDU lottie animations for persistent and transient." into tm-qpr-dev 2022-12-08 23:11:27 +00:00