Commit Graph

11309 Commits

Author SHA1 Message Date
Evan Rosky
1754a6a2b2 Merge "Phase-out shell-transit flag" into main 2024-04-26 22:24:35 +00:00
Brian Isganitis
4fcf4016a0 Merge "Make IME force stash the Taskbar." into main 2024-04-26 21:37:23 +00:00
Jordan Silva
4e741082dc Merge "Make TaskMenuViewWithArrow width wrap content with a minimum width" into main 2024-04-26 15:14:46 +00:00
Sam Cackett
dcfe4ef27d Merge "Make DesktopTaskView's icon handling more similar to standard TaskView" into main 2024-04-26 14:53:40 +00:00
Mykola Podolian
6e43b862ce Merge "Fixed issue with shadow for overflow icon" into main 2024-04-26 12:14:39 +00:00
Alex Chau
02ec92b229 Make DesktopTaskView's icon handling more similar to standard TaskView
- Add back touch handling on icon to make task menu work again
- Add back a couple of UI state handling for icon
- Fixed pivot of TaskView to use overviewTaskThumbnailTopMarginPx for calculations
- No longer require `taskView.getTask().icon` to populate TaskMenuView as it's no longer used in the menu; for TaskMenuViewWithArrow, check iconView.drawable instead which will get copied into DragLayer
- Added menu item handling for DesktopTaskView, and aligned GroupedTaksView handling to same mechanism
- Refactored Screenshot and Modal shortcut availability check into TaskShortFactory for consistency with other shortcuts

Bug: 249371338
Test: manual
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I22ee6a5ca3c16a1bd510b0910211823e8c0be71b
2024-04-26 12:32:26 +01:00
Liran Binyamin
9af43dfdf8 Merge "Don't animate new bubble when already expanded" into main 2024-04-25 22:56:57 +00:00
Liran Binyamin
b8cf10a409 Merge "Handle taps on the animating bubble" into main 2024-04-25 22:56:32 +00:00
Brandon Dayauon
46776af42d Merge "Make all apps text focusable by accessibility." into main 2024-04-25 22:34:34 +00:00
Brian Isganitis
b3a3ffa8bb Merge "Remove nav button controller dependency on TIS." into main 2024-04-25 20:51:49 +00:00
Shan Huang
da82c82a2b Merge "Generate progress events from app process for app animations." into main 2024-04-25 19:48:53 +00:00
mpodolian
0786deaedc Fixed issue with shadow for overflow icon
Made icons elevation animates to flat state while bubble bar is being
expanded and animate to full elevation while bubble bar is being
collapsed.

Test: Visual
Fixes: 295027436
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: I8286cd79904367654e319d6a84a307bd64c28d93
2024-04-25 20:16:55 +01:00
Mykola Podolian
cbc77c9818 Merge "Removed arrow animation on selected bubble closing." into main 2024-04-25 17:31:34 +00:00
Evan Rosky
fa1b1332b6 Phase-out shell-transit flag
Shell-transit has been in production for a whole release
now, so disable the flag.

Bug: 294268547
Test: N/A - unused
Flag: NA
Change-Id: Idbc8ffc007b4d0aa01ecdfe47c846c05a937de70
2024-04-25 10:31:24 -07:00
mpodolian
1e7e52b923 Removed arrow animation on selected bubble closing.
We should first decide how we would like to animate dismissal of the
selected bubble, and than implement arrow animation. The issue exists
because background is shrinked without an animation.

Test: Visual
Fixes: 293350516
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: Ia0cf04671bf9e93c98c45c99a21865055462e6df
2024-04-25 15:21:57 +00:00
Alex Chau
2db50a8545 Merge "Avoid adding unnecessary topMargin to TaskThumbnails in DesktopTaskView" into main 2024-04-25 14:45:59 +00:00
Liran Binyamin
4f35ee9968 Don't animate new bubble when already expanded
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
Change-Id: I2fe4eb1ad05cfe693630c3a4a8493fecba81965c
2024-04-25 09:58:17 -04:00
Alex Chau
191f4de96e Merge "Use BaseContainerInterface.getTaskDimension for windowSize in DesktopTaskView" into main 2024-04-25 10:09:58 +00:00
Alex Chau
fa402d1da9 Avoid adding unnecessary topMargin to TaskThumbnails in DesktopTaskView
- TaskThumbnails in DesktopTaskView already take into account topMarign during onMeasure, we should avoid adding double margin
- mTaskThumbnailViewDeprecated's visibility is always GONE, so no need to set margin either

Fix: 336968808
Test: manual, image test to follow-up
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I6a7cb128ead0b042974b95199ab720cafc3bcc18
2024-04-25 10:57:30 +01:00
Holly Jiuyu Sun
96d8b02cf9 Merge "[omni] Read haptic bit from AGSA." into main 2024-04-25 06:09:03 +00:00
Brandon Dayauon
98e150ba7a Make all apps text focusable by accessibility.
From b/330638194, the requirement is that
1. "all apps" can be focusable with talkback
2. "all apps" text is persisted when in accessibility mode.

bug:330638194
Test: manual video: https://drive.google.com/file/d/1QI_F4dUijfnU2ahE2Mg6yrmRJfOVyuVJ/view?usp=sharing
Flag: None

Change-Id: Ibabb92bd9d202221fdc9cfacb585755167898187
2024-04-24 16:10:38 -07:00
Brian Isganitis
79d0569d49 Remove nav button controller dependency on TIS.
This refactor will make it easier to initialize TaskbarManager in a test
environment. Se go/taskbar-controller-tests for context.

Test: TaskbarNavButtonControllerTest
Bug: 230027385
Flag: N/A
Change-Id: I157649ff93b5e1751e6774e2cba2f76750792292
2024-04-24 18:17:00 -04:00
Holly Sun
430fdee946 [omni] Read haptic bit from AGSA.
Bug: 335475048
Flag: legacy OVERRIDE_LPNH_LPH_THRESHOLDS disabled
Test: manual
Change-Id: I8e4ebd9f7faecc236763db367be63cc47e7c0e31
2024-04-24 09:43:58 -07:00
Alex Chau
944a7a61ec Use BaseContainerInterface.getTaskDimension for windowSize in DesktopTaskView
- Instead of using widthPx/heightPx, use BaseContainerInterface.getTaskDimension that takes into account of whether Taskbar is persistent or pinned

Fix: 336788597
Test: Swipe up from Desktop; press recents button from Desktop
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I04d3b5bbc577ea650f8a9dc45cc6d01bca3f6466
2024-04-24 17:33:45 +01:00
Saumya Prakash
8245ac04e3 Merge "Only run search edu when enabled, also make code more generic." into main 2024-04-24 16:13:43 +00:00
Alex Chau
de68b73d16 Merge "Avoid unnecessarily add stub task for Desktop task" into main 2024-04-24 13:28:27 +00:00
Jordan Silva
d889ee37c9 Merge "Add a refactored TaskThumbnailView" into main 2024-04-24 11:53:17 +00:00
Alex Chau
576d6ba60e Avoid unnecessarily add stub task for Desktop task
- ag/27016210 caused a regression for DesktopTaskView, where shouldAddStubTaskView returns false whenever DesktopTaskView have multiple tasks
- This is because for an unknown reason, runningTasks for Desktop task is always a single element array. This will be further investigated in b/249371338
- For now, shouldAddStubTaskView will still match DesktopTaskView if any runningTasks matches any of the tasks

Bug: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Test: Swipe up from desktop
Flag: NONE
Change-Id: I40cff473595a21ad1619bcdbde30bb8bfd600e15
2024-04-24 12:25:03 +01:00
Treehugger Robot
f87a1ec91e Merge "Add permanent TaskView logs to track taskIds being launched" into main 2024-04-24 10:14:44 +00:00
Alex Chau
aa10f54ace Add permanent TaskView logs to track taskIds being launched
Sample logs:
```
04-24 09:26:08.713 12608 12608 D TaskView: launchTaskInternal - launchExistingSplitPair: [1078, 925]
04-24 09:26:11.092 12608 12608 D TaskView: launchTasks - composeRecentsLaunchAnimator: [1078, 925]
04-24 09:26:13.940 12608 12608 D TaskView: launchTaskAnimated - startActivityFromRecents: [933, -1]
04-24 09:26:16.254 12608 12608 D TaskView: launchTasks - composeRecentsLaunchAnimator: [933, -1]
```

Bug: 310064698
Test: manual
Flag: None
Change-Id: Ic190bc9ea749ba4c8324832be8bc86112947b9ba
2024-04-24 09:26:20 +01:00
Alex Chau
0e5a4bb4bd Merge "Add stub task when matching TaskView is grouped while runningTasks is not grouped" into main 2024-04-24 07:07:50 +00:00
Brian Isganitis
5247849454 Make IME force stash the Taskbar.
This change moves the IME flag to be part of FORCE_STASHED rather than
STASHED_IN_APP, since there are cases where we are not in an app but
still want to stash the IME.

You can still bring up transient taskbar over IME since we do not set
the IME flag for transient mode (see TaskbarStashController#shouldStashForIme() first guardrail).

Test: Manual
Flag: N/A
Fix: 336592511
Change-Id: Iafa32b1a52f4bfbc0d3a4e77b19c82149dc42d0a
2024-04-23 18:30:24 -04:00
Uwais Ashraf
e21525da40 Add a refactored TaskThumbnailView
- Live Tile, swipe (left+right) and dismiss working
- Tests of ViewModel state transitions
- Deprecate the old TaskThumbnailView
- Renaming TaskThumbnailView to TaskThumbnailViewDeprecated

Fix: 335440878
Fix: 331754672
Bug: 331753115
Test: TaskThumbnailViewModelTest
Test: Attached video on bug
Flag: ACONFIG com.android.launcher3.enable_refactor_task_thumbnail DEVELOPMENT
Change-Id: I063b957fe6e56960970dcaadc641848fbd73251c
2024-04-23 23:05:14 +01:00
Saumya Prakash
17cd6ca62a Only run search edu when enabled, also make code more generic.
We only need to run the Search edu if it is enabled on devices. The code
itself is also made more generic in terms of method and variable names.

Fix: 330401405
Test: Enable and disable the search function and check whether the edu tooltip shows
up for each specific use case.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
2024-04-23 22:02:15 +00:00
Alex Chau
492965326e Add stub task when matching TaskView is grouped while runningTasks is not grouped
- Completely rewrote shouldAddStubTaskView to simplify the logic

Fix: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Flag: None
Change-Id: I2f33f91956d485957cedf43ccd684f16d42803be
2024-04-23 20:37:44 +01:00
Winson Chung
a9ccb34d1c Merge "Migrate PackageManagerHelper to MainThreadInitializedObject" into main 2024-04-23 18:10:56 +00:00
Sunny Goyal
edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Fengjiang Li
02ff0add09 Merge "[Launcher Jank] Schedule LauncherApps#getAppUsageLimit on single bg thread" into main 2024-04-23 17:46:26 +00:00
Gustav Sennton
568e0bff90 Merge "Show running apps in Taskbar when in Desktop Mode" into main 2024-04-23 14:02:11 +00:00
Alex Chau
0e64dbe149 Make TaskMenuViewWithArrow width wrap content with a minimum width
- Also add a end padding for the text
- http://screen/3yTa8tmJfJuVf2t

Fix: 331555315
Test: OverviewMenuImageTest
Flag: NONE
Change-Id: Ic9bc2799cd25f87d2ec6c7ce83d50d060513a292
2024-04-23 11:53:48 +01:00
Gustav Sennton
0b33b172fb Show running apps in Taskbar when in Desktop Mode
In Desktop Mode: show currently running (Desktop) apps in Taskbar

Bug: 332504528
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT

Change-Id: I10dec022f4b16562e81d7cbd5f9ce835474e9d20
2024-04-23 10:43:27 +00:00
Sunny Goyal
10fa016352 Fixing MainThreadInitializedObject
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
2024-04-22 17:04:33 -07:00
Liran Binyamin
5905d55a9d Merge "Only animate bubbles when in app" into main 2024-04-22 21:38:39 +00:00
Liran Binyamin
3232d8a5e7 Only animate bubbles when in app
We currently animate bubbles on home but the animation hasn't been implemented properly yet, so ensure we don't play the animation on home.

This also deflakes some tests that fail because we're not yet handling interruptions while animations are playing.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Fixes: 333796110
Fixes: 333910495
Fixes: 336086185
Test: https://android-build.corp.google.com/builds/tests/view?invocationId=I78600010269170812&testResultId=TR95029270629703599&redirect=http://fusion2/ac10ec72-4e02-4573-86be-59ecb823ecd1
Change-Id: I99de02cbaebeb6c930a1368ea65562aa178f6762
2024-04-22 19:11:25 +00:00
Fengjiang Li
7686997079 [Launcher Jank] Schedule LauncherApps#getAppUsageLimit on single bg thread
b/336326937 shows that getAppUsageLimit is being called a lot and it's scheduled on a thread pool, which is causing quite a lot of contention and should be scheduled on a single thread

Fix: 336326937
Flag: NONE
Test: presubmit
Change-Id: Ie041e72f2bff9f5d2dbfa4ce3c63a4bb2e5b08d4
2024-04-22 11:24:04 -07:00
Schneider Victor-tulias
77d3524b1b Merge "Remove debug tracing for b/332386996" into main 2024-04-22 18:01:57 +00:00
Schneider Victor-tulias
abf9f308a5 Remove debug tracing for b/332386996
Flag: N/A
Fixes: 332386996
Test: TaplTestsQuickstep
Change-Id: I0d0aa5d5654dbf391269333eb4808d36f5e645ed
2024-04-22 16:16:42 +00:00
Mykola Podolian
1f40fa0e7f Merge "Updated pointer to match visual specification." into main 2024-04-22 16:06:39 +00:00
Winson Chung
bb32b7e0de Migrate PackageManagerHelper to MainThreadInitializedObject
- This is in preparation for other things that can be loaded with
  PMH initialization and prevents duplicate temporary helpers from
  loading this many times.
- Most calls in PMH can use the app context, but one call requires
  starting activities/showing toasts so that one needs to take the
  context and can be made static instead.

Bug: 323112914
Test: atest NexusLauncherTests
Change-Id: Id11c780955880cf49c022cbf2744c41e1b696355
2024-04-22 12:35:03 +00:00
Schneider Victor-tulias
1ebeb1d1ae Merge "Update KQS to better support desktop tasks" into main 2024-04-22 01:37:39 +00:00