Commit Graph

10907 Commits

Author SHA1 Message Date
Liana Kazanova
d8d4fb4375 Revert "Add CUJ Jank interactions for App Pair saving and launching"
Revert submission 26567492-appPairsCUJ

Reason for revert: http://b/330185095

Reverted changes: /q/submissionid:26567492-appPairsCUJ

Change-Id: I73d29fe3618a55622e0daa22c9960e3c5783c275
2024-03-18 18:35:02 +00:00
Vinit Nayak
7ce42078da Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: I5dce4b7e83fb17cc3a70565bfd5ce100a4cf72bb
2024-03-15 14:10:36 -07:00
Andreas Agvard
d632f22258 Merge "Adds new AssistStateManager settings" into main 2024-03-06 09:37:17 +00:00
Fengjiang Li
f114ec5b26 Merge changes Iab1de455,I0c6585e6,I125670d1 into main
* changes:
  [Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
  [Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
  [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
2024-03-06 01:32:17 +00:00
Fengjiang Li
cc1c582d89 [Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
Fix: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: Iab1de455bf23d73b34f4a0d60f7e7a143bd028d1
2024-03-05 14:02:53 -08:00
Fengjiang Li
9280a68bbd [Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
Bug: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: I0c6585e6374db9412c8399ce3fdaf57348043d36
2024-03-05 14:02:53 -08:00
Fengjiang Li
cad1f13d27 [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
For taskbar all apps, the background scrim is child view of AbstractSlideInView, thus scaling AbstracSlideInView during PB swipe will scale down background scrim. There is no need to re-apply scale effect on background scrim separately.

Bug: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: I125670d14bc788664a1371008589e4106496ae2e
2024-03-05 14:02:45 -08:00
Jeremy Sim
e874bd603d Merge "Remove finished TODO" into main 2024-03-05 19:59:40 +00:00
Saumya Prakash
af85ef74cc Merge "Increase the delay in between gesture tutorials" into main 2024-03-05 19:25:23 +00:00
Sunny Goyal
28ade08654 Merge "Using fractions in MultiValueUpdateListener instead of absolute durations" into main 2024-03-05 19:07:46 +00:00
Andreas Agvard
d78d9bb5e2 Adds new AssistStateManager settings
Flag: NONE
Bug: 326143814
Test: Unit

Change-Id: Ie5cbae55452cf283a0ffde18e5237cebae6ee40e
2024-03-05 15:18:18 +01:00
Vinit Nayak
ed92a14eb9 Merge "Fix split selection for 3P launcher with animations off" into main 2024-03-05 01:58:31 +00:00
Vinit Nayak
b0f37b73ff Merge "Revert "Revert "Implements the "Save App Pair" button in Overvie..."" into main 2024-03-05 01:49:25 +00:00
Jeremy Sim
aa8b7b9a02 Remove finished TODO
Finished in ag/25945753.

Test: N/A
Flag: N/A
Change-Id: I7d86a62c5a84d7d68b89ef9f2fa6548df21588aa
2024-03-04 16:09:15 -08:00
Saumya Prakash
959dff1220 Increase the delay in between gesture tutorials
The time in between each gesture's finish page and the start of the next
gesture tutorial was too short. We increased the time we spend on the
finish page by 1000 ms based on this feedback.

Fix: 293967263
Test: Run through the gesture tutorial and note the longer pause in
between each gesture
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED

Change-Id: I2c22e19dff91ac720877e596df90efe7f3cfcd80
2024-03-04 23:51:23 +00:00
Andy Wickham
929005440e Merge "Add custom extra width to trigger LPNH" into main 2024-03-04 22:46:22 +00:00
Vinit Nayak
91b06fb4ac Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-04 12:26:23 -08:00
Andy Wickham
e92f25d7cb Add custom extra width to trigger LPNH
This is defined in dp from the edge of the nav handle. So if you
set it to 48, you can invoke 48dp from the left or right of the
handle (which is roughly the size of an average fingertip).

You can also set it to a negative value to make the invocation
region smaller. This applies to both navbar and stashed taskbar,
and the minimum touch target is always 48dp.

For reference, the navbar width is 108dp and taskbar is 220dp.

Defaults to 0, i.e. you can only invoke within the visible navbar.

Bug: 325118077
Flag: LEGACY CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual
Change-Id: I904a484a99ac4af05de13573fac610b84fd7f0f1
2024-03-04 10:56:16 -08:00
Sam Cackett
ddde91b915 Merge "Translate IconMenu up when the TaskMenu is expanded and moved" into main 2024-03-04 17:17:24 +00:00
Sunny Goyal
f584b32811 Using fractions in MultiValueUpdateListener instead of absolute durations
This ensures that any global animation scale applies properly

Bug: 327645429
Flag: NONE
Test: Manual
Change-Id: I12205429dca5a87208fa9964b3307fb718af4fd0
2024-03-04 09:15:11 -08:00
samcackett
3a2aa5bc04 Translate IconMenu up when the TaskMenu is expanded and moved
Fixes: 327564916
Test: OverviewMenuImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I8acd79a21c7ce1d65496e7e6cb8ea0aa8912738d
2024-03-04 11:43:17 +00:00
Jeremy Sim
742f710168 Merge "Fix bug with TalkBack not reading out SplitInstructionsView" into main 2024-03-03 00:18:47 +00:00
Jagrut Desai
02c56e8258 Merge "Fixing taskbar being unstashed after opening to unfolded mode" into main 2024-03-01 21:43:24 +00:00
PODISHETTY KUMAR
b588e4618b Merge "Revert "Implements the "Save App Pair" button in Overview Actions"" into main 2024-03-01 09:27:08 +00:00
Jeremy Sim
d2c28c7ee3 Fix bug with TalkBack not reading out SplitInstructionsView
This CL sets an accessibility title so that TalkBack and other tools will properly read out the instructions on SplitInstructionsView.

Fixes: 323461342
Flag: ACONFIG com.android.wm.shell.enable_split_contextual TRUNKFOOD
Test: TalkBack announces the instructions immediately when the view appears, and is not interrupted.
Change-Id: I1666f0c374d40b31d732d3cca529f03a7f2f7f28
2024-02-29 21:35:20 -08:00
Jeremy Sim
c8c4fd8aeb Merge "Fix disabled state for non-resizeable app pairs" into main 2024-03-01 05:14:48 +00:00
Vinit Nayak
5c8978c4db Revert "Implements the "Save App Pair" button in Overview Actions"
Revert submission 26391074-save-app-pair-button

Reason for revert: breaks image comparison tests b/327665771
Reverted changes: /q/submissionid:26391074-save-app-pair-button

Change-Id: Ic4580fc39d8394771551f100932157e6ef35c4b7
2024-03-01 01:02:35 +00:00
Jagrut Desai
3c3bef333a Fixing taskbar being unstashed after opening to unfolded mode
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: I91aa947a707e3fc918e617f207e823b2f1460466
2024-02-29 16:17:24 -08:00
Vinit Nayak
b274152194 Fix split selection for 3P launcher with animations off
* When animations were off, the currentState in
FallbackRecentsStateController is incorrect (we didn't need
that check at all)
* Surfaced a bug in MultiValueUpdateListener that is being
fixed in ag/26416537

Test: 1P + 3P launcher all of the following:
starting split from overview with animations and without
rotation
selecting second app before and after rotation
Fixes: 327346105

Change-Id: I4f19119c30a8669bba6ced06e30773f085a78047
2024-02-29 15:50:50 -08:00
Jeremy Sim
31b934f28f Fix disabled state for non-resizeable app pairs
This CL makes it so that app pair creation includes updating some flags on the newly created WorkspaceItemInfos -- specifically the FLAG_NON_RESIZEABLE flag. Previously, flag updating only happened upon launcher restart or package change, which meant that newly created app pairs were missing some flags.

This caused App+Camera pairs to not have the FLAG_NON_RESIZEABLE flag immediately on app pair creation, which affected the disabled state.

Fixes: 323088270
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I96c6ec3723bec2ddaa0af625890b983faf2fe2c7
2024-02-29 13:42:43 -08:00
Saumya Prakash
3fb35d3fb8 Merge "Remove the tint from taskbar themed icons for dark mode." into main 2024-02-29 20:05:15 +00:00
Jeremy Sim
8c383aceda Merge "Implements the "Save App Pair" button in Overview Actions" into main 2024-02-29 19:47:20 +00:00
Tony Wickham
47a85e4607 Merge "Call showCurrentTask again if applyLoadPlan doesn't include running task" into main 2024-02-29 17:19:11 +00:00
Jeremy Sim
41d8ae8a7a Implements the "Save App Pair" button in Overview Actions
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!

This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.

Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
2024-02-28 19:39:04 -08:00
Vinit Nayak
2b4e99344d Merge "Remove A11y node info for SplitInstructionsView" into main 2024-02-29 03:16:28 +00:00
Tony Wickham
bf885ceb5f Call showCurrentTask again if applyLoadPlan doesn't include running task
Test: swipe up from an app that has excludeFromRecents=true, e.g.
Volume Dialog, Home quick settings tile, and Routines widget; ensure
the gesture works as expected (e.g. can quick switch, go home, or to
overview with all tasks visible).
Flag: none
Fixes: 324495241

Change-Id: If3b61f7d1725ee573fad38140bfeb77f3a6cea1e
2024-02-29 00:36:16 +00:00
Saumya Prakash
ba04c0c1dc Remove the tint from taskbar themed icons for dark mode.
We remove the added tint to taskbar themed icons to match how they look
in the hotseat on launcher home screen specifically for dark mode.

Fix: 323952706
Test: Turn on themed icons and dark mode. Compare app icons in taskbar
and in hotseat
Flag: N/A

Change-Id: I4dfe352ca17ef5537e48fcc3cff66ba4fd4f603a
2024-02-28 23:07:07 +00:00
Jagrut Desai
07959348e6 Merge "Fixing taskbar unstashing after unfolding" into main 2024-02-28 15:21:40 +00:00
Eghosa Ewansiha-Vlachavas
7cc75c6a43 Merge changes from topics "removeDesktopMode2", "replaceDesktopWindowingFlag" into main
* changes:
  [2/n] Remove use of `persist.wm.debug.desktop_mode_2`
  [2/n] Replace read-only desktop windowing flag with runtime flag
2024-02-28 14:24:09 +00:00
Vinit Nayak
0edcfa4979 Merge "Update animation timing for split dismiss animation" into main 2024-02-28 04:14:28 +00:00
Sukesh Ram
1909570ed3 Debugging Logs for TaplOverviewIconTest#testOverviewActionsMenu
Add logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: I5f08192bb1143c1d23f8884bb207ce69c5830a41
2024-02-28 01:06:14 +00:00
Vinit Nayak
dfbf253f90 Remove A11y node info for SplitInstructionsView
* Individual text view and cancel button still
have their own a11y actions, but top level
view doesn't need one

Test: Tested w/ switches to ensure parent view
doesn't get selected. Tested w/ Talkback to
ensure we can still cancel through talkback
Fixes: 323462927

Change-Id: I60d21f6e768c59f29f51007f56ff784821487895
2024-02-27 16:54:02 -08:00
Jagrut Desai
e424570af1 Fixing taskbar unstashing after unfolding
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: Iddd10df6e40ee2de4ef08eb18df88d48b7468035
2024-02-27 14:44:26 -08:00
Vinit Nayak
9c29c1e1c4 Update animation timing for split dismiss animation
* We weren't specifying an animation duration for the
dismiss placeholder animation, and it wasn't inheriting
from the animatorSet since that didn't have any duration
set on it.
* Now we explicitly set a duration (usually matching that of
the current launcher state config) to the timings line up
well

Test: Repro steps don't show bug. Also tested on large screen dismissing
contextual split from overview and home, seems fine
Fixes: 314860754

Change-Id: I701e4f88c1ddd92561da4fb76715a859f587c91e
2024-02-27 12:10:44 -08:00
Schneider Victor-tulias
7e0703eca0 Merge "Fix blocked gesture handling on failed startRecentsActivity calls" into main 2024-02-27 18:53:13 +00:00
Sam Cackett
fe2ff288de Merge "Set max height on TaskMenuView and scroll if too many elements" into main 2024-02-27 17:02:51 +00:00
Treehugger Robot
287e981ce9 Merge "Fix bouncing of task view when dragged past dismiss threshold." into main 2024-02-27 16:41:59 +00:00
Uwais Ashraf
dddafae44e Fix bouncing of task view when dragged past dismiss threshold.
Before: https://screenshot.googleplex.com/56AHSMFkNwC76BV
After: https://screenshot.googleplex.com/AjuWqZaSNxmNYn8

Other cases after:
https://screenshot.googleplex.com/oaNotdg79v7LGUA
https://screenshot.googleplex.com/8SVtzpokbvmAzpv
https://screenshot.googleplex.com/87uRqmEAasBMQz2

Fix: 319577620
Flag: NA
Test: Manual (animation), analyse setPlayFraction log - see screenshots
Change-Id: Ib1f24182b8fc0f6ea1ff07125f25dbfc206ae5c2
2024-02-27 14:15:48 +00:00
Luca Zuccarini
0547036143 Merge "Move remote animation utils to the Animation lib." into main 2024-02-27 13:53:59 +00:00
samcackett
6c93e88faf Set max height on TaskMenuView and scroll if too many elements
Video of functionality: http://shortn/_pz6qhz5yxM

Fixes: 210466650
Test: Manual
Flag: NONE
Change-Id: I8b7873cf03857ee3be047ab30388e679f7a95bfd
2024-02-27 12:45:53 +00:00