Commit Graph

18015 Commits

Author SHA1 Message Date
Saumya Prakash
cc0a69e0ca Increase Done button size to be more accessible for the gesture tutorial
Touch targets have to meet a minimum of 48 dp to meet accessibility
requirements. The Done button in the gesture navigation tutorial menu
was previously too small.

Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Fixes: 319752098
Test: Opened the gesture tutorial menu in smaller and larger screens.
Change-Id: I7d9b856ad4829e4ffe26a7df00f42e5e4fcf1b2e
2024-01-22 23:15:09 +00:00
Winson Chung
5a1c88629b Merge "Remove path to provide Launcher with the nav bar surface" into main 2024-01-22 21:10:51 +00:00
Vinit Nayak
520f284e3a Merge "Implement bounce animation for invalid split target" into main 2024-01-22 20:57:29 +00:00
Jagrut Desai
d176477b7f Merge "Fixing folder drawLeaveBehind() with Taskbar Pinning enabled" into main 2024-01-22 19:40:58 +00:00
Sunny Goyal
7ec2e11b0c Merge "Implementing an unfold animation using CannedAnimationController" into main 2024-01-22 19:06:41 +00:00
Anushree Ganjam
e6760e6855 Merge "Pause the prediction update until the app launch transition ends." into main 2024-01-22 19:05:36 +00:00
Jagrut Desai
f5a27ac0c5 Fixing folder drawLeaveBehind() with Taskbar Pinning enabled
Test: Manual
Bug: 320579559
Flag: NONE
Change-Id: If0c7cb7cf8deb89868cb34c310c91fd0cf028643
2024-01-22 10:08:09 -08:00
Anushree Ganjam
b3bf0276e4 Pause the prediction update until the app launch transition ends.
b/319162661 issue is similar to hotseat updates on app click : b/148800229 and ag/10235572

So we will pause the prediction updates until the app launch transition is complete.

See https://b.corp.google.com/issues/319162661#comment9 and https://b.corp.google.com/issues/319162661#comment10 for bug report
analysis.

Before fix: https://b.corp.google.com/issues/319162661#comment11

After fix: https://b.corp.google.com/issues/319162661#comment12

Bug: 319162661
Test: Manual
Flag: NA
Change-Id: I797ce982569c7950628368b854fb3b6766f0fc28
2024-01-22 09:51:05 -08:00
Sam Cackett
77a7bf2ac7 Merge "Use app short name in Overview IconAppChipView" into main 2024-01-22 14:46:00 +00:00
Jeremy Sim
d9c91a45e8 Implement bounce animation for invalid split target
When the user selects an app pair as a split target, the split instructions view will now bounce up and down to prompt the user to select something else.

Fixes: 315529271
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I1ff194449db2263b266404f42a75ebc35ee6077c
2024-01-22 12:23:58 +08:00
Winson Chung
c05363a620 Remove path to provide Launcher with the nav bar surface
- It's not currently being used at all, and with the taskbar/navbar
  unification we will likely not need it going forward as well

Fixes: 318651465
Test: Builds
Change-Id: I909c0165468e8da9c3ca2df4ba98da9dcc43eb53
2024-01-20 22:13:41 +00:00
Tracy Zhou
e66ed03992 Merge "Update task bar height update logic to consider screen rotation cases" into main 2024-01-20 02:12:19 +00:00
Sunny Goyal
3ef2768922 Merge "Simplyfing SystemShortcut rendering" into main 2024-01-20 01:11:36 +00:00
Tracy Zhou
a009a5e82e Update task bar height update logic to consider screen rotation cases
When home screen rotation is enabled, instead of updating taskbar height (assuming that folded task bar is always on the bottom of screen display), we should update taskbar width instead.

Bug: 313371759
Test: try out both folded and unfolded 3-button and gesture nav modes, enable home rotation, make sure all the nav buttons are functional and visible when they should be.
Change-Id: I16f53d9e9c3cd0229fc50b73613b032a96322b97
2024-01-19 16:58:03 -08:00
Tony Wickham
7eceb5b101 Merge "Revert to passing mIsStashed to StashedHandleViewController again" into main 2024-01-20 00:38:16 +00:00
Federico Baron
2b691f67b4 Merge "Add logs to debug b/318394698" into main 2024-01-19 22:38:23 +00:00
fbaron
e5e37faa1f Add logs to debug b/318394698
Flag: NONE
Test: n/a
Bug: 318394698
Change-Id: I3142dafeae0ba31713f514e690c5b7bb730541b0
2024-01-19 13:24:18 -08:00
Tony Wickham
c4df8c2ec6 Revert to passing mIsStashed to StashedHandleViewController again
- Fixes case where handle is initially invisible but will be stashed
  and visible, e.g. when launching an app from home screen
- To fix the original issue of sampling happening unnecessarily for
  three button nav, also check supportsVisualStashing()

Fixes: 321257120
Flag: None
Test: Launch an app from home in gesture nav mode
Test: testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Change-Id: I1f26436de3081fd00f75a5921010e361e9a9f34e
2024-01-19 20:25:25 +00:00
Bill Yi
f00c59e2f4 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-01-19 18:49:23 +00:00
Sunny Goyal
9f226dff72 Simplyfing SystemShortcut rendering
Instead of opening the popup again when the status of AppSharing
changes, updating the UI in-place.

Bug: 321179015
Test: Presubmit
Flag: N/A
Change-Id: I6d7bd8cdf2014fd881324347e3e01b8e7e84ef1e
2024-01-19 10:48:54 -08:00
Sunny Goyal
defc9058a1 Merge "Cleaning up some unused notifications functionality" into main 2024-01-19 16:39:12 +00:00
samcackett
548c4d0e8d Use app short name in Overview IconAppChipView
Fixes: 313649435
Test: Build & Run
  Open an app with a longer name, like Google News or Youtube Music.
  Open "Overview". IconAppChipMenu should have a short name like "News"
  or "YT Music"
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Ieb449c5e574dd3c7b88a9cd3979175cbc91ef3eb
2024-01-19 14:35:13 +00:00
Johannes Gallmann
3cbcdaff19 Merge "Attach launcher protection scrim to the opening target instead of Launcher's surface." into main 2024-01-19 08:31:32 +00:00
Sunny Goyal
e0c1649d87 Cleaning up some unused notifications functionality
Bug: 321154530
Test: Presubmit
Flag: N/A
Change-Id: I1ff2a4f19595659d89e7d72ee1b29036bbd54d8f
2024-01-19 00:21:02 -08:00
Anushree Ganjam
917619a06a Merge "Remove Pin Prediction shortcut from private space app." into main 2024-01-18 21:45:23 +00:00
Bill Yi
b5c58ab125 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic18cb29c11bae16ae1f9e91c16f444045ede1137
2024-01-18 13:11:49 -08:00
Sunny Goyal
2c206400a2 Implementing an unfold animation using CannedAnimationController
Bug: 297057373
Flag: aconfig enable_unfold_state_animation DISABLED
Test: Manual
Change-Id: Iaa352133ebf06ab74b9ba4b8c4d3523f27666089
2024-01-18 11:49:37 -08:00
Anushree Ganjam
245402984d Remove Pin Prediction shortcut from private space app.
Before: https://screenshot.googleplex.com/68S4y4efJWQkyYk.png
After: https://screenshot.googleplex.com/8XdwUFGsYvHkEQ4.png

Bug: 319250810
Test: Manual
Flag: aconfig com.android.launcher.enable_delete_private_space_pin_shortcut DEVELOPMENT

Change-Id: I33ef2cc35c31f86101197405502d84ad98b36bdc
2024-01-18 11:17:09 -08:00
Saumya Prakash
b617daa6c6 Merge "Add standalone taskbar edu tooltip for the pinnable taskbar feature" into main 2024-01-18 01:41:14 +00:00
Anushree Ganjam
cbfa8043c8 Merge "Add "Don't suggest app" shortcut to suggested apps." into main 2024-01-17 22:25:17 +00:00
Saumya Prakash
dddebdff0c Add standalone taskbar edu tooltip for the pinnable taskbar feature
This change adds in a standalone edu window for the pinnable taskbar
feature. The reason for the change is to educate users about pinnable
taskbar to those who have already seen taskbar edu before.

Fixes: 302589411, 300161174
Test: Went through taskbar education taskbar with the flag on and off.
Check that the standalone pinning taskbar only shows up if previous
taskbar education was already completed.
Flag:  ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I03a5fb05ae5f15892421a57355f6d503de56d9fd
2024-01-17 21:23:30 +00:00
Andy Wickham
32f2cae290 Merge "Allow stashed taskbar to be long pressed." into main 2024-01-17 21:09:15 +00:00
Shamali Patwa
56fd022d10 Merge "Filter shortcuts in the widget picker activity." into main 2024-01-17 14:15:51 +00:00
Pat Manning
5b7f564395 Merge "Add flag guard to hover actions in TouchInteractionService." into main 2024-01-17 13:05:20 +00:00
Pat Manning
8bcf485ac4 Add flag guard to hover actions in TouchInteractionService.
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states NEXTFOOD
Test: Manual.
Bug: 306745595
Change-Id: I74818f517b84c4aba8a7dd4a77397495595bbef5
2024-01-17 11:44:31 +00:00
Andy Wickham
caf0c35661 Allow stashed taskbar to be long pressed.
Bug: 319175012
Test: Manual and unit test
Flag: NA
(see other change)

Change-Id: Ic8ac68d21c64a909a1035339d36f9c3b50a8963c
2024-01-16 21:43:46 -08:00
Vinit Nayak
701d267b05 Add log when user attempts to split with widget
Bug: 295467097
Flag: none

Change-Id: Ice6cdc7a2db85c8efca7d4e1bc74a0cdc367a9ab
2024-01-16 23:54:19 +00:00
Vinit Nayak
fc02f88d1b Merge "Sync split dismiss anim scrim fadee timing with taskbar to home anim duration" into main 2024-01-16 23:21:03 +00:00
Shamali P
ddde81f4c0 Filter shortcuts in the widget picker activity.
In its current state the WidgetPickerActivity only allows adding widget
items, so to match the state, updated it to show only widgets.

manual test - https://screen/cast/NDUxMjg1NjI0MTM0MDQxNnwxMzE4MzNhOS1mZg

Bug: 320495335
Test: atest Launcher3Tests
Flag: N/A
Change-Id: Ifa75f457219efef49e104efc428d369187db2710
2024-01-16 21:19:16 +00:00
Vadim Tryshev
f93d6ed80e Demoting new flaky test testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme to postsubmit
Bug: 320490387
Test: presubmit
Flag: N/A
Change-Id: I1e94ebc71089f68354069fd932be98dd53926ec4
2024-01-16 10:50:52 -08:00
Schneider Victor-tulias
0c8439e17d Merge "Update the KQS app launch animation to match the spec exactly" into main 2024-01-15 18:42:37 +00:00
Johannes Gallmann
898b9af9a2 Merge "Fix stuck wallpaper with predictive back" into main 2024-01-15 09:51:42 +00:00
Anushree Ganjam
64614a1ec6 Merge "Add null check since LauncherUserInfo can be null." into main 2024-01-13 05:04:14 +00:00
Anushree Ganjam
32b5ac61e0 Add null check since LauncherUserInfo can be null.
Bug: 319142187
Test: Manual
Flag: N/A. Crash in tests.
Change-Id: Iaa9fc1b8e7c2c09621d984bfdeb9012bcc479ef8
2024-01-12 18:05:29 -08:00
Tony Wickham
dc566559d0 Merge "Improve Taskbar touchableRegion debuggability" into main 2024-01-13 01:38:18 +00:00
Jagrut Desai
a15b88f484 Merge "Adding Taskbar Pinning Analytics again." into main 2024-01-13 00:54:14 +00:00
Sunny Goyal
39f235154e Merge "Fixing some launcher model tests" into main 2024-01-12 23:04:39 +00:00
Jagrut Desai
fff93577e8 Merge "Update enableTaskbarNoRecreate logic" into main 2024-01-12 22:31:15 +00:00
Charlie Anderson
9fc2fa34b3 Merge "Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag." into main 2024-01-12 21:37:17 +00:00
Jagrut Desai
777f3a4b9d Merge "Fix TaskbarDividerPopupView vertrical Arrow offset" into main 2024-01-12 21:18:27 +00:00