Commit Graph

349 Commits

Author SHA1 Message Date
y
cb5bb989e3 [Work] Fix duplicate work button issue
Bug: 195623679
Test: manual
Change-Id: I882c5f7a196e07fa0dab3a2f27437abd233ec782
2021-08-30 00:27:21 -07:00
Hyunyoung Song
44424572b4 Fix work profile disable button falsing
Bug: 191996677

Test: before this CL: when tapping on immediately above keyboard when
keyboard is translating or when onApplyWindowInset is called, the
hidden (GONE) view handles touch and triggers work profile to be disabled.

After the CL, the button view is not attached to the parent container
when on personal tab. Also, the onApplyWindowInsets method translations
can only be called when work tab is selected.

Change-Id: Ib3e9a5c4b3280052f9ccb62a199ed256ae4e094f
2021-07-14 15:09:26 -07:00
Hyunyoung Song
2d8856537e Merge "Remove flicker when dismissing snackbar" into sc-dev 2021-07-02 20:29:59 +00:00
Hyunyoung Song
1b68cbb822 Remove flicker when dismissing snackbar
Bug: 191972314
Test: manual

Change-Id: Icf185b89c07b363ec44c77ba3ac1bdeb34e30e59
2021-07-02 11:35:53 -07:00
Hyunyoung Song
9804c0472e Fix NPE inside dispatchRestoreInstanceState
Bug: 192559704
Test: manual
Change-Id: I212518ac4a7feddd8e87f4be601332ea62e99313
2021-07-01 23:26:57 -07:00
Hyunyoung Song
0b9537e6fc Rebind recycler views if launcher activity restarted
Bug: 185038312
Test: manual
TL;DR;;
What was attempted but was too much refactoring of the code.

Failed attempt #1: try re triggering the search.
This was not trivial as SearchSession object is yet created.

Failed attempt #2: Restoring AdapterItems in AlphabeticalAppsList
This meant AdapterItems class and also it's children
had to extend Parceleable object.

Ultimate fix:
Original issue of dupe view id among slice and work recyclerview
should be fixed. And restoring should just work.

Change-Id: I1bddd6aa5bc736ade3b02f69aa947d64cfa467d6
2021-06-29 14:52:57 -07:00
Samuel Fufa
1e70c235cf Merge "Polish work for work profile" into sc-dev 2021-06-23 18:58:29 +00:00
Samuel Fufa
ce820f51e2 Polish work for work profile
Bug: 191478900 Work profile toggle specs
Bug: 187761192 Fix issue where Installing app scrolling apps to top
Bug: 191121890	Fix issue where top of AllApps becomes empty when returning to AllApps
Bug: 191477329 String change for work profile paused state
Test: local
Change-Id: Idbaab333566b54afa3dc879f5bea98e1f77c44fc
2021-06-23 16:46:52 +00:00
Hyunyoung Song
7d3b25734a Hide searchbox when header protection is on.
Bug: 191726215
Test: manual
Change-Id: I086a05654faf718683ebe5dfbcf64b6bd6347ca8
2021-06-23 00:44:49 -07:00
Samuel Fufa
e79b469986 Allow AllApps to restore current selected tab on activity recreate
This CL also fixes:

- Wrong tab selection on RTL
- Fixes header protection hydraulic scroll issue
- Work toggle button text background contrast

Bug: 186005219
Bug: 191250799
Bug: 191227662
Bug: 191349226
Test: Manual
Change-Id: I3777474c954ed0d542ac38ff552367904be147d3
2021-06-17 16:59:56 -05:00
Samuel Fufa
efa5df380c Merge "Refactor FolderInsetAnimationCallback to be used with any view" into sc-dev 2021-06-17 18:48:49 +00:00
Samuel Fufa
d04a92d1ed Refactor FolderInsetAnimationCallback to be used with any view
- Update ic_corp_off icon to outline
- Remove shadow from work toggle
- Translate work fab when keyboard is shown

Screenshot: https://screenshot.googleplex.com/593tEg7bE4kSS4y

Bug: 191251404
Bug: 191250785
Test: local
Change-Id: Ie7dddfd17eb90575a1e1f67e281070dd8d268f8d
2021-06-16 17:25:53 -05:00
Hyunyoung Song
d2ad97989c Merge "All apps motion" into sc-dev 2021-06-16 20:14:46 +00:00
Hyunyoung Song
54a44d4c44 All apps motion
Bug: 189970327
Test: manual

TL;DR;;

equation: settleVelocity = releaseVelocity + interpolator 2nd deritive * t

Change-Id: I86fec339523fbc3bb347dec4affbd2d1c063d13d
2021-06-16 11:17:59 -07:00
Samuel Fufa
dfc274364e Add work toggle to work apps paused message
This also fixes scrolling issues in landscape

Bug: 186857875
Bug: 161929312
Bug: 189983516
Bug: 190567199
screenshot: https://screenshot.googleplex.com/BCjcyJFqJo6W4Tr
Test: local
Change-Id: I7bcf23cc4be2fca936eba41342731789eb8f3292
2021-06-15 14:58:05 -05:00
Samuel Fufa
154ad76f40 Introduce inline education for work profile
Bug: 186857875
Test: local
Change-Id: I796b04fbb3ffc714a01104107774819d35034f93
2021-06-14 01:01:42 -05:00
Samuel Fufa
2f346b8666 Merge "[AllApps][Work] Introduce work toggle Fab" into sc-dev 2021-06-14 02:34:58 +00:00
Samuel Fufa
45e0e26971 [AllApps][Work] Introduce work toggle Fab
Screenshot: https://screenshot.googleplex.com/C4r7kKPxv3PKdyN
Bug: 186856928
Test: on-device
Change-Id: Ifd8ce20fcf2247a6e80537dc7631458e594a8a63
2021-06-13 20:01:20 -05:00
Anton Hansson
17ef90b2cb Merge "Revert "[AllApps][Work] Introduce work toggle Fab"" into sc-dev 2021-06-11 15:02:25 +00:00
Anton Hansson
fc235903ab Revert "[AllApps][Work] Introduce work toggle Fab"
This reverts commit 08cca82eca.

Reason for revert: broke errorprone build
Bug: 190150515

Change-Id: I1d8707392310e745713b8780bdb957299b88a3a6
2021-06-11 14:05:07 +00:00
Hyunyoung Song
8f3d9eba02 Merge "Revert the squish translate from all apps" into sc-dev 2021-06-10 03:53:33 +00:00
Samuel Fufa
08cca82eca [AllApps][Work] Introduce work toggle Fab
Screenshot: https://screenshot.googleplex.com/C4r7kKPxv3PKdyN
Bug: 186856928
Test: on-device
Change-Id: I69ffa0ef367b182688e69c730fc9dee1afa7cadd
2021-06-09 17:13:07 +00:00
Hyunyoung Song
afa327d176 Revert the squish translate from all apps
Bug: 189973274
Bug: 189975416

Test: manual, attached video on the bug
Change-Id: I881a2b79462e8d420b3dcb6a6b98adbe9e8e0394
2021-06-09 09:47:29 -07:00
Samuel Fufa
41f15a107f [Search] Resolve afterimage when closing allapps
Preview: https://drive.google.com/file/d/1AM6WAY4kImCgHueNvH6eXUtnHgK3U6vo/view?usp=sharing&resourcekey=0-3mzBobzFuzQXCNZRUlToYA
Test: Manual
Bug: 184711608
Bug: 188556051
Change-Id: Ib43c71083460c236347dd1f340b1ad95d7d4aa15
2021-05-25 17:34:18 -05:00
Samuel Fufa
76b33404b5 [Search] Update all apps header protection
- Introduce spacing between header protection and search box
- introduce vertical padding for "personal | work" tab
- animate tab header protection color change when docking

Test: Manual
preview: https://drive.google.com/file/d/1eS4B7hcLExxCdjSp1IzBcziKm-9w87UR/view?usp=sharing&resourcekey=0--mtY6bCC9GJpFSUC8I5d6w
Bug: 184946772
Change-Id: I840af27c7557f1dffd7a15874aa09833514b4bb1
2021-05-18 17:14:14 -05:00
Samuel Fufa
0a709374ae Fix header protection interactions
Bug: 184711608
Bug: 187790639
Preview: https://drive.google.com/file/d/1MDh71t8DQn0SxTQY3-GZTfIlGECQs_Kn/view?usp=sharing&resourcekey=0-ep9C3q9Meo8cQShVJqnKEw
Test: Manual
Change-Id: I9c939a894adc3e9cd1ed1beb7c11f9c2dd673824
2021-05-18 16:28:55 +00:00
Hyunyoung Song
b83e8f614a Merge "Catch NPE for AllAppsContainerView.dispatchRestoreInstanceState" into sc-dev 2021-05-17 21:44:16 +00:00
Hyunyoung Song
05d3e86401 Fix searchbox font and other specs
Bug: 187654557
Test: manual, see attached image on the bug

Change-Id: I570df1bcc926258ca406810ea10b3d1fdd3cd2ec
2021-05-17 01:08:44 -07:00
Hyunyoung Song
2cecad8e75 Catch NPE for AllAppsContainerView.dispatchRestoreInstanceState
TL;DR;;
Missing view id for work profile recycler view
caused restore failure as there are different type of
views that contains same id. However, even after that fix,
lack of view id in slice views generated by other process
causes failure when mFlags on these not restored slice
views needs to be accessed.

Bug: 186596139
Test: manual
Change-Id: I8a97598c27acbc05ac8a39c50fe5862e541d62ad
2021-05-17 00:47:28 -07:00
Samuel Fufa
ff9fcd8e6b Fix CastError on SecondaryDisplay
Bug: 185566696
Test: Manual
Change-Id: I0dbf0edccc40172e802cc197e200a8fb9502b4ec
2021-05-13 10:27:11 -05:00
Samuel Fufa
890240f470 Merge "[WorkProfile] Fix Work profile switch synchronization" into sc-dev 2021-05-12 21:12:31 +00:00
Samuel Fufa
9e4a9bc777 [WorkProfile] Fix Work profile switch synchronization
Bug: 185566696
Bug: 185557440
Test: Manual
Change-Id: Ie9c94c6daee233d299aa63dc5bcb258a37c321e4
2021-05-12 20:40:20 +00:00
Hyunyoung Song
222a59e79a Implement overshoot and squish motion in all apps open
Bug: 187475924
Bug: 183062683
Test: manual

Change-Id: I33b6c647c45ff467c6d49cf3796f92ca366ab3f1
2021-05-11 13:49:45 -07:00
Samuel Fufa
acebd1f69a [Search][Motion] Introduce header protection in AllApps
ScrimView exposes ScrimDrawingController that allow FloatingHeaderView to observe AllApps scroll progress and draw header protection on Scrim. In addition, search box independently adopts header protection background to ensure proper clipping behavior.

Test: local
preview: https://drive.google.com/file/d/1_E577AAJ0LBg0zrKJQSEJK9GQnrtx7uv/view?usp=sharing&resourcekey=0-MTxjlB3xWyJ3qPvr4qMdig
Bug: 184946772
Change-Id: I64c0f4f50d26c475d31542148a15c7c145588d3f
2021-05-07 11:15:05 -05:00
TreeHugger Robot
04b5003b2e Merge "All apps motion tuning [1/n]" into sc-dev 2021-05-05 02:58:48 +00:00
Hyunyoung Song
96d4ec4544 All apps motion tuning [1/n]
- reverse spring direction to enable overshoot
- change master interpolators for swipe / fling

Test: manual
Bug: 183001675
Bug: 186121789
Change-Id: I5869d84daab99594cc2a261cb8f5d28e0293afe1
2021-05-04 23:59:48 +00:00
Sunny Goyal
19ff728b92 Adding support for determining split layout for launcher.
> Simulating the windo wmanager API to get available device
  profiles until final API
> When a device has multiple internal displays, and with both
  tablet and phone possibilities, it uses a split workspace layout

Bug: 186160341
Bug: 175782275
Test: Manual
Change-Id: Ieff2329acac7cdd6b9abe6f96cd459cd45bd0efe
2021-05-03 14:48:28 -07:00
Hyunyoung Song
4fc2428474 Change spring effect on All Apps
Bug: 185942188
Test: Manual

Change-Id: Ic460d85e19074b7f2b2adf714b211591f0d23a08
2021-04-21 00:34:27 -07:00
Hyunyoung Song
9e7faadba4 Reduce the spring effect on All Apps
Bug: 185290838
Test: manual
Change-Id: Ie48ae27071d113603451c4198e762f03feaaa0d6
2021-04-13 20:48:25 -07:00
Sunny Goyal
0b5b8d4969 Fixing all-apps appearing as blank
Since all-apps and homescreen do not share any QSB, we can
change the alpha for hotseat QSB directly

Bug: 184122599
Test: Manual
Change-Id: Ifa610fe75ad22cfe8a7d816ed2b48e2b9411c4c1
2021-03-31 14:59:54 -07:00
Sunny Goyal
b456429a95 Merge "Using edgeEffect for overscroll in all-apps and widget tray" into sc-dev 2021-03-30 17:13:04 +00:00
Hyunyoung Song
8a5e0c8e27 Merge "Remove AA+ decorator logic from aosp code" into sc-dev 2021-03-30 16:19:58 +00:00
Jonathan Miranda
efeb27ce9c Merge "Update All Apps apps per row when DeviceProfile changes." into sc-dev 2021-03-30 14:52:44 +00:00
Sunny Goyal
c5797893e7 Using edgeEffect for overscroll in all-apps and widget tray
Bug: 183966408
Test: Manual
Change-Id: Iea1b67504fc59fc7ce2ec657bf8ac7e3d8bfff1c
2021-03-29 12:35:39 -07:00
Hyunyoung Song
c07e3b3c28 Remove AA+ decorator logic from aosp code
Bug: 179495850
Test: manual

Change-Id: I7e029e4970f45a0f7c410533f85335a95e4e448c
2021-03-29 00:29:09 -07:00
Jon Miranda
3f28e0686d Update All Apps apps per row when DeviceProfile changes.
This fixes the bug where # all apps columns does not change as
expected during a grid change.

Bug: 183534910
Test: manual, visual
Change-Id: Id6a6abd3c7c5e9f36be96eef92961ecfdd477ac9
2021-03-23 17:29:31 -04:00
Samuel Fufa
c6995f3eb2 [Search] Resolve work/personal tab overlap with A-Z list
This issue was caused due to launcher falling out of sync with DEVICE_SEARCH_FLAG. This change makes AllApps views agnostic of search input type when rendering layout.

Bug: 182591985
Test: local
Change-Id: Ic015b68e110eea9ab5184325f2a3633a5c7d15cc
2021-03-23 11:09:15 -05:00
Samuel Fufa
147527229b [Search] Tie quick-launch and focus highlight
Highlight and quick-launch item should be determined by Search service pipeline based on quick_launch flag on SearchTarget

Bug: 183083807
Bug: 183083682
Test: Manual
Change-Id: I0191474653deca7e1ecd01fa92c90efcdbb9a8dc
2021-03-19 15:38:38 -05:00
Sunny Goyal
c373e1c642 Adding an optional QSB in hotseat
Removing sections in all-apps during transition and treating
it as a single unit

Bug: 175137718
Test: Manual
Change-Id: I55a501d80b5903f1a9d92a26b3784784fd9e50fd
2021-03-17 12:21:44 -07:00
Hyunyoung Song
a79c7e4227 Merge "Hide keyboard only when scrolling happens" into sc-dev 2021-03-16 16:42:58 +00:00