Fix: 402219336
Test: Turn on Talkback and make sure "Add new desk" is read out when
the AddDesktopButton is focused
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Ia500114d2ac73edabe935be1920af76b0e3d4242
Fix: 413764920
Flag: EXEMPT. Bugfix
Test: Manual. Open recents, tap menu, "Close" should now be "Clear"
Change-Id: Ic727ae7dedf23af65a382e0c7bfe455653865819
This change removes the legacy skip button from the gesture tutorial. It
is not needed in the current version of the gesture tutorial.
Bug: 400485351
Test: Run tutorial and observe no change as this was for the legacy
tutorial that is no longer in use.
Flag: EXEMPT bugfix
Change-Id: Ice384a0b5811fdc0d09da58ade68539aa146d84d
Flag: EXEMPT bug fix
Fixes: 392616062
Test: launched all set page with empty and test devices names
Change-Id: I885603f64478642c825e15563f5526399114f0f2
These resources changes will be used in a follow up CL that implement
the nudge view.
Note that most of the values and layout are temporarily placeholder and subject
to change in follow up CL as the mock is being finalized.
Bug: 398033012
Test: Manual
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I1d88da404637200b44bd2a3a5719f52d68011fbf
Adds accessible pane name, and content description for keyboard quick
switch view. Improves content description for task views, by having it
provide the task position in the task list. Also, sets a task content
description immediately when it gets associated with a task, even if the
task description is not available at the time. Accessibility focus for a
task may be requested as the KQS view is shown, so the task view should
have a meaningful content description from the start.
While here, update KQS to focus first task by default when opened from
taskbar.
Bug: 399032757
Test: Manual, with Talkback enabled - open KQS via taskbar overflow view,
and Alt+Tab, and verify Talkback announcements are informative
(e.g. no "Pixel launcher" utterance).
Also atest NexusLauncherTests:TaplTestsKeyboardQuickSwitch
Flag: EXEMPT bug fix
Change-Id: I3688954ab383035c1db35c5eb7a0ddf9a39a123f
Bug: 397878339
Bug: 397975686
Flag: com.android.launcher3.taskbar_overflow
Test: Enter taskbar overflow, and open the overflow view.
Verify that arrow buttons are present; tapping them scrolls in the
correct direction; when fully scrolled in a direction, the
associated arrow button is disabled; verify arrow buttons have hover
effects.
Open Alt+Tab view, verify no buttons are present if the view cannot
be scrolled (and present if the view can be scrolled).
Change-Id: Id1c37a2967a629aeb4b3cc2dc5ff7efb21c90cbe
Create an accessibility action to create application bubble from the
taskbar icon
Fixes: 394159660
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Trigger "Actions" for the taskbar icon. One of the action
would be "Create application bubble". Activate action for the selected
icon. Observe new bubble is created.
Change-Id: I9b20631e0536e9bef23bed24389a7804bb45a4e2
This cl adds the unpin option by tracking the hotseat/taskbar state. The
option shown is determined by the following conditions:
1. If the target non-predicted item is on the taskbar, shows
"Unpin from taskbar"
2. If the taskbar is not full, that is, reaching the limit of the
available spaces, and the target item is anywhere outside of the
taskbar, including All apps, shows "Pin to taskbar".
3. If the taskbar is full, simply don't show any shortcut option.
This cl also removes the option that will be shown on Launcher
homescreen or hotseat, as further UX alignment is needed.
One note about why the pin shortcut is not implemented in the
getShortcuts(). The reason is that getShortcuts does not have the
ItemInfo of the triggered item, while the SystemShortcut.Factory doesn't
have the hotseat/taskbar information. The simplest way at this point is
to check all the conditions in the controller and then manually add the
shortcut into the list.
Bug: 375648361
Test: Manual, Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I7d048bcb1b00f78651e909fbfcd911052a4cd4ef
This cl also removes forced hidden annoucement and focus for Bubble Bar since they are annouced together.
we are keeping the tasksbar show annoucement and focus since it is only way to notify user of taskbar being shown on screen until we figure out proper solution with talkback team.
Test: Manual, Presubmit
Bug: 383928453
Flag: EXEMPT bugfix
Change-Id: I2c32ea393da2509af49e2fce795759a6903b0451
The header has an app icon, app title and a close button. Currently
clicking on the close button does nothing. Will address it in a
following CL.
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353965691
Change-Id: I5e0303a02d5f8afd16a5f5f0335a8fa489ff98f2
According to accessibility guidelines, we shouldn't be using this API and definitely not for notifying a user a task has closed, so just removing this use case altogether.
Fix: 386001961
Test: Enable Talkback.
Open some apps.
Go to Overview and dismiss an app.
Talkback shouldn't announce "Task closed".
Flag: EXEMPT bugfix
Change-Id: I1a55017cbd4825103b9a8b93532b06276f28aef6
DisplayController caches the display size, so when the user unfolds a foldable, the screen size is incorrect, which messes with the touch handling. Using DeviceProfile instead.
Flag: EXEMPT bug fix
Fixes: 361694048
Test: fold/unfold device during home/back/overview tutorial steps
Change-Id: Ie49f677f97ea5ddb0f91d2e662677edaaa81860a
- Adds placeholder view to represent the Overflow affordance.
- Overflow button will always appear as long as there are any
recent apps.*
- Click / long click on the button will open KeyboardQuickSwitch
- Relevant code is Guarded by Flags.taskbarOverflow.
*Note that this is not up to spec. This change is only meant to
setup the codebase to support Taskbar Overflow.
Bug: 368119679
Test: open app, enter desktop windowing, click overflow button
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I47f96797408fda09e8326ba8fb7981c91de80e36
- Updated recent apps KQS task view
- Added a desktop mode KQS task view
- Did some code cleanup to support this more cleanly
Flag: EXEMPT ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 357512178
Test: Used KQS with and without desktop mode; opened recent apps and desktop mode
Change-Id: Ib47a8a7f41b56af1ba9d0cbec65ababf8aad7881
This CL changes the way the "Cancel" string is bolded, so that it can automatically react to the "Use bold text" accessibility setting and double-bold itself appropriately. (Previously the bolding was hard coded in XML, this change allows TextView to handle its own bolding.)
Fixes: 323111449
Test: Visually confirmed
Flag: EXEMPT bugfix
Change-Id: Ie50b5a1aab569cebd0101814b6ba896ad4151e7b
When bubble bar has bubbles, it will be expanded together with taskbar.
Include information about bubble bar appearing together with the taskbar
announcement. During expand include the location of the bubble bar,
whether it is on the left or right.
Bug: 344675357
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, enable talkback and check that taskbar expand announcement
includes information about bubble bar, check that when bar is on left,
announcement includes left and bar is right, announcement says right
Change-Id: I116ed531fe7032940478451508b37f4fd0bc98ff
Add a talkback announcement that tells the user when bubble bar expands
or collapses. The announcement includes the bubble name.
Bug: 344670486
Flag: com.android.wm.shell.enable_bubble_bar
Test: expand bubble bar by tapping on it, hear the announcement
Test: collapse bubble bar by tapping on it, hear the announcement
Test: expand/collapse bubble bar from action menu, hear the announcement
Test: use action menu to move expanded bubble bar from one side to the
other, make sure there is no announcement
Change-Id: I3908bda3eb9e3eb201067fb2c465c3a883ce73d4
Bug: 344670180
Test: open accessibility action menu on bubble bar. use menu to
- expand bubble bar
- dismiss bubble bar
Test: when bubble bar is on the right, the action menu has an option to
move bubble bar to the left only, use menu to move bar to the left
Test: when bubble bar is on the left, the action menu has an option to
move bubble bar to the right only, use menu to move bar to the right
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id875a43927bc3410a83d1342b9456330c9521085
Move strings to quickstep as bubble bar is in that folder.
Bug: 344670947
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, check talkback on bubble bar and bubbles
Change-Id: I2da1f0c8fc6ec13f04b2c75c9eb1a27ec598d564
Bug: 309481654
Change-Id: Id7b5db662d578eb625171055d30c37cd59e7d73c
Flag: EXEMPT refactor since it is removing obsolete code with no changes to current behavior.
We only need to run the Search edu if it is enabled on devices. The code
itself is also made more generic in terms of method and variable names.
Fix: 330401405
Test: Enable and disable the search function and check whether the edu tooltip shows
up for each specific use case.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD
Change-Id: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
While we wait for a way to display a sreenshot of the desktop statically, using a placeholder solution.
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 335632286
Test: TaplTestKeyboardQuickSwitch
Change-Id: I2525ab89eb3a5a902e7ab55367187d87aada1f10
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing
Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
This change adds a new education tooltip for pinned taskbar that teaches
users how to use Circle to Search invoked through the action key. It won't run on
transient taskbar or if the user is in 3 button mode. The disclosures at
the bottom of the tooltip link to localized legal agreements for the feature.
Fix: 330401405
Test: Pin the taskbar and observe that the next time an app is launched
the edu shows up. After dismissal it shouldn't show up again.
Additionally, click on the disclosures and ensure they launch.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD
Change-Id: I64aea3004aca77c3ec81b81dea0cfab7a9c1e272
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN
Reason for revert: Test failure in question wasn't related to this topic b/328016248
Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN
Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!
This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.
Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
This change updates the feedback shown to users to align with the
strings in figma for the back gesture tutorial.
Fix: 300919987
Test: Went through both the redesigned and previous gesture tutorial and
ensured the updated strings show up in the redesigned tutorial.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Change-Id: I057af6e8631b86ffaec8093ffbfbeae01c9d917c
The current character limit for the taskbar pinning edu subtitle does
not fit many translations. We are increasing the character limit to
enable proper translations.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Fix: 323943380
Test: N/A
Change-Id: I56225711c475e617451e5db0b1c226e3603e5c02
This change adds in a standalone edu window for the pinnable taskbar
feature. The reason for the change is to educate users about pinnable
taskbar to those who have already seen taskbar edu before.
Fixes: 302589411, 300161174
Test: Went through taskbar education taskbar with the flag on and off.
Check that the standalone pinning taskbar only shows up if previous
taskbar education was already completed.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I03a5fb05ae5f15892421a57355f6d503de56d9fd
