Commit Graph

17621 Commits

Author SHA1 Message Date
Jagrut Desai
ad88561612 Merge "Migrating Tapl Overview test to platform scenario project" into main 2024-01-05 18:53:24 +00:00
Jordan Silva
49374a905d Merge "Reduce the iconSize to fit inside the cellSize when display size largest" into main 2024-01-05 18:33:40 +00:00
Jordan Silva
10ce3f5fe2 Reduce the iconSize to fit inside the cellSize when display size largest
For some cases, even after reducing the iconSize and iconTextSize the content of the cell does not fit inside the cell height. This issue leads the icons or labels of the folders and workspace to crop. To prevent the icons of cropping when the display size or font size is largest (for acessibility) we allow the icons and labels shrink until it fits inside the defined cell height.

Bug: 314285621
Bug: 316087877
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: NexusLauncherImageTests
Change-Id: Id8da3ee89658b9fc53a36d8605b9bd56ce168834
2024-01-05 13:24:32 -03:00
Charlie Anderson
67636269dd add metrics for when db grid migration fails
Flag: ACONFIG enable_launcher_br_metrics TEAMFOOD
Test: locally verified
Bug: 307527314

Change-Id: Iab84a337d76d63bb3bc2ed81fdf4b6fd50dc5661
2024-01-05 10:48:40 -05:00
Jakob Schneider
b88ba19233 Merge "Add support for progress bar during unarchival of app." into main 2024-01-05 10:21:58 +00:00
Charlie Anderson
6c4dde2c4d Merge "Adds a legacy flag to enable Launcher BR metrics." into main 2024-01-05 01:32:11 +00:00
Jagrut Desai
71e8dcca46 Migrating Tapl Overview test to platform scenario project
- Removes tapl overview test form platinum test suite
 - adds individual overview test to platform scenario test.

Test: Presubmit, Manual
Bug: 303256981
Flag: NONE
Change-Id: I7d04dc5dc63ba3a5e63ad03d98760dbd24c974f8
2024-01-04 16:25:17 -08:00
Sunny Goyal
1a8f804195 Merge "Removing ENABLE_CACHED_WIDGET since we now have always listenign widget" into main 2024-01-05 00:02:54 +00:00
Charlie Anderson
a4240c72c0 Adds a legacy flag to enable Launcher BR metrics.
This is necessary because the aconfig flag requires reboot to enable, however backup/restore happens on the first load so the flag will not be ready.

Flag: LEGACY ENABLE_LAUNCHER_BR_METRICS TEAMFOOD
Test: compilation / presubmit
Bug: 305984208
Change-Id: Ida90b1bd485fb037ebf3dde7ad17bf4e462661e6
2024-01-04 17:40:51 -05:00
Charlie Anderson
f0b1ddc038 Merge "Adds restore metrics to RestoreDbTask.java" into main 2024-01-04 22:25:09 +00:00
Andy Wickham
93504b4225 Merge "Ensure header view expected height accounts for tabs." into main 2024-01-04 21:32:13 +00:00
Sergey Pinkevich
f78644b4eb Merge "Revert "Wrong app icon position in seascape mode for RTL layout"" into main 2024-01-04 17:54:32 +00:00
Tony Wickham
97e6c9c214 Merge "Fix KI in test and re-enable for postsubmit." into main 2024-01-04 17:50:35 +00:00
Sunny Goyal
4df719a1e6 Removing ENABLE_CACHED_WIDGET since we now have always listenign widget
> Also using PendingWidgetView for deferred widget view

Bug: 270395008
Flag: LEGACY ENABLE_CACHED_WIDGET enabled
Test: Exising widgets tests pass.
      Verified UI by forcefully rendering deferred widget

Change-Id: Id34f89d778f9f993c1b7ad13f66e57fda9843417
2024-01-04 09:26:10 -08:00
Sergey Pinkevich
387e99f4bc Revert "Wrong app icon position in seascape mode for RTL layout"
This reverts commit 9b6587d80f.

Reason for revert: Show app icons in wrong order

Change-Id: I0fcc6b6f6431a8e596a504f5f7eb2c2d533be887
2024-01-04 14:54:30 +00:00
Jordan Silva
873d49937c Merge "Add ESCAPE key to dismiss Overview" into main 2024-01-04 14:12:28 +00:00
Jordan Silva
9878a7206e Add ESCAPE key to dismiss Overview
This CL adds the functionality of escape key to Overview. It dismisses Overview when the esc key is pressed.
When Overview is showing a Modal Task, it will return to Overview state instead of the Normal state.

Fix: 315283507
Flag: N/A
Test: TaplTestsQuickstep
Change-Id: I02e02f623d9a4aad1c2d6188fdea4e3fc4f96d64
2024-01-04 09:08:44 -03:00
Sergey Pinkevich
e8f4fbf012 Merge "Wrong app icon position in seascape mode for RTL layout" into main 2024-01-04 12:07:40 +00:00
Andy Wickham
f495102326 Ensure header view expected height accounts for tabs.
This was already handled except for the case where there were no
predicted apps and no all apps divider, i.e. suggested apps are
disabled and a work profile is added (so tabs show instead of the
divider).

Why did the other cases work? Predicted apps and the divider are
FloatingHeaderRows which call FloatingHeaderView#onHeightUpdated
whenever they are updated (triggering updateExpectedHeight()).

And why did this sometimes "fix itself" until a reboot? When the
search bar is tapped, the search transition causes the expected
height to be updated. So that is my guess.

The key to this change is to wait to update the expected height
until after we have defined mTabsHidden during setup(). It is
normal for the header to be initialized without tabs and then
updated to show the tabs when the work apps are available. So
this was previously incorrectly using mTabsHidden=true for the
calculations.

Fix: 245516031
Test: Manual (force stop launcher and verify tabs scroll correctly)
Flag: NA
Change-Id: Ifcc2f39649c5494b5f3ebefc1cdddfbefbe5d9a0
2024-01-03 18:54:24 -06:00
Tony Wickham
c5d4e4dcf5 Fix KI in test and re-enable for postsubmit.
- The taskbar stashing logic with hardware keyboards was different
  between tests and user experience; aligned the test to be the
  same.
- There is still a previous test failure that only occurred in
  post submit, so also add ScreenRecord to diagnose it
- Once that is resolved, can promote the test to PRESUBMIT.

Test: testQuickSwitchToPreviousAppForTablet
Flag: NA
Fixes: 318544733
Bug: 314873201
Change-Id: Ia813eb0294d759c40d90cec7a8e9a7e0aea2d917
2024-01-03 23:27:18 +00:00
Andy Wickham
60dcb19a48 Merge "Better handling of insets for All Apps." into main 2024-01-03 22:34:36 +00:00
Federico Baron
8d23a6762d Merge "Fix IllegalArguemntException for ClipIconView#update" into main 2024-01-03 22:28:00 +00:00
Charlie Anderson
1fcf8da4e5 Adds restore metrics to RestoreDbTask.java
Bug: 307527314
Flag: ACONFIG enable_launcher_br_metrics TEAMFOOD
Test: locally verified
Change-Id: I105b17276cf7e2c270c819854a8fbc269b7c81b4
2024-01-03 22:06:44 +00:00
fbaron
3b894e1f70 Fix IllegalArguemntException for ClipIconView#update
The scale was infinity sometimes which means that the view minSize is probably getting set to 0 due to lp height and width being 0, so we do not update the views as they are no longer laid out

Flag: NONE
Test: Opening apps should work fine, but i wasn't able to repro this exception before or after this fix
Fix: 318099222
Change-Id: I1c08346c7ee1d4e89d9c3ba23ee2aa51a451cb31
2024-01-03 12:44:10 -08:00
Sergey Pinkevich
9b6587d80f Wrong app icon position in seascape mode for RTL layout
Bug: 317072320
Test: manual
Flag: NONE

Change-Id: If998033d6008626941eb766dcc96803c25b8bf02
2024-01-03 19:28:52 +00:00
Andy Wickham
99d7d4f2cb Better handling of insets for All Apps.
Changes:
 - For tablet, always center All Apps without applying additional
   insets for things like cutouts.
 - For tablet, allow the panel to span the full height of the
   screen (minus system bars), rather than 5.5 app rows. This also
   ensures the panel fully closes even if there are cutouts.
 - Remove additional padding for vertical bar mode (landscape on
   phones). This was double counting the cutout insets, but only
   for some views, so things were not aligned. Now the apps line
   up with the search bar, and the scroll bar still makes room for
   any side insets.

Before and after examples:
https://drive.google.com/drive/folders/1k0vSzisf4ZuGyp-qR-IF0QwM-IcHBFrZ?resourcekey=0-uxjzuVQ1KA3WwOQ4v6Dh2w&usp=drive_link

Bug: 299923399
Bug: 259617884
Fix: 300761324
Test: Manual
Flag: NA
Change-Id: I136d516260a1343b1198693c73fa389fe0e11cc9
2024-01-03 19:21:01 +00:00
Vinit Nayak
05d5424049 Merge changes I21801b63,I017f1d55 into main
* changes:
  App pairs: themed icons
  Fix bug where app pair icons were appearing empty
2024-01-03 18:26:04 +00:00
Rohit Goyal
2e6010c421 Add support for progress bar during unarchival of app.
* With this change, progress bar should appear whenever app update for archived app reaches non-zero progress.
* Once the update is cancelled, the progress bar should also disappear.

Test: PromiseIconUiTest and manually tested the progress bar using Play Store
Bug: 302115555
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iacf7a0fd865dba34915fa09f59c63a1da6e47315
2024-01-03 23:44:52 +05:30
Jagrut Desai
39e4b611b5 Merge "Refactor TaskbarDividerPopup Open/close animation" into main 2024-01-03 17:00:52 +00:00
Jeremy Sim
14424e9e1f App pairs: themed icons
App pairs now use themed icons when theming is enabled.

Fixes: 312452183
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I21801b63bc3b52da9b2dfff02cc9ec70e679b300
2024-01-03 15:14:31 +00:00
Jeremy Sim
d36d4f3f94 Fix bug where app pair icons were appearing empty
Using similar logic as other BubbleTextViews, checks for PlaceholderIconDrawables and redraws the icons if needed.

Fixes: 316041983
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I017f1d5597fd28d37ca9a8a5758f33468e46f384
2024-01-03 15:13:48 +00:00
Vinit Nayak
a85fa48883 Merge "Improve null safety for app pairs" into main 2024-01-03 15:11:27 +00:00
Vinit Nayak
d6493f4558 Improve null safety for app pairs
- Improves crash safety in AppPairIcon.java. An app pair should never have more or fewer than 2 app members, but if it happens somehow and there is an app pair on the home screen, the device will enter a crash loop that is hard to recover from. Added some safety checks so that it doesn't happen.

Fixes: 317283244
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I2cbd90f028f7c31af6e832b5515502ba992f0b54
2024-01-02 22:22:02 -08:00
Charlie Anderson
81b6b21faf Merge "Adding extensions for backup restore test" into main 2024-01-02 23:30:55 +00:00
Jagrut Desai
25cb918a37 Refactor TaskbarDividerPopup Open/close animation
Test: Manual
Bug: 315848479
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I3c43bd718cef24ec334f7f4884167ecb2ce0cfd5
2024-01-02 15:25:42 -08:00
Charlie Anderson
d6fc23f230 Adding extensions for backup restore test
Bug: 294386159
Test: presubmit
Flag: N/A
Change-Id: I4acc48c0bdd967d3c5463c85acd275a57d4a28ba
2024-01-02 16:19:32 -05:00
Jagrut Desai
2107717252 Merge "Change Tracking Bug for Taskbar pinning feature flag" into main 2024-01-02 20:52:50 +00:00
Fengjiang Li
abd3d6ddcc Merge "Revert " ALLAPPS PREINFLATION to TEAMFOOD"" into main 2024-01-02 20:00:35 +00:00
Jeremy Sim
0c8a38d181 Merge "Fix crash with app pairs and grid migration" into main 2023-12-21 00:07:47 +00:00
Jagrut Desai
5bcad413ec Change Tracking Bug for Taskbar pinning feature flag
Test: Presubmit
Bug: 296231746
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I4be1d2a247f0aa6b39854a667b576a523a8a776a
2023-12-20 11:09:50 -08:00
Federico Baron
1abb9a47b4 Merge "Align QSB with hotseat and workspace icons" into main 2023-12-20 17:36:12 +00:00
Sergey Pinkevich
4d2515b4e2 Merge "Wrong app chip menu position for RTL layout" into main 2023-12-20 12:21:25 +00:00
Sergey Pinkevich
3030a6d74a Wrong app chip menu position for RTL layout
Bug: 315787393
Test: manual
Flag: icon_app_chip_menu
Change-Id: I26846262ada3704afb0da58748df3dae36da5655
2023-12-20 12:20:42 +00:00
Jeremy Sim
ee596789de Fix crash with app pairs and grid migration
This CL makes it so that app pair contents are loaded properly during grid migration, like folder contents.

Fixes: 316052056
Test: Have app pairs on home screen, change home grid (e.g. 4x5 to 5x5), launcher does not crash
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I6a531d0d29d15ed7b8dfe7933690effe5344d941
2023-12-19 22:44:46 -08:00
fbaron
e69b6f49f7 Align QSB with hotseat and workspace icons
The QSB was a bit wider becuase icons visible size is a bit smaller than their actual size due to b/235886078 so we add a workaround to adjust QSB size based on the visible icon size

Bug: 281587788
Test: atest HomeScreenImageTest
Flag: NONE
Change-Id: I593ca2d588f08b830be0b2ac389c747b6f558b91
2023-12-19 13:52:45 -08:00
Helen Cheuk
c225b99be2 Merge "Add radius to widget internal focus to fit new focus outline design" into main 2023-12-19 16:59:50 +00:00
Tony Wickham
054d953a0d Merge "Log app launches via taskbar drag and drop" into main 2023-12-19 16:17:21 +00:00
Himanshu Gupta
ce2b013d31 Merge "Adding methods to access LauncherApps APIs." into main 2023-12-19 11:27:09 +00:00
helencheuk
1b3b67d004 Add radius to widget internal focus to fit new focus outline design
Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I9b11e8bf21dbb5045586907f0fc13577e236c8e7
2023-12-19 11:27:04 +00:00
Sergey Pinkevich
102e54ba05 Merge "Split tasks in RTL mode" into main 2023-12-19 10:19:02 +00:00