Commit Graph

3482 Commits

Author SHA1 Message Date
Sunny Goyal
9d85f52386 Merge "Fixing swipe-up form app in landspace, rotates the surface" into ub-launcher3-rvc-dev 2020-05-08 20:11:56 +00:00
TreeHugger Robot
4d1203efab Merge "Fixing Fallback recents crashes when going to modal state" into ub-launcher3-rvc-dev 2020-05-08 19:46:35 +00:00
TreeHugger Robot
16fb9fac22 Merge "Adding tracing for switching to overview instead of all apps" into ub-launcher3-rvc-dev 2020-05-08 18:39:39 +00:00
vadimt
2794f563a0 Adding tracing for switching to overview instead of all apps
Bug: 156095088
Change-Id: I1257617192e913d06edd0879396957b1e40524b7
2020-05-08 10:39:29 -07:00
Tony Wickham
a8a377cd49 Merge "Cleanup quick switch logic" into ub-launcher3-rvc-dev 2020-05-08 17:22:19 +00:00
Sunny Goyal
302ecabf2c Fixing Fallback recents crashes when going to modal state
> Adding robo tests to prevent such regressions
Bug: 155570625

Change-Id: I5cfbfc454849116f881322e8785dfdbad6f24d08
2020-05-08 10:12:17 -07:00
TreeHugger Robot
9e77f25d52 Merge "Adding tracing for non-detection of Pause" into ub-launcher3-rvc-dev 2020-05-08 16:08:32 +00:00
Sunny Goyal
7a63fb2da6 Fixing swipe-up form app in landspace, rotates the surface
PreviewPositionHelper was getting the Launcher rotation from context,
instead of RecentsOrientationState

Bug: 156042694
Change-Id: I645eccfcb519c59fe2f78ecb1a77d8a315bc36c9
2020-05-08 08:48:36 -07:00
Jonathan Miranda
759995980a Merge "Add logs to debug playtime crash and band aid fix for release builds." into ub-launcher3-rvc-dev 2020-05-08 03:38:50 +00:00
vadimt
091794671d Adding tracing for non-detection of Pause
Bug: 156044202
Change-Id: I16f196db6266a0c3a84b59b7cdeb29863a37ff0f
2020-05-07 20:06:58 -07:00
TreeHugger Robot
0e0bcc7631 Merge "Moving TransformParams to an separate class." into ub-launcher3-rvc-dev 2020-05-08 00:09:05 +00:00
TreeHugger Robot
e4d1a71413 Merge "Disabling OverviewActionsView buttons while scrolling or clear all shown." into ub-launcher3-rvc-dev 2020-05-08 00:02:54 +00:00
Sunny Goyal
f29376bb29 Moving TransformParams to an separate class.
Moving some hepler methods to TransformParams so that some configurations
can be shared easily.

Change-Id: I07fff1e27e4615b56491aebf0ca2a911686ad979
2020-05-07 15:24:38 -07:00
Tony Wickham
cc9fe80323 Cleanup quick switch logic
- Remove mFinishingRecentsAnimationTaskId and related logic;
  track mLastStartedTaskId and mLastAppearedTaskTarget instead.
- Don't finish controller if new gesture is in progress, only
  finish it when the last started task appears (and invalidate
  the handler at that point).
- Remove onTaskAppeared() from GestureState, handle it directly
  in BaseSwipeHandler.
- When the end target animation finishes, possibly change the
  end target from LAST_TASK to NEW_TASK or vice versa,
  depending on the last appeared task.

Bug: 154814771
Bug: 154727089
Bug: 155609695
Bug: 154812078
Change-Id: I38669515d064a131361359087f502783d875ddde
2020-05-07 15:39:57 -05:00
Sunny Goyal
f67db3531b Moving animation configuration and definition out of state definition
This removes cross dependency between StateManager and State object so
that it can be easily generalized

Change-Id: I62851fc4b653655cb40f37023db9651055ec7c9c
2020-05-07 01:33:57 -07:00
James O'Leary
ac327df55c Merge "Revert "Compose gesture integrated fully into Launcher"" into ub-launcher3-rvc-dev 2020-05-07 01:14:44 +00:00
TreeHugger Robot
d13dd3bc44 Merge "Skip setting the controller if the animation is already finished" into ub-launcher3-rvc-dev 2020-05-07 00:14:15 +00:00
James O'Leary
2610bfde05 Revert "Compose gesture integrated fully into Launcher"
Revert "Compose gesture integrated fully into Nexus Launcher"

Revert submission 11035205-compose_gesture_fully_integrated_launcher

Reason for revert: Broke Launcher Android Studio build, quick switch, and home gesture doesn't work if Compose is open.
Reverted Changes:
I2d97b22d5:OverscrollPlugin refactored to use onTouchEvent
Ia19a55f65:Compose gesture integrated fully into Nexus Launch...
I65aa07ac1:Compose gesture integrated fully into Launcher

Change-Id: Ic05c47eb686b3942ba519e76db32977fc568844b
2020-05-07 00:13:47 +00:00
Sreyas
78f53856a9 Disabling OverviewActionsView buttons while scrolling or clear all shown.
Bug: 153469850, 153387526
Video: https://drive.google.com/a/google.com/file/d/1mOc8yubux92iKtXRtSOKTcnjWWzvDgC7/view?usp=sharing

Change-Id: Id507d3a050e67057fc34a30771c9566ddfcf94ca
2020-05-06 16:36:24 -07:00
TreeHugger Robot
e725a69fb5 Merge "Updates Back and Home tutorial animations." into ub-launcher3-rvc-dev 2020-05-06 22:45:27 +00:00
TreeHugger Robot
870ec6a974 Merge "Improve Hybird hotseat cache support" into ub-launcher3-rvc-dev 2020-05-06 22:19:53 +00:00
Samuel Fufa
385e93249e Improve Hybird hotseat cache support
Loads list of cached apps and shows predicted app icons with the rest of workspace items.

-> Extracted prediction caching logic into a model layer

Bug: 155029837
Test: Manual

Change-Id: I6981594a910f5fe4e8e8cf8fe39db0cb856e7acd
2020-05-06 14:14:08 -07:00
Zak Cohen
0029fd7794 Overview Actions - fade action buttons, avoiding jump cuts
Test: local build and inspect
Bug: 155016287
Change-Id: I6015ce01b5095138ddd4e5f171ccb4d151c8f3fc
2020-05-06 11:45:14 -07:00
James O'Leary
d9c86d4b3b Compose gesture integrated fully into Launcher
- Support dismissing Compose via the reverse gesture from the appear
gesture
- Use Tony Wickham's ag/10204761 with some glue code to enable the
app below Compose panning in the same direction as the gesture as
Compose peeks in
- Add feature flag to use Compose hosted in a window (permits underlying
app panning)
- Use InterpolatingVelocityTracker to fix OtherActivityInputConsumer
processing swipes in the wrong direction ~20% of the time due to a bug
in VelocityTracker (see go/quirky-bubbles)

Change-Id: I65aa07ac112db8bd89cec9acfa0ce2b6ebacd43f
2020-05-06 13:40:47 -04:00
TreeHugger Robot
e93d6d615c Merge "Removing some unused AppWindowAnimationHelper dependencies" into ub-launcher3-rvc-dev 2020-05-06 17:33:27 +00:00
TreeHugger Robot
18f367a5f7 Merge "Bias rotation to remain in existing rotation" into ub-launcher3-rvc-dev 2020-05-06 17:30:40 +00:00
TreeHugger Robot
164d0c6509 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into ub-launcher3-rvc-dev 2020-05-06 16:23:32 +00:00
Sunny Goyal
d67569eac8 Fix AlwaysOnTop stack may covered by RemoteAnimation
Merging changes from Change-Id: I8028cd50d66f7d77e5d1ec6514e953c8be9935d6
in TaskViewSimulator

Bug: 151024899
Change-Id: Id41e5af227be2557032387bdaa61cac3458baf32
2020-05-06 02:41:15 -07:00
Sunny Goyal
84d9c42559 Removing some unused AppWindowAnimationHelper dependencies
Change-Id: I594853696c63dc6c22d22cab2faab0ed7529b594
2020-05-06 02:30:02 -07:00
Bill Yi
77fe1a7c90 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I2a006876dfa9ef67f47ff5e29aa9e2bcd4ef328d
2020-05-05 22:50:24 -07:00
Jon Miranda
e620872b18 Add logs to debug playtime crash and band aid fix for release builds.
Bug: 153821199
Change-Id: I0caa546254bb51ca8b88cdb16d79c054560bf2be
2020-05-05 18:18:40 -07:00
Zak Cohen
224ef0efe7 Merge "OverviewActions - make button ripple workspace text color." into ub-launcher3-rvc-dev 2020-05-05 19:11:21 +00:00
Tony Wickham
c0535b23f6 Merge "Fix continueComputingRecentsScrollIfNecessary() running infinitely" into ub-launcher3-rvc-dev 2020-05-05 17:14:03 +00:00
Sunny Goyal
cf19a92cde Merge "Not caching TaskView during quickswitch" into ub-launcher3-rvc-dev 2020-05-05 17:05:20 +00:00
Tony Wickham
49b57e955c Fix continueComputingRecentsScrollIfNecessary() running infinitely
When continuing a gesture during quick switch, we cancel the
previous animation but don't invalidate it (since the gesture
isn't fully finished), and the new gesture handler calls
mRecentsView.setOnPageTransitionEndCallback(), so the previous
handler will never get STATE_RECENTS_SCROLLING_FINISHED. Thus,
continueComputingRecentsScrollIfNecessary() will never end.

To fix this, also check !mCanceled, since that is set when
continuing the gesture. Also use postOnAnimation() instead of
post() since that has better guarantees that the next
computation will wait for the next animation frame, rather
than whenever the message queue is available, which might
happen too frequently.

Test: quick switch from A to B and back to A before settling
on B, ensure we stop calling computeScroll().

Bug: 153589287
Change-Id: I6b4389ef2cf5a818438c7ae36d8807b3e41c8501
2020-05-05 02:32:39 -05:00
Winson Chung
7ad937c78d Merge "Account for various launcher states when setting back button alpha" into ub-launcher3-rvc-dev 2020-05-05 04:37:38 +00:00
TreeHugger Robot
43e789ff9b Merge "Fixing max-zoom-scale not taking into account the the fullScreen scale" into ub-launcher3-rvc-dev 2020-05-05 02:01:00 +00:00
Sunny Goyal
a88ca7643a Not caching TaskView during quickswitch
RecentsList update case cause the TaskView to get unparented

Bug: 155568411
Change-Id: Ia05de9658ba2154f73311679a359a2eefeb73aec
2020-05-04 18:30:02 -07:00
Sunny Goyal
29e7a58f1a Fixing max-zoom-scale not taking into account the the fullScreen scale
Also fixing the issue where display info is is not correctly initialized

Bug: 155257023
Bug: 155682580
Change-Id: Ib2cc981c1900f3d14f158f4dbb60ae77311f339b
2020-05-04 18:11:15 -07:00
Becky Qiu
8f3b7e3249 [Overview Actions] Expose task corner radius to use in TaskOverlay.
Test: local
Bug: 153478940

Change-Id: I03d410edb5a55ce5eda5c703752daf0ef5d04500
2020-05-04 17:31:40 -07:00
Zak Cohen
b4ee058955 OverviewActions - make button ripple workspace text color.
Uses a theme to set the control highlight color.

Test: local on dark and light wallpaper
Change-Id: Iddb668fcbd3ab760faabd9c296274315d63e044f
2020-05-04 17:17:52 -07:00
TreeHugger Robot
f9ec6f670c Merge "Decouple feature flag and predictions" into ub-launcher3-rvc-dev 2020-05-04 23:12:37 +00:00
Samuel Fufa
49d0f64a9d Decouple feature flag and predictions
- Always default to true for ENABLE_HYBRID_HOTSEAT
- Allow launcher to show predictions anytime regardless of notification and on-boarding.
- Remove past beta specific plans
- Migrate if first screen can accommodate hotseat items otherwise show tip

Bug: 142753423
Test: Manual
Change-Id: I142cd95d779964822da07a96e5884a0c82813742
2020-05-04 15:20:39 -07:00
TreeHugger Robot
0dbbd8951d Merge "Use rotation based on PagedOrientationHandler instead of touch" into ub-launcher3-rvc-dev 2020-05-04 20:21:50 +00:00
Vinit Nayak
bb55f9e982 Use rotation based on PagedOrientationHandler instead of touch
Fixes: 154928106
Test: Tested overview w/ and w/o
home rotation enabled.

Change-Id: Ib7e91e51b2181824e5520ad69965ed3379302c27
2020-05-04 11:58:11 -07:00
Vinit Nayak
d079aed058 Revert drag factor calculation to pre-vertical overview
Fixes: 149609070
Test: Swiped up in landscape past
where thumbnail would be. Scaled accordingly.

Change-Id: Ib8e64af2d7a9e4ce517d5f56300d50b659217b71
2020-05-03 22:38:20 -07:00
TreeHugger Robot
4544af1996 Merge "[Overview Actions] Disable touching on the empty area when recent is modal." into ub-launcher3-rvc-dev 2020-05-01 20:43:03 +00:00
TreeHugger Robot
c6d8838c33 Merge "Sets icon invisible when alpha 0 (Cannot be tapped while TaskView modal)" into ub-launcher3-rvc-dev 2020-05-01 20:27:40 +00:00
Becky Qiu
2d9f8284ca [Overview Actions] Disable touching on the empty area when recent is modal.
Originally touching on the empty space would bring user back to homescreen. We will disable this for select mode.

Test: local
Bug: 154531538
Change-Id: Iee3780755fc2c32682ea0fa039ca5822a95fce2c
2020-05-01 12:51:07 -07:00
Winson Chung
a4b11dd984 Skip setting the controller if the animation is already finished
Bug: 154568748
Change-Id: I999c0cc3a4d9661bcf6dcd1e804746a3a0959a83
2020-05-01 16:25:04 +00:00