This handles cases that were previously ignored, such as dismissing
the IME with the back key/gesture.
Removed extraneous manual state updates that were used for specific
cases previously. The only remaining state updates are from our
controlled IME animation in KeyboardInsetsHandler, as that correctly
handles the case where you start closing the IME but end up keeping
it open (or vice versa).
Bug: 277738379
Fix: 320659754
Test: Manually go through various IME transitions on Launcher,
open and close apps, lock/unlock, etc to verify keyboard state
is correctly updated. And verify b/320659754 steps do not repro.
Flag: NA
Change-Id: I4787afbb37eed815b909a0215d8afeb3894ab985
Before we did it as normal just without requesting focus. However, we
also need to not log the new state, as this must happen only after the
controlled animation has completed (or been cancelled).
Bug: 309756056
Flag: NA
Test: manual
Change-Id: I7f1564d2b29d91c9fdb0afce586fe5cc1148bac0
- All apps icons do not show the focus rectangle when focused as mIconFocusListener is null in BaseAllAppsAdapter when onCreateViewHolder is called.
- All apps recyclerview does not scroll down when focus goes from top to bottom of list, as AllAppsToastUiDelegate calls hideKeyboard which clears focus.
- Focus goes behind AllApps into hotseat, so update hotseat setDescendantFocusability.
Flag: NONE
Fix: 296844600
Test: TaplKeyboardFocusTest
Change-Id: I65f6fbb6f4df0be4b4ff922dda267d27da16effe
The default handling of back in this preIme case already closes
the keyboard if we return false, so adding it before our own key
handling was stomping on our existing syncronized keyboard.
We should still handle other cases where the system ime animation
coincides with our control, but we at least shouldn't force it on
ourselves.
This fixes the back issue in 3 button mode, and also closes all
apps on the first back gesture as intended (if you hadn't entered
0 state that is).
Demo after fix: https://drive.google.com/file/d/1pK18iEdgxQ0HQmilAMFzn66LVyCH5Ma1/view?usp=drive_link&resourcekey=0-kW4BOC-Pj-wZ_DZL51z6Rg
Bug: 270144901
Bug: 277738379
Test: Manual with 3 button mode and gesture nav, with always on
keyboard on and off
Flag: N/A
Change-Id: I9b1c525494b49cde3307df8b0a73d6143ac9c616
- Add a feature flag for IME Latency logging.
- Removed mShowImeAfterFirstLayout from ExtendedEditText.
http://ag/1414509 added `mShowImeAfterFirstLayout`and cl description
says "Show IME when search query != null after rotation".
I verified the behavior by turning on "Allow home screen rotation".
Keyboard is not getting dismissed on rotation in AA+ screen in a-z list
or even in the search screen.
Video : https://drive.google.com/file/d/1BWUTrW9OSEo6ojErj8INMwjFCPArVD4B/view?usp=sharing&resourcekey=0-SXTcKyUw1wCSi8Bm37ktow
Bug: 240192346
Test: Manual.
Verified by setting `ENABLE_KEYBOARD_TRANSITION_SYNC` to false and for
following usecases.
- All apps entry with ime enabled, scrolling a-z list to hide keyboard
- Folder name change - showing and dismissing keyboard
- Toast entry from Allapps and QSB - showing and dismissing keyboard
Change-Id: I1a6b5759b8e71e77744f58677b6d1b73e2f633e8
Hide keyboard with WindowInsetsController if could. In case
hideSoftInputFromWindow may ignored by input connection being finished
when the screen is off.
Bug: 233158645
Test: manual as steps:
1. Launch AllApps.
2. Tap search bar to invoke IME.
3. Screen off.
4. Screen on.
And all other keyboard hide cases such as back gesture, swipe down, etc.
Change-Id: I4154f38f94b6760a430f7510a650422020d8f59a
- Disables header protection on AOSP
- Fades in/out search box pill instead of sudden movements
- Work tabs protection shows and hides based on scroll position
Bug: 194106968 [APK attached]
Test: Manual
Change-Id: I5532847ddba3d4555003b0934b8fc846dc5a5cc7
Bug: 161594550
TL;DR;;
- draging an item closes the IME
- clearing a searchbox to empty string has no effect on IME
Change-Id: Ic3a91d1b22434dcb78347dd8b12b5ceab14eb928
Bug: 147769158
- Use both InputConnectionWrapper and TextWatcher to detect
manual input
- Also fix a bug in FolderNameProvider
Change-Id: I7bc0f380c6641481d934a53e9feb77caa19c674a
We turn on suggestions, turn off auto complete, and disable the
default behavior where red lines appear under typos.
Bug: 30055146
Change-Id: Ia151b7a4db1dfc6908504e6ea82a1f6989f05ca5
> Creating a base view for floating panels with some common methods
> Moving the getOpen method to individual classes
> Moving the folder icon animation logic to folder icon
> Moving all the logic related for opening folder to Folder class
Change-Id: I898dfb6870b857cb921d2729b89618bc43ff2e88
