Commit Graph

10192 Commits

Author SHA1 Message Date
Thales Lima
bfb6996484 Merge "launcher: create attrs for more horizontal margin options" into sc-v2-dev 2021-10-01 13:20:25 +00:00
Steven Ng
9114f280a2 Merge "Group weather widgets under the widget category" into sc-v2-dev 2021-10-01 10:17:47 +00:00
Schneider Victor-tulias
858d82b8be Merge "Improve all apps loading times." into sc-v2-dev 2021-10-01 07:01:48 +00:00
TreeHugger Robot
d1ad84c6df Merge "Overview - Remove Chips code" into sc-v2-dev 2021-09-30 22:14:41 +00:00
Steven Ng
43859f10bc Group weather widgets under the widget category
Test: manual (see video in bug) and added PackageUserKeyTest
      Also tested pending conversation widget to ensure the right icon
      is shown.
Fix: 201062480
Change-Id: If23c28bd93c54fb1747648309ab3c238a1810902
2021-09-30 14:22:21 +01:00
Thales Lima
d90faab655 launcher: create attrs for more horizontal margin options
According to new specs, margins are different depending on orientation
and fold/unfolded. Also change the name of the variable to
horizontalMargin, since it applies the same padding to both sides.

Bug: 191879424
Test: manual and checking paddings in HSV
Change-Id: I8990c02b928a22b9f3b0cf3cbc3abf08df4daa9d
2021-09-30 14:06:56 +01:00
Thales Lima
f8182da6c5 Merge "launcher: create paddings for foldables" into sc-v2-dev 2021-09-30 09:19:22 +00:00
TreeHugger Robot
a246eb4aa5 Merge "Add logging to help debug b/200572078." into sc-v2-dev 2021-09-30 07:01:41 +00:00
TreeHugger Robot
70cc9ffe7c Merge "Remove the Share button option from Overview." into sc-v2-dev 2021-09-30 04:11:47 +00:00
TreeHugger Robot
31a0b39daf Merge "Allow icon add animations when user touches the screen." into sc-v2-dev 2021-09-30 01:51:49 +00:00
Samuel Fufa
abb827b376 Merge "[Foldable] Apply max width to AllApps in unfolded state." into sc-v2-dev 2021-09-29 22:07:42 +00:00
Zak Cohen
71c527126b Overview - Remove Chips code
The proactive chips code has bit rotted and doesn't work properly anymore.
The product direction is not being pursued, so remove the code.

Bug: 201568600
Test: local
Change-Id: Ia00ceb027719c841bed665c1c50a132230bffe89
2021-09-29 14:43:27 -07:00
Zak Cohen
283ee7d74b Remove the Share button option from Overview.
It has never been enabled, and is not plan of record.

Bug: 201446691
Test: local and updated unit tests

Change-Id: I5ac6d40ba1dbcf28de4355cc51fff74cfb37ebc6
2021-09-29 14:43:27 -07:00
Alina Zaidi
a4c1d0cfa4 Merge "Do not reorder recommended widgets in widget picker." into sc-v2-dev 2021-09-29 21:23:23 +00:00
Pat Manning
429b8df180 Merge "Add TAPL tests for hiding the actions view when scrolling away from focused task in overview." into sc-v2-dev 2021-09-29 21:03:46 +00:00
Brian Isganitis
3fca6717ed Merge "Only set arrow color once when below icon." into sc-v2-dev 2021-09-29 19:57:23 +00:00
Schneider Victor-tulias
dccfe04a3a Improve all apps loading times.
Updated loadAllApps to load all required icons in a series of bulk sql queries. This reduces the cost of SQL lookups (up to two lookups per user, rather than one lookup per icon)

Bug: 195674813
Test: Added all icons to workspace, added duplicate icons, added icons for same component name from different users
Change-Id: Ifda8980386084999c53d7f881e8967be0d57d263
2021-09-29 12:37:40 -07:00
Brian Isganitis
3a91a6241f Merge "Update arrow color after all notifications dismissed." into sc-v2-dev 2021-09-29 16:38:52 +00:00
Brian Isganitis
8b678206cf Only set arrow color once when below icon.
We were setting it again for the first child in any recursive call,
which could cause the color to be incorrect.

Test: Arrow always matches menu item below icon.
Fix: 201537864
Change-Id: I8f344bb7bdec4ebc51f8b8de118bec678d71e649
2021-09-29 12:30:50 -04:00
Brian Isganitis
1e34f65395 Update arrow color after all notifications dismissed.
assignMarginsAndBackgrounds updates determines the new arrow color, but
it doesn't actually update it. That is normally done in
updateArrowColor.

Test: Icon menu arrow color changes to content above it after notification
dots dismissed.
Fix: 201458705

Change-Id: I5ee40b420b03c29c197983af5968d4f2902bc59b
2021-09-29 16:29:16 +00:00
Alina Zaidi
fc6837bb65 Do not reorder recommended widgets in widget picker.
This is to show them in ranking order sent by aiai.

Bug: b/201079509
Test: Added unit test in WidgetsTableUtilTest

Change-Id: I366ecaee8bc157aca185f633462d95fbd1dd180b
2021-09-29 15:52:47 +01:00
Steven Ng
d9f0c84f27 Merge "Add a new string for widget configuration drop target" into sc-v2-dev 2021-09-29 13:13:31 +00:00
Steven Ng
29f46c9628 Add a new string for widget configuration drop target
Test: manual. See screenshot in b/201286923
Fix: 201286923
Change-Id: I5be4f723523befe359b922273d11f57fb9f0b3fd
2021-09-29 12:15:07 +01:00
Thales Lima
7a6752da51 launcher: create paddings for foldables
This creates a new padding file that bring some foldables up to spec
with VisD. For 2 panel layouts it now uses workspace margin instead of
cell layout padding.

Bug: 191879424
Fixes: 200035429
Test: checking paddings in HSV
Change-Id: I11b8e1afd76f535368d4c26e31630ce496171e13
2021-09-29 11:53:29 +01:00
Alex Chau
81f168ee7c Merge "Always let Hotseat touches follow through to Workspace if not intercepted" into sc-v2-dev 2021-09-29 10:45:56 +00:00
Pat Manning
35231f3041 Add TAPL tests for hiding the actions view when scrolling away from
focused task in overview.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: Ie44a5bd99d7c9ffbc5405973c0ba1950cd90665c
2021-09-29 10:30:18 +00:00
Alex Chau
b830b2d999 Merge "Return mSynchronouslyBoundPages as getPagesToBindSynchronously between onInitialBindCompleteand finishBindingItems" into sc-v2-dev 2021-09-29 08:25:49 +00:00
Zak Cohen
c1359c448d Merge "Remove Content Push prototype." into sc-v2-dev 2021-09-28 20:16:23 +00:00
Schneider Victor-tulias
0021338461 Add logging to help debug b/200572078.
Bug: 200572078
Test: ran launcher and checked logs
Change-Id: If59d850021df226d645aa6a72da2b5bb7ec63782
2021-09-28 12:02:51 -07:00
Alex Chau
21698c5799 Always let Hotseat touches follow through to Workspace if not intercepted
Fix: 200812841
Fix: 201306660
Test: Long press around QSB, hotseat, inbetween hotseat icons works
Test: Can scroll pages on top of hotseat and QSB
Test: Drag and drop still works in hotseat
Test: Can still press and long press on QSB
Change-Id: I3f6807be08ff2c55644e3bf8f6d05a3954a8ede6
2021-09-28 12:27:26 +00:00
TreeHugger Robot
c77e3fde09 Merge "Moving activity tracker to Launcher process" into sc-v2-dev 2021-09-27 20:10:02 +00:00
Zak Cohen
b48b84634f Remove Content Push prototype.
Bug: 201314561
Test: Build and run
Change-Id: I64f5ab40b349d68a50b0f49361f019456667b933
2021-09-27 11:57:50 -07:00
Brian Isganitis
03be53443d Merge "Refactor arrow popups to allow easier code overriding and sharing." into sc-v2-dev 2021-09-27 18:31:26 +00:00
vadimt
5ade8e890d Moving activity tracker to Launcher process
This will improve diagnostics for OOP tests,
like we now have a list of leaked activity classes.

Also some cleanups.

Bug: 187761685
Test: local runs
Change-Id: I8b5711ac727874fd826cfef9c742ea97048763e0
2021-09-27 17:36:14 +00:00
TreeHugger Robot
ac81e8a92a Merge "Fix getWidgetItemSizePx estimation" into sc-v2-dev 2021-09-27 15:52:33 +00:00
Steven Ng
6d8deb32f6 Fix getWidgetItemSizePx estimation
The size returned by getWidgetItemSizePx is used by the widget picker
for the NavigableAppWidgetHostView. We should NOT deduct the padding
applied to NavigableAppWidgetHostView to this size.

If a launcher grid insets NavigableAppWidgetHostView, then we must
add the inset to the NavigableAppWidgetHostView width / height.

Test: Compare the size of widgets in preview and home screen using
      layout inspector. See screenshots in the bug
Fix: 200983939
Change-Id: I35022861b65f2624f69940cf3856d9c47f8dbbd9
2021-09-27 15:01:04 +01:00
Brian Isganitis
a85ae69c72 Refactor arrow popups to allow easier code overriding and sharing.
Test: Existing menus work as intended.
Bug: 188222480
Change-Id: I7d19b06ce8bb7d765624c64c0042c4efd6faf348
2021-09-24 20:32:14 -04:00
Tony Wickham
2fb815b2fd Cleanup split screen offset in TaskViewSimulator
- Removed mRunningTargetWindowPosition and mSplitOffset, as they countered each other out anyway
- Removed PagedOrientationHandler#setLeashSplitOffset() since it's no longer used

Test: Swipe up from split and non split apps in both orientations on large and small devices, with and without home rotation enabled
Bug: 200817624
Change-Id: I78a80cbc718ee38a8933fa323798fb436710d59f
2021-09-24 15:37:30 -07:00
sfufa@google.com
de0132939b [Foldable] Apply max width to AllApps in unfolded state.
Since we are applying the same iconWidth in AllApps as Workspace in unfolded state, this change restricts AllApps to span only the area required to display AllApps contents and not span full available width. Unfolded/phone behavior remains the same.

Bug: 199959857
Bug: 194259694
Test: visual
Change-Id: Ie5658d566f20e825e666ef17db79a87b07dc2936
2021-09-24 15:18:01 -07:00
Tracy Zhou
cc1e94a982 Merge "Consolidate isTablet logic across Launcher and SysUI" into sc-v2-dev 2021-09-24 17:16:41 +00:00
Pierre Barbier de Reuille
578deba57d Correct the computation of the cell size.
The previous computation ignored the left/right padding of the cell
layout.

Fix: 200968203
Test: Manually
Change-Id: I5a017b90c11e2cd710f16fece5cdae902ccb1e72
2021-09-24 14:18:28 +01:00
Hyunyoung Song
8c2f308521 Merge "extract text conversions from composing text and send them for search" into sc-qpr1-dev am: b458541470
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15532476

Change-Id: Ic591cf62d70eb41c1614795d798c37a88e9ca594
2021-09-24 04:09:34 +00:00
Hyunyoung Song
b458541470 Merge "extract text conversions from composing text and send them for search" into sc-qpr1-dev 2021-09-24 03:54:12 +00:00
Andy Wickham
329cb37591 Disables Feedback flow for Smartspace. am: 587ab5c723
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15899654

Change-Id: Ie9b6028178557bd4f87966eaeeeba6a8ca7ac856
2021-09-24 02:49:32 +00:00
Tracy Zhou
ba086b8125 Merge "Hide task bar icons when notification shade is expanded" into sc-v2-dev 2021-09-24 00:57:26 +00:00
Jonathan Miranda
e2455aa1cf Merge "Significantly reduce gesture feedback when swiping up to home screen." into sc-v2-dev 2021-09-23 23:14:50 +00:00
Tracy Zhou
c8beebf5a3 Consolidate isTablet logic across Launcher and SysUI
Fixes: 197960261
Test: Change display size; no nav bar and task bar showing at the same time
Change-Id: I56753e9389a49ca3ee455b248a041b3c1569f153
2021-09-23 15:06:53 -07:00
Andy Wickham
587ab5c723 Disables Feedback flow for Smartspace.
Fix: 198444652
Test: Manual
Change-Id: Iff8ad50e5af7082d7618f75c66132e338c67323b
2021-09-23 20:53:37 +00:00
Jon Miranda
13519e4402 Significantly reduce gesture feedback when swiping up to home screen.
- Uses overscroll damping logic to reduce the velocity
- The start to target rect interpolation can be from the
  start, center, or bottom of the rect depending on where the item
  is on the workspace. This reduces the  amount of distance needed to
  travel between, which helps further reduce gesture feedback.

Bug: 173107751
Test: test closing app that is on:
      -  top row of home screen
      -  middle of home screen
      - in hotseat

Change-Id: I055dd61ca3491807109ff2f6c501bf710c8d340f
2021-09-23 20:13:40 +00:00
Samuel Fufa
9ac78866d3 Merge "[Refactor] Extract work profile related logic from AllAppsContainerView to WorkProfileManager" into sc-v2-dev 2021-09-23 20:11:15 +00:00