Commit Graph

12813 Commits

Author SHA1 Message Date
Brian Isganitis
be388b8933 Merge "Make action optional for snackbar." into sc-v2-dev 2021-12-01 00:18:40 +00:00
Jonathan Miranda
199644c397 Merge "Fix NPE in FloatingIconView" into sc-v2-dev 2021-11-30 18:43:29 +00:00
TreeHugger Robot
96f34af124 Merge "Fling to close tasks in the GestureNav can be too small." into sc-v2-dev 2021-11-30 18:34:09 +00:00
TreeHugger Robot
c5f18aa980 Merge "Resets taskSplitTranslation of inactive orientation" into sc-v2-dev 2021-11-26 18:23:43 +00:00
Thales Lima
d9d7f7214a Merge "launcher: use same icon size for all apps drawer in foldables" into sc-v2-dev 2021-11-26 15:10:03 +00:00
Thales Lima
6e0005af6b launcher: use same icon size for all apps drawer in foldables
For foldables, no matter the grid size, we use 60dp for icons sizes.
This also fix a bug where the icon size was always the minimum between
default and all apps, which means that for foldables it would always be
default.

Bug: 202708085
Test: visual, using HSV and Window
Change-Id: I315718a8ba7a0aaed2204ad12e6b184dda2be48e
2021-11-26 10:03:43 -03:00
Alex Chau
9a5f99bfe6 Resets taskSplitTranslation of inactive orientation
Fix: 204185003
Test: manual

Change-Id: I10e49994e8a9723f39d7f9159de7c1f8216ea77f
2021-11-26 12:04:47 +00:00
Jerry Chang
71b7d1537d Merge "Support to launch app pair from overview with recorded split ratio." into sc-v2-dev 2021-11-26 05:43:34 +00:00
TreeHugger Robot
32ebd9f94f Merge "Fix ClassCastException in QuickstepModelDelegate" into sc-v2-dev 2021-11-25 04:00:37 +00:00
Jerry Chang
279c3b7fa2 Support to launch app pair from overview with recorded split ratio.
Bug: 207479945
Test: Quickswitch back to app pair keep split ratio
Change-Id: Id24195c15fe59053cc51515a942f72c3b8e87ba7
2021-11-25 11:38:14 +08:00
Schneider Victor-tulias
380f8fd890 Fix ClassCastException in QuickstepModelDelegate
- Added a casting check as an immediate fix to b/173838775
- Added logging to help debug the corrupt state where an item of type other than FolderInfo is used as an other item's container.
- Added LoaderMemoryLogger for adding large logs that are only conditionally printed.

Bug: 173838775
Test: manually checked logs
Change-Id: I9491cb421b9fb807d5fb110b04ad069481de768f
2021-11-24 14:26:45 -08:00
Alex Chau
376b09ade2 Merge "Consider two panel in home to overview transition" into sc-v2-dev 2021-11-24 20:33:32 +00:00
Alex Chau
6095333370 Consider two panel in home to overview transition
- Get the value from DeviceProfile directly

Fix: 202444558
Test: manual
Change-Id: Ifadbbf34c8103d7275b8b4043dcae47d1168ae83
2021-11-24 18:11:45 +00:00
Tony Wickham
b4aefc1277 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev 2021-11-24 17:54:18 +00:00
Tony Wickham
821e37b447 Stash taskbar when IME is present, including during gestures
- SysUI removes SYSUI_STATE_IME_SHOWING when starting a gesture from an app, but because unstashing has implications on the gesture transition (e.g. clips the bottom of the app), we defer handling the ime hiding until the gesture settles. Repurposed the flow that swaps the taskbar background during the gesture to support this case as well.
- Delay the unstash when IME is closing, to align with the end of the IME exit transition
- Remove TaskbarViewController.ALPHA_INDEX_IME now that we stash when IME is opening, since stashing already hides the taskbar icons
- Also support passing a starting progress to the stashed handle reveal animation, to allow it to be reversed when cancelled. For example, when returning to an app that has IME showing, we first start unstashing because we're in an app, but then we get the signal that IME is attached so we stash again almost immediately (within a frame or two).

Test: In both 3 button and fully gestural, open a keyboard in an app, ensure taskbar gets out of the way and then reappears at the end when the keyboard is dismissed
Bug: 202511986
Change-Id: I93c298a98ba369ea6310466ff3f802231c582687
2021-11-23 16:37:06 -08:00
Winson Chung
c1afaa4042 Merge "Removing logs" into sc-v2-dev 2021-11-23 21:58:14 +00:00
Vinit Nayak
458832c09e Merge "Show multiple App Info A11y options for split app icons" into sc-v2-dev 2021-11-23 20:09:47 +00:00
Alex Chau
48644c75b3 Merge "Consider launching task's position on screen in pivot calculation" into sc-v2-dev 2021-11-22 21:07:41 +00:00
Alex Chau
4f49c9ce62 Log the display state when number of screen bounds is inconsistent
- If the number of screen bounds a.k.a. number of displays has changed, it should be a bug from system and add a log for that

Bug: 198965093
Test: manual
Change-Id: I74612e6c0d2f3cfd52b509e43ea16adf0eec76de
2021-11-22 15:16:17 +00:00
Zak Cohen
d95942132d Remove temporary logging for NO_SCREENSHOT bug/.
Bug: 202414125, 203583301
Test: Local
Change-Id: I8345bd9f1c3ee93971d64ed49cf613cfd09ce10c
2021-11-19 13:49:36 -08:00
Jon Miranda
73a7e1ce41 Fix NPE in FloatingIconView
Happens when view is reset before animation starts

Bug: 201946253
Test: manual
Change-Id: I62817f698996dc1c6bebcd038d01eb8d6923a305
2021-11-19 13:40:59 -08:00
Alex Chau
2998307cd6 Use only current density to check isTablet
- Removed DeviceProfile.allowRotation and use DeviceProfile.isTablet instead, which only uses current density to calculate its value
- Reverted default allow_rotation preference handling to before ag/14234761

Fix: 203817448
Test: isTablet is set correctly in different screen sizes
Change-Id: Ic6c8dfc774e7787f62d489ad27720a7644c1e8c7
2021-11-19 15:27:01 +00:00
Alex Chau
6499e83c57 Consider launching task's position on screen in pivot calculation
- Instead of using RecentsViewScroll, put task's position offset versus current scroll as TaskRect calculation, so it's considered when calculating for putting task to full screen
- Revert back RecentsViewScroll to apply before RecentsViewScale
- Added new property in PagedOrientationHandler to apply both primary/secondary param without clearing the other, and renamed an existing method

Fix: 206972618
Test: Quick switching
Test: Launch task from grid, launch side task from carousel overview
Change-Id: I5977975ed1e930ad70b81d83513d8f3a00c0aed4
2021-11-19 14:42:20 +00:00
Vinit Nayak
f957244b88 Show multiple App Info A11y options for split app icons
* AccessibilityNode actions are required to have a
unique resourceId to show as an action in A11y dialog.
For now, only AppInfo option is shown for each app in split,
but moving forward we'll need to add resourceIDs for
each option that can show up for either app.

Fixes: 200609838
Test: Saw multiple options for App Info for each app
come up in talkback mode

Change-Id: I92b349347354ac639537021d775eea814c866a0e
2021-11-18 23:22:46 -08:00
Schneider Victor-tulias
ce740c832c Merge "Add TODO to fix b/206508141 before removing or changing the default value to the feature flag ENABLE_LOCAL_COLOR_POPUPS" into sc-v2-dev 2021-11-18 18:45:16 +00:00
Thales Lima
bd1aec6721 Merge "open grid task menu to the right of icon" into sc-v2-dev 2021-11-18 18:19:58 +00:00
TreeHugger Robot
160d85c815 Merge "Adding back the badges on widgets for widget recommendations." into sc-v2-dev 2021-11-18 17:44:50 +00:00
Brian Isganitis
49f25681ef Make action optional for snackbar.
Test: Manual
Bug: 188222480
Change-Id: I923dcf50633d8ba751d86095f43e97563a53b692
2021-11-18 10:22:41 -05:00
Thales Lima
45f2306ce9 open grid task menu to the right of icon
This makes the TaskMenuViewWithArrow open to the right of the icon if
there is enough space, and to the left if not. It also works correctly
in RTL, inverting the side to open by default.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: Ib1098f48ed28d2e0758fb0e3fb733e86271fa1a0
2021-11-18 12:01:16 -03:00
TreeHugger Robot
5394db834f Merge "Use split thumbnail width/height directly" into sc-v2-dev 2021-11-18 04:42:27 +00:00
Vinit Nayak
be7ce023de Use split thumbnail width/height directly
* When swiping to QS from home, the
bounds for the rect on screen are incorrect
because it's technically off-screen when
it's being queried

Fixes: 206155441
Change-Id: Ibb17f2ac291f867b6de06041c980e434ce92cf27
2021-11-17 19:05:29 -08:00
Tony Wickham
49da26f636 Merge changes I36871463,I691a5cbb,I62105c1c into sc-v2-dev
* changes:
  Update reorder and folder creation radii
  Fix misaligned folder creation drag over target
  Update CellLayout.DEBUG_VISUALIZE_OCCUPIED to include drag over targets
2021-11-17 22:08:28 +00:00
Sebastian Franco
0a1328d9fb Adding back the badges on widgets for widget recommendations.
Test: Manual Testing
Fix: 202956924
Change-Id: I859d3d93d95bdc8d0742eb6b5dd40ad12a386928
2021-11-17 15:08:09 -06:00
Schneider Victor-tulias
92c6ae64de Add TODO to fix b/206508141 before removing or changing the default value to the feature flag ENABLE_LOCAL_COLOR_POPUPS
Bug: 206508141
Test: None
Change-Id: I8a8290f1e7d24c9fd2e8922f0126fa3d713e10a4
2021-11-17 12:22:02 -08:00
Winson Chung
0e1cd933ba Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev 2021-11-17 19:42:53 +00:00
TreeHugger Robot
42f111dc27 Merge "Revert "Add feature flag to control two panel home in portrait"" into sc-v2-dev 2021-11-17 17:47:16 +00:00
Winson Chung
9304879387 Fix issue with grouped task rects being calculated slightly off
- This was causing bleed through between split tasks and perhaps
  some rounded corners to be calculated incorrectly
- Also reset the translation after it is adjusted for dismissing
  in case the dismiss gesture is canceled.  This doesn't fix the
  issue with bleed through between the task views (to be fixed
  separately), but makes sure it isn't permanently set on the task

Bug: 206739664
Test: Split tasks, swipe up and check the bounds

Change-Id: I34430e958ca7a75f48621bc27a281e93fdf97179
2021-11-17 17:40:58 +00:00
Alex Chau
9012582ef7 Revert "Add feature flag to control two panel home in portrait"
This reverts commit b1c36ce938.

Reason for revert: experiment no longer requried
Bug: 197723099

Change-Id: I585fa4364ab5326a19b099a80a1a02a66370d84f
2021-11-17 14:16:58 +00:00
Sebastian Franco
3b86202a95 Fling to close tasks in the GestureNav can be too small.
The problem is that the velocity threshold to activate the fling
was set using pixels per second, so a better aproach would is to
use dp/s. So now there is a variable set in the dimes.xml file
called base_swift_detector_fling_release_velocity.

Test: Manually tested
Fix: 201252634
Change-Id: Ief14f25de136dead74f03cb24d2120b67900239e
2021-11-16 14:46:36 -06:00
TreeHugger Robot
82fc85f9b8 Merge "Fix LauncherProvider newScreenId issue" into sc-v2-dev 2021-11-16 19:00:47 +00:00
TreeHugger Robot
d8a1b5c366 Merge "Fix overview scroll triggering haptics on swipe up gesture" into sc-v2-dev 2021-11-16 16:48:14 +00:00
Tracy Zhou
0200636585 Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev 2021-11-16 09:41:58 +00:00
TreeHugger Robot
3d7084863a Merge "Deletes old feature flags." into sc-v2-dev 2021-11-13 00:38:07 +00:00
Andras Kloczl
953eb8041e Fix LauncherProvider newScreenId issue
Remove maxScreenId from LauncherProvider and whenever we need
a new screenId, query the database to calculate a new screenId.
Also converted and refactored AddWorkspaceItemsTaskTest
and added some extra test cases.

Test: manual & AddWorkspaceItemsTaskTest.kt
Bug: 199160559
Change-Id: I185f6823fed171d778af0130497f5ffaf89c0a70
2021-11-12 19:56:07 +00:00
Winson Chung
21d129de28 Removing logs
Bug: 201305599
Test: Builds
Change-Id: Ic480136ee6b158dc614d43beaed1dfce91b9ca8a
2021-11-12 17:18:11 +00:00
Hyunyoung Song
3f14c80d4c Merge "Add FeatureFlag to enable two line label inside all apps" into sc-v2-dev 2021-11-11 21:29:30 +00:00
Hyunyoung Song
afe8fadc15 Add FeatureFlag to enable two line label inside all apps
Bug: 201388851
Test: screenshot on the bug
Change-Id: Id01d6f9f9e25b98cad8368ac0faf671addf793f8
2021-11-10 22:26:51 -08:00
Becky Qiu
c919e67a9b Merge "[AA+ Search] Add logging for header search icon tapping events." into sc-v2-dev 2021-11-11 01:11:00 +00:00
Brian Isganitis
bc1b36344f Merge "Allow overriding getOptionsPopup test method." into sc-v2-dev 2021-11-10 19:56:07 +00:00
TreeHugger Robot
0aadbc6b37 Merge "launcher: use a different task menu for foldables" into sc-v2-dev 2021-11-10 19:45:36 +00:00