Commit Graph

1633 Commits

Author SHA1 Message Date
Vadim Tryshev
daa553c7a9 Merge "Starting to tighten leak detector checks" into main 2023-10-03 04:59:09 +00:00
Sebastián Franco
bad922f50f Merge "Moving testWidgets from TaplTestsLauncher3 to it's own test TaplWidgetPickerTest" into main 2023-10-03 03:05:15 +00:00
Vadim Tryshev
d8c049f2af Starting to tighten leak detector checks
This will help to detect leaks earlier, not when we have 3 activities in some cases, but when we have 2.

Adding a parameter that enables more strict detection, and using it in some places.

I'll try to convert as many places as possible to the more strict check after landing this CL.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Idd5a0386005e46dad8aab222bd77c0240f23f43a
2023-10-02 18:34:32 -07:00
Vadim Tryshev
a6b74ffdfc Merge "Verifying that workspace looks correct at the end of the test." into main 2023-10-02 21:48:04 +00:00
Alex Chau
8eb662c67b Merge "Create icon app chip menu for overview tasks." into main 2023-10-02 17:40:33 +00:00
Pat Manning
1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Vadim Tryshev
b57e25127e Verifying that workspace looks correct at the end of the test.
I hope that this will lock bugs like b/298114205 in the test that created the bad condition, not the next one.

Bug: 298114205
Test: presubmit
Flag: N/A
Change-Id: If9b48fb5159fc35948607a99f87199d5a32e64d6
2023-09-29 18:31:04 -07:00
Pat Manning
ff74bb5ded Mark existing Launcher CUJs as Platinum tests.
Exclusion CL: cl/565329636 & cl/569615823

Acceptance Criteria:
- TaplTestsQuickstep#testOverviewActionsMenu: https://android-build.corp.google.com/test_investigate/?invocationId=I68300010197543619&testResultId=TR13128935381586398&tab=performance
- OopTaplOpenCloseAllApps#testAllAppsSwipeUpToWorkspace: https://android-build.corp.google.com/test_investigate/?invocationId=I29900010197342608&testResultId=TR26328933842394642&tab=performance
- AddWidgetTest#testResizeWidget: https://android-build.corp.google.com/test_investigate/?invocationId=I56600010197561454&testResultId=TR14428935383013115&tab=performance
- TaplTestsLauncher3#testLaunchHomeScreenMenuItem: https://android-build.corp.google.com/test_investigate/?invocationId=I56600010197561454&testResultId=TR20028935383489058&tab=performance

Bug: 300249773
Test: TaplTestsLauncher3
Test: OopTaplOpenCloseAllApps
Test: AddWidgetTest
Test: TaplTestsQuickstep
Change-Id: Ica71dbad91efe8f5b4fd243f0ec78fc3c3c4d456
2023-09-29 23:27:27 +00:00
Sebastian Franco
7ab324a503 Moving testWidgets from TaplTestsLauncher3 to it's own test TaplWidgetPickerTest
Bug: 298234173
Test: atest TaplWidgetPickerTest
Change-Id: Ia19469d2021cb833b5c1d9d176425b9d6d352797
2023-09-29 20:55:36 +00:00
Sebastián Franco
770559cb6e Merge "Moving test related to the app icon menu to their own file" into main 2023-09-29 20:46:17 +00:00
Brandon Dayauon
a651f9ef97 Merge "Fix bubbleTextview Test when height should not be limited." into main 2023-09-29 18:40:50 +00:00
Winson Chung
351ea3c7ba Merge "Revert "Reset the frozen recents list state prior to test runs"" into main 2023-09-29 18:40:24 +00:00
Sebastian Franco
894c2d970d Moving test related to the app icon menu to their own file
Bug: 298234173
Test: atest TaplAppIconMenuTest
Change-Id: Ifa3422a835d87163a16895b0c011e118dde40044
2023-09-29 11:15:44 -07:00
Winson Chung
08751d4d09 Revert "Reset the frozen recents list state prior to test runs"
Revert submission 24866277-recents_freeze_tests

Reason for revert: b/302267317

Reverted changes: /q/submissionid:24866277-recents_freeze_tests

Change-Id: I18a69ff8f98f02cab8a2b89b6e70eca15317dc35
2023-09-29 17:36:09 +00:00
Jagrut Desai
3a7d139110 Add isTransientTaskbar as DeviceProfile Builder Property
- Breakout CL part 5
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of adding isTransientTaskbar as DeviceProfile Builder Poropety
- This cl alos consist a shared pref listener for taskbar pinning to update device profile.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I2ade751ffc8c59bd4b862b56c8ca7eb2aa05b7f2
2023-09-28 12:01:58 -07:00
Brandon Dayauon
30f290e453 Fix bubbleTextview Test when height should not be limited.
bug: 302548618
Test: locally/presubmit
Flag: n/a
Change-Id: I14f8c3cd90642078118e0230cbd969537c572816
2023-09-28 11:10:40 -07:00
Vinit Nayak
909fe37472 Merge "Revert "Verifying that workspace looks correct at the end of the test."" into main 2023-09-27 18:42:25 +00:00
Winson Chung
1004399028 Merge "Reset the frozen recents list state prior to test runs" into main 2023-09-27 07:22:01 +00:00
Anushree Ganjam
02c2bd3dcb Use SetFlagsRule instead of StaticMockitoRule for aconfigFlag.
Bug: 294913042
Test: Unit tests
Flag: ENABLE_TWOLINE_ALLAPPS
Change-Id: I04e9a95aff609a3ba8eefadc1dd247592f4419b9
2023-09-26 17:08:27 -07:00
Vinit Nayak
df751430bc Revert "Verifying that workspace looks correct at the end of the test."
This reverts commit 62e3b162ba.

Reason for revert: Possible culprit for b/301966780

Change-Id: Ice6babe404feeddf9f8b13ce2a6288005402c9cd
2023-09-26 15:19:20 -07:00
Brandon Dayauon
cd460094ba Merge "Do a vertical check for two line text, if it clips dont show two line." into main 2023-09-26 22:16:37 +00:00
Charlie Anderson
eb247042fc Merge "Clear Launcher workspace after ReorderWidgets test finishes." into main 2023-09-26 21:16:48 +00:00
Winson Chung
e5d9cc8855 Reset the frozen recents list state prior to test runs
- A quickswitch will freeze the spatial order of the recents list
  (to allow quickswitching back) for up to 5s, but this can affect
  runs of other tests due to the list being in the wrong order

Bug: 298544839
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep
Change-Id: I5d01991821c6b79ceac47fefffed60ef4a18b248
2023-09-26 17:33:09 +00:00
Charlie Anderson
a8e277145d Clear Launcher workspace after ReorderWidgets test finishes.
This is to help prevent test crashes with workspace items out of place when using TestWorkspaceBuilder.
Adds ModelTestExtensions to move common methods for clearing Launcher DB.

Bug: 296620387
Test: running ReorderWidgets test
Flag: none
Change-Id: I677b1b8fa09aa13aee43651bf66d28ced410a681
2023-09-26 13:26:58 -04:00
Brandon Dayauon
3cdb32cc1f Do a vertical check for two line text, if it clips dont show two line.
Added extra 16dp to the cell height in DeviceProfile as per spec: https://docs.google.com/presentation/d/1dSt-zY_wRrOmd9a9nsQG458CIK0RUqVJsHJxLHP_0Nc/edit#slide=id.g237e909075a_2_6
Updated tests andincluded vertical check to see if two line can be fully rendered without being clipped. Otherwise just show one line.
Since existing cell height is 104dp, we add 16dp to be up to spec (120dp)
- Clean up FeatureFlag ENABLE_TWOLINE_ALLAPPS and now use aconfig flag

bug: 270390937
Test: manually - photos
Regular font: https://screenshot.googleplex.com/ArUcgZgHqR4ZWBQ
Bigger font than regular that makes text to one line because it wouldve truncate: https://screenshot.googleplex.com/6s8EdMAbBLsYhLi
Bigger font than regular with predicted app row (twoline):
https://screenshot.googleplex.com/38TEQei5GvPiCc7
Super big font: https://screenshot.googleplex.com/3JUYYprJRQ32Hsq
big display and regular font: https://screenshot.googleplex.com/55rBKVQ8htSe9Vc
big display and bigger than regular font: https://screenshot.googleplex.com/3atzKzJUbfM7YQW
flag: is off

Change-Id: I6998ea5da35d3e00ac75327d16b5ca676fb11c1a
2023-09-26 02:38:16 +00:00
Brandon Dayauon
c65b902cc4 Merge "Fix gray work apps when WorkPausedCard shoul've shown" into main 2023-09-25 18:13:12 +00:00
Stefan Andonian
7f1b5d0a70 Merge "Revert "Add unit tests for LoaderTask"" into main 2023-09-25 17:07:23 +00:00
Thales Lima
2d1d14193b Merge "Fix to prevent unsorted breakpoints returning wrong spec" into main 2023-09-25 16:12:56 +00:00
Stefan Andonian
e4735d77f1 Revert "Add unit tests for LoaderTask"
This reverts commit 4c7d7d6749.

Reason for revert: New Test assets were getting pulled into the release APK, making the APK size growth too much. I will re-upload when I figure out how to avoid this.

Change-Id: I738eb6c26632eeee30be4098d0225836d283b218
2023-09-22 18:23:22 +00:00
Sebastián Franco
885953d1f1 Merge "Moving test related to Uninstalling and removing to their own class" into main 2023-09-22 17:34:46 +00:00
Brandon Dayauon
c8af851e99 Fix gray work apps when WorkPausedCard shoul've shown
The reason is because WorkManager doesn't reset when user searches (which is why the apps gray out when you go to toast, turn off work profile then back gesture to all apps)

Added test for ActivityAllAppsContainerView that test onAppsUpdated() and check for if there are work apps.
From the test environment, onAppsUpdated() needs to be public because the method is outside the package. However, I've wrapped onAppsUpdated package private so I can test it with a boolean parameter.

bug: 298492729
test: video:
before: https://drive.google.com/file/d/1D0VlGeJEI5lGbYgP5Tnu5UO_Dv61X8Dv/view?usp=sharing
after: https://drive.google.com/file/d/1D0qsq7sX_kAp2t92xser7YI4ADBhQfHY/view?usp=sharing
Change-Id: I4eb7cf21e273e29171fcd62a4762e8bb1778e720
2023-09-22 17:18:10 +00:00
Charlie Anderson
605db4b74a Merge "Make sure to set Launcher restore pending as false after setting in RestoreDbTaskTest to not affect state of Launcher in tests. See tearDown method in RestoreDbTaskTest for fix." into main 2023-09-22 14:13:39 +00:00
Sebastian Franco
4fffab9d85 Moving test related to Uninstalling and removing to their own class
Bug: 298234173
Test: atest OopTaplUninstallRemove
Change-Id: I9b51bea7c1f3130b70296f945bef9b903ac34342
2023-09-21 21:17:38 +00:00
Sunny Goyal
052c11d2fe Cleaning up screenrecord for fixed tests
Bug: 256898879
Test: Presubmit
Flag: N/A
Change-Id: Ib9d3b82219971c975e8a09968fcb9cc0c96637c3
2023-09-21 09:51:34 -07:00
Jordan Silva
e4d7aaa6fd Fix to prevent unsorted breakpoints returning wrong spec
It orders the breakpoint list to guarantee that the smallest breakpoint is always returned for a given availableWidth or availableHeight.

Fix: 301396419
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: CalculatedWorkspaceSpecTest
Change-Id: Ia545e84150027bd8daa8d0dde58ff6fc579c3b6a
2023-09-21 11:44:56 +01:00
Treehugger Robot
34291f07fb Merge "Run leak detector in test isolation rule" into main 2023-09-20 23:04:01 +00:00
Sebastián Franco
8171e2fb84 Merge "Moving test related to Dragging to their own class from TaplTestsLauncher3" into main 2023-09-20 22:08:03 +00:00
Sebastian Franco
6b059deea6 Moving test related to Dragging to their own class from TaplTestsLauncher3
Renaming the following test names:
 - testDragAppIconToWorkspaceCell to testDragAppIconToMultipleWorkspaceCells
 - testDragShortcutToMultipleWoCells to testDragShortcutToMultipleWorkspaceCells

Bug: 298234173
Test: atest OopTaplDragTest
Change-Id: I16707e0a882164c7a5acec6a4197bd0bea8514a7
2023-09-20 18:56:13 +00:00
Charlie Anderson
8c1cf2db26 Make sure to set Launcher restore pending as false after setting in RestoreDbTaskTest to not affect state of Launcher in tests.
See tearDown method in RestoreDbTaskTest for fix.

This reverts commit 2d86f3337a.

Reason for revert: fixing the issues for revert b/298077774
Test: running presubmit and affected test suite on CL

Change-Id: I94c643f38259c4e920869c231f706229390c7c2a
2023-09-20 18:43:35 +00:00
Vadim Tryshev
7772c32603 Run leak detector in test isolation rule
This will help to fail the test causing the leak, not the next one

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I07e2457a9c8b9794d9c3ecc4764500dcdd3bbb10
2023-09-19 18:25:58 -07:00
Stefan Andonian
4fc16ab256 Merge "Add unit tests for LoaderTask" into main 2023-09-19 16:02:50 +00:00
Vinit Nayak
af40345edc Merge "Add WorkProfileTest back into presubmit" into main 2023-09-15 19:13:10 +00:00
Vadim Tryshev
a4853ab2b7 Merge "If running in presubmit, ignore @PortraitLandscape annotation. It's important to keep presubmits fast even if we will occasionally miss regressions in presubmit." into main 2023-09-15 16:53:14 +00:00
Thales Lima
8f2c11fed0 Merge "Revert "Add ScreenRecord for a flaky test"" into main 2023-09-15 12:40:08 +00:00
Vadim Tryshev
0d50b19f4b Merge "Verifying that workspace looks correct at the end of the test." into main 2023-09-14 23:44:24 +00:00
Vinit Nayak
4b46428c91 Add WorkProfileTest back into presubmit
Bug: 243688989
Change-Id: I6cf389e5056cd6eea000530d4f974591dbf0e8eb
2023-09-14 16:35:05 -07:00
Vadim Tryshev
a3030444ec If running in presubmit, ignore @PortraitLandscape annotation.
It's important to keep presubmits fast even if we will occasionally miss
regressions in presubmit.

Bug: 295939967
Test: presubmit
Flag: N/A
Change-Id: I9b65a2dc1e912fbfe834d7eee67815cb05f30bb2
2023-09-14 23:07:07 +00:00
Sebastián Franco
c468af4139 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev am: 216a765894 am: 07ce8fa893
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681787

Change-Id: I74496b2ce863dadce1fbe3889de242c133a75121
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 19:02:27 +00:00
Sebastián Franco
07ce8fa893 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev am: 216a765894
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681787

Change-Id: I91986355b221bbd623100dcf79d180ed9cc9a0c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 18:08:54 +00:00
Sebastián Franco
216a765894 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev 2023-09-14 17:50:54 +00:00