Commit Graph

363 Commits

Author SHA1 Message Date
Adam Cohen
b2b02b9bd2 Fix a small UI nit with screen reordering
-> When in overview mode, flinging the pages can leave the scroller
   running (invisibly) for much additional time, since the scroller
   fling bounds far exceed the alloawble scroll bounds (in order to
   achieve a hard wall type effect)
-> When this is happening, user couldn't pick up a page for reordering
-> Ended the scroller early in this case to avoid the problem

Change-Id: I8b6f140d9a87bb742e57625e90ca7d76a2158e28
2015-06-10 18:45:38 -07:00
Sunny Goyal
316490e636 Removing some synthetic method creation
> Make package-private and @Thunk all private methods and constructors accessed from inner classes.

Change-Id: Ie5913860a0c33e48e9bf68f9b5b1699f64c2f174
2015-06-02 10:04:59 -07:00
Vadim Tryshev
04a9bc4a50 Merge "Setting scroll X, Y and related attributes for TYPE_VIEW_SCROLLED event." into ub-launcher3-burnaby 2015-05-28 22:07:56 +00:00
Vadim Tryshev
7066c1235f Setting scroll X, Y and related attributes for TYPE_VIEW_SCROLLED event.
Change-Id: Idec0e333a0d3c3a0c232d3e2240f18174e0ea88c
2015-05-28 15:06:18 -07:00
Vadim Tryshev
8b80baec06 Merge "Fixing non-scrolling of workspace view after opening/closing AllApps vew. The reason for non-scrolling was excluding the pages view from the accessibility hierarchy by marking it as non-important. So, I just removed the code manipulating [non]importance of the PagedView." into ub-launcher3-burnaby 2015-05-28 21:42:16 +00:00
Vadim Tryshev
7af0d4474f Fixing non-scrolling of workspace view after opening/closing AllApps vew.
The reason for non-scrolling was excluding the pages view from the
accessibility hierarchy by marking it as non-important. So, I just
removed the code manipulating [non]importance of the PagedView.

However, this would make the PagesView accessibility-focusable, which is
undesirable. It becomes focusable because it supports long clicks in "normal"
mode. Since it doesn't support accessibility long clicks (i.e. Overview mode is
fetched NOT via accessibility long-click), I just disabled accessibility
long-clickability, which made PageView non-focusable, and it started to behave
correctly.

Bug: 21281859
Change-Id: I7ab01e5f39cb37c456c961199c27458c9bda1c3d
2015-05-28 14:33:36 -07:00
Sunny Goyal
1740d901ff Fixing build breakage
Change-Id: I2d8ac9a92d2da3d6b0f52ff8a6e3683b05663aec
2015-05-27 11:14:01 -07:00
Sunny Goyal
5a1f53b306 Removing SmoothPagedView as all its methods are disabled
Change-Id: I83c99bb3d3546693200d64e2233957b4c679e7e6
2015-05-27 10:24:24 -07:00
Sunny Goyal
a1fbd84b79 Fixing unnecessary padding added to pages in overview mode
Change-Id: Icd17c2956b201ea0b6c6a2a495f567f51987b1ac
2015-05-20 13:40:57 -07:00
Vadim Tryshev
bc51766dea Merge "Removing itemCount, fromIndex and toIndex from AccessibilityEvent.TYPE_VIEW_SCROLLED sent by PagedView. This causes an additional reduntant voice message on scroll (see the bug)." into ub-launcher3-burnaby 2015-05-20 18:10:54 +00:00
Vadim Tryshev
cd4f4138f0 Removing itemCount, fromIndex and toIndex from
AccessibilityEvent.TYPE_VIEW_SCROLLED sent by PagedView.
This causes an additional reduntant voice message on scroll (see the
bug).

Also, setting these attributes violate rules set here:
http://developer.android.com/reference/android/view/accessibility/AccessibilityEvent.html
i.e. that these fields should be set only for descendants of
AdapterView.

Note that we can't just stop sending TYPE_VIEW_SCROLLED, because in this
case, accessibility focus won't be set after scrolling.

Bug: 21304383
Change-Id: I84f8e064d8209c0e09d6827551e00c9913829b57
2015-05-19 21:34:55 +00:00
Sunny Goyal
83a8f042ad Moving LauncherAccessibilityDelegate to accessibility package
Change-Id: I510204a5a12abf2da2757f3e3f8b0e8869a6b04a
2015-05-19 12:52:30 -07:00
Sunny Goyal
a8a4546805 Merge "Adding padding to the folder content" into ub-launcher3-burnaby 2015-05-15 02:22:00 +00:00
Sunny Goyal
41b22c0924 Overriding proper layout params methods for a custom ViewGroup
Change-Id: Ib6176a0da510eaa0992551ab4afa6f73b4763db0
2015-05-14 15:21:53 -07:00
Sunny Goyal
7066003b20 Various lint error fixes.
> Fixing some RTL errors by specifying both marginStart and marginLeft
> Moving all layout direction checks to Utilities
> Explicitely adding @TargetApi before every method

Change-Id: Ibe9c52b93b5a6adeadb27ace2b312770fd732ea0
2015-05-14 12:28:07 -07:00
Sunny Goyal
22fc63ee29 Adding padding to the folder content
Change-Id: I88e56ff1aa26282e0167e2599f1b34ee374b705f
2015-05-13 16:01:26 -07:00
Vadim Tryshev
8a496ac99e Merge "Fixing accessibility scrolling events generated by PagedView:" into ub-launcher3-burnaby 2015-05-13 17:42:31 +00:00
Vadim Tryshev
f4715974b8 Fixing accessibility scrolling events generated by PagedView:
1. Not generating scroll events from snapToPage(). It already gets
   generated from computeScrollHelper().

2. Not setting action because doing so is not mentioned here:
   http://developer.android.com/reference/android/view/accessibility/AccessibilityEvent.html.

3. Not generating scroll event when the page stays same (before it was
   generated, say, when we simply returned from the AllApps view to
   Workspace).

4. From/To index is not the old and new page numbers; they are indices
   of the first and last item; in our case, the item is the page, and
   both FromIndex and ToIndex should be set to this page number.

Bug: 18761184
Change-Id: I3dadf816c3d45b8bd42a13930344874584467499
2015-05-11 17:40:07 +00:00
Sunny Goyal
067e5e0177 Merge "Removing some dead code in paged view" into ub-launcher3-burnaby 2015-05-07 17:19:37 +00:00
Sunny Goyal
8e2133b2c2 Removing some dead code in paged view
> Removing fling to delete pages
> Removing delete drop target for pages
> Removing syncpages support (was used by paged all apps)

Change-Id: I0a35ae30da8c48a27aac341bbee9fb5623665902
2015-05-06 14:12:05 -07:00
Sunny Goyal
1d08f70441 Accessibility: Page re-ordering in overview mode
Change-Id: I5fc0ad326a63b6768cb1fae55ee6e05a9fc2b659
2015-05-06 12:06:48 -07:00
Winson Chung
dc61c4d414 Refactoring to single path for overview mode.
Change-Id: I590a813c6f031342d75c3a6c3e9c9afda1808f2e
2015-04-21 15:54:22 -07:00
Hyunyoung Song
df41097194 Merge "Focus handling null pointer exception during monkey tests." into ub-launcher3-burnaby 2015-04-16 21:52:13 +00:00
Sunny Goyal
3e2ff8afef Updating maxscroll only after layouttranstion has finished
Bug: 20092568
Change-Id: I6ff8d9759b71b0b00ebfdaa75b558254dbeb0ef9
2015-04-16 14:50:22 -07:00
Hyunyoung Song
b76cd628e6 Focus handling null pointer exception during monkey tests.
- Also fix a bug where the focus is not navigating to the next page when there
isn't an icon within +45 and -45 range of the origin.

b/20294717

Change-Id: I16dac5c6a0463fbc9f56a447abedad18abadde98
2015-04-16 14:34:09 -07:00
Sunny Goyal
2f0ec85acf Disabling overscroll when folder has only one page
Change-Id: I3cc3964dba1af8d96822e46baf2dc9cfaee824ae
2015-03-26 13:38:27 -07:00
Adam Cohen
091440a9cb Reducing method count by eliminating synthetic accessors
Elimates 304 methods based on dex analysis

The java compiler generates sythetic accessor methods for all private
fields, methods and contructors accessed from inner classes. By marking them
package-private and @Thunk instead, sythentic accessor methods are no
longer needeed. These annotated elements should be treated as private.

Change-Id: Id0dc2c92733474250d8ff12fa793d3a8adeb1f26
2015-03-20 11:15:54 -07:00
Adam Cohen
c2d6e897db First pass of the Launcher Overlay interface / impl
-> Added simple reference launcher extension
-> Make launcher able to handle a null qsb

Change-Id: Ib1575243cac800a335e95bbf00cdc394bb4741c3
2014-10-22 17:40:39 -07:00
Sunny Goyal
4cbf046bf9 Updating content of page description frequently.
> Removing unused search icon page indicator

issue: 17256565

Change-Id: I95158cf68f98b2af847cefb4d126468b908301e2
2014-08-28 16:21:22 -07:00
Adam Cohen
69ed200530 Fix regression which was causing requestLayout in layout pass
-> This caused funky layout issues with views not appearing
   on devices prior to K in addition to log spam.

issue 17282728

Change-Id: Id05856ba2ef3de3a8a636ba9b4b46ddef3eff75e
2014-08-28 10:10:13 -07:00
Adam Cohen
1e4359c54e Adding dampened snap back overscroll to Workspace and AppsCustomizePagedView
issue 15475254

Change-Id: I5eb9fc480167faf4be16bd17bf18e2d103f40f47
2014-08-18 13:45:36 -07:00
Adam Cohen
1d3d4f1a82 Get rid of pages overhang in AppsCustomizePagedView
Change-Id: I7543af84a6a52b79b7d6f369bb3139fc4024f074
2014-08-14 19:15:30 -07:00
Adam Cohen
63f1ec00fb Further refinement of all apps / widgets transition
Change-Id: Id107a9aff74f014c07f8cbea6e74951a02dbddab
2014-08-13 21:39:48 +00:00
Adam Cohen
4e243a2dad Updating the widget tray
-> adding dark panel / associated visual updates
-> cleaning up the sizing / padding / to match all apps
-> fixing a couple things from previous CL
-> (removed Context#getDrawable() calls, L-only)

Change-Id: Ia65a6eb704b35f74e7305be9334c27971b22235a
2014-08-11 15:40:37 +00:00
Adam Cohen
9bfdb76aaf Polishing the AllApps transition
-> separating HW layers during animation to be siblings
   instead of parent-child (was destroying parent layer
   on each frame)
-> Unifying material transition with pre-L, everything
   is the same, just missing the reveal.

Change-Id: I8f7d5e658c2d9298bea83ce8199cb35e6fc0d44e
2014-08-10 18:29:36 -07:00
Adam Cohen
6f127a614c More defense for issue 14491953
Change-Id: I90de51c74e337d56aad891741233e6a857d89b62
2014-06-12 17:08:27 -07:00
Adam Cohen
327acfea13 Fix for regression which made issue 14491953 occur more easily
Change-Id: I27711aad8aae2824a54a043f686918d342ffc5bb
2014-06-06 14:28:10 -07:00
Adam Cohen
309260ee59 Merge "Don't notifyPageSwitchListener until page settles (issue 12069757)" into jb-ub-now-kermit 2013-12-13 23:59:53 +00:00
Adam Cohen
674531f261 Don't notifyPageSwitchListener until page settles (issue 12069757)
-> Should address the dismiss timer not working quite right

Change-Id: I63ad32d8f7c37f1a090ff1dd6024eeb7c0c6ce65
2013-12-13 15:59:01 -08:00
Michael Jurka
34c2e6cf7a Clean up imports 2013-12-13 16:20:53 +01:00
Adam Cohen
4de0974c46 Fix NPE from feedback (issue 12106858)
Change-Id: I63f7f73b85d4c1652d1e722f94c51b567a83cc6b
2013-12-12 16:16:55 -08:00
Adam Cohen
59b5c79b6f Fix page jumping regression in overview mode (issue 12003672)
Change-Id: I4315d4e97c8df4db25e2d70be759b94a0348d644
2013-12-04 16:12:19 -08:00
Adam Cohen
cccfe95beb Merge "Allowing ability to pick up items / enter overview before full page settle" into jb-ub-now-jolly-elf 2013-11-25 18:46:23 +00:00
Winson Chung
540efef758 Merge changes Ida9603e3,I3dfa45cc into jb-ub-now-jolly-elf
* changes:
  Initialize FastBitmapDrawable bounds with default bitmap dimensions.
  Updating LauncherModel filtering to use screen ids. (Bug 11685286)
2013-11-18 22:12:11 +00:00
Adam Cohen
a765215280 Allowing ability to pick up items / enter overview before full page settle
-> Fixes issue 11701996
-> Fixes issue where if you tried to longpress a widget before the page
   settled, it would instead enter overview

Change-Id: Ic6321805687dd5e8c69506c6cd6941a11d557ed6
2013-11-18 20:08:11 +00:00
Adam Cohen
f9618856d6 Syncing up state transition with paging transition
Change-Id: Id91e4c046cfe7d9aa6e7de10dbf57ee727ba160e
2013-11-18 15:21:29 +00:00
Winson Chung
9b9fb967b2 Updating LauncherModel filtering to use screen ids. (Bug 11685286)
- Fixes the issue with the current page not synchronously binding

Change-Id: I3dfa45cc1777f846c77f3e86059dfb715553e1a3
2013-11-15 15:46:27 -08:00
Adam Cohen
84a465aa0e Small tweaks to custom content management
-> Never allow the custom content overhang onto the viewport when
   it is not the current page
-> Never fade the custom content screen as a consequence of scrolling

Change-Id: I91a4cfb3f740ee8b429084fce1c96258bac8dd9e
2013-11-11 18:50:56 +00:00
Adam Cohen
4683041885 am 2da0a053: Fix small scrolling regression
* commit '2da0a0532752fae8985e3e8a192eb5087cf78aab':
  Fix small scrolling regression
2013-11-08 07:29:13 -08:00
Adam Cohen
2da0a05327 Fix small scrolling regression
-> only cancel scrolling when necessary to avoid
   unnecessary snapToDestination() calls

Change-Id: I406bef2453c88d61d25f66be67205ab8fbd69ec9
2013-11-08 06:30:18 -08:00