Commit Graph

17218 Commits

Author SHA1 Message Date
Schneider Victor-tulias
bdae57c157 Fix janky Alt+Tab through overview animation
Flag: not needed
Fixes: 282172884
Test: used alt+tab in overview; also launched overview through keyboard quick switch view
Change-Id: I3d1e54cda317ee8f8d2b2d698480cd3ca01dfc85
2023-10-10 11:20:15 -04:00
Liran Binyamin
5bec1164b9 Merge "Make the bubble bar flag dynamic in Launcher." into main 2023-10-03 17:47:11 +00:00
Liran Binyamin
e41e6185e4 Make the bubble bar flag dynamic in Launcher.
Changing the flag currently requires a reboot, because it is read once when the process starts and never changes.
This change triggers a re-read of the flag value from SystemProperties whenever Taskbar is recreated.
This allows setting the flag as part of integration tests for bubble bar.

Bug: 273994695
Test: Manual:
       - turn flag off
       - create bubbles
       - observe floating bubbles are added
       - turn flag on
       - change navigation mode to gesture navigation
       - observe bubble bar becomes visible
Change-Id: I277ea6aa2c8d3ab04094537bf4cd31630310dfec
2023-10-03 10:49:30 -04:00
Vadim Tryshev
d8c049f2af Starting to tighten leak detector checks
This will help to detect leaks earlier, not when we have 3 activities in some cases, but when we have 2.

Adding a parameter that enables more strict detection, and using it in some places.

I'll try to convert as many places as possible to the more strict check after landing this CL.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Idd5a0386005e46dad8aab222bd77c0240f23f43a
2023-10-02 18:34:32 -07:00
Vadim Tryshev
a6b74ffdfc Merge "Verifying that workspace looks correct at the end of the test." into main 2023-10-02 21:48:04 +00:00
Tracy Zhou
fe38407873 Merge "Repostion contextual buttons upon layout changes" into main 2023-10-02 20:15:31 +00:00
Brian Isganitis
c0b9b422be Merge "Add AllApps TAPL APIs for toggling with meta key." into main 2023-10-02 19:09:38 +00:00
Alex Chau
8eb662c67b Merge "Create icon app chip menu for overview tasks." into main 2023-10-02 17:40:33 +00:00
Alex Chau
a84e50412c Merge "Mark existing Launcher CUJs as Platinum tests." into main 2023-10-02 13:05:30 +00:00
Pat Manning
1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Schneider Victor-tulias
8f795844e9 Merge "Refactor the BorderAnimator for simplicity" into main 2023-10-01 17:27:16 +00:00
Vadim Tryshev
b57e25127e Verifying that workspace looks correct at the end of the test.
I hope that this will lock bugs like b/298114205 in the test that created the bad condition, not the next one.

Bug: 298114205
Test: presubmit
Flag: N/A
Change-Id: If9b48fb5159fc35948607a99f87199d5a32e64d6
2023-09-29 18:31:04 -07:00
Pat Manning
ff74bb5ded Mark existing Launcher CUJs as Platinum tests.
Exclusion CL: cl/565329636 & cl/569615823

Acceptance Criteria:
- TaplTestsQuickstep#testOverviewActionsMenu: https://android-build.corp.google.com/test_investigate/?invocationId=I68300010197543619&testResultId=TR13128935381586398&tab=performance
- OopTaplOpenCloseAllApps#testAllAppsSwipeUpToWorkspace: https://android-build.corp.google.com/test_investigate/?invocationId=I29900010197342608&testResultId=TR26328933842394642&tab=performance
- AddWidgetTest#testResizeWidget: https://android-build.corp.google.com/test_investigate/?invocationId=I56600010197561454&testResultId=TR14428935383013115&tab=performance
- TaplTestsLauncher3#testLaunchHomeScreenMenuItem: https://android-build.corp.google.com/test_investigate/?invocationId=I56600010197561454&testResultId=TR20028935383489058&tab=performance

Bug: 300249773
Test: TaplTestsLauncher3
Test: OopTaplOpenCloseAllApps
Test: AddWidgetTest
Test: TaplTestsQuickstep
Change-Id: Ica71dbad91efe8f5b4fd243f0ec78fc3c3c4d456
2023-09-29 23:27:27 +00:00
Jagrut Desai
9c80d72947 Merge "Fixing testQuickSwitchToPreviousAppForTablet" into main 2023-09-29 19:38:48 +00:00
Brian Isganitis
c3c0664ab1 Add AllApps TAPL APIs for toggling with meta key.
Test: TAPL
Bug: 300147433
Flag: No
Change-Id: Ie4d91ac77a325febb521806a008f8fcad5869f85
2023-09-29 15:26:42 -04:00
Schneider Victor-tulias
7335bcf7f5 Refactor the BorderAnimator for simplicity
The internal implementation of BorderAnimator does not need to be as exposed. refactored the class to be simpler to implement

Flag: ENABLE_KEYBOARD_QUICK_SWITCH, ENABLE_CURSOR_HOVER_STATES
Bug: 302334949
Test: check border animation in keyboard quick switch and recents view
Change-Id: I8a2e4fa0abc5af743352cd6409aee9f2912b41a2
2023-09-29 15:08:05 -04:00
Schneider Victor-tulias
0606b1f296 Merge "Add TAPL tests for the keyboard quick switch view" into main 2023-09-29 18:42:11 +00:00
Luca Zuccarini
850a282446 [Toast] Fix ANR when tapping on rich card chip. am: ba44979d79 am: f876cb4bf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24894969

Change-Id: Iac57076c82c798876d7d94c9f03d3fc1d34bc09f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 18:41:51 +00:00
Schneider Victor-tulias
41b42bf7d5 Add TAPL tests for the keyboard quick switch view
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 267520665
Test: TaplTestsKeyboardQuickSwitch
Design doc: go/kqs-tapl-tests

Change-Id: I1c3c5c758011a36ed405426f543ce450910f774e
2023-09-29 14:39:35 -04:00
Luca Zuccarini
f876cb4bf4 [Toast] Fix ANR when tapping on rich card chip. am: ba44979d79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24894969

Change-Id: Ic9371183df1de229eb96a867c01eab21fd0f8b02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 17:36:12 +00:00
Sunny Goyal
72a7407695 Merge "Passing activityClassName when setting unlock controller" into main 2023-09-29 16:48:03 +00:00
Fengjiang Li
576c7ff4d7 Merge "Don't preinflate all apps for taskbar in AllAppsStore#setApps" into main 2023-09-29 16:16:58 +00:00
Luca Zuccarini
ba44979d79 [Toast] Fix ANR when tapping on rich card chip.
This method recursively looks up the view hierarchy for a suitable view
to animate. The wrong variable was causing an infinite loop by never
updating the object being checked for the end condition.

With the fix, the animation behaves as expected.

Fix: 302568434
Flag: ENABLE_SEARCH_RESULT_LAUNCH_ANIMATION
Test: see video in the bug.
Change-Id: I123e50f1618a1e48256c0c976eeb46c93e8391b2
Merged-In: I123e50f1618a1e48256c0c976eeb46c93e8391b2
2023-09-29 11:41:55 +00:00
Jagrut Desai
f9ad6ab8bb Merge "Add more debugs logs to TaskbarManager" into udc-qpr-dev am: f2412770e2 am: 7a150d07d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24829188

Change-Id: Ia5fae16bbb40ac5553b92380f8b1f7f592cb201e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 05:04:26 +00:00
Jagrut Desai
7a150d07d7 Merge "Add more debugs logs to TaskbarManager" into udc-qpr-dev am: f2412770e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24829188

Change-Id: I4abe9d51d2fb4e0b740484dcb5e08c3198848b39
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 03:57:48 +00:00
Sunny Goyal
613254e657 Passing activityClassName when setting unlock controller
Bug: 302621267
Test: Presubmit
Flag: N/A
Change-Id: I84f9e404dc2e0654d38dd24c08e82fa5d103a067
2023-09-28 20:29:53 -07:00
Jagrut Desai
f2412770e2 Merge "Add more debugs logs to TaskbarManager" into udc-qpr-dev 2023-09-29 02:39:18 +00:00
Vinit Nayak
5b759afe90 Merge "Revert "Unignore splitscreen tapl tests"" into main 2023-09-28 23:14:29 +00:00
Jagrut Desai
c1bd53c3f0 Add more debugs logs to TaskbarManager
- adding more logs to TaskbarManager to investigate taskbar being present in folded state of the device.

Test: Presubmit
Bug: 254119092
Flag: not needed
Change-Id: I81c475f1c6bbc8d5b7874ddc45e8778861b61cd0
2023-09-28 15:46:22 -07:00
Fengjiang Li
e92556819b Don't preinflate all apps for taskbar in AllAppsStore#setApps
Triggering all apps pre-infation at AllAppsStore#setApps is too late for taskbar, because it is in same frame when user opens all apps from taskbar. We should find an earlier entry point to pre-inflate all apps for taskbar.

Test: Verify taskbar is rendered correctly. Also verify we no longer pre-inflate all apps for taskbar in perfetto trace
Change-Id: If1f8c616b6be7f64ea16807f4b7a8b75da55d038
2023-09-28 14:29:07 -07:00
Brian Isganitis
a5cdbe5d4e Merge "Fix Taskbar AllApps touch interception when above EDU." into main 2023-09-28 21:17:55 +00:00
Jagrut Desai
e34b94f5b9 Merge "Gesture Error Detection - Improvements Part 3" into main 2023-09-28 18:55:38 +00:00
Vinit Nayak
8d0442372b Revert "Unignore splitscreen tapl tests"
This reverts commit 80d274e041.

Reason for revert: b/302542596

Change-Id: Iac1274dd844ff1baea1e8c7b22a54bf353c69974
2023-09-28 18:45:37 +00:00
Jagrut Desai
dbbeac7747 Fixing testQuickSwitchToPreviousAppForTablet
Bug: 286084688
Test: Presubmit
Flag: not needed
Change-Id: Ibd2a98096df5dc15fa3ae5833b8cab0fe77850e5
2023-09-28 10:57:26 -07:00
Vinit Nayak
6120e525d8 Merge "Unignore splitscreen tapl tests" into main 2023-09-28 05:12:36 +00:00
Jagrut Desai
f39c5099a8 Gesture Error Detection - Improvements Part 3
- Adding Gesture Event to log when detected invalid velocity in AbsSwipeUpHandler.

Bug: 288462574
Test: Presubmit
Flag: not needed
Change-Id: I5656e2eaaba3b2ae6c2143cb2a5752c106f5fd6f
2023-09-27 18:55:57 -07:00
Jagrut Desai
257b5cade6 Merge "Gesture Error Detection - Improvements Part 2" into main 2023-09-28 01:52:06 +00:00
Vinit Nayak
80d274e041 Unignore splitscreen tapl tests
* Previous they were failling locally, now they've magically
started working, let's see if the same happen in TH.

Bug: 297135374
Test: Passes/gets ignored correctly locally
Change-Id: I580afa43011237ca167bb763c65ef1974586a0fa
2023-09-27 14:45:13 -07:00
Helen Cheuk
5ab9a57ec0 Merge "Fixed delay of thumbnail loading when going to overview from home" into main 2023-09-27 20:29:00 +00:00
Jagrut Desai
883ea7c72b Gesture Error Detection - Improvements Part 2
- Adding gesture error detection for ON_START_RECENTS_ANIMATION for to be getting callabck within time limit.

Bug: 293379641
Bug: 290266108
Test: Presubmit
Flag: not needed
Change-Id: I7d0f70c55dc44749218ff8d8427e71cd512d083c
2023-09-27 13:24:09 -07:00
Holly Jiuyu Sun
01088a4001 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev am: 6c3cd3c092 am: 564a0acda7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24856663

Change-Id: I0ec7ee12bf09f7b7902915c28e22b5e923f5ac55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 19:44:28 +00:00
Vinit Nayak
909fe37472 Merge "Revert "Verifying that workspace looks correct at the end of the test."" into main 2023-09-27 18:42:25 +00:00
Holly Jiuyu Sun
564a0acda7 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev am: 6c3cd3c092
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24856663

Change-Id: If4a73bc64242feec4786705603c5c128fc2cecba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 17:49:29 +00:00
Holly Jiuyu Sun
6c3cd3c092 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev 2023-09-27 16:05:41 +00:00
helencheuk
9e142d3998 Fixed delay of thumbnail loading when going to overview from home
Some thumbnail snapshots show up slowly when GRID_ONLY_OVERVIEW is enabled because more thumbnails are displayed than before and some cache related code needs to be changed. This issue should be fixed for smooth user experience so all thumbnails could be shown quickly and at the same time.
Root causes and corresponding solution are as below:
1. No high resolution thumbnails are in cache when entering overview. It is either no cache at all or just low resolution cache
Solution: Preload when high resolution is enabled
2. The cache size is 3 which is not enough for tablet
Solution: Update cache size to 8 when it is tablet, and preload more if cache size increases. Remove least recent ones when cache size decreases

Fix: 271570416
Test: RecentsModelTest
Test: TaskKeyByLastActiveTimeCache
Test: TaskThumbnailCacheTest
Change-Id: I60003ca20942c256a0a1047678ea4368cd2520eb
2023-09-27 16:57:27 +01:00
Liran Binyamin
44bd688301 Merge "Let the bubble bar handle gestures over the bubble bar." into main 2023-09-27 15:39:16 +00:00
Tracy Zhou
a9194c54ef Repostion contextual buttons upon layout changes
Also make sure the contextual buttons are centered in its respective orientation

Fixes: 300849078
Test: Rotate around, and make sure the rotation button stays in the same corner
Change-Id: Ibc40739eff050f258b938ccf94c2056ed1ee596b
2023-09-26 19:09:59 -07:00
Tracy Zhou
aa366d03cd Merge "Fix wrong 3 button order in landscape mode sometimes" into main 2023-09-26 23:58:47 +00:00
Ats Jenk
a54772832b Merge "Animate launching desktop from overview" into main 2023-09-26 23:20:46 +00:00
Vinit Nayak
df751430bc Revert "Verifying that workspace looks correct at the end of the test."
This reverts commit 62e3b162ba.

Reason for revert: Possible culprit for b/301966780

Change-Id: Ice6babe404feeddf9f8b13ce2a6288005402c9cd
2023-09-26 15:19:20 -07:00