Commit Graph

9800 Commits

Author SHA1 Message Date
Samuel Fufa
9353b00616 Merge "Fix folder available height calculation" into ub-launcher3-qt-future-dev 2019-11-18 18:19:14 +00:00
Winson Chung
9b5f4aa48d Fix two small thumbnail leaks
- Even though the object wrapper is used within the same process, the
  call to start the fallback recents activity means that the system
  still ends up holding a reference to a copy of the intent and its
  extras, including the reference to the wrapper and the thumbnail it
  references, until the activity is destroyed (or next restarted).
  We need to clear the actual object strong ref after it's used when
  handling the new intent.
- The running task can have an associated thumbnail, so we should also
  clear the tmp running task ref when we leave overview.

Change-Id: Icdc0b1989b13927d112949797752615014856970
2019-11-15 11:31:15 -08:00
Tony Wickham
37a0970bf5 Improve quick switch from home by tracking both x and y motion
- Add NoButtonQuickSwitchTouchController which uses
  BothAxesSwipeDetector to track horizontal and vertical motion.
- Initially, we only detect swipe left to right to quick switch
  (like before), but then we allow swipe up to either go to
  overview (if you hold) or back home (if you don't hold).
- xDisplacement transitions non-overview components out (e.g. shelf
  and workspace), and translates overview in.
- yDisplacement translates overview up and scales it down

Bug: 126596417
Change-Id: Id679ad84c08246e205c667a78ed5df00d7276258
2019-11-14 15:50:18 -08:00
Pinyao Ting
c90742775b [a11y] fix the issue where launcher announces item added to homescreen before
it does

Test:
1. long press on home screen -> widgets
2. enable talkback
3. add a custom shortcut to home screen (i.e. 1x1 widgets, e.g. drive
scan in Google Drive, Driving Mode in Google Maps ... e.t.c )
4. verify talkback announces "item addded to homescreen" after it does
get added to the homescreen
5. repeat the same test for widgets (e.g. calendar)

Bug: 141527338
Change-Id: I232e6e796c9edb81128f816c71a33310c3700e73
2019-11-14 22:37:24 +00:00
Thiru Ramasamy
445cc2421e Merge "Fixes missing LauncherEvent for TAP action on FOLDER_ICON" into ub-launcher3-qt-future-dev
am: 9d9c42ef38

Change-Id: I1d67cb5a77c46e05ddfdfa547a12d8c64c7b4fdd
2019-11-14 14:07:42 -08:00
Samuel Fufa
ddab25da6b Merge "Enable a11y scrolling with item drag" into ub-launcher3-qt-future-dev
am: 574e8413ba

Change-Id: I37c71d6f55d2478d029a9509ca61d32599582442
2019-11-14 14:04:35 -08:00
Thiru Ramasamy
9d9c42ef38 Merge "Fixes missing LauncherEvent for TAP action on FOLDER_ICON" into ub-launcher3-qt-future-dev 2019-11-14 22:02:09 +00:00
Samuel Fufa
574e8413ba Merge "Enable a11y scrolling with item drag" into ub-launcher3-qt-future-dev 2019-11-14 21:53:04 +00:00
Tony Wickham
2785a5996c Improve quick switch from home by tracking both x and y motion
- Add NoButtonQuickSwitchTouchController which uses
  BothAxesSwipeDetector to track horizontal and vertical motion.
- Initially, we only detect swipe left to right to quick switch
  (like before), but then we allow swipe up to either go to
  overview (if you hold) or back home (if you don't hold).
- xDisplacement transitions non-overview components out (e.g. shelf
  and workspace), and translates overview in.
- yDisplacement translates overview up and scales it down

Bug: 126596417
Change-Id: Id679ad84c08246e205c667a78ed5df00d7276258
Merged-In: Id679ad84c08246e205c667a78ed5df00d7276258
2019-11-14 12:31:01 -08:00
Samuel Fufa
1c8d90aed0 Fix folder available height calculation
Bug: 139456471
Test: Manual
Change-Id: Ic86c481e76f8b6629ad74109ef98900f1c00e16c
2019-11-14 11:02:49 -08:00
Tony Wickham
4df42f85a4 Fix recents scale sometimes lagging behind window scale
We were previously offsetting the launcher animation progress based
on when we got onGestureStart, which meant it would lag behind if
onGestureStart came late. Now that we track the window instead of
the launcher shelf, and we don't show the launcher animation right
away in fully gestural mode anyway, we should remove this to ensure
the launcher part of the animation always lines up with the app
window.

We also reapply state whenever predictions are enabled, e.g. when
launcher starts after being force stopped, and previously this was
canceling the existing state animation. We don't want to do that
because predictions can be enabled at any point on a cold start,
and cancelling the existing state animation means that RecentsView
shows up in fullscreen and not attached to the app window for the
duration of the gesture.

Bug: 144454486
Change-Id: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
2019-11-13 16:37:32 -08:00
TreeHugger Robot
49e72ac059 Merge "Tapl: AllApps: ensuring a minimal vertical size of an icon" into ub-launcher3-qt-future-dev 2019-11-13 22:03:11 +00:00
vadimt
ec7c044c89 Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the icon on AllApps is higher that 2 paddings.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
Merged-In: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 21:45:16 +00:00
Samuel Fufa
8fb487413c Enable a11y scrolling with item drag
Bug:142300278
Test:Manual
Change-Id: Ieb79dac8a793f5adfe715b1cbe5b7ecae95a26b5
2019-11-13 13:22:49 -08:00
vadimt
480083490f Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the whole icon is visible.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 20:20:57 +00:00
Pinyao Ting
1397a42fc2 include predicted_rank in app launch logging
Test:
1. . build/envsetup.sh && tapas NexusLauncher
2. ccdebug && cclogcat
3. launch from workspace any app that is also in predicted apps
4. verify in terminal it has correct predicted_rank

Bug: 143855018
Change-Id: I07a62f07057537a6c09384cf944bbc5aa5888d22
Merged-In: I07a62f07057537a6c09384cf944bbc5aa5888d22
2019-11-13 01:15:37 +00:00
Pinyao Ting
2cf2871392 include predicted_rank in app launch logging
Test:
1. . build/envsetup.sh && tapas NexusLauncher
2. ccdebug && cclogcat
3. launch from workspace any app that is also in predicted apps
4. verify in terminal it has correct predicted_rank

Bug: 143855018
Change-Id: I07a62f07057537a6c09384cf944bbc5aa5888d22
2019-11-12 16:40:34 -08:00
Thiru Ramasamy
aea8820229 Fixes missing LauncherEvent for TAP action on FOLDER_ICON
Bug: 143969621

Change-Id: I8d08d1c55f90c6aeacd63ced8235de851ec2cad9
2019-11-12 14:38:56 -08:00
Sunny Goyal
e48b55d86e Preventing dead lock in layout inflation
Bug: 143353100
Change-Id: I52d0794aad26c1d1de8cb373f3398f626c15b4af
(cherry picked from commit d1a67d0d72)
2019-11-12 19:57:31 +00:00
TreeHugger Robot
40755182ee Merge "Preventing dead lock in layout inflation" into ub-launcher3-master 2019-11-12 19:56:17 +00:00
Sunny Goyal
cac41df9ad Fixing inverted filtering logic for notifications
Bug: 144290150
Change-Id: I52e54148069b4ba7ccd318ad47920b45a53300f1
2019-11-11 14:03:44 -08:00
Sunny Goyal
d1a67d0d72 Preventing dead lock in layout inflation
Bug: 143353100
Change-Id: I52d0794aad26c1d1de8cb373f3398f626c15b4af
2019-11-11 11:08:39 -08:00
Sunny Goyal
7b97eebbe5 Adding utility class to load customization resources for easier prototype
Also adding support for grouping multiple plugins in same APK using process name

To customize resources update the defination of dymanic_resources in config.xml:
    <array name="dynamic_resources">
        <item>@color/delete_target_hover_tint</item>
        <item>@integer/config_folderDelay</item>
        <item>@dimen/all_apps_action_spacing</item>
        <item>@fraction/container_margin</item>
    </array>

Change-Id: I79c08845464510af96b16d375b424ad914657f39
2019-11-11 10:39:45 -08:00
TreeHugger Robot
1ca9c89b01 Merge "[DO NOT MERGE] Folder name suggest Bug: 142498588" into ub-launcher3-master 2019-11-09 02:52:21 +00:00
Hyunyoung Song
4c74620d6a [DO NOT MERGE] Folder name suggest
Bug: 142498588

Change-Id: I735c842522f08db1fb9a11f731b63f8dba5a298f
Signed-off-by: Hyunyoung Song <hyunyoungs@google.com>
2019-11-08 15:07:48 -08:00
Jon Miranda
238343a65b Merge "Address SessionCommitReceiver vulnerability by validating intent." into ub-launcher3-qt-future-dev
am: 992cfbf63d

Change-Id: Id80274e147008bd00aeb581d637fcd82938c034f
2019-11-08 13:59:11 -08:00
TreeHugger Robot
992cfbf63d Merge "Address SessionCommitReceiver vulnerability by validating intent." into ub-launcher3-qt-future-dev 2019-11-08 21:50:02 +00:00
Jon Miranda
7e04887e59 Address SessionCommitReceiver vulnerability by validating intent.
Bug: 144081762
Change-Id: I28699d26abefc716e57c281c15699f15003229b2
2019-11-08 13:02:52 -08:00
TreeHugger Robot
f59803e708 Merge "Add visual indicator for predicted hotseat icons" into ub-launcher3-master 2019-11-08 15:45:22 +00:00
Samuel Fufa
ba6b47fd8e Add visual indicator for predicted hotseat icons
Bug: 142753423
Test: Manual
Change-Id: Ie4325660fc5392358ec845ae58385bef279db60f
2019-11-07 16:49:24 -08:00
TreeHugger Robot
45656e296f Merge "Scaling down hotseat to match prediction row size when going to overview" into ub-launcher3-qt-future-dev 2019-11-07 23:35:15 +00:00
Hyunyoung Song
00105625f4 Merge "[DO NOT MERGE] Folder name suggest Bug: 142498588" into ub-launcher3-qt-future-dev 2019-11-06 23:24:02 +00:00
Hyunyoung Song
7564d3b8bd [DO NOT MERGE] Folder name suggest
Bug: 142498588

Change-Id: I735c842522f08db1fb9a11f731b63f8dba5a298f
Signed-off-by: Hyunyoung Song <hyunyoungs@google.com>
2019-11-06 23:06:01 +00:00
Sunny Goyal
37279e2313 Scaling down hotseat to match prediction row size when going to overview
Bug: 141265005
Change-Id: I3b11146881af334508f553e4ca3a36b9291511d9
2019-11-06 14:39:28 -08:00
Sunny Goyal
a5020007e3 Scaling down hotseat to match prediction row size when going to overview
Bug: 141265005
Change-Id: I3b11146881af334508f553e4ca3a36b9291511d9
2019-11-06 22:36:34 +00:00
Tony Wickham
238c4bae27 Merge "Add BothAxesSwipeDetector" into ub-launcher3-qt-future-dev
am: ea09b9c963

Change-Id: I926c97b277e1ee268269955b6a8c66dab32f3178
2019-11-06 09:12:00 -08:00
Tony Wickham
ea09b9c963 Merge "Add BothAxesSwipeDetector" into ub-launcher3-qt-future-dev 2019-11-06 16:58:07 +00:00
Samuel Fufa
5fe9dd028c Merge "Fix icons vanishing when dragged within folder" into ub-launcher3-qt-future-dev
am: 734574221b

Change-Id: I857a428a0a828a922482372dbe63a8bd3bbd233b
2019-11-05 20:54:57 -08:00
TreeHugger Robot
734574221b Merge "Fix icons vanishing when dragged within folder" into ub-launcher3-qt-future-dev 2019-11-06 04:40:41 +00:00
Samuel Fufa
1b9e540a52 Fix icons vanishing when dragged within folder
Bug: 143702700
Test: Manual
Change-Id: Idc24086553fd337fc2a553e25daa570073d9ad51
2019-11-05 19:49:30 -08:00
Samuel Fufa
306177c14e Fix dragging icon badge offset
am: 37b2489ff7

Change-Id: Ibe7dbed4d3880086da14692597341ea9487efc29
2019-11-05 18:53:46 -08:00
Pinyao Ting
fe160c55c2 Merge "Add IconCache support for deep shortcuts, loads deepshortcut on background thread. Added a feature flag to toggle on/off this feature." into ub-launcher3-master 2019-11-05 23:33:48 +00:00
Samuel Fufa
37b2489ff7 Fix dragging icon badge offset
Bug: 143702640
Test: Manual
Change-Id: I86d97c1f0ea02c86f4bf745a8bdda3887c62f27e
2019-11-05 15:29:22 -08:00
Pinyao Ting
c1a1ced33a Add IconCache support for deep shortcuts, loads deepshortcut on
background thread.  Added a feature flag to toggle on/off this
feature.

Bug: 140242324
Test:
  1. (Custom Shortcut) Long click on google maps -> widgets -> drag
     driving mode to workspace.

  2. Open chrome -> add to home screen -> add -> add automatically.

  3. InstallShortcutReceiver
     In Launcher.completeAddShortcut, commend out the code that
     calls PinRequestHelper.createWorkspaceItemFromPinItemRequest,
     then open chrome -> add to home screen -> add -> add
     automatically.

  4. ShortcutDragPreviewProvider
     qdb -> long press on suggested app that has deep shortcut
     -> drag to workspace.

Change-Id: If7babe4eddf5434909bf686b4e9bde15e444d9fd
2019-11-05 11:27:28 -08:00
TreeHugger Robot
8e24097014 Merge "Implement hotseat prediction client" into ub-launcher3-master 2019-11-05 19:18:49 +00:00
Samuel Fufa
efb665d3ec Implement hotseat prediction client
Bug: 142753423
Test: Manual
Change-Id: I9f697c474b29340c9b33ddf896a49e8f3f893f8b
2019-11-05 09:53:25 -08:00
Winson Chung
5d3dc9c76d Merge changes I4649483a,I890a45e6,I6ccfab86 into ub-launcher3-master
* changes:
  17.5/ Remove synchronized calls, verify controller before finishing animation
  17/ Update activity tracker callback
  16/ Renaming the swipe handlers
2019-11-05 05:18:05 +00:00
Winson Chung
52c57f73d2 17/ Update activity tracker callback
- Immediately callback when scheduling activity tracker callback and the
  activity already exists
- Remove LauncherInitListenerEx, it was only used to update the prediction
  ui state, but not all of the callers of the launcher activity init
  listener actually needs this (ie. Go doesn't have overview predictions,
  overscroll input consumer/touch interaction service doesn't need it.)

  Instead we only call it in the places we need it LauncherSwipeHandler (for
  swipe up) and OverviewCommandHelper (for the nav bar button).

Bug: 141886704

Change-Id: I890a45e658be813e99b2a02f179fce611ede9ce8
2019-11-04 20:13:11 -08:00
Jon Miranda
e6691f34c1 Add additional shortcutExists check to prevent same app from being auto added.
am: f788bbb0c4

Change-Id: I42f0c4d75f8be38b9e81c5932fc1def710a68f36
2019-11-04 17:32:56 -08:00
Jon Miranda
f788bbb0c4 Add additional shortcutExists check to prevent same app from being auto added.
Since we made the change to treat all auto added workspace items as promise
icons, the initial shortcutExists check breaks since its comparing the promise
intent to the actual app intent. This additional shortcutExists check can
compare the proper intents.

Bug: 143803446
Change-Id: Ifa27b15205d6e17f83a4437ac175d51815688c84
2019-11-04 14:19:17 -08:00