Commit Graph

12738 Commits

Author SHA1 Message Date
Winson Chung
bc5637296a Merge "2b/ Update launcher to use GroupedTaskInfos" into main 2024-11-05 15:43:01 +00:00
Treehugger Robot
c0746bb887 Merge "Reduce log frequency of TasksRepository.setVisibleTasks()" into main 2024-11-05 11:32:32 +00:00
Uwais Ashraf
ae2c01a0b6 Reduce log frequency of TasksRepository.setVisibleTasks()
Fix: 377438334
Bug: 377437341
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: SwitchBackToSplitFromRecentGesturalNavLandscapeMicrobenchmark
Test: QuickSwitchTasksMicrobenchmark
Change-Id: I0cf56995ece9187a9a4da3ad61a17a795d0934db
2024-11-05 09:22:37 +00:00
Shamali Patwa
20cde49b4c Merge "Add a resource override for providing default widgets filter." into main 2024-11-05 01:01:00 +00:00
Shamali P
ea078cb647 Add a resource override for providing default widgets filter.
The implementation in this CL is no-op i.e. all widgets will be shown

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
2024-11-04 22:17:23 +00:00
Treehugger Robot
d66079d003 Merge "Handle null RecentsView in FallbackTaskbarUIController" into main 2024-11-04 21:54:28 +00:00
Tony Wickham
463a40fdb3 Handle null RecentsView in FallbackTaskbarUIController
Test: not crashing
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 365775636
Change-Id: I98c52cc09f1ca686ce3844044bbf734ef0b05e59
2024-11-04 20:01:14 +00:00
Matt Sziklay
9bede60992 Merge "Start background tasks via task instead of intent." into main 2024-11-04 16:57:45 +00:00
Treehugger Robot
9cafa2f8e2 Merge "Revert "Revert "Don't allow Desktop tasks to go outside Overview..."" into main 2024-11-04 15:34:43 +00:00
Sam Cackett
1ecdc2d712 Revert "Revert "Don't allow Desktop tasks to go outside Overview..."
Reland submission "Don't allow Desktop tasks to go outside Overview task bounds"

Reverted changes: /q/submissionid:30210454-revert-30114356-desktop-task-view-corner-clipping-KXYKHZHSWL

Change-Id: Ia263edcc876f9f72ca7f70733e96b0823dbd750e
Fix: 376206104
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: OverviewDesktopTaskImageTest, TaplTestsOverviewDesktop
2024-11-04 10:40:57 +00:00
Sam Cackett
127eb0b44d Merge "Revert "Don't allow Desktop tasks to go outside Overview task bounds"" into main 2024-11-04 10:01:08 +00:00
Manusaran Reddy Avula (xWF)
e906e733be Revert "Don't allow Desktop tasks to go outside Overview task bounds"
Revert submission 30114356-desktop-task-view-corner-clipping

Reason for revert: Culprit for b/376872073

Reverted changes: /q/submissionid:30114356-desktop-task-view-corner-clipping

Fix: 376872073
Bug: 376206104
Change-Id: I51c8b11a868a727145f0bc8a6feb13352a8cbead
2024-11-04 10:00:23 +00:00
Treehugger Robot
22a60f4940 Merge "Recycle tasks that are split when split select anim complete for reuse" into main 2024-11-02 06:13:53 +00:00
Uwais Ashraf
ca39594be9 Recycle tasks that are split when split select anim complete for reuse
Fix: 376428479
Flag: EXEMPT bugfix
Test: Manual verification of heap dumps
Change-Id: I8574c68da76227258985cb77955548352275049d
2024-11-02 00:48:26 +00:00
Winson Chung
d8ddd4c023 2b/ Update launcher to use GroupedTaskInfos
Bug: 346588978
Flag: EXEMPT adding new flag enable_shell_top_task_tracking
Test: Build SystemUI & Launcher
Test: atest WMShellUnitTests

Change-Id: I1e41712d9f94649f4381d4235d8f2925df71e2b2
2024-11-01 22:52:09 +00:00
Liran Binyamin
5aa29ea9df Merge "Update the flyout collapsed position" into main 2024-11-01 20:08:07 +00:00
mattsziklay
e6d75ca4ff Start background tasks via task instead of intent.
When the second app is selected, check if there is a background task
that matches the intent provided and start the task if there
is one.

This is done to correct an issue where freeform background tasks opened
via intent will open in the correct split stage but in freeform
windowing mode and bounds.

Bug: 338382550
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ibefe4b5045cbcefdbc71c99c4eaba4fdf67d7a0e
2024-11-01 11:04:20 -07:00
Liran Binyamin
6563429e2b Update the flyout collapsed position
This change ensures that we're updating the distance to the flyout's
collapsed position before we start collapsing it. The distance is
initially calculated before we start expanding, but when a new bubble
is added while we're fully expanded, and if we previously had 1
bubble and now have 2, the collapsed position changed, so we need to
update it before we start collapsing.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 376276297
Test: manual
      - dismiss all bubbles
      - create 1 bubble
      - after the flyout is fully expanded create a second bubble
      - observe the flyout is updated with the contents of the second
        bubble
      - observe when the flyout collapses, it collapses to the dot
        on the second bubble
Change-Id: I219886fd6463d69692d9945d901d1f3ad3cb26a0
2024-11-01 11:56:36 -04:00
Treehugger Robot
72a6d4539a Merge "Don't allow Desktop tasks to go outside Overview task bounds" into main 2024-11-01 12:35:20 +00:00
Liran Binyamin
65edaf53af Merge "Hide bubble dot after flyout init" into main 2024-10-31 22:46:56 +00:00
Mykola Podolian
db427334f2 Merge "Preserve bubble bar state." into main 2024-10-31 20:57:36 +00:00
Tony Wickham
0f954d9d3b Merge "TaskbarManager now sets TaskbarUIController for RecentsWindowManager" into main 2024-10-31 20:17:21 +00:00
Liran Binyamin
0e8093ae92 Hide bubble dot after flyout init
After the flyout initializes to its collapsed state, hide the
notification dot so that the flyout and dot will seem visually as
one.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 376276297
Test: atest BubbleBarFlyoutControllerTest
Change-Id: Ie581ddcd56a26844526f80b2169639c1a7d87500
2024-10-31 15:56:19 -04:00
mpodolian
647266f298 Preserve bubble bar state.
Added logic to save and then restore existing bubbles in the
TaskbarSharedState object.

Bug: 375482371
Test: Manual. Switch between pinned and unpinned taskbar. Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/d8hVHxksAokx85J8P7etoC
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I34f580f1c652859f427385edc0ccadd447e1400f
2024-10-31 11:50:46 -07:00
Wen-chien Wang
71ec86e398 Merge "Add margins to KQS view that is triggered from transient taskbar" into main 2024-10-31 18:06:49 +00:00
Mady Mellor
886387fd58 Merge "Fix an issue where the overflow wouldn't show if the flag was disabled" into main 2024-10-31 17:18:28 +00:00
Treehugger Robot
2891d5cb47 Merge "Add listener to update taskInfo when task change via transition" into main 2024-10-31 16:30:42 +00:00
Jordan Silva
2627657ab6 Add listener to update taskInfo when task change via transition
This change ensures the task information in TopTaskTracker stays updated with any task modifications. For instance, switching a task between freeform windowing and fullscreen will now update in TopTaskTracker, and consequently, in the RecentTasksList used by RecentsModel and RecentsView. This resolves a previous bug where switching a freeform task to fullscreen wasn't reflected, causing the new Fullscreen task and an incorrect DesktopTask state to display in the Overview.

Fix: 356355595
Flag: com.android.window.flags.enable_task_stack_observer_in_shell
Test: Manual.
Change-Id: Ib4a6eb8ea6abd21903018b05186c516511526746
2024-10-31 16:29:34 +00:00
Liran Binyamin
3955e224be Merge "Handle new bubble notification during animation" into main 2024-10-31 13:56:06 +00:00
Liran Binyamin
0242d124c2 Handle new bubble notification during animation
When a new bubble notification is pushed during an ongoing animation
we now update it to reflect the new bubble.
 - If the current animation is in the middle of animating in,
   we only update the animating bubble without interrupting the
   current animation. The flyout content will show the data for the
   new bubble.
 - If the current animation is in the IN state, then the flyout is
   showing and we're just waiting for it to be hidden. In this case
   we update the flyout and reschedule the hide animation to run after
   a delay.
 - If the current animation is animating out,
   - If we're in the middle of collapsing the flyout, we reverse it
     so it shows with the new content and reschedule the hide animation
   - If the flyout is gone already, then we reverse the handle animation
     and show the flyout. If the handle animation is not running, then
     the animation is already over.

Not really related to this change, but while testing one of the tests
was flaky, so rewrote it to make it deterministic.

25x runs: https://android-build.corp.google.com/test_investigate/invocation/I56000010330987902/test/TR44729496826317635/

Demo of interrupting the animation while animating out: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/cu4fLeFlnDkg7mDVaaDTB

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 277815200
Fixes: 346400677
Test: atest BubbleBarFlyoutControllerTest
Test: atest BubbleBarViewAnimatorTest
Change-Id: I2b4af36d39bedbdfc4a08a988967ccbc33c06522
2024-10-30 16:57:08 -04:00
Tony Wickham
87455f28fc TaskbarManager now sets TaskbarUIController for RecentsWindowManager
- FallbackTaskbarUIController can take in a generic
  RecentsViewContainer parameter, i.e. RecentsActivity or
  RecentsWindowManager.
- When changing Overview targets to RecentsWindowManager, which is not
  an Activity, we still update the TaskbarUIController

Test: Switch between default Home activities with the flag on and off,
ensure Taskbar works as expected in each case (3P vs 1P launcher).
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 368030750
Fixes: 365775636

Change-Id: Ife775e8c226f8c73ec9e1f97b4a6f2972f6c905f
2024-10-30 20:21:26 +00:00
Mady Mellor
e07699ae6a Fix an issue where the overflow wouldn't show if the flag was disabled
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - check that optional overflow flag is off and get
               bubbles in bubble bar, overflow should be present
Bug: 358304168
Change-Id: I1eb709003d4dcdde7ae465b837a2c68d40b1a828
2024-10-30 12:30:14 -07:00
Brian Isganitis
f9dea5e095 Merge changes I20cff11c,I751cdab5 into main
* changes:
  Stop suspending Launcher Taskbar in tests.
  Sandbox SettingsCache for Taskbar tests.
2024-10-30 19:05:14 +00:00
Schneider Victor-tulias
de739c226d Merge "Fix launcher crash on configuration changed" into main 2024-10-30 14:08:49 +00:00
samcackett
3ae3d297e6 Don't allow Desktop tasks to go outside Overview task bounds
Wrap TaskThumbnailView's in a new DesktopTaskContentView. This is in order to correctly crop the thumbnail children contained in the DesktopTaskView, otherwise any freeform task screenshots at the edges of the DTV leak outside the bounds.

We need a new container to do this, otherwise we will cut off the icon
or the hover border if we apply an outline to the DesktopTaskView itself.

Fix: 376206104
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: OverviewDesktopTaskImageTest
Change-Id: Ic51438e63aaf671a0a8156815d11fc7fa12beac0
2024-10-30 07:22:45 +00:00
Vinit Nayak
d626cdd727 Merge "Disable OrientationEventListener in RotationTouchHelper#destroy()" into main 2024-10-30 01:38:32 +00:00
Cosmin Băieș
a8190abb3a Merge "Cleanup ENABLE_HIDE_IME_CAPTION_BAR flag" into main 2024-10-30 00:19:01 +00:00
Yuichiro Hanada
ca23e23655 Merge "Move the animator for the minimization to WMShell" into main 2024-10-29 23:19:09 +00:00
Brian Isganitis
bab87b1551 Stop suspending Launcher Taskbar in tests.
The Taskbar under test should now be sufficiently isolated from
Launcher, so we no longer have to suspend it.

Flag: TEST_ONLY
Bug: 230027385
Test: go/testedequals
Change-Id: I20cff11c90208b59f1dca3730ec3978913c43a50
2024-10-29 19:15:58 -04:00
Wen-Chien Wang
c16a6394e4 Add margins to KQS view that is triggered from transient taskbar
This cl adds additional bottom margins to the KQS view for the
transient taskbar. Also adds a behavior that when the KQS view is
showing, the transient taskbar won't be stashed.

Screenshots with the new layout after this cl is uploaded to the
buganizer.

Bug: 368119679
Test: open KQS via transient taskbar and observe the bounds change
Flag: com.android.launcher3.taskbar_overflow
Change-Id: Ie50e768f828a24f0111df4cdba474a6482a4e1c7
2024-10-29 22:44:31 +00:00
Tracy Zhou
9b18ec739a Merge "Tuning gesture nav params for trackpad 3-finger gestures" into main 2024-10-29 22:12:28 +00:00
Treehugger Robot
331c3e3bef Merge "[Dagger] Make SystemUiProxy provided by DaggerSingletonObject" into main 2024-10-29 21:57:58 +00:00
Treehugger Robot
4674c3bb2b Merge "Fix NPE in QuickstepTestInformationHandler#getWindowInsets" into main 2024-10-29 20:34:54 +00:00
Tracy Zhou
21bb53ff08 Tuning gesture nav params for trackpad 3-finger gestures
It's harder to slow down in trackpad swipes than finger swipes on the screen, so the deceleration required to be considered pause for swiping from app should be less strict (set the number for trackpad to 0.85f instead of 0.6f for on-screen). Also added a speed_trackpad_somewhat_fast for the case of swiping up to overview, so that we can be a little bit more lenient to the users for the end speed.

Bug: 375688524
Test: play with 3-finger swipe to home / overview. Make it easier to go to overview, but fast swipe from app still takes user to home
Flag: EXEMPT bugfix
Change-Id: I196a92163fd36e9b7013f4893876b79c9c2c9de0
2024-10-29 13:10:49 -07:00
Schneider Victor-Tulias
716a154211 [Dagger] Make SystemUiProxy provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger migration
Change-Id: I00cb14ec5d7e423a34c88e75d1bcf9db4f0ae229
2024-10-29 16:01:36 -04:00
Treehugger Robot
7112a56ede Merge "Tapping overflow button toggles KQS" into main 2024-10-29 19:56:33 +00:00
Schneider Victor-Tulias
3736f44f8e Fix NPE in QuickstepTestInformationHandler#getWindowInsets
Flag: EXEMPT fixing NPE
Fixes: 28555142
Test: TAPL tests
Change-Id: I722dfe196b93861723ef3de9961f0a30b9056583
2024-10-29 14:27:25 -04:00
Vinay Joglekar
9859982e0a Merge "Fix icon during split task which is inside DW from taskbar." into main 2024-10-29 14:29:50 +00:00
vinayjoglekar
f6a773a476 Fix icon during split task which is inside DW from taskbar.
We don't animate DesktopTaskView into split placeholder to avoid having desktop icon as the split placeholder, which isn't accurate as we're only splitting with a single task rather than the whole desktop.

Test: Manual, split app from taskbar which is in desktop window
Fix: 376002803
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: Ib62d831b1f0c0ca5ee8f355a15f14baff8ec67ee
2024-10-29 14:29:15 +00:00
Treehugger Robot
9c062e472d Merge "Add a feature flag to toggle DW carousel detach" into main 2024-10-29 14:21:13 +00:00