Commit Graph

8726 Commits

Author SHA1 Message Date
TreeHugger Robot
9187337d15 Merge "Fix spring loaded scale when taskbar is present" into sc-dev 2021-03-24 00:43:33 +00:00
TreeHugger Robot
cb6dff62d9 Merge changes I6ce23251,I56fca1b7 into sc-dev
* changes:
  Update the resize frame to use the forced radius.
  Enforce rounded corners on App Widgets.
2021-03-24 00:39:17 +00:00
TreeHugger Robot
acb3cac938 Merge "Update Pin widget dialog UI according to mocks." into sc-dev 2021-03-24 00:29:41 +00:00
TreeHugger Robot
b9d201a5d6 Merge "Remove some unused hotseat/qsb scaling code" into sc-dev 2021-03-24 00:16:01 +00:00
Pierre Barbier de Reuille
452df2d5bb Update the resize frame to use the forced radius.
When forcing the rounded corners, the radius may be smaller than the
default one. When this happens, we should change how the frame is drawn
to only use that reduced radius, or this looks weird.

Bug: 183097166
Test: Manual tests with top 1P App Widgets
Change-Id: I6ce232515ce14059e1168e16735719ea2370132c
2021-03-23 20:57:33 +00:00
Pierre Barbier de Reuille
298526e812 Enforce rounded corners on App Widgets.
The feature is controlled by the ENABLE_ENFORCED_ROUNDED_CORNERS flag
(currently set to false).

If does not yet handle P/H flags to control its behavior.

Bug: 183097166
Test: Manual tests with top 1P App Widgets (See bug for results)
Change-Id: I56fca1b717f37ad518588115409f2144a71d4b98
2021-03-23 20:57:33 +00:00
Tony Wickham
3629b93546 Merge "Add TaskbarView as a child of Hotseat" into sc-dev 2021-03-23 18:36:53 +00:00
Tony Wickham
d0b6bfaa69 Remove some unused hotseat/qsb scaling code
Now that QSB is always part of Hotseat, we don't need
getQsbScaleAndTranslation(), and now that HOTSEAT_ICONS are never in
Overview, we can remove the getHotseatScaleAndTranslation() override

Test: Everything works as before
Bug: 175137718
Change-Id: I902815d8e270269c1a2a9af54fa8480e5aef929d
2021-03-23 10:33:44 -07:00
Steven Ng
d8c2a7b2da Merge "Update title of bottom widgets tray" into sc-dev 2021-03-23 17:19:01 +00:00
Alina Zaidi
6d97d893e0 Update Pin widget dialog UI according to mocks.
Test: Tested manually and RequestPinItemTest passed
Bug: 182982143
Bug: 182994819
Bug: 182929673
Change-Id: I905ea0c1860d28ee9fbb456ddf6abd728b65bac4
2021-03-23 13:36:48 +00:00
Jonathan Miranda
b40025756a Merge "Account for children margins when orienting popup container." into sc-dev 2021-03-23 09:38:37 +00:00
TreeHugger Robot
1764c7ee94 Merge "Do not allow widget to be resized beyond max size." into sc-dev 2021-03-23 00:57:20 +00:00
Tony Wickham
9ce3b25ef6 Add TaskbarView as a child of Hotseat
Instead of keeping the Taskbar window showing above the home screen,
we now integrate a copy of TaskbarView directly into Launcher's view
hierarchy. Most TaskbarController calls apply to both TaskbarViews
(mTaskbarViewInApp and mTaskbarViewOnHome), except for calls related
to Hotseat, which only apply to mTasbkarViewInApp given the real
Hotseat will be showing with mTaskbarViewOnHome.

More cleanup will follow this change.

Test: All taskbar interactions (e.g. drag and drop) continue to work
Bug: 182512211
Bug: 171917176
Change-Id: I0f0b124f652daa85f866e1df8f9e2981540331a0
2021-03-22 15:26:01 -07:00
Steven Ng
867ff5f60c Update title of bottom widgets tray
Only use the "app name" instead of "app name widgets" as title
Remove "Touch & hold to move a widget" subtitle.

Test: manual

Bug: 179797520
Change-Id: I7a5954af73aa5b480096e93ade3520cef6c93f17
2021-03-22 22:23:46 +00:00
Hyunyoung Song
9197cfa36a Merge "Remove cursor when edit text no longer has focus" into sc-dev 2021-03-22 21:24:10 +00:00
Steven Ng
164936c3db Merge "Add an 65% opacity for workspace elements drag over button drop target" into sc-dev 2021-03-22 19:44:20 +00:00
Steven Ng
aa3c6468b0 Merge "Align widgets previews top to the table layout" into sc-dev 2021-03-22 18:54:52 +00:00
András Klöczl
3043ef1689 Merge "Fix widget scrolling issue on right panel" into sc-dev 2021-03-22 18:53:45 +00:00
Steven Ng
f45f875232 Merge "Fix corner radius for single item in the widgets tray." into sc-dev 2021-03-22 18:51:41 +00:00
Andras Kloczl
2bb5134413 Fix widget scrolling issue on right panel
Since we added support for multiple panels on the home screen,
we need to call cancelLongPress on all the visible pages not
just on the leftmost visible page.

Test: manual
Bug: 178582378
Change-Id: I88ded543a16b1bbf2a53a627e5725f68b42e742b
2021-03-22 17:39:06 +01:00
Steven Ng
f4fb4d9429 Fix corner radius for single item in the widgets tray.
If there is only one item, corner radius at 4 corners should be 28dp.

Test: Corner radius of one item is correctly shown in the widgets
      picker.

Bug: 183382610
Change-Id: Ief46af8c41ce944792d08212e93f7d68c6278d05
2021-03-22 16:30:57 +00:00
Jonathan Miranda
93e1e56675 Merge "Dump DeviceProfile to help with debugging grid changes Some of these internal values are not exposed in hierarchy viewer" into sc-dev 2021-03-22 15:48:46 +00:00
Steven Ng
267270e859 Align widgets previews top to the table layout
Test: Manual

Bug: 179797520
Change-Id: I0716432e72327b825619bc35d55cb74d9621ee6a
2021-03-22 15:26:13 +00:00
Steven Ng
6a2acfaa59 Add an 65% opacity for workspace elements drag over button drop target
Also remove the draggable item hover top button color change.

Test: Manual
Bug: 183193201
Change-Id: Id80622b8c0152180c47c0c9ebff8aa8bc2a5c2be
2021-03-22 13:20:48 +00:00
Yogisha Dixit
471922c5ac Do not allow widget to be resized beyond max size.
Test: manual
Bug: 179807199
Change-Id: I38e108a8db2c5f06c0922972efa334e3b2864046
2021-03-22 11:14:48 +00:00
Steven Ng
f3814eea2d Merge "A11y fix for all widgets tray (Part 2 / n)" into sc-dev 2021-03-22 10:22:54 +00:00
Hyunyoung Song
a22574aa66 Remove cursor when edit text no longer has focus
Bug: 180142918

Test: manual
Change-Id: I9a58ef605b145889e30cb42e99f0b98e16af1e46
Signed-off-by: Hyunyoung Song <hyunyoungs@google.com>
2021-03-21 15:59:34 -07:00
Samuel Fufa
7bcdaa13c7 Merge "[Search] Tie quick-launch and focus highlight" into sc-dev 2021-03-21 20:33:25 +00:00
Steven Ng
e85b5565c6 A11y fix for all widgets tray (Part 2 / n)
Fix the focus change when expanding / collapsing an app in
the all widgets tray by adding stable ids and disable item
animator.

Item animator is also disable even accessibility isn't enabled
because the default item animator also disrupts the header
padding. It also makes the expansion / collapsing of widgets table
very unpredicible.

Test: Navigate all widgets tray with talkback on.

Bug: 183120145
Change-Id: Ib1e2ea4d543757248e635a834204db688532cbfa
2021-03-19 23:58:19 +00:00
Steven Ng
682af23651 Merge "Renders widget recommendations" into sc-dev 2021-03-19 23:18:22 +00:00
Jon Miranda
116e94e0a7 Account for children margins when orienting popup container.
Instead of recalculating the orientation after adding margins,
we account for the margins in the initial calls to orientAboutObject.

This ensures consistent mIsAboveIcon throughout calls to show the popup.

- Also updates the smaller radius to match the middle items.

Bug: 175329686
Test: long press on item where height and height without margins would
      result in differing mIsAboveIcon values
      eg. the 3rd item in a folder in the top middle of 5x5 workspace

Change-Id: I6132b544a89c7948339d17f219ad75c797233f55
2021-03-19 18:30:03 -04:00
Tony Wickham
9053b90751 Fix spring loaded scale when taskbar is present
Test: scaled workspace doesn't overlap QSB during drag and drop
Bug: 171917176
Change-Id: I56c7ee834e2c3ee2c796e88e83f75dbd24d28bd5
2021-03-19 15:13:24 -07:00
Steven Ng
4235fc129c Renders widget recommendations
Update the tapl test logic to scroll a smaller distance to avoid the
search bar blocking the target touch area.

Test: Open full widgets sheet and observe the widget recommendations
      shown at the top.
      Run AddConfigWidgetTest

Bug: 179797520

Change-Id: I6d53bbb46e2cb928ed7d015aaac604be17d33178
2021-03-19 21:11:32 +00:00
Jonathan Miranda
83c4b1fd72 Merge "Folder updates." into sc-dev 2021-03-19 20:40:49 +00:00
Samuel Fufa
147527229b [Search] Tie quick-launch and focus highlight
Highlight and quick-launch item should be determined by Search service pipeline based on quick_launch flag on SearchTarget

Bug: 183083807
Bug: 183083682
Test: Manual
Change-Id: I0191474653deca7e1ecd01fa92c90efcdbb9a8dc
2021-03-19 15:38:38 -05:00
Jonathan Miranda
48a2f09349 Merge "Add separate background colors to each popup container child." into sc-dev 2021-03-19 20:34:10 +00:00
Tony Wickham
4076cae87f Merge "Use taskbarSize as bottom inset when taskbar is present." into sc-dev 2021-03-19 18:15:52 +00:00
Samuel Fufa
9751c532e4 Merge "Move SearchWidgetInfoContainer to NexusLauncher" into sc-dev 2021-03-19 18:07:39 +00:00
Jon Miranda
2a58d13b9b Add separate background colors to each popup container child.
- Colors interpolate between the primary and secondary popup colors
- Removed condensed height and icon scale

Bug: 175329686
Test: visual, manual checking apps with different shortcut options
Change-Id: I064c329dc8ad3ae6f408056c74372cca3ce20b68
2021-03-19 13:41:07 -04:00
Tony Wickham
ff78367361 Merge "Fix QSB and Hotseat positions when ENABLE_DEVICE_SEARCH is enabled" into sc-dev 2021-03-19 17:32:19 +00:00
Alina Zaidi
7358069a91 Merge "Fix bugs for Widgets picker Search UI." into sc-dev 2021-03-19 16:57:11 +00:00
Zak Cohen
02393204e6 Merge "Return empty, not null, a11y node in Workspace" into sc-dev 2021-03-19 16:56:02 +00:00
Jon Miranda
0369cd5470 Folder updates.
- 3 item folder preview has the first item on top of the other 2
- Skip first frame of the folder open animation as there is no
  visual change in that first frame.

Bug: 175329686
Test: visual
Change-Id: Ida9a55ee5093c49f230cdf22d7943b2a6a7ed42d
2021-03-19 12:07:19 -04:00
Alina Zaidi
c4f3f49805 Fix bugs for Widgets picker Search UI.
- On orientation change, clear search bar.
- Change text and search bar color to make similar to mocks/ all apps search bar.
- Fix search recycler view visual bugs.
- If back is pressed in search mode, exit search mode instead of exiting widget picker.

Test: Manually seen widget picker on phone.
Bug: 183103133
Bug: 183103936
Bug: 183115050
Bug: 157286785
Change-Id: I056f089eada84d00133038f4a3d7b18bc51be564
2021-03-19 14:42:47 +00:00
Jonathan Miranda
b0cb399d21 Merge "Update deep shortcut to new ui." into sc-dev 2021-03-19 13:31:08 +00:00
Steven Ng
be73868634 Merge "Notify WidgetHostView drag content change only at onDraw" into sc-dev 2021-03-19 12:38:32 +00:00
TreeHugger Robot
fd0a75e1fb Merge "Don't store Launcher as a class variable in CellLayout" into sc-dev 2021-03-19 12:28:46 +00:00
Zak Cohen
f19300e479 Return empty, not null, a11y node in Workspace
It's not valid to return a null accessbilitynode.

Test: local
Bug: 182529089

Change-Id: I94245fb33128c68e33ce388284f64e5ac3bb23dc
2021-03-18 20:48:45 -07:00
Tony Wickham
72c15ef913 Fix QSB and Hotseat positions when ENABLE_DEVICE_SEARCH is enabled
Test: visual
Change-Id: I755de7552e2bb3f927f6be59c07f910ddfbc4650
2021-03-18 18:06:47 -07:00
Evan Rosky
16a713c450 Merge "Add rotation support to launch animations" into sc-dev 2021-03-18 23:24:50 +00:00