Commit Graph

5326 Commits

Author SHA1 Message Date
TreeHugger Robot
bbfef42e48 Merge "Prevent setting task thumbnail during swipe to overview" into sc-dev 2021-03-24 01:46:34 +00:00
TreeHugger Robot
b9d201a5d6 Merge "Remove some unused hotseat/qsb scaling code" into sc-dev 2021-03-24 00:16:01 +00:00
Vinit Nayak
706ff85fe5 Prevent setting task thumbnail during swipe to overview
Previously we were setting the incorrect thumbnail when
swiping to overview, then taking a task screenshot right
when the animation ends and replacing the first thumbnail.
This sometimes caused a flicker of the old thumbnail, now
we avoid setting the thumbnail at all for the taskview that
is being swiped up.

Another edge case handled here is when switching nav modes
and then immediately entering overview, Recents receives an
onConfigChange for changing task icon size. That would cause
all taskviews to null out both their existing icon and
thumbnail, now only the icon gets nulled out.
Existing issue where switching to 3 button nav and then
entering overview shows blank icon, doesn't register for
receiving the updated task snapshot fast enough.

Fixes: 179307265
Test: Ask assistant for weather, swipe to overview
Ask assistant for time, swipe to overview, no flicker

Switch nav modes to gesture, swipe to overview.
There's a flicker for config change, but thumbnail is correct

Change-Id: I300b29f999f6d6876f82bc0189b44f4c10ae33fe
2021-03-23 12:00:06 -07:00
Tony Wickham
3629b93546 Merge "Add TaskbarView as a child of Hotseat" into sc-dev 2021-03-23 18:36:53 +00:00
Tony Wickham
d0b6bfaa69 Remove some unused hotseat/qsb scaling code
Now that QSB is always part of Hotseat, we don't need
getQsbScaleAndTranslation(), and now that HOTSEAT_ICONS are never in
Overview, we can remove the getHotseatScaleAndTranslation() override

Test: Everything works as before
Bug: 175137718
Change-Id: I902815d8e270269c1a2a9af54fa8480e5aef929d
2021-03-23 10:33:44 -07:00
Steven Ng
dd1026b0c0 Merge "Increase the number of prediction for widgets model" into sc-dev 2021-03-23 10:12:14 +00:00
TreeHugger Robot
516dfc6ace Merge "Fix extra haptic on swipe up" into sc-dev 2021-03-23 03:06:48 +00:00
Sreyas
59b5e241e2 Hide chips if loaded in select mode.
Bug: 182375263
Test: Manual

Change-Id: Id9709a2033b303c09d9ca26d2e05af6af45df564
2021-03-22 15:59:54 -07:00
Tony Wickham
9ce3b25ef6 Add TaskbarView as a child of Hotseat
Instead of keeping the Taskbar window showing above the home screen,
we now integrate a copy of TaskbarView directly into Launcher's view
hierarchy. Most TaskbarController calls apply to both TaskbarViews
(mTaskbarViewInApp and mTaskbarViewOnHome), except for calls related
to Hotseat, which only apply to mTasbkarViewInApp given the real
Hotseat will be showing with mTaskbarViewOnHome.

More cleanup will follow this change.

Test: All taskbar interactions (e.g. drag and drop) continue to work
Bug: 182512211
Bug: 171917176
Change-Id: I0f0b124f652daa85f866e1df8f9e2981540331a0
2021-03-22 15:26:01 -07:00
Tony Wickham
62e08797f3 Fix extra haptic on swipe up
Test: swipe up in 0 button mode, no haptic until pause detected

Bug: 181165935
Change-Id: I69b598cf8e1ac1038d5cfad0f43468a8d7d23e4a
2021-03-22 15:13:21 -07:00
Tracy Zhou
5ac61e1a2e Merge "Support live tile with OVERVIEW_GRID" into sc-dev 2021-03-22 21:20:22 +00:00
Steven Ng
05df2843ee Increase the number of prediction for widgets model
Test: launch all widgets tray and observes widgets predicted.

Bug: 179797520
Change-Id: Id231cde5015a2a79b7532a39343b3340c27e09c9
2021-03-22 20:22:42 +00:00
TreeHugger Robot
6db6c9fe7d Merge "Don't go to NORMAL after task launches if animation in progress" into sc-dev 2021-03-22 19:42:35 +00:00
Tony Wickham
089ad5faab Merge "Dump input monitor and input event receiver to bug reports" into sc-dev 2021-03-22 19:04:14 +00:00
Tracy Zhou
ef45cc95b5 Support live tile with OVERVIEW_GRID
Test: turn on both ENABLE_QUICKSTEP_LIVE_TILE and OVERVIEW_GRID. Swipe up from app to overview
Fixes: 183231362
Change-Id: Ic918e1fad423295d532cefce13c85e622ff8116c
2021-03-22 10:30:22 -07:00
Tony Wickham
85a8da0290 Dump input monitor and input event receiver to bug reports
Test: adb shell dumpsys activity service TouchInteractionService
Bug: 180915942
Change-Id: Ic1155b323cd3f9cef164ce4d663cadc4b29a0893
2021-03-22 09:30:18 -07:00
Bob Badour
41b58c6ec7 Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/apps/Launcher3" into sc-dev 2021-03-19 23:55:24 +00:00
Tracy Zhou
f209a77a96 Merge "Continue receiving key events from input consumer after settling into Overview" into sc-dev 2021-03-19 20:18:41 +00:00
Tony Wickham
4076cae87f Merge "Use taskbarSize as bottom inset when taskbar is present." into sc-dev 2021-03-19 18:15:52 +00:00
Tony Wickham
e31af6264d Don't go to NORMAL after task launches if animation in progress
Test: Swipe down on a task, swipe up immediately as it launches;
state stays as BACKGROUND_APP instead of NORMAL
Fixes: 171757635

Change-Id: Ia38774c01190bd184e229ff532ea9df2a75abcb4
2021-03-19 11:07:39 -07:00
Sreyas Rangaraju
a2c2d861ba Merge "Fixes OverviewActionsView height sizing." into sc-dev 2021-03-19 17:06:21 +00:00
Tracy Zhou
b0b2a9acd0 Continue receiving key events from input consumer after settling into Overview
This builds on ag/13732971. In live tile mode after settling into overview, recents_animation_input_consumer should have the focus, and thus we will need to extend the lifecycle of input consumers so that key events can be routed to launcher

Overall, since live tile extends the lifecycle of certain private variables of AbsSwipeHandler, I am thinking of doing a refactor by putting those things into a separate class, but it might be too big for this change.

TODO: I've verified that this change works while if we don't process motion events, it would cause b/182932863. Will investigate on that.

Fixes: 181404912
Test: Cherry pick ag/13732971; Go to overview; Swipe back; Observe the animation to go back to app
Change-Id: I5afd397be387b75f373442781dd1d00560dca99e
2021-03-19 10:00:54 -07:00
Sunny Goyal
ddbc7bf03d Merge "Fixing ActivityInit getting called before the full launcher components are initialized" into sc-dev 2021-03-19 16:41:34 +00:00
Pat Manning
b2cfab5321 Merge "Respect clip hint when aligning cropped thumbnails." into sc-dev 2021-03-19 15:26:18 +00:00
Bob Badour
390b27e46c [LSC] Add LOCAL_LICENSE_KINDS to packages/apps/Launcher3
Added SPDX-license-identifier-Apache-2.0 to:
  quickstep/Android.bp
  robolectric_tests/Android.bp
  tests/Android.bp

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all

Exempt-From-Owner-Approval: janitorial work
Change-Id: I699e0796410f691ae7cf4802c41987d79e4e486d
2021-03-19 04:22:23 -07:00
Winson Chung
6ffdceadfe Merge "Update calls to go through the feature interface instead of sysui proxy" into sc-dev 2021-03-19 06:55:32 +00:00
Tracy Zhou
e3ae7e3afa Merge "Revert "[Live tile] Finish recents animation when the phone goes to sleep in live tile mode"" into sc-dev 2021-03-19 04:28:13 +00:00
Sreyas
8dbf38e30f Fixes OverviewActionsView height sizing.
By fixing the action buttons container height and allowing wrap content on overviewActionsView all views have enough room to be displayed and actions button container height can be calculated.
Bug: 182854439
Test: Manual

Change-Id: I34516ba42430d8fe6774e10215dd8ac1127920c8
2021-03-18 20:18:36 -07:00
Evan Rosky
16a713c450 Merge "Add rotation support to launch animations" into sc-dev 2021-03-18 23:24:50 +00:00
Sunny Goyal
a8bbcb9c04 Fixing ActivityInit getting called before the full launcher components are initialized
Bug: 182575999
Test: Presubmit
Change-Id: Iea6986624b70caf2d502c1b21318b57a8b2fde03
2021-03-18 15:49:00 -07:00
Tony Wickham
b31d8fc379 Use taskbarSize as bottom inset when taskbar is present.
This was done in ag/13841736 but not included in ag/13821586

Test: QSB in correct position when taskbar present and not present
Bug: 171917176
Change-Id: I6aa220559afebe8710b5f01cdec9c2baa9f4c926
2021-03-18 13:57:20 -07:00
Tracy Zhou
e6354c1ab2 Revert "[Live tile] Finish recents animation when the phone goes to sleep in live tile mode"
This reverts commit d028937e74.

Reason for revert: Caused a few bugs

Change-Id: I1a3f4aa90679dec18ed27d2a5a5f0446c6d52594
Fixes: 174866547
Fixes: 181937887
Fixes: 183124957
2021-03-18 19:23:44 +00:00
Mariia Sandrikova
f7864feded Merge "Revert "Enable Live Tile"" into sc-dev 2021-03-18 19:18:34 +00:00
Vadim Tryshev
93f2b75223 Merge "Fixing testOverview test" into sc-dev 2021-03-18 18:07:32 +00:00
Winson Chung
19946daf22 Update calls to go through the feature interface instead of sysui proxy
Bug: 180074017
Test: atest PinnedStackTests
Test: Verify Pip works w/ launcher (shelf offsets, autoenter, etc)
Change-Id: I7de733f7267123218f6550963e44f6a893ad99b2
2021-03-18 10:25:39 -07:00
Pat Manning
7c67fafe4d Respect clip hint when aligning cropped thumbnails.
With clipping off, alignment will show letterbox borders. With clipping
we will respect the clip hints.

Test: manual
Bug: 177402412
Change-Id: Ie9d2c95636f23c4f64635ac6d55eb59306c30223
2021-03-18 17:24:25 +00:00
Mariia Sandrikova
ea0d30de68 Revert "Enable Live Tile"
This reverts commit 56c0931e99.

Reason for revert: DroidMonitor: Potential culprit for Bug 183078688 - verifying through Forrest before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Fix: 183078688
Fix: 183091281
Change-Id: I050b3e26d35a7a1b60b5ccc58d371a7ab8efb0dc
2021-03-18 16:44:50 +00:00
Sunny Goyal
b8cffbfcb4 Merge "Using recents animation and swipe handler for 3-button mode" into sc-dev 2021-03-18 16:08:05 +00:00
Sunny Goyal
fa699566f5 Merge "Adding an optional QSB in hotseat" into sc-dev 2021-03-18 16:07:45 +00:00
Sunny Goyal
f0ae3631ca Merge "Adding some build rules in Launcher3" into sc-dev 2021-03-18 06:26:06 +00:00
Tracy Zhou
7e7bab4cb6 Merge "Enable Live Tile" into sc-dev 2021-03-18 05:24:48 +00:00
Tracy Zhou
56c0931e99 Enable Live Tile
Fixes: 169694902
Fixes: 174866547
Fixes: 181937887
Test: manual
Change-Id: I5f2f304d4003e72ed2fb4ea0b0c74f06d2adfe4b
2021-03-17 18:34:52 -07:00
Sunny Goyal
f5c42ea6aa Adding some build rules in Launcher3
Bug: 182502086
Test: Presubmit
Change-Id: Ib2c18f1e252b3382030293fd3b873e840320301a
Merged-In: Ib2c18f1e252b3382030293fd3b873e840320301a
2021-03-18 01:26:36 +00:00
[1;3C
a608d81359 Add rotation support to launch animations
This only adds support for launch animations. Recents
requires some auxiliar work.

Adds a rotation parameter to the animation targets that
only gets used by shell transitions. If this is non-zero,
launcher will transform it's coordinates relative to that
provide rotation.

Bug: 179308296
Test: Launch and exit apps with different orientation from
      default (portrait).
Change-Id: I7b52cbd37432bcd43e7155bcb07b30cc65c43186
2021-03-17 15:30:47 -07:00
vadimt
17ba630cd9 Fixing testOverview test
Apparently, we can't generally expect that flinging to and
fro will return Overview to the original task, especially
if the device performance is low.

Now starting the expected task explicitly.

Test: presubmit
Bug: 182794819
Change-Id: Ia2931f4f3005c46dd72990c247a90f9010b9b8d5
2021-03-17 14:41:04 -07:00
Sunny Goyal
c373e1c642 Adding an optional QSB in hotseat
Removing sections in all-apps during transition and treating
it as a single unit

Bug: 175137718
Test: Manual
Change-Id: I55a501d80b5903f1a9d92a26b3784784fd9e50fd
2021-03-17 12:21:44 -07:00
Sunny Goyal
d5347045d0 Using recents animation and swipe handler for 3-button mode
Bug: 181165935
Test: Manual

Change-Id: I7fe586319e4dde1a1b398a0c75896c4dfdb75862
2021-03-17 09:26:51 -07:00
Samuel Fufa
7165a1d6de Merge "[Hotseat] Fix badging for shortcut predictions in hotseat" into sc-dev 2021-03-17 13:15:47 +00:00
Alex Chau
b4254cd504 Merge "Align task thumbnails to edge when cropped." into sc-dev 2021-03-17 11:09:04 +00:00
Pat Manning
0fe7326cf0 Align task thumbnails to edge when cropped.
Align to left edge unless RTL enabled. Do not rotate thumbnails if they
would not fit nicely once rotated.

Test: manual - Ensure task thumbnails align with left edge if cropped.
Bug: 177402412
Change-Id: I6e03715061120deb5a8fde005d676170eed0f819
2021-03-17 01:30:07 +00:00