Commit Graph

20933 Commits

Author SHA1 Message Date
Treehugger Robot
bd203f948d Merge "Fix icon flicker from home-> overview when 3 button navigation is enabled in 3P launcher." into main 2024-12-06 19:52:26 +00:00
Treehugger Robot
07bf3c3085 Merge "Restore fallback Overview state when restarted by theme changes" into main 2024-12-06 19:35:07 +00:00
Alex Chau
c76d4a8971 Restore fallback Overview state when restarted by theme changes
- Moved RUNTIME_STATE_RECREATE_TO_UPDATE_THEME to StatefulActivity
- Handle uiMode in RecentsActivity
- When RecentsActivity is recreated due to theme changes, restore previous state

Fix: 382072029
Test: Manual: Change light/dark them from QuickSettings while in fallback Overview, Overview stay open
Flag: EXEMPT bugfix
Change-Id: Ia596150afa1436c4a25e94fd2b6930a8ded0b0d4
2024-12-06 17:10:03 +00:00
Winson Chung
3660fe4505 Merge "Add some debug names to various remote transitions" into main 2024-12-06 17:00:32 +00:00
Treehugger Robot
2173882ec6 Merge "Revert "Recycle tasks that are split when split select anim complete for reuse"" into main 2024-12-06 14:37:28 +00:00
vinayjoglekar
88420d8636 Fix icon flicker from home-> overview when 3 button navigation is enabled in 3P launcher.
Flicker occurs due to calling fade for 0 to 1 twice which needed to be corrected.

Also renamed confusing terms for updating alpha of app icons.

Test: Manual. Install 3P launcher, 3 button navigation enabled, go to Overview.
Fix: 378419654
Flag: EXEMPT bug fix.
Change-Id: I46ff564712f5fd217c5992042ee441242159fe99
2024-12-06 14:25:34 +00:00
Uwais Ashraf
2a1946ee65 Revert "Recycle tasks that are split when split select anim complete for reuse"
This reverts commit ca39594be9.

Reason for revert: Potential fix for b/378007383

Bug: 376428479
Change-Id: Id38db589e9e11220237314a0f1c63178899714de
2024-12-06 12:19:48 +00:00
Treehugger Robot
40f9eb0567 Merge "Dismiss recents when device goes to sleep" into main 2024-12-06 11:29:56 +00:00
Treehugger Robot
4ab6f0451c Merge "[CD Taskbar] Refactor TaskbarManager to create object creation methods" into main 2024-12-06 09:02:06 +00:00
Winson Chung
b26430a9e4 Add some debug names to various remote transitions
- This helps with debugging and shell dumps

Bug: 378565144
Flag: EXEMPT adding debug strings
Test: dumpsys activity service SystemUIService WMShell
Change-Id: I57ea1c359667b4e7f7ac1e261cc6fba6ad30c6e7
2024-12-06 06:07:29 +00:00
Liran Binyamin
f8b5dec6dc Merge "Fix cropped bubble flyout when animating in app" into main 2024-12-06 01:19:15 +00:00
Sukesh Ram
23470e8832 [CD Taskbar] Refactor TaskbarManager to create object creation methods
Every object that needs its own instance for an instance of a new display-specific taskbar needs its own creation method.

Flag: EXEMPT not adding new behavior
Bug: 381105283
Test: Manual
Change-Id: I24794fefbf2a64f38795eca970cf30eb63c51e66
2024-12-05 15:39:10 -08:00
Liran Binyamin
bd19a3b2c2 Merge "Set the bubble bar background scale for initial animation" into main 2024-12-05 22:23:12 +00:00
Liran Binyamin
789a8c7f43 Merge "Don't crop bubble flyout in overview" into main 2024-12-05 22:22:36 +00:00
Liran Binyamin
0e14bb8ef9 Merge "Fix bubble bar flicker in initial animation" into main 2024-12-05 22:22:07 +00:00
Uwais Ashraf
4b05341d6e Merge "Use custom background dispatcher to stop excess thread creation." into main 2024-12-05 21:37:38 +00:00
Jon Miranda
433c9ef018 Merge "Keep transient taskbar open while overflow is open." into main 2024-12-05 21:09:13 +00:00
Ikram Gabiyev
b95b0eec92 Merge "Do not send setFinishTaskTransaction if not swipe" into main 2024-12-05 20:38:14 +00:00
Treehugger Robot
e457cb7a78 Merge "Revert^2 "Check if all apps are translucent when finishing recents animation."" into main 2024-12-05 20:29:00 +00:00
Saumya Prakash
cfe6de65b4 Merge "Prevent Taskbar all apps from showing multi instance options" into main 2024-12-05 20:14:55 +00:00
Liran Binyamin
f2161dd8c3 Fix cropped bubble flyout when animating in app
When animating the bubble bar in an app with a stashed handle,
the flyout might not be displayed entirely.

Fix the calculation of the amount of space needed to fully display
the bubble bar and flyout views.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 382513856
Test: manual
       - remove all bubbles
       - launch app
       - send a bubble with a 2-line message
       - observe flyout is fully visible
Change-Id: I7953cb7f619f2c00b04bb4cb08c57a8195ff79fe
2024-12-05 14:35:09 -05:00
Jagrut Desai
dbfd95e6de Merge "Open Task into Desktop Mode when Taksbar is in DesktopMode" into main 2024-12-05 19:32:26 +00:00
Jagrut Desai
463c3b06b9 Merge "Don't recreate taskbar in Overview" into main 2024-12-05 19:32:07 +00:00
Liran Binyamin
f0e5a19658 Set the bubble bar background scale for initial animation
When turning off DND all the previous bubbles get reposted and
the bubble bar background scale is set for stashed state incorrectly.

This change sets the background scale correctly.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 377597242
Test: manual
       - send some bubbles in the bubble bar
       - go to settings -> do not disturb -> turn on
       - observe bubbles are hidden
       - turn do not disturb off
       - observe bubbles animate in correctly
Change-Id: I50c07248fb95cf3ae92c86090838c40901918220
2024-12-05 14:24:32 -05:00
Tracy Zhou
d2b90982eb Merge "Restore barMode and wallpaperVisible to Taskbar NavbarButtonsViewController state" into main 2024-12-05 19:08:24 +00:00
Uwais Ashraf
1348514466 Use custom background dispatcher to stop excess thread creation.
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Performance tests
Change-Id: I0e205cf7f55c90375a5a1e95fbd0f1adf0fc6658
2024-12-05 11:05:27 +00:00
Luca Zuccarini
7be62fbe00 Merge "Revert "Revert "Use the Coreographer's frame time for a more rel..."" into main 2024-12-05 10:23:36 +00:00
Matt Sziklay
f47c28ef95 Merge "Implement cancel transition on tapping floating view." into main 2024-12-05 03:16:51 +00:00
Saumya Prakash
ddd667ac9a Prevent Taskbar all apps from showing multi instance options
This change makes it so that we don't show any multi instance options in
Taskbar all apps. This matches the behavior from regular All apps.

Fix: 382342931
Test: Long press an app icon in Taskbar all apps and ensure multi
instance options don't show up.
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar

Change-Id: I5322df328ee5484168b96831f32c2023521704e6
2024-12-05 01:04:54 +00:00
Treehugger Robot
db013a8e75 Merge "TaskViews indices inside RecentsView continue [2/n]" into main 2024-12-05 00:35:26 +00:00
Ikram Gabiyev
ee4d9ed3ad Do not send setFinishTaskTransaction if not swipe
In PiP2, there is no need to send setFinishTaskTransaction()
unless we are swiping PiP to home.

This is because either ATMS#enterPictureInPictureMode() is supposed
to request a TRANSIT_PIP as the activity goes to pause.

Bug: 380515865
Flag: com.android.wm.shell.enable_pip2
Test: repro the steps in the bug
Change-Id: Ic24c0c0f471179198a5fe3221971cf5b6d634797
2024-12-04 15:36:26 -08:00
Jon Miranda
591c44a63b Keep transient taskbar open while overflow is open.
Fixes: 380375446
Test: open taskbar overflow, interact with overflow, taskbar stays open
Flag: com.android.launcher3.taskbar_overflow
Change-Id: Iec95e40336debd6cc2a8f9a79fce2093b6d10e6c
2024-12-04 22:57:34 +00:00
minch
1bf7678154 TaskViews indices inside RecentsView continue [2/n]
In applyLoadPlan
- Refactored newFocusedTaskView to be based on first non-Desktop TaskView
- Set newFocusedTaskView to null when enableGridOnlyOverview() is on
- Updated target page calcuation to be based on the following priority: running task, focused task, first non-desktop task, last desktop task

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure targetPage in applyLoadPlan is correct in the following scenarios:
1. Only have desktop task
2. Desktop task and a few full screen tasks
3. Swipe up from desktop, 1st fullscreen task, and 2nd fullscreen task
4. Repeat with enableGridOnlyOverview() on, which does not have focused task

Change-Id: Iea519ad4a37c15f76557487078ac4dcf4d53480c
2024-12-04 22:21:20 +00:00
Jon Miranda
73797f8188 Revert^2 "Check if all apps are translucent when finishing recents animation."
This reverts commit 4fd400994a.

Reason for revert: Found the cause of the regression and fixed it
The regression was caused when adding a new method params to an
overloaded method, and then passing in the wrong parameter.

Bug: 379602904 
Bug: 354627538 
Change-Id: I54bc40042e08ae2da1808427b16e3587b6da789c
2024-12-04 21:57:04 +00:00
Liran Binyamin
77827d3167 Fix bubble bar flicker in initial animation
When the first bubble animates in we make the bubble bar visible
before translating it below the screen to prepare for the spring
animation. This change defers updating the visibility letting the
animator notify when it's safe to update visibility.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 382296842
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - dismiss bubble bar
       - send new bubble
       - observe bubble bar does not flicker
Change-Id: Ib611771dd9f315ab57ef00f8f6cb982b8b88ea73
2024-12-04 15:05:22 -05:00
Jordan Silva
aed3b14abc Dismiss recents when device goes to sleep
Dismiss recents automatically after lock and unlock the device, otherwise recents screen becomes non-responsive for 3P Launchers.

Bug: 319365581
Change-Id: I6571f25cf311ca586f6d9c9e1228f1addcbed1f1
Flag: EXEMPT bugfix.
Test: FallbackRecentsTest
2024-12-04 18:37:47 +00:00
Liran Binyamin
0de5987efb Don't crop bubble flyout in overview
When switching to overview we set the taskbar window size as part
of the taskbar animation. If a bubble is animating the window size
becomes too small and the bubble flyout gets cropped. This change
avoids updating the window size in the middle of a bubble animation.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 377809168
Test: manual
       - create a bubble and wait for the flyout to show
       - switch to overview
       - observe the flyout is not cropped
Change-Id: Ic0a3f2c0fc534162ae5583e744a7bc400c3d921b
2024-12-04 12:36:56 -05:00
Treehugger Robot
9fdf9efdd2 Merge "multiple-desktops: Add new desktop button xml file" into main 2024-12-04 14:02:41 +00:00
Alex Chau
ba8b4d7851 Merge "Reland "Handle uiMode changes in QuickstepLauncher"" into main 2024-12-04 10:45:02 +00:00
minch
7fbc82cab1 multiple-desktops: Add new desktop button xml file
- Add the skeleton xml file for the new desktop button
- Add the icon for this button as well
- Create the kotlin file for this button

Flag: EXEMPT as added files haven't connected with the production logic
Fix: 379941322
Test: None
Change-Id: I5c7ea2c061f0f9539483221f40c892626103d11e
2024-12-04 10:26:42 +00:00
Tracy Zhou
3d31b97389 Restore barMode and wallpaperVisible to Taskbar NavbarButtonsViewController state
Fixes: 379816005
Test: manual
Flag: EXEMPT bugfix
Change-Id: I2a181c498cb674f077d1b0accfe85b62880a1cfc
2024-12-03 17:16:09 -08:00
Tony Wickham
ab8fa5e67e Merge "Factor in userId for updateHotseatItemsFromRunningTasks" into main 2024-12-04 00:31:48 +00:00
Tony Wickham
db64e1b3d1 Factor in userId for updateHotseatItemsFromRunningTasks
Test: onRecentTasksChanged_inDesktopMode_sameHotseatPackage_differentUser_isInShownTasks
Test: Pin personal Chrome, open work Chrome in desktop mode; ensure a
new work icon is created in the running apps section
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 376818660

Change-Id: Ie5cf3ab8e839456e6bd774de8a4398835e790019
2024-12-04 00:31:36 +00:00
Saumya Prakash
1fa9b25b73 Merge "Ensure Desktop Tasks show up in Taskbar multi instance menu" into main 2024-12-03 21:14:32 +00:00
Alex Chau
007abe80e4 Reland "Handle uiMode changes in QuickstepLauncher"
- Added uiMode in handled configChanges for QuickstepLauncher, NexusLauncherActivity
- RecentsActivity will be handled separately in b/382072029
- This avoids Launcher from being recreated when swithching from an app in driving mode (e.g. Maps), which causes massive jank
- Launcher layout is unaffected when driving mode changes, so a recreation is unnecessary
- When Light/dark mode changes, BaseActivity.updateTheme will still causes activity to be recreated. Launcher will mark a boolean in saved staete so next recreate will restore previous state even if state has FLAG_DISABLE_RESTORE (e.g. Overview), similar to the existing check that force restore when UI_MODE changes

Relanded changes: /q/submissionid:27627108-b/339747262

Fix: 339747262
Test: Swtich from driving mode app to another or home in 1p and 3p laucnher
Test: Switch light/dark mode and Launcher is updated correctly and stay in previous state
Flag: EXEMPT bugfix
Change-Id: I5a62b1bcd19eed9d232f30db94aa0e032f4541bd
2024-12-03 18:20:56 +00:00
Schneider Victor-tulias
bbefa5daf7 Merge "Use the RecentsWindowTracker in FallbackRecentsTest rather than RecentsActivity's ActivityTracker when flag is enabled" into main 2024-12-03 16:06:40 +00:00
Treehugger Robot
1c9b6dd4f3 Merge "[Launcher Memory Leak] Fix leak of AbsSwipeUpHandler via Launcher#mOnDeferredActivityLaunchCallback" into main 2024-12-03 03:56:03 +00:00
Saumya Prakash
a32f7f3f4a Ensure Desktop Tasks show up in Taskbar multi instance menu
This change adds in desktop tasks to show up in the Manage Windows
Taskbar menu. Previously these were getting filtered out.

Fix: 380167542
Bug: 315989246
Test: Launch multiple tasks in desktop mode and see that they show up in
the multi instance viewer from the Taskbar menu
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar

Change-Id: Ia07b3ad68f43c0f121b0608c5341d50970c8af4c
2024-12-02 23:44:59 +00:00
Tony Wickham
7614088dc5 Merge "Fix Taskbar 3 Button y position on launcher home pause/resume" into main 2024-12-02 23:33:57 +00:00
Wen-chien Wang
ef427290c9 Merge "Register back action to close the KQS view" into main 2024-12-02 22:04:11 +00:00