Commit Graph

6592 Commits

Author SHA1 Message Date
Android Build Prod User
b862d2c30f Merge "Add Split button in OverviewActions" into sc-v2-dev 2021-08-26 20:21:08 +00:00
Tony Wickham
8b07b8f6d0 Merge "Hide taskbar icons when recents button is disabled" into sc-v2-dev 2021-08-26 20:10:39 +00:00
Vinit Nayak
6174106f68 Add Split button in OverviewActions
Shows up only for large screen devices, not phones.
Tested for NexusLauncher, general 3P launcher support
needed for staged split (TODO b/195607777)

Bug: 195423591
Change-Id: I4d455769b17637174b590c640516b9fbb6352c3d
2021-08-26 11:49:38 -07:00
Tony Wickham
ee3814de1a Merge "Fix taskbar folder leave-behind not being drawn" into sc-v2-dev 2021-08-26 17:39:07 +00:00
Tony Wickham
3feebeb196 Fix taskbar folder leave-behind not being drawn
I guess FrameLayout has willNotDraw=true by default, so we need to set it to false in order to get onDraw().

Test: open a folder on taskbar
Bug: 197866264
Change-Id: Ia521bc3da28527b9c3f1fa7bcdaf5d9ffb7feccf
2021-08-26 17:38:53 +00:00
Tony Wickham
bc30e25cec Hide taskbar icons when recents button is disabled
The idea is that both taskbar icons and recents navigate you to new apps, which we'd want to disable in similar contexts. Hence reusing FLAG_DISABLE_RECENTS.

Test: locally set FLAG_DISABLE_RECENTS=true, ensure taskbar icons don't show up (both in 3 button mode and gesture nav)
Bug: 193183428
Bug: 194990283
Change-Id: I9537f57dc25663151b1414c5260dadb58506fdb0
2021-08-26 10:18:04 -07:00
Alex Chau
da7fe8ced1 Merge "More more logging for for Nexus home activity appearing after to-home gesture in L3" into sc-v2-dev 2021-08-26 10:57:52 +00:00
Vinit Nayak
759e15fe45 Merge "Null out RemoteTargetHandles as soon as finishing recents is requested" into sc-v2-dev 2021-08-26 05:54:46 +00:00
vadimt
1a79f87004 More more logging for for Nexus home activity appearing after to-home gesture in L3
Bug: 192018189
Test: presubmit
Change-Id: Id99dbf9469c61f81643e5182d17012b508cfce1e
2021-08-25 20:12:56 -07:00
Vinit Nayak
f1aa726e9f Merge "Fix public variables to not have 'm' prefix" into sc-v2-dev 2021-08-26 00:07:45 +00:00
Android Build Prod User
14a7d63c23 Merge changes I54e39cc5,Iec62abae into sc-v2-dev
* changes:
  Set thumbnails for GroupedTaskView based on split layout bounds
  Implement swipe gesture for staged split in landscape
2021-08-25 20:30:43 +00:00
Android Build Prod User
9b2ec7d2d2 Merge "Revert^2 "Enable input window rotation flag"" into sc-v2-dev 2021-08-25 20:11:15 +00:00
Vinit Nayak
aa11976cc5 Fix public variables to not have 'm' prefix
Bug: 181704764
Change-Id: I89e43ce6cc74119514c8124e7cc61b11dc475f58
2021-08-25 11:59:43 -07:00
Vinit Nayak
c35507dc29 Set thumbnails for GroupedTaskView based on split layout bounds
Bug: 181704764
Test: Go to stage split in landscape w/
home rotation on/off, swipe up.
Thumbnails aren't perfectly overlaid, polish needed

Change-Id: I54e39cc5a18f527e80a664d60aca72dfd706ebdc
2021-08-25 11:59:00 -07:00
Lucas Dupin
45f09dc38a Merge "Synchronize surface transaction" into sc-v2-dev 2021-08-25 00:34:31 +00:00
Vinit Nayak
8b78c138d4 Implement swipe gesture for staged split in landscape
* Maintain task split percentages when swiping up.
* Split percentages not maintained in GroupedTaskView, however.
That is a TODO.

Bug: 181704764, 181705607
Test: Swiped up in landscape with home rotation on/off.
Portrait still works.

Change-Id: Iec62abae34f6ccadf98e2afdc9409cf3160f8223
2021-08-24 17:32:47 -07:00
Android Build Prod User
02da47404c Merge "Moving OrientationTouchTransformerTest to instrumentation tests" into sc-v2-dev 2021-08-24 23:30:54 +00:00
Lucas Dupin
0c70dbdc5e Synchronize surface transaction
Until now the SurfaceControl transaction was being applied
asynchronously, which could lead to it being executed out of sync with
launcher drawing.
This became an issue at higher refresh rates, where frames are produced
at a much faster pace.

In order to fix this issue, we can use BLAST transactions, which are
annotated with a frame number.

Test: record video, go through it manually
Fixes: 194320152
Change-Id: I1636a1ded4f9dd84c54ba12239e3549b92ed7567
2021-08-24 14:17:59 -07:00
Vinit Nayak
46e0999612 Merge "Rely on presense of divider target to determine split screen state" into sc-v2-dev 2021-08-24 21:17:07 +00:00
TreeHugger Robot
907c22ca14 Merge "Not checking for some anomalies when switching nav modes" into sc-v2-dev 2021-08-24 19:49:41 +00:00
Andy Wickham
7b65460e9a Merge "Adds additional pages to Taskbar Edu." into sc-v2-dev 2021-08-24 18:37:17 +00:00
Alex Chau
204e749f06 Merge "Revert "Migrating all model tests to Instrumentation tests"" into sc-v2-dev 2021-08-24 17:29:06 +00:00
Alex Chau
7a4a30d86d Revert "Migrating all model tests to Instrumentation tests"
This reverts commit 455ba62b5d.

Reason for revert: Breaks tests on all targets

Bug: 196825541
Bug: 197570389
Change-Id: Ida6792a09c54dee46105b6b914a0dd1545bdf48d
2021-08-24 17:27:52 +00:00
vadimt
51ae38304b Not checking for some anomalies when switching nav modes
Test: presubmit
Bug: 196820244
Change-Id: I3e9554d3deb453625cde5003ccf132f21253f58a
2021-08-24 17:23:12 +00:00
Alex Chau
96ffcbcd2d Avoid unnecessary onLayout if gesture is going to state without overview panel
Fixes: 186508379
Test: swipe up to carousel, then to home
Test: quick switch, immediately swipe up to overview, then to home
Change-Id: I0b28e163cbb289a636a89bc52c43a1977a59d86f
2021-08-24 12:43:56 +01:00
TreeHugger Robot
19a616f268 Merge "More logging for for Nexus home activity appearing after to-home gesture in L3" into sc-v2-dev 2021-08-24 09:04:12 +00:00
TreeHugger Robot
02fe560dc8 Merge "Revert "Move/Launch task on the TaskView's display."" into sc-v2-dev 2021-08-24 07:14:31 +00:00
Jerry Chang
6ca6de89c0 Revert "Move/Launch task on the TaskView's display."
This reverts commit 2cdc359b84.

Reason for revert: this brokes split screen and result to device reboot.
Bug: 197293995

Change-Id: I154287230fa3849cad1c0e337e3bf3fd826257a4
2021-08-24 04:54:49 +00:00
Andy Wickham
a0cc0903e8 Adds additional pages to Taskbar Edu.
Currently there are pages for the following:
 - Splitscreen
 - Customize (add apps/predicted apps)
 - Docking (long press to hide)

At the moment they all use the same placeholder
image from before.

Button states:
 Page 1: Close and Next
 Page 2: Back and Next
 Page 3: Back and Done

You can also swipe left and right between the pages.

Demo: https://drive.google.com/file/d/1_D3i-jZxCRRVHV92p6hG5cm3VGcJ_bhK/view?usp=sharing&resourcekey=0-KHLHTTx67JlmVv-UZoAUAw

Bug: 180605356
Test: Manual
Change-Id: Ibbb81610a611f6ca412e53ed90dc1c67764f417e
2021-08-23 15:12:39 -10:00
TreeHugger Robot
83e6d67e37 Merge "Draw rounded corners above the taskbar" into sc-v2-dev 2021-08-24 00:18:34 +00:00
Vinit Nayak
98314d0d4b Rely on presense of divider target to determine split screen state
* Don't rely on the number of leashes, since an app with
assistant invoked returns multiple remote app targets
even though the device isn't in split screen

Fixes: 197293347
Test: Repro steps in bug don't cause crash.
Less fatal bugs need to be addressed,
TODO(b/197568823)

Change-Id: I3432e3d8c54a433dd38d297db73ea3d46bad7ba9
2021-08-23 16:30:56 -07:00
Tony Wickham
dd7a418335 Draw rounded corners above the taskbar
- Increase height of taskbar window, but not contentInsets
- Draw the inverted corners as part of TaskbarDragLayer#dispatchDraw() (which handles the background already)

Test: visual

Bug: 196257194
Fixes: 197129604
Change-Id: I517949a4c2b97c92e3bb43408776db6deb1379b4
2021-08-23 15:33:43 -07:00
TreeHugger Robot
c817d2a633 Merge "Migrating all model tests to Instrumentation tests" into sc-v2-dev 2021-08-23 21:08:51 +00:00
vadimt
bea7e2ee6e More logging for for Nexus home activity appearing after to-home gesture in L3
Bug: 192018189
Test: presubmit
Change-Id: I92cfa9e40f71773e636c700ab7f84df1d9feac19
2021-08-23 13:57:51 -07:00
Vinit Nayak
e07bab8c7f Null out RemoteTargetHandles as soon as finishing recents is requested
* Instead of waiting for recents animation to be complete
before we stop manipulating remote leashes, stop it as soon
as RecentsView gets the request.

Bug: 197232424
Change-Id: I7f3cb6d2fc389d502e57054f60f28e7967212194
2021-08-23 13:56:30 -07:00
Schneider Victor-tulias
f4f6c0fd4f Merge changes I3e7d3c61,I1cba811c into sc-v2-dev
* changes:
  Convert gesture navigation feedback videos to animations with real callbacks.
  Convert gesture navigation tutorial still image vector drawables to layout files
2021-08-23 19:49:30 +00:00
Sunny Goyal
455ba62b5d Migrating all model tests to Instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: Iebd46eb41eb46c187d569197f4b97b4fddc0f6f7
2021-08-23 12:34:44 -07:00
Schneider Victor-tulias
69c4b54dce Convert gesture navigation feedback videos to animations with real callbacks.
Fixes: 192939067
Test: manual, started full tutorial, started home, back and overview individually, locked and unlocked phone mid-tutorial step.
Change-Id: I3e7d3c6153eeff6273e4b7ebc8cdb8328df7facc
2021-08-23 11:14:53 -07:00
Schneider Victor-tulias
ff322310a3 Convert gesture navigation tutorial still image vector drawables to layout files
Bug: 192939067
Test: manual, started full tutorial, started home, back and overview individually, locked and unlocked phone mid-tutorial step.
Change-Id: I1cba811c556139bc9ba52459f1b27f21eb156ac0
2021-08-23 11:14:04 -07:00
Alex Chau
c8295216d5 Merge "Fix animation problem when swipeing up app to screen edge and release" into sc-v2-dev 2021-08-23 11:18:49 +00:00
TreeHugger Robot
12bfd96432 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-08-22 17:45:42 +00:00
Bill Yi
cd493170fa Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ibfa4e4ffc8a72e59edbd24cd28473647b5b9bd89
2021-08-21 02:31:33 +00:00
TreeHugger Robot
47fde77687 Merge "Allow clipping individual direction of TaskView" into sc-v2-dev 2021-08-20 19:22:19 +00:00
TreeHugger Robot
35e09fe019 Merge "Snap to current page's relative position after dismissal." into sc-v2-dev 2021-08-20 12:54:10 +00:00
Alex Chau
8ebd11af14 Fix animation problem when swipeing up app to screen edge and release
- Consider scroll diff between currentPage and primary scroll when calculating adjacent page offset
- Removed setEnableFreeScroll call in onPrepareGestureAnimation that calls setCurrentPage and causes jumping

Fixes: 197012570
Fixes: 195740577
Test: Swipe up from app to end of screen, adjacent task should come from screen edge, and app should snap smoothly to position
Test: Swipe up from app, scroll immediately, free scroll should be enabled
Test: Swipe up immediately after quick switch, task thumbnails are loaded
Change-Id: Id88266634183dfcb18d5ba8a803883b7d6f50ab4
2021-08-20 12:07:08 +00:00
Pat Manning
0abfe4e7be Snap to current page's relative position after dismissal.
Test: manual
Fix: 196200215
Change-Id: Ic65313e2082ca2248e5860b77c438615c62b5581
2021-08-20 11:10:26 +00:00
Sunny Goyal
39aa2e0f1d Moving OrientationTouchTransformerTest to instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: Ifb0b00f789214a8dde246ab13703211d536364af
2021-08-19 12:03:26 -07:00
TreeHugger Robot
a35786c9c5 Merge "Null out reference to RemoteAnimationTargets when animation finishes" into sc-v2-dev 2021-08-19 17:39:17 +00:00
Prabir Pradhan
4fbd2f2252 Revert^2 "Enable input window rotation flag"
Reland the per-window-input-rotation flag. It was reverted because it
broke touch on foldables. The issue is now fix, so attempt to reland
this.

312a44adba

Bug: 179274888
Test: presubmit
Test: manual using foldable

Change-Id: Icb18baf81875e32535e277f9c4246be669013a03
2021-08-19 15:00:40 +00:00
Nick Chameyev
88cd9aaa6b Merge "Update unfold transition package name" into sc-v2-dev 2021-08-19 10:53:44 +00:00