Commit Graph

1371 Commits

Author SHA1 Message Date
Schneider Victor-Tulias
b8440b75ef Update AbstractLauncherUiTest to use recents window when possible
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Id3ddc11aa9163df3f2914edba66e1db36fdde63b
2025-04-29 14:13:26 -07:00
Min Chen
31f5e79ffd Merge "Fix integration tests with multi-desks on" into main 2025-04-28 16:44:30 -07:00
Pat Manning
9fd78aa76d Merge "Drag tasks from center when perfoming dismiss cancel for tests." into main 2025-04-28 04:08:39 -07:00
minch
4e3d48e998 Fix integration tests with multi-desks on
Bug: 362720309
Test: Presubmit
Flag: EXEMPT tests failure fix
Change-Id: I381b8751083a7fb235cf597fd35314ca6f2c0a9b
2025-04-26 15:59:18 +00:00
Pat Manning
8eeaa6009c Drag tasks from center when perfoming dismiss cancel for tests.
Follow up to Change-Id: I14f3012973ddee0d850db5de284a0efde6122d2c

Fix: 412766455
Test: TaplTestsQuickstep#dismissCancel
Flag: EXEMPT bugfix.
Change-Id: Idcf17fe810a935c325d043519d2b8d216b3f5c13
2025-04-25 16:12:32 +01:00
Treehugger Robot
4b74cfa36d Merge "Fix tapl tests with multi-desks on" into main 2025-04-24 15:15:16 -07:00
minch
94d8fc6206 Fix tapl tests with multi-desks on
Bug: 362720309
Test: TaplTestsKeyboardQuickSwitch, TaplTestsQuickstep.testOverview
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Ia670eb0f0ccf0ecbe08051f0fc1cd0a39b0089e2
2025-04-24 16:44:30 +00:00
Will Osborn
05e4134b73 Merge "Pass display id to startRecentsAnimation" into main 2025-04-23 02:23:40 -07:00
Will Osborn
50a1b9089c Pass display id to startRecentsAnimation
Test: local + unit
Bug: 392703464
Flag: com.android.launcher3.enable_overview_on_connected_displays
Change-Id: I7eb65a1d6b98703a19432b9fa24c3c4b262aa045
2025-04-22 17:46:01 +00:00
Treehugger Robot
8184e7116d Merge "Fix broken TaplStartLauncherViaGestureTests close activity flow" into main 2025-04-22 08:50:08 -07:00
Treehugger Robot
fede3aee46 Merge "Don't blur workspace targets when dragging out of All Apps." into main 2025-04-18 16:28:27 -07:00
mpodolian
04bd5b49ea Stash the taskbar on every bubble bar expansion
Added logic to enable BubbleBarView to  notify BubbleBarViewController
of expanded state change. Also updated all the test that uses
BubbleBarView to pass empty Controller.

Fixes: 411304392
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Go to any app. Swipe up to show the taskbar. Trigger any
bubble. Observe taskbar is stashed on bubble bar expanded.

Change-Id: I88ad167eb0ed444629716df3672bbb06ca8adcc4
2025-04-18 11:16:40 -07:00
Andy Wickham
c626620f74 Don't blur workspace targets when dragging out of All Apps.
Sorry for the whack-a-mole here. The intention is to only blur
going to All Apps or returning from All Apps to Normal. Added some
tests to help prevent regressions.

Test: DepthControllerTest#test_blurWorkspaceDepthTargets
Flag: com.android.launcher3.all_apps_blur
Bug: NA (noticed locally from a recent cl)
Change-Id: Ib0285dae42c41ba9eb2e747b272d40c228e0b035
2025-04-17 21:00:21 +00:00
Schneider Victor-Tulias
a6951ba731 Fix broken TaplStartLauncherViaGestureTests close activity flow
When trying to destroy the launcher activity in TaplStartLauncherViaGestureTests test cases, we weren't cleaning up the recents window properly. This was also causing following tests to fail since they didn't expect the recents window to already be open.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Ibf568fd1e9abf946c3d3be933b575aa4501828de
2025-04-17 15:42:59 -04:00
Sebastián Franco
95aa4a3267 Merge "Revert "No-op change, remove methods from BaseLauncherActivityTe..."" into main 2025-04-16 09:58:09 -07:00
Treehugger Robot
ef95172183 Merge "Fix broken -1 -> home transition with overview in window enabled" into main 2025-04-15 16:29:43 -07:00
Sebastián Franco
a746ec8aa4 Revert "No-op change, remove methods from BaseLauncherActivityTe..."
Revert submission 32999330-activity-test-refactor-1

Reason for revert: b/410713970

Reverted changes: /q/submissionid:32999330-activity-test-refactor-1

Change-Id: Id9dd4692bc5c500fd8831a2edad80a034c4fa405
2025-04-15 15:55:35 -07:00
Treehugger Robot
0aa937de1a Merge "Enforce a mutex in all remote tapl tests" into main 2025-04-15 14:52:13 -07:00
Schneider Victor-Tulias
d079748134 Enforce a mutex in all remote tapl tests
Flag: EXEMPT test fix
Fixes: 405849365
Test: TAPL tests; pre/postsubmit
Change-Id: Icf5b3c6b43b4d8ecc39246f3eb03e32738af7444
2025-04-15 15:05:26 -04:00
Treehugger Robot
ba07ec67ab Merge "Dispose input monitor on the main thread in InputConsumerUtilsTest" into main 2025-04-15 10:19:06 -07:00
Schneider Victor-Tulias
3731a852bf Fix broken -1 -> home transition with overview in window enabled
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Fixes: 402147664
Test: pre/post-submit tests; attempted home gesture from -1 with flag on and off; attempted gestures from home after: 1P launcher -> -1 -> settings -> switch to 3P launcher
Change-Id: Ibd945e0c861e0fa59c16738da476be3c16454382
2025-04-15 10:15:31 -07:00
Schneider Victor-Tulias
bfe39bdf36 Dispose input monitor on the main thread in InputConsumerUtilsTest
Flag: EXEMPT test fix
Fixes: 410599758
Test: InputConsumerUtilsTest
Change-Id: I2016d4711d5913e4e9baad1c394bcd1fb2f043ea
2025-04-15 10:37:27 -04:00
Sebastián Franco
526d80a550 Merge "No-op change, remove methods from BaseLauncherActivityTest into Utilities" into main 2025-04-14 16:21:19 -07:00
Sebastian Franco
c08c7de5e3 No-op change, remove methods from BaseLauncherActivityTest into Utilities
Bug: 324261526
Test: all test that inherit BaseLauncherActivityTest
Flag: TEST_ONLY
Change-Id: I0851373d179f064721a3a618853a05796cc1379f
2025-04-14 13:38:20 -07:00
Shamali P
8fa26ebe5b Map timer info to ui state in TaskViewModel
Bug: 405359562
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: Unit tests
Change-Id: I080e9c94a41c747210fa9621f913e43b9f584c29
2025-04-14 12:50:14 +00:00
samcackett
2244b633cc Add TaskContentView wrapper to TaskThumbnailView
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.

Reason for revert: Reland previously reverted CL's with fixes

Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
2025-04-09 16:36:51 +01:00
Sebastián Franco
59ae5808c7 Merge "Use LauncherActivityScenarioRule in BaseLauncherActivityTest" into main 2025-04-08 15:28:11 -07:00
minch
42efd0c6cc Let TaskView.bind take GroupTask instead of Task
1. Introduce a `groupTask` property to `TaskView` and let all the
   `bind` functions take a type of `GroupTask` as the parameter
   instead of a `Task`.
2. Then let `RecentsView.removeGroupTaskInternal` take the
   `GroupTask` as the parameter instead of a `TaskView`.
3. Caches the `groupTask` before `removeGroupTaskInternal` then
   we can avoid the corresponding `deskId` being set to invalid
   on `removeViewInLayout` in the main thread, which might happen
   before `removeGroupTaskInternal`.

Bug: 408032417
Test: m
Flag: EXEMPT refactor
Change-Id: I51c5b810eb63bc1267b90b915f90164f7ca3cba5
2025-04-08 17:16:08 +00:00
Alex Chau
7dce980f9a Merge "Refactor RotationTouchHelper to be per-display" into main 2025-04-07 04:27:26 -07:00
Eghosa Ewansiha-Vlachavas
6665030709 Merge "[2/n] Isolate desktop entry point disabling from window exemptions" into main 2025-04-04 15:45:16 -07:00
Will Osborn
d515f1a3ed Refactor RotationTouchHelper to be per-display
Bug: 398195845
Test: locally tested + ran unit tests
Flag: EXEMPT refactor
Change-Id: I2a5ae4171fd211650624291574f84f8bff8b8825
2025-04-04 12:59:34 +00:00
Sebastian Franco
089f07c2b6 Use LauncherActivityScenarioRule in BaseLauncherActivityTest
The goal is that eventually remove BaseLauncherActivityTest and
uase LauncherActivityScenarioRule by compositions instead of
using inheritance and move methods that make sense to have in
LauncherActivityScenarioRule and other in utility classes.

Bug: 324261526
Test: All Tests that inherit from BaseLauncherActivityTest
Flag: TEST_ONLY
Change-Id: I1b2f3ed9e9d41a9185711ba682895b0b3fffe2df
2025-04-03 15:35:20 -07:00
Vadim Tryshev
94a9dca7fc Revert "Demote unstable test testQuickSwitchFromApp from presubmit"
This reverts commit 67c85d8fc2.

Reason for revert: Test is stable

Change-Id: Ie76ff933c2871278ba0a86291ed73c118231cbdc
2025-04-02 14:30:58 -07:00
Eghosa Ewansiha-Vlachavas
34605d8575 [2/n] Isolate desktop entry point disabling from window exemptions
The windowing exemptions logic is used for both exempting apps from
opening in desktop but also hiding the entry point so apps cannot be
moved into desktop. However, disabling desktop entry points is not
constrained by the same security restrictions as exempting apps from
opening as freeform in desktop. Instead we should have a separate
heuristic for disabling entry points and forcing to fullscreen.

Flag: EXEMPT Refactoring
Fixes: 407704088
Test: atest NexusLauncherTests:com.android.quickstep.ExternalDisplaySystemShortcutTest.kt,
      atest NexusLauncherTests:com.android.quickstep.DisplaySystemShortcutTest.kt

Change-Id: I268566072ca5fba090d05f0202468d086c41a66d
2025-04-01 15:24:11 +00:00
Schneider Victor-tulias
f311ff67ff Merge changes Ib386c3b8,I2315e0af into main
* changes:
  Fix broken uses of TISBinder.refreshOverviewTarget
  Fix missing TAPL test state checks
2025-04-01 07:26:27 -07:00
Treehugger Robot
181a4b1911 Merge "Initialise and retain TaskViewModel in TaskView's constructor." into main 2025-04-01 06:22:15 -07:00
Uwais Ashraf
e65743b7de Initialise and retain TaskViewModel in TaskView's constructor.
This means that the VMs are created on the bg threads in the ViewPool setup stage rather than at critical points in CUJs.

Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces
Change-Id: I3aab5271d552e5f292533617a6842a046cb43bf1
2025-04-01 11:11:36 +00:00
Will Osborn
f655091164 V small tidy of InputConsumerUtilsTest
Test: locally tested on Tangor
Bug: 399371607
Flag: EXEMPT refactor
Change-Id: Ie034525cfb88c378c7edfbbcabeb7d68d62ea5da
2025-04-01 11:06:14 +00:00
Schneider Victor-Tulias
924c181fcd Fix missing TAPL test state checks
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I2315e0af7b0567368ddc194a2d5ec7b3e563175f
2025-03-31 16:15:42 -07:00
Alex Chau
f0575814e1 Add ScreenRecord for DigitalWellBeingToastTest
Bug: 407406547
Test: DigitalWellBeingToastTest
Flag: EXEMPT test only
Change-Id: I45caf7e9fc6e091180bfcbabab1d06c3a302eb96
2025-03-31 21:32:45 +01:00
Will Osborn
5c00b41505 Merge "Refactor RecentsAnimationDeviceState and TaskAnimationManager using new PerDisplay library" into main 2025-03-28 14:05:39 -07:00
Will Osborn
ec8d20d0ed Refactor RecentsAnimationDeviceState and TaskAnimationManager using new PerDisplay library
Test: locally tested on Tangor
Bug: 399371607
Flag: EXEMPT refactor

Change-Id: Ie52f53a2d5dee757a8dc3b19248736bc15e5e0c6
2025-03-28 12:08:36 +00:00
Treehugger Robot
d1b30baedb Merge "Update SplitSelectDataHolderTest for HSUM" into main 2025-03-27 16:31:45 -07:00
Vinit Nayak
b988ca81b0 Update SplitSelectDataHolderTest for HSUM
Test: atest NexusLauncherTests:com.android.quickstep.util.SplitSelectDataHolderTest
Flag: EXEMPT test
Fixes: 398855338
Change-Id: Ia224be5291d9aa37f76ec0e1ac3d8096ec73d7c0
2025-03-27 17:20:44 -04:00
Sunny Goyal
3b307455a0 Revert^2 "Simplifying model testing rules"
35b6d322ab

Change-Id: I3ed574a517dbe350b6dfe5b1d3ed198203d22f44
2025-03-26 23:08:55 -07:00
Priyanka Advani (xWF)
35b6d322ab Revert "Simplifying model testing rules"
Revert submission 32704934-model-test-cleanup

Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:32704934-model-test-cleanup

Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
2025-03-26 16:12:16 -07:00
Sunny Goyal
cb84230913 Simplifying model testing rules
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions

Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit

Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
2025-03-26 11:34:15 -07:00
Schneider Victor-Tulias
58b82620df Fix miscellaneous TAPL testing issue
- the recents view container's root view can be null, which is valid with the flag enabled
- The taskbar is now also present in 1P with flag enabled

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I4d822a8ea20cc7a28d7a703acbf9b589aa18593e
2025-03-25 12:58:29 -07:00
minch
e7a054ae2b Make sure the correct input consumer is created
Let `isGestureBlockedTask` return false directly if
`mGestureBlockingTaskId` is not valid. This can avoid
the caller go to create incorrect InputConsumer when
the chekcing `taskId` is also invalid.

Bug: 402218420
Flag: EXEMPT bug fix
Test: m
Change-Id: Ia0cde8ee2b97fc92028458d01487d958f2e87a80
2025-03-24 17:00:28 +00:00
Massimo Carli
2d70081aa5 Merge "Fix Test supporting HSUM" into main 2025-03-24 07:47:17 -07:00