Commit Graph

401 Commits

Author SHA1 Message Date
Anushree Ganjam
25717836e1 Merge "Use RunListener to Clear inline mocks at the end of each test class." into main 2025-01-16 13:28:04 -08:00
Anushree Ganjam
0a29e73ffb Use RunListener to Clear inline mocks at the end of each test class.
Inline mocks are leaking activity contexts and accumulation of these activity contexts led to OOM that resulted in test failure.

See https://github.com/mockito/mockito/issues/1614 for details on mockito caused memory leaks

This change works for both soong and gradle builds.

Bug: 378520480
Test: atest and android studio builds
Flag: TEST_ONLY
Change-Id: I4a50993621ea416a02a41dd2f9c330d1599f065c
2025-01-16 11:19:52 -08:00
Sunny Goyal
01a976f210 Adding some source hints when generating theme icons
Bug: 381897614
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ief779bb04cd69372ec3acd4501e283f09de41b4d
2025-01-14 16:00:46 -08:00
Treehugger Robot
bc3995222b Merge "Moving DisplayController to dagger" into main 2025-01-14 13:39:19 -08:00
Sunny Goyal
55dc2d1c31 Moving DisplayController to dagger
Separating various overrides to individual modules so that they can be reused in tests

Removing ContextualEduStatsManager and directly using SysUiProxy as all the usescases
are only in quickstep/
This avoids additional Module definition and delegation

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I096459d638553991ed01766002b874589c6b976e
2025-01-14 11:40:35 -08:00
Adnan Begovic
8d3eaf1a36 Merge "launcher3: Introduce onGridMigrationComplete callback." into main 2025-01-13 15:22:18 -08:00
Xiaoqian (Daisy) Dai
6dbd67ae7d Merge "desktop-exploded-view: Add header to individual windows." into main 2025-01-13 11:40:53 -08:00
Adnan Begovic
4b9b9d7e40 launcher3: Introduce onGridMigrationComplete callback.
onGridMigrationComplete is invoked when grid migration
  successfully completes.

  ModelDelegate's can choose to observe this by overriding
  the callback.

Test: manual, existing
Flag: com.android.launcher3.one_grid_specs
Bug: 386802204

Change-Id: Iaca2e61a95c3d3decc12b2cc54461dba441202a0
2025-01-13 09:52:16 -08:00
Michele Fan
89b039da83 desktop-exploded-view: Add header to individual windows.
The header has an app icon, app title and a close button. Currently
clicking on the close button does nothing. Will address it in a
following CL.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353965691

Change-Id: I5e0303a02d5f8afd16a5f5f0335a8fa489ff98f2
2025-01-10 22:25:43 +00:00
Treehugger Robot
ce9ea2caef Merge "Simplifying IconShape" into main 2025-01-09 18:14:30 -08:00
Sunny Goyal
1138f5fe59 Simplifying IconShape
Removing various custom shapes and replacing it with a generic shape implementation. This works with any valid svg path.

Bug: 366237794
Flag: EXEMPT refactor
Test: atest IconShapeTest
Change-Id: I4665bc657b8bffc4d4efa30cebe00341b3140c55
2025-01-09 15:04:46 -08:00
Sebastian Franco
a8e1984852 Promote ReorderAlgorithmUnitTest since it's not failing anymore
Fix: 332527963
Flag: TEST_ONLY
Test: ReorderAlgorithmUnitTest
Change-Id: I69257ff8a267f6f2e94f8d0c3c5e0c662ec5efb9
2025-01-08 12:20:13 -08:00
Sunny Goyal
c369d1e4af Adding ThemeManager as a centralized place for controlling icon theming
Bug: 381897614
Flag: EXEMPT refactor
Test: atest ThemeManagerTest

Change-Id: Ib1dafdcc303f05f78cf586741c3d35243ab06e69
2025-01-06 21:53:22 -08:00
Sunny Goyal
6d6529cff9 Merge "Converting LauncherPrefs to dagger" into main 2025-01-03 14:18:19 -08:00
Sunny Goyal
e79d453bc8 Converting LauncherPrefs to dagger
Fixing ENABLE_TWOLINE_ALLAPPS_TOGGLE not properly tied to IDP:
http://recall/-/ep7WJ8pKwCEklUN5J1mAkM

Bug: 361850561
Flag: EXEMPT dagger-migration
Test: atest LauncherPrefsTest FakeLauncherPrefsTest
Change-Id: Iba63d060f4a8c2e31033fca2a4638c559c161338
2025-01-03 13:49:53 -08:00
Treehugger Robot
d4bfadf263 Merge "Fixing low res folder icon when preview changes" into main 2025-01-02 10:11:27 -08:00
Sunny Goyal
04b50a08f6 Fixing low res folder icon when preview changes
Also removing legacy for drawable sharing between folder-content and folder-icon, since preview now always creates new drawables

Flag: EXEMPT bugfix
Bug: 386842651
Test: atest PreviewItemManagerTest
Change-Id: Ib8e4b4d5be4fb0c9601b9d8e3cef8a29d6c77651
2024-12-30 15:47:17 -08:00
Charlie Anderson
0415a35168 Add new utility method for setting ImageTest workspace icon Component
Bug: 350758155
Test: ArchivedAppImageTest
Flag: TEST_ONLY
Change-Id: I3f88c64528abeab68d03ba81ebb8e34b5d0e5dad
2024-12-30 09:57:08 -08:00
Treehugger Robot
cdfec1a942 Merge "Replacing custom parcelables with platform types for test APIs" into main 2024-12-27 10:39:19 -08:00
Sunny Goyal
c2639e464f Replacing some fixed lookup flags with specific constant flag
This would make it easier to customize flags used on desktop icons

Bug: 366237794
Flag: EXEMPT refactor
Test: atest CacheLookupFlagTest
Change-Id: I0f3f04ddbe73abea207a5b58a65714ff172b2726
2024-12-26 20:19:02 -08:00
Sunny Goyal
a39a09ba6a Replacing custom parcelables with platform types for test APIs
Bug: 377772352
Flag: EXEMPT test only
Test: Presubmit
Change-Id: Ie464c67adf6502aee1fe65ef643e1a67260b820f
2024-12-26 17:19:15 -08:00
Sunny Goyal
d5ad770d2c Converting BaseIconCache to kotlin
Bug: 366237794
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ia191ed468eda24f910bba87221cf1f1714408a55
2024-12-24 21:27:33 -08:00
Sunny Goyal
60bad051c4 Fixing module inheritence when overriding Launcher component
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I1f726e9895f6872d0294a11ab0c52c6c619c2a3f
2024-12-18 10:38:00 -08:00
Treehugger Robot
a429476ec6 Merge "If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name" into main 2024-12-17 15:38:17 -08:00
Stefan Andonian
fa1b2ba983 If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name
Bug: 356096502
Test: Verified locally that if you hard-code the PINNED shortcut query to not return data, the backup query still allows the deep shortcuts to show up on the home screen.
Flag: EXEMPT bug fix
Change-Id: I7a9b2d2c3be2ecce38a5af71951f1a12bc1c20ee
2024-12-17 18:06:48 +00:00
Sihua Ma
e5a3789024 Attempt on deflaking FolderTest
Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: EXEMPT test deflake
Bug: 382305734
Change-Id: I7f66b5b8973c97f6bc03a739044fb8c90886e41e
2024-12-17 06:32:53 +00:00
Treehugger Robot
f340be6e4f Merge "Replacing all int lookup flags and boolean overrides with an object to make it easier to extend options" into main 2024-12-13 06:20:44 -08:00
Sihua Ma
48db4ef770 Move model tests to multivalent
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: EXEMPT test only
Change-Id: I751c449561175d3c7c5a770b7b30bc4f24c1cd44
2024-12-13 05:51:51 +00:00
Sunny Goyal
18e480838a Replacing all int lookup flags and boolean overrides with an object to make it easier to extend options
Bug: 381897614
Bug: 366237794
Flag: EXEMPT refactor
Test: atest CacheLookupFlagTest
Change-Id: Ic89d48dd1c5dc8b0a89b1898cd7b00d9c61d6513
2024-12-12 18:32:55 -08:00
Sunny Goyal
41e8057bbf Moving WMProxy to dagger
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I9a8031037f2167658b7bc212b59c9b11abbf2f03
2024-12-11 13:24:26 -08:00
Treehugger Robot
11537828ad Merge "Fising some tests bugs, assuming primary user is user 0" into main 2024-12-10 23:50:28 +00:00
Sunny Goyal
89551b71be Fising some tests bugs, assuming primary user is user 0
Bug: 383091872
Bug: 383183795
Bug: 383088668
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: I551f13fc3d51bf1c2718f0582f8ee76d51067896
2024-12-10 12:09:33 -08:00
Shamali Patwa
d60bb5a2f2 Merge "[HSUM] Update createTestWidgetItem to use current user for test widget" into main 2024-12-10 19:42:42 +00:00
Shamali P
2536bcae0c [HSUM] Update createTestWidgetItem to use current user for test widget
Bug: 383087777
Fix: 383087777
Test: Unit test and ABTD for HSUM
Flag: EXEMPT BUGFIX
Change-Id: I3d7ac21628b8ddc16ed09853523a45cde858adb6
2024-12-10 03:59:28 +00:00
Treehugger Robot
b172e86472 Merge "Loading generated preview on-demand instead of keeping everything in memory" into main 2024-12-09 17:26:02 +00:00
Treehugger Robot
45e274977d Merge "Some test fixes where default user is assumed to be user 0" into main 2024-12-07 08:11:56 +00:00
Sunny Goyal
9c58954488 Some test fixes where default user is assumed to be user 0
CheckLongPressHelper: Cancelling view longpress which inturn also cancels self
This ensures that long press is properly cancelled if the default timeout for system longpress is same as ours

Bug: 379777736
Bug: 379807782
Bug: 379805363
Bug: 379805788
Bug: 379777734
Bug: 379774350
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ic4d9d6c4f79325a5d7ab98eafa1c86db4c2e67a5
2024-12-06 22:23:51 -08:00
Sunny Goyal
ee15f52a7c Loading generated preview on-demand instead of keeping everything in memory
Bug: 369906121
Test: atest GeneratedPreviewTest
Flag: EXEMPT bugfix
Change-Id: Idd7610e8a5c577d2c7b0a1d7d2a1f1efde40b11f
2024-12-06 22:25:40 +00:00
Treehugger Robot
3e159f5654 Merge "Generalizing monochrome icon into Theme icons" into main 2024-12-06 18:29:07 +00:00
Sunny Goyal
97eb832cd3 Generalizing monochrome icon into Theme icons
Bug: 381897614
Flag: EXEMPT refactor
Test: atest MonoIconThemeControllerTest
      atest MonoThemedBitmapTest

Change-Id: Iaa0cbe3523ee26a6d4f77e002d0cca90657f89b2
2024-12-05 14:57:06 -08:00
Uwais Ashraf
1348514466 Use custom background dispatcher to stop excess thread creation.
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Performance tests
Change-Id: I0e205cf7f55c90375a5a1e95fbd0f1adf0fc6658
2024-12-05 11:05:27 +00:00
Treehugger Robot
27c2f4ddc1 Merge "Decouple Backup / Restore Error Codes" into main 2024-12-02 18:57:17 +00:00
Stefan Andonian
6df13d3b8e Decouple Backup / Restore Error Codes
Bug: 381315244
Test: Simply looked at emitted error codes and changed names if they were used in multiple locations.
Flag: EXEMPT bug fix
Change-Id: Iab4a8d6ff410682f448b2ac32e44b766d79a7616
2024-11-27 16:48:28 -08:00
Juan Sebastian Martinez
12c5b06add Merge "Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest." into main 2024-11-22 18:21:05 +00:00
Juan Sebastian Martinez
86f3d35839 Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest.
The mock makes sure we don't rely on a device hardware for tests.

Test: DeleteDropTargetTest
Flag: com.android.launcher3.msdl_feedback
Bug: 379958544
Change-Id: I202b81f3dd16af1c0985980d0b962be0000bf31f
2024-11-21 13:32:43 -08:00
Charlie Anderson
24e3132bbd Revert^2 "Update test activities with a non-default icon."
3e7d28e1c7

Change-Id: Ifea50664980a5bb52700e494abb10643d68fbd01
2024-11-20 23:23:01 +00:00
Juan Sebastian Martinez
3f0d356619 Merge "Adding MSDL feedback to dragging apps and widgest over drop targets." into main 2024-11-19 15:58:35 +00:00
Treehugger Robot
7f103a6d5c Merge "Remove any fixed landscape foldable dumps" into main 2024-11-19 02:54:46 +00:00
Federico Baron
dd28335d78 Remove any fixed landscape foldable dumps
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I71f026d34dd536cc4041e1dd36908824eb479153
2024-11-19 00:49:26 +00:00
Shamali Patwa
f05d59cdad Merge "Update the enforce_system_radius_for_app_widgets flag's type" into main 2024-11-19 00:03:34 +00:00