Commit Graph

3195 Commits

Author SHA1 Message Date
Lucas Dupin
b60fff3929 Disable blurs when dev setting or battery saver
Stop rendering blurs whenever a user:
- disables blurs on developer settings
- enables battery saver

Test: manual
Bug: 191814337
Change-Id: I8fd04796054d92171732c8db95b64cfa3ec469ec
2021-06-23 08:37:27 -07:00
Winson Chung
d27f127b3a Merge "Don't finish to home when launching a task from recents" into sc-dev 2021-06-22 18:54:14 +00:00
Winson Chung
856cd1bd4d Don't finish to home when launching a task from recents
- When launching without a task view, we should also not be finishing
  to home (similar to composeRecentsLaunchAnimator) since it will
  clobber the newly launched task

Fixes: 191182965
Test: Open overview with live tile, try to open usb debugging settings
      page
Change-Id: If7464ebf155cee33e81205fbf4899e9ab49a52d0
2021-06-22 18:54:03 +00:00
Cyrus Boadway
9dd0351ed1 Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev 2021-06-22 18:13:52 +00:00
Sunny Goyal
eb3367796a Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev 2021-06-22 18:08:25 +00:00
Tracy Zhou
578b45f919 Merge "Null check on target set before rendering task open animation" into sc-dev 2021-06-22 17:21:32 +00:00
Zak Cohen
049c2f578b Merge "Fade overview action buttons faster in overview -> home" into sc-dev 2021-06-22 16:53:52 +00:00
Matt Casey
3a65795298 Merge "Send a zero for assist invocation on animation end" into sc-dev 2021-06-22 16:46:41 +00:00
Matt Casey
eeac1aba30 Send a zero for assist invocation on animation end
When a corner gesture doesn't complete, we animate the progress from its
current value back to 0. When it hits 0, sysui will perform some cleanup
e.g. removing the window. However, it's possible the animator won't
return exactly 0 and will complete, so we should send an explicit 0
whenever the animator completes.

Bug: 187768368
Test: We don't have a repro for the bug, but expect this should be more
      robust. Tested to validate it didn't regress.
Change-Id: Id65f94534363c326fc2c8d0a9114a3c036aa55e4
2021-06-22 10:46:10 -04:00
Cyrus Boadway
f158ec33d8 Use icon splash screen when starting activity from widget interaction
Set the flag to use the icon splash screen rather than the empty splash
screen when starting an activity from a widget interaction.

Bug: 191738655
Test: manual
Change-Id: Iff771a43648bbf6dfb88e2a6749c4526fd17da07
2021-06-22 10:14:06 +00:00
Tracy Zhou
8af0dd3e0c Null check on target set before rendering task open animation
Fixes: 190854921
Test: N/A
Change-Id: Iae7ef7cf3f4d2309223bfabe6d40f24b7e34439c
2021-06-21 21:33:28 -07:00
Lucas Dupin
818ed4b794 Merge "Apply depth even when surface is null" into sc-dev 2021-06-22 01:10:23 +00:00
Lucas Dupin
a6c38be150 Apply depth even when surface is null
We need to update mDepth even when the surface is null, otherwise
events will be ignored and mDepth will have the wrong value when
waking up from screen-off.

Test: pull up app drawer, screen off, unlock
Test: go to overview, screen off, unlock
Test: launch app, observe blurs and zoom
Fixes: 191153501
Change-Id: I33f5d84a50e24f05a09769b1f7f3c27969f847cd
2021-06-21 16:27:11 -07:00
Sunny Goyal
696c612964 Fixing TaskView.launchTask.onEndCallback is not called
Sometimes onAnimaitonCancelled can be called without onCreate. Calling
onEnd in this case so that the sate is cleared

Removing additional subclassing for the runner

Bug: 190856140
Test: Manual
Change-Id: If105cb343cab446a4eac90a45184ce50c6e4c485
2021-06-21 16:06:40 -07:00
Sunny Goyal
871d435be2 Merge "Finish wrapped launcher animations if impl is gone" into sc-dev 2021-06-21 23:03:27 +00:00
Sunny Goyal
b3eafe97bb Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev 2021-06-21 22:32:23 +00:00
zakcohen
061548668d Fade overview action buttons faster in overview -> home
Spec says transition should take ~80ms, default for this transition is
~300ms, so clamp to a quarter of the range.

Bug: 191699762
Test: Local
Change-Id: I5ef6701eee0d25d5d9987e05cb53aee3e5e8e143
2021-06-21 15:18:16 -07:00
Tony Wickham
82fc5c83a5 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev 2021-06-21 22:15:48 +00:00
Evan Rosky
08c3480b84 Finish wrapped launcher animations if impl is gone
If the runner impl is gone (since it is a weakreference), we
still need to complete the animation contract by calling the
finish callback, so do that.

Bug: 183993924
Test: atest ActivityMetricsLoggerTests
Change-Id: Idce1859f0417cb74bbb9884e0d06750539e4545e
(cherry picked from commit 8a672e15cc)
2021-06-21 20:51:12 +00:00
Sunny Goyal
de644313b0 Fixing animation end not-called when cancelling state the animation recursively
Bug: 190856140
Test: Manual
Change-Id: I5d6a00c1d1c0e95e615b7f2115e3e4ebb56b987f
2021-06-21 13:47:49 -07:00
Tony Wickham
9c10d08e1e Ensure mConsumer isn't set to null in reset().
mResetGestureInputConsumer is not initialized until onUserUnlocked(), meaning it might still be null in reset(). Use NO_OP input consumer in that case.

Test: none
Bug: 191669813
Change-Id: Ib9edde50fba0b6164390ec2b5c877d3db74ddfeb
2021-06-21 13:24:01 -07:00
Jon Miranda
651abb9924 Fix bug where workspace alpha does not get set to 1 when animation gets cancelled.
- Can also remove QSB from app launch animator, since its in the hotseat now.

Bug: 189458349
Test: manual
Change-Id: Ib41376e3f8c58166c6ee6fbfed38bdd443663df4
2021-06-18 15:39:36 -07:00
Winson Chung
caabfa1519 Merge "Do some additional cleanup when switching handlers" into sc-dev 2021-06-17 16:48:42 +00:00
Jonathan Miranda
28e39335bc Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev 2021-06-16 20:34:48 +00:00
Jon Miranda
b73e591712 Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag.
Bug: 191088291
Test: manual
Change-Id: Ia144c72e0fe1292ed856a37ee714a1cda50083d5
2021-06-16 18:13:23 +00:00
Jonathan Miranda
c846245f1b Merge "App Shortcut menu bug fixes and polish." into sc-dev 2021-06-16 18:06:13 +00:00
Jon Miranda
229c4c3235 App Shortcut menu bug fixes and polish.
- Widget is its own item.
- Change order of icon order.
- Update grab handle colors

Bug: 188095695
Test: long press on apps with/without widgets, long press apps on workspace/
      all apps/search

Change-Id: Iabb9b4b3f3a928103b9d62601f22e74ef2325d7c
2021-06-15 18:59:51 -07:00
Winson Chung
d14190d547 Do some additional cleanup when switching handlers
Bug: 183962705
Test: Presubmit

Change-Id: Ia9295d2cf89fa6b6fe77c5e4861a704c4a82ab12
2021-06-15 13:57:06 -07:00
Hongwei Wang
e3bfeddd04 Merge "Use RectFSpringAnim for auto-enter-pip" into sc-dev 2021-06-15 20:50:45 +00:00
Thiru Ramasamy
640fc8b84d Merge "Enable logging for 'Themed icons' setting." into sc-dev 2021-06-15 20:47:23 +00:00
Hongwei Wang
9d3e31e67c Use RectFSpringAnim for auto-enter-pip
Make SwipePipToHomeAnimator a subclass of RectFSpringAnim and use the
bounds calculated from latter for auto-enter-pip transition.

Note that the landscape to portrait case may not fully comply to
RectFSpringAnim as we calculate the position separately in
SwipePipToHomeAnimator.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/CWBPU2A6vB8CeTFRanQLx
Bug: 184789411
Test: manual, see video
Change-Id: I67dae09e682b7d8f1a1f08995eb3bcf76bdf7417
2021-06-15 12:04:17 -07:00
TreeHugger Robot
4ff2682787 Merge "Update all apps divider to pill shape" into sc-dev 2021-06-15 18:33:22 +00:00
Winson Chung
1b369c4763 Merge "Don't rely on intent to call back from activity tracker" into sc-dev 2021-06-15 18:04:52 +00:00
TreeHugger Robot
3e366d6529 Merge "Fix foreground position during widget home animation" into sc-dev 2021-06-15 17:59:48 +00:00
Thiru Ramasamy
74a6d2ea55 Enable logging for 'Themed icons' setting.
Eldar: http://eldar/510864786
Bug: 191161241
Test: local - http://gpaste/5934701681311744 & http://gpaste/6715297709948928
Change-Id: I18ad97f68b372997e222f06dabf8bbe83f15d92f
2021-06-15 10:48:43 -07:00
Winson Chung
1c2d522d1b Don't rely on intent to call back from activity tracker
- The intent is not updated in certain cases which means that the
  callback may not be made if Launcher gets recreated. Instead
  have the tracker manage the set of registered callbacks.
- This change allows AbsSwipeUpHandler to continue to receive
  onActivityInit calls even if Launcher restarts, and also to
  handle a case where restarting while waiting for a page-settling
  callback will continue to finish the gesture.

Bug: 183962705
Test: Force recreate at various points in the gesture

Change-Id: Ib5ead8c868e798e26e56776f57bd715c79d087cd
2021-06-14 20:57:40 -07:00
Jonathan Miranda
bea8267854 Merge "Address LAUNCHER_APP_LAUNCH_FROM_ICON jank." into sc-dev 2021-06-15 00:32:40 +00:00
Jon Miranda
0750f03c96 Address LAUNCHER_APP_LAUNCH_FROM_ICON jank.
- Delay app launch animations by a frame, and skip logic to skip the first frame.
- Note the icon pressed state animation still occurs, so there is still some
  visual feedback for the user that something is happening.

Bug: 181901105
Test: ensure animation still looks smooth (using window animation scale & record in slow mo)
Change-Id: Ia904b8b96301042c900e0589f33fc625c1c1148b
Merged-In: Ia904b8b96301042c900e0589f33fc625c1c1148b
2021-06-14 23:29:29 +00:00
Hongwei Wang
5a2a6e7325 Merge "Calculate the position from start bounds for auto-enter PiP" into sc-dev 2021-06-14 22:21:19 +00:00
Samuel Fufa
d85735db47 Update all apps divider to pill shape
Screenshot: https://screenshot.googleplex.com/4AJFL7MjJuZr7tf
Bug: 188946089
Test: local
Change-Id: If45512b24caefc66725892ab8429afd3d9ce20c8
2021-06-14 13:37:52 -05:00
Jon Spivack
3e48c63180 Merge "Send NIU Actions Intents to default Assistant" into sc-dev 2021-06-14 18:13:34 +00:00
Winson Chung
9f5ba22d74 Merge "Skip entering PIP when dismissing auto-enter pip task" into sc-dev 2021-06-14 16:39:19 +00:00
Winson Chung
c5d50f710a Skip entering PIP when dismissing auto-enter pip task
- Revert some changes from ag/14827090, we don't actually need to
  screenshot when dismissing, but we do need to prevent pip

Fixes: 190751761
Test: Swiping up from YT -> PIP
      Swiping up from YT to Overview to home -> PIP
      Swiping up from YT to Overview
Change-Id: I2057467d5146be6edc382d3745a1e5269cd76a6b
Merged-In: I2057467d5146be6edc382d3745a1e5269cd76a6b
2021-06-14 16:39:11 +00:00
Winson Chung
a50c38c457 Merge "Ignore source hint rect if it is too small" into sc-dev 2021-06-13 22:55:48 +00:00
Winson Chung
b009faca5e Merge changes Ib7d3a07e,Ic22ccf17 into sc-dev
* changes:
  Disallow auto-enter PIP when there is an existing PIP
  Don't use icon home animator when entering PIP
2021-06-13 20:50:51 +00:00
Winson Chung
be2a0989ce Merge "Ensure we pass the pointer id to the velocity tracker and not the index" into sc-dev 2021-06-13 20:49:58 +00:00
TreeHugger Robot
cfa0baeca6 Merge "Polish the gesture navigation tutorial sandbox" into sc-dev 2021-06-13 01:25:56 +00:00
Winson Chung
62b5692736 Ignore source hint rect if it is too small
- When the source hint rect is too small, we can't do a nice transition
  when going home (it would require scaling the surface up to fit the
  rect, which conflicts spatially with the crop down to launcher
  icon/pip), so in this case, just fallback to the overlay

Bug: 190464560
Test: Enter YT Pip, play video, swipe it down to miniplayer then
      enter pip
Change-Id: I44b253ca440f6d2ca0eb20eef3454c5d4e3ae3e9
2021-06-12 13:58:32 -07:00
Winson Chung
954681d837 Disallow auto-enter PIP when there is an existing PIP
- Remove some deprecated calls when registering task stack listeners

Bug: 190464560
Test: Enter YT Pip, try to enter another auto-enter PIP app
Change-Id: Ib7d3a07effadb7b13f7c37f938741e27cf0e254e
2021-06-12 13:58:32 -07:00
Winson Chung
5300fce94f Don't use icon home animator when entering PIP
- If the app supports pip, can just do the fallback workspace
  home animation since the app will not be going to the icon

Bug: 190464560
Test: Open YT, swipe up, ensure it goes to the icon,
      Reopen YT video, swipe up, ensure it goes into PIP without
      icon animation
Change-Id: Ic22ccf17c664b9941ed944c0e39dc1f8d4efa84a
2021-06-12 13:58:17 -07:00