Commit Graph

9022 Commits

Author SHA1 Message Date
Vinit Nayak
af2f3b43ca Use SplitPosition instead of StagePosition in TaskViewSimulator
* Ultimately we want to migrate to SplitIndex, but
first we'll slowly remove all usages of StagePosition

Test: Compiles
Flag: EXEMPT cleanup
Bug: 254378592
Change-Id: I44651b4c378dedd4409d99986f7c92371180afd2
2025-04-18 17:21:00 +00:00
Treehugger Robot
c562b3ce4e Merge "Fix a crash on null getLegacyBaseTask" into main 2025-04-17 21:51:27 -07:00
Treehugger Robot
efd9b79a4c Merge "Remove feature flag for OverviewCommandHelper timeout" into main 2025-04-17 14:33:39 -07:00
Fengjiang Li
dda14192b7 Merge "[Taskbar] Add taskbar root view on per-window-thread" into main 2025-04-17 12:51:01 -07:00
minch
95922915a1 Fix a crash on null getLegacyBaseTask
Bug: 410090695
Test: m
Flag: EXEMPT crash fix
Change-Id: I4b198764f182bf31769860619842feeb2191e583
2025-04-17 16:52:15 +00:00
Jordan Silva
612b58b344 Merge "Fix Drag to launch desktop still shows app chip" into main 2025-04-17 08:36:33 -07:00
Jordan Silva
5713bf2ef0 Remove feature flag for OverviewCommandHelper timeout
Fix: 409608875
Flag: EXEMPT Flag removal.
Test: OverviewCommandHelperTest.kt
Change-Id: I094eed94620665b8b089716b2cfe15773243e573
2025-04-17 08:36:06 -07:00
Alex Chau
bb5958ec48 Merge "Clean-up enableDesktopWindowingCarouselDetach and refactor detachDesktopCarousel" into main 2025-04-17 07:04:21 -07:00
Alex Chau
e4413f929d Clean-up enableDesktopWindowingCarouselDetach and refactor detachDesktopCarousel
- Removed enableDesktopWindowingCarouselDetach flag
- detachDesktopCarousel is now always false, except in home quick switch (QuickSwitchState)
- Updated home quick switch controller NoButtonQuickSwitchTouchController to apply DESKTOP_CAROUSEL_DETACH_PROGRESS

Fix: 411127271
Test: manual
Flag: EXEMPT flag cleanup and refactor
Change-Id: I1cbf0987b111d0111cb8b9b6c7994f4494780e1a
2025-04-17 05:08:41 -07:00
Jordan Silva
46cb63d619 Fix Drag to launch desktop still shows app chip
Extract logic for `settledProgressFullscreen` to `TaskView` to reuse it in subclasses.
`DesktopTaskView` now uses `updateSettledProgressFullscreen` instead of updating `settledProgressFullscreen` directly.

Fix: 406236028
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual. Drag a Desktop tile to launch.
Change-Id: I31bab76e44dbe5219c65b9dc3654e0988bf77fef
2025-04-17 10:31:54 +01:00
Alex Chau
5951ff0bcd Merge "Recents keyboard switch on focused display" into main 2025-04-17 01:51:29 -07:00
Treehugger Robot
73779be7cd Merge "Change the handling of shouldBlurWorkspace in LauncherState." into main 2025-04-16 22:09:21 -07:00
Andy Wickham
e3371d32f5 Change the handling of shouldBlurWorkspace in LauncherState.
Previously: blur if previous and next state want it blurred.
New: blur if previous OR next state want it blurred.

As part of this, change the default from true to false. Only All
Apps currently sets it to true, meaning we blur workspace only
going to or from All Apps.

Fix: 405836159
Test: Launch app, quickly go home and to All Apps
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic52c5aa2dce7e1e107418952031574bc2e47e585
2025-04-17 02:31:50 +00:00
Fengjiang Li
d952514e04 [Taskbar] Add taskbar root view on per-window-thread
1. Add LooperExecutor in TaskbarManager
2. Add taskbar root view to window in that LooperThread if flag is on

Bug: 404636836
Test: presubmit
Flag: com.android.launcher3.enable_taskbar_ui_thread
Change-Id: I45c6db760b1aafbd186d433ae6f15292f7fe5b43
2025-04-16 19:03:53 -07:00
Treehugger Robot
dfda4408cf Merge "Cleaning up useActivityOverlay flag" into main 2025-04-16 19:00:18 -07:00
Treehugger Robot
2711f8d0d9 Merge "Removing flag enable_smartspace_removal_toggle" into main 2025-04-16 18:57:40 -07:00
Treehugger Robot
8a45dc2cd1 Merge "Make static DisplayController methods respect display id" into main 2025-04-16 17:10:04 -07:00
Alex Chau
baa84629ce Merge "Log LAUNCHER_OVERVIEW_ACTIONS_SCREENSHOT/SELECT with ItemInfo" into main 2025-04-16 12:21:59 -07:00
Treehugger Robot
3a245f5fc2 Merge "Consolidate how we're cleaning up from split in recents" into main 2025-04-16 10:55:59 -07:00
Sunny Goyal
613db2b609 Removing flag enable_smartspace_removal_toggle
Test: Presubmit
Flag: EXEMPT cleanup
Bug: 303471576
Change-Id: Iae8cc3afbf15c66612589fd1e19377e4339af7fc
2025-04-16 10:54:45 -07:00
Treehugger Robot
a9bb3b53a5 Merge "Adds Blur and BlurFallback styles for All Apps." into main 2025-04-16 10:21:48 -07:00
Sunny Goyal
0b22c5d9ee Cleaning up useActivityOverlay flag
Bug: 409606388
Test: Presubmit
Flag: EXEMPT cleanup
Change-Id: I0c9b4885dc6d8678b85443571d4714921825c1eb
2025-04-16 08:36:50 -07:00
Vinit Nayak
ac743912a0 Merge "Pass split info to PreviewPositionHelper" into main 2025-04-16 08:11:28 -07:00
Will Osborn
135e6f999f Recents keyboard switch on focused display
Use the focused display for overview show and toggle commands from keyboard events

Bug: 404854138
Test: local + presubmits
Flag: com.android.launcher3.enable_overview_on_connected_displays

Change-Id: I0e88a4312c3157e318fe2629c9fc27fe9e582351
2025-04-16 14:56:55 +00:00
Treehugger Robot
ab20ede66c Merge "Fix gesture distance for quick switch home with multiple desks" into main 2025-04-16 07:56:22 -07:00
Will Osborn
7efffe621a Make static DisplayController methods respect display id
Bug: 404854138
Test: local + presubmits
Flag: com.android.launcher3.enable_overview_on_connected_displays
Change-Id: Ica46a400101b1b0126355ef842ca5d8b9be20306
2025-04-16 13:45:29 +00:00
Andy Wickham
16a024df71 Adds Blur and BlurFallback styles for All Apps.
Technically these styles can be used throughout Launcher, e.g.
Widget Picker and Folders, but this CL only applies it to All Apps.

At a high level, views wishing to apply transparency to show blur
should use these new attr values rather than colors directly.

When blur changes, e.g. starting or stopping battery saver, the
style is re-applied and revelant views are invalidated. For
Launcher, this is handled by DepthController, and for Taskbar it's
handled by a CrossWindowBlurListener.

Also updated the Private Space animation slightly to account for
the translucent decorators (specifically, we can't use the mask
view to cover them when blur is enabled).

Screenshots: https://drive.google.com/drive/folders/1tU472KHotgEBpT-Ec9VOBWPBf_YdVqv2?resourcekey=0-ebf7W8O6iDJ4UVMtRzTABg&usp=sharing
Private Space animations: https://drive.google.com/file/d/1h5pn8Xb17TPcbujr7uSAJNTq8kwNZoIp/view?usp=drive_link&resourcekey=0-TzpaJ16Gg8_QJctBx4oiIg
Private Space QS Tile animations: https://drive.google.com/file/d/1dCuqnqd5z2kSBEakGobMlEkMwFDBWRbJ/view?usp=drive_link&resourcekey=0-qRVFPb-a6OzaZQOf4x86Jw

Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ia9f581f50d1adc0830569656bdeb751deb710a9c
2025-04-15 16:42:56 -07:00
Treehugger Robot
ef95172183 Merge "Fix broken -1 -> home transition with overview in window enabled" into main 2025-04-15 16:29:43 -07:00
Saumya Prakash
178b49beb3 Merge "Remove the skip button from the gesture tutorial" into main 2025-04-15 15:29:37 -07:00
Treehugger Robot
d1c2f620a5 Merge "Disable overlay on Desktop tasks to match existing behaviour." into main 2025-04-15 11:25:02 -07:00
Suhua Lei
d5f65a0bc4 Fix gesture distance for quick switch home with multiple desks
Bug: 410054827
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: quick switch home
Change-Id: Icb552b8e9538446d93248f14178d27922aa11575
2025-04-15 17:19:26 +00:00
Vinit Nayak
b227f70b6b Pass split info to PreviewPositionHelper
* Needed to properly crop flex split apps that
are offscreen

Bug: 395547133
Test: Swipe up shows correct crop
Flag: com.android.wm.shell.enable_flexible_two_app_split
Change-Id: I8006ea497f46b97cf38fd8576265d7b4a4452615
2025-04-15 17:18:23 +00:00
Schneider Victor-Tulias
3731a852bf Fix broken -1 -> home transition with overview in window enabled
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Fixes: 402147664
Test: pre/post-submit tests; attempted home gesture from -1 with flag on and off; attempted gestures from home after: 1P launcher -> -1 -> settings -> switch to 3P launcher
Change-Id: Ibd945e0c861e0fa59c16738da476be3c16454382
2025-04-15 10:15:31 -07:00
Steven Ng
c5e8d1a929 Merge "Use SysUi focus display ID as the source of truth" into main 2025-04-15 10:11:20 -07:00
Alex Chau
db58258e08 Log LAUNCHER_OVERVIEW_ACTIONS_SCREENSHOT/SELECT with ItemInfo
- This will allow task specific information e.g. index, title etc. to be logged

Fix: 365041030
Test: manual
Flag: EXEMPT bug fix
Change-Id: I5e6af8c064062fa3ad2e61d08e9447b076c66463
2025-04-15 17:49:16 +01:00
Helen Cheuk
d5dfd7e7b7 Merge "[Action Corner] Handle overview action in launcher" into main 2025-04-15 09:46:47 -07:00
Alex Chau
3019338ae9 Use WindowContext in RotationTouchHelper
- See the bug on analysis on perfromance regression
- Using WindowContext which is able to have updated Resource after configuration change on all displays.

Fix: 408988616
Test: manual
Flag: EXEMPT refactor
Change-Id: I716a78072e77e2a5af11bc595f8d477ca136cc48
2025-04-15 09:04:15 -07:00
Uwais Ashraf
dfef467212 Disable overlay on Desktop tasks to match existing behaviour.
Fix: 406931344
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskViewModelTest#taskOverlayDisabled_when_OverlayIsEnabledForVisibleDesktopTask
Change-Id: Iadf6946e5eb67dc422c20f91f4395baf22c7ed57
2025-04-15 15:29:03 +00:00
helencheuk
f4d8a9d3a2 [Action Corner] Handle overview action in launcher
Add a new command type "TOGGLE_OVERVIEW_PREVIOUS" to toggle between overview and the previous task or homepage.
Renamed the existing command types to make them more precise

Bug: 409036363
Flag: com.android.systemui.shared.cursor_hot_corner
Test: OverviewCommandHelperTest
Change-Id: I7bab39adb0c933e16ac222fafc8be3f60fe36cc1
2025-04-15 15:08:54 +01:00
Steven Ng
8cb1ae879b Use SysUi focus display ID as the source of truth
For key gesture events received in SysUi & Launcher, we will use the SysUi tracked display Id as the source of truth.
The KeyGestureHandler mechanism will be kept because it has less redirection compare to the existing pipeline.

Bug: 406452076
Test: atest NexusLauncherTests:QuickstepKeyGestureEventsHandlerTest
Test: atest NexusLauncherTests:AllAppsActionManagerTest
Test: atest NexusLauncherOutOfProcTests:com.google.android.apps.nexuslauncher.TaplTestsNexus
Test: Verfiy manually that meta key event triggered all apps if the display focused is the default display.
Flag: com.android.window.flags.enable_key_gesture_handler_for_recents
Change-Id: I032a44b903e4e49e85c2a40a1e0bdc49ef8d86b0
2025-04-15 12:51:05 +01:00
Treehugger Robot
bb2b582e7f Merge "Injrect WindowContext into RecentsWindowManager" into main 2025-04-15 02:22:07 -07:00
Treehugger Robot
20db2b67c2 Merge "Fix addDeskButton visibility for quick switch home" into main 2025-04-14 19:51:51 -07:00
Saumya Prakash
ebfcad524b Remove the skip button from the gesture tutorial
This change removes the legacy skip button from the gesture tutorial. It
is not needed in the current version of the gesture tutorial.

Bug: 400485351
Test: Run tutorial and observe no change as this was for the legacy
tutorial that is no longer in use.
Flag: EXEMPT bugfix

Change-Id: Ice384a0b5811fdc0d09da58ade68539aa146d84d
2025-04-14 23:35:10 +00:00
Randy Pfohl
72e980e116 Merge changes I3054ef81,If90b1f98 into main
* changes:
  fixing splitview issue not receiving callback in recents in window
  Moving RecentsWindowManager away from taskstackchangelistener
2025-04-14 16:08:15 -07:00
Suhua Lei
a9f1bd967d Fix addDeskButton visibility for quick switch home
Bug: 409575334
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: quick switch home
Change-Id: Ia6f47c2db3bbcffe41ea53fa0160c839ff45611f
2025-04-14 23:05:29 +00:00
Treehugger Robot
f3f945ed16 Merge "Clean up fully rolled out flag enable_additional_home_animations" into main 2025-04-14 15:40:20 -07:00
Treehugger Robot
70901445dc Merge "Use DesktopExperienceFlags for freeform display taskbar" into main 2025-04-14 15:18:38 -07:00
Vinit Nayak
f5aa8582c0 Consolidate how we're cleaning up from split in recents
Test: Launched fullscreen from first split selected app,
seems fine
Flag: EXEMPT bugfix
Bug: 292269949

Change-Id: Ide2d64e5e15485f8bc2ba4accd1363db7bc0833c
2025-04-14 20:01:19 +00:00
Randy Pfohl
b0487db434 fixing splitview issue not receiving callback in recents in window
Test: Built and ran locally. Verified cycling back to default state.

Flag: com.android.launcher3.enable_fallback_overview_in_window
      com.android.launcher3.enable_launcher_overview_in_window

Bug: 292269949

Change-Id: I3054ef815baf1a852c365a07cad5e66a168f88c5
2025-04-14 18:27:41 +00:00
Randy Pfohl
6abaca4e03 Moving RecentsWindowManager away from taskstackchangelistener
Test: Built and ran locally, tested against various cases, verified with
logs

Flag: com.android.launcher3.enable_fallback_overview_in_window
      com.android.launcher3.enable_launcher_overview_in_window

Bug: 292269949

Change-Id: If90b1f98ad18286fa0c9b9625077237823197967
2025-04-14 18:27:41 +00:00