Commit Graph

5990 Commits

Author SHA1 Message Date
Tracy Zhou
f9fafe7a92 Merge "Fix ime switcher not showing for 3-button nav" into tm-qpr-dev 2022-06-25 06:36:39 +00:00
TreeHugger Robot
ce12869fad Merge "Treat all apps predictions as all app icons when animating icons to their original position" into tm-qpr-dev 2022-06-25 06:33:16 +00:00
Schneider Victor-tulias
a36e5f13c0 Treat all apps predictions as all app icons when animating icons to their original position
Taskbar all apps predictions were being ignored when animating a cancelled drag to their original position. This was causing a null pointer since they no longer had a view parent that could be used. These icons will now animated to the taskbar all apps icon.

Fixes: 236669335
Test: cancelled drags of taskbar icons, predicted taskbar icons, taskbar all apps icons and taskbar all apps prediction icons
Change-Id: I2a9a1ed4120927a08b8c8341ad36dfdb95fef608
2022-06-24 12:22:04 -07:00
Tracy Zhou
804feb76e7 Fix ime switcher not showing for 3-button nav
Bug: 226489759
Test: connect to a physical keyboard in 3 button nav and make sure the ime switcher shows
Change-Id: Iabde149e8bcd1edacff8e039f956628c69341ecb
2022-06-24 11:17:40 -07:00
Luca Zuccarini
4a0129fa5f Merge "Unify the source of truth for NORMAL <> ALL_APPS transitions." into tm-qpr-dev 2022-06-24 10:25:49 +00:00
Alex Chau
f7526085a9 Merge "Check null before getting DeviceProfile in AbsSwipeUpHandler" into tm-qpr-dev 2022-06-24 10:05:27 +00:00
Sunny Goyal
c3a5c4b16e Merge "Fixing wrong flags used by AllAppsController in SystemUiController" into tm-qpr-dev 2022-06-23 22:52:11 +00:00
Schneider Victor-tulias
2df19a2345 Merge "Fix a potential null-pointer onActivityDestroyed" into tm-qpr-dev 2022-06-23 18:29:09 +00:00
Alex Chau
7ba6cadf27 Check null before getting DeviceProfile in AbsSwipeUpHandler
Fix: 236677962
Test: manual
Change-Id: Ibf3dbc6db509a54c87dc4bd64a7c7ea213870708
2022-06-23 12:05:42 +01:00
Sunny Goyal
24b441051e Fixing wrong flags used by AllAppsController in SystemUiController
Bug: 236857339
Test: Verified the UI manually
Change-Id: I2773837932ed50a59ebc9d2810f9e7ee501b6f6b
2022-06-22 12:09:22 -07:00
Alex Chau
7356c13760 Merge "Revert "Finish recents animation on activity destroyed."" into tm-dev am: ed2e7719cb am: 90abf51d5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19015866

Change-Id: I3d68a995880a27c953164e2d4767f63ab38b0bfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-22 12:39:41 +00:00
Alex Chau
ed2e7719cb Merge "Revert "Finish recents animation on activity destroyed."" into tm-dev 2022-06-22 11:59:31 +00:00
Sunny Goyal
506165689f Revert "Finish recents animation on activity destroyed."
This reverts commit 0fd3b13d01.

Reason for revert: b/236514960
Bug: 228137694
Bug: 230373809

Change-Id: Ifed5f2a13fda4409982d548e3212bd16c81b63bc
2022-06-22 11:59:13 +00:00
Schneider Victor-tulias
6c71fe71bd Merge "Fix taskbar unstash animation delay when launching a split task." into tm-qpr-dev 2022-06-21 19:38:46 +00:00
Schneider Victor-tulias
bfde6b2e5d Fix a potential null-pointer onActivityDestroyed
Fixes: 234082544
Test: started recents from a large screen and phone
Change-Id: I54ee93793ec146d1b0b0f00f23256aaca5975bc0
2022-06-21 12:34:02 -07:00
Schneider Victor-tulias
dfadafe45b Fix All set activity not drawing on initial swipe. am: 4d18da78c0 am: 3a126d78a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18930603

Change-Id: Ie74ad15bc52082615cabced4f86c33e69de9560c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-20 08:10:49 +00:00
Schneider Victor-tulias
4d18da78c0 Fix All set activity not drawing on initial swipe.
The launcher was not properly preloading upon launching the All Set Activity. The Launcher would only start loading once the user started swiping up. This would stop the all set activity from drawing.

Test: Factory reset with a restore and tested the all set page.
Fixes: 234536107
Change-Id: I6bcb805ea6c43fb993f2b57499444ea62bcc37e1
2022-06-16 20:38:24 +00:00
Luca Zuccarini
c703f3a3e0 Unify the source of truth for NORMAL <> ALL_APPS transitions.
Bug: 231682175
Bug: 234812580
Test: manual
Change-Id: I5b66735474915d7a59bda337f67df37ff397908a
2022-06-16 16:40:26 +00:00
Tony Wickham
d100f6825f Merge "Clear MotionPauseDetector onRecentsAnimationCanceled()" into tm-dev am: 9d5f64adf1 am: 1cba5f9d47
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18914942

Change-Id: Ib76e6458f71282ebb7753db8c4ea9b671fb0fa19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-16 15:28:03 +00:00
Tony Wickham
9d5f64adf1 Merge "Clear MotionPauseDetector onRecentsAnimationCanceled()" into tm-dev 2022-06-16 14:55:48 +00:00
Alex Chau
ccc55f1668 Merge "Detect force visible nav bar based on kids mode." into tm-qpr-dev 2022-06-16 13:55:14 +00:00
Schneider Victor-tulias
e164995f9e Fix taskbar unstash animation delay when launching a split task.
Fixes: 232033354
Test: switched between split and unsplit tasks using 3 button nav and gesture nav
Change-Id: I9a4e2eb08e9970540093e3dc60b64a372be2052f
2022-06-15 14:55:37 -07:00
Alex Chau
c1d26448c5 Animate inline QSB between home and apps
- Added a QSB to taskbar to be animated between inline QSB and taskbar
- Passed endValue of taskbar animator to TaskbarController to have aniamtion variation between home -> app and app -> home
- Tuned duartion of taskbar animation and also stagger animation when taskbar is present
- Disabled scaling down of taskbar and inline QSB for home -> app
- Disabled stagger animation of taskbar and inline QSB for app -> home

Bug: 220733187
Test: manual
Change-Id: I4aac0bbc343b992a0472298595770e2bf2a55990
2022-06-15 22:12:29 +01:00
Tony Wickham
a379435d04 Clear MotionPauseDetector onRecentsAnimationCanceled()
Fixes: 234022857
Test: Open ImCapture and swipe up to home; repeat 20 times and ensure never see empty overview tasks over launcher
Change-Id: Icef6d7a54000e1e21453feeae7e207679077b772
2022-06-15 11:59:59 -07:00
Pat Manning
c773d7cdc8 Detect force visible nav bar based on kids mode.
WM was changed to use NAV_BAR_KIDS_MODE instead of NAV_BAR_FORCE_VISIBLE, this needs to update to match.

Fix: 229580780
Test: manual.
Change-Id: I38fb23dcc85676593a3f8f0851676bc526802d2e
2022-06-15 15:03:52 +01:00
Winson Chung
4d5ce7c16c Merge "Snap to running task if it's offscreen when back is invoked" into tm-dev am: 7d54b06c29 am: 43f3398d25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18897728

Change-Id: Iaf6037519f6985c44d6198bc772f3a6ef375b87f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 04:23:50 +00:00
Winson Chung
7d54b06c29 Merge "Snap to running task if it's offscreen when back is invoked" into tm-dev 2022-06-15 03:30:16 +00:00
TreeHugger Robot
ec8a85099e Merge "Prevent showing divider if launcher was never shown" into tm-qpr-dev 2022-06-15 03:29:21 +00:00
Tracy Zhou
51ceb5f200 Merge "Fix "software rendering doesn't support hardware bitmaps" from task bar all apps" into tm-qpr-dev 2022-06-14 22:08:05 +00:00
Winson Chung
2345fee566 Snap to running task if it's offscreen when back is invoked
- If the user has scrolled the running task offscreen, then
  snap back to the task if back is invoked.

Bug: 233952141
Test: Swipe to overview, scroll away from the current task
      and then go back
Change-Id: Icc5040d4b38c97e0329f937e24bd517a71a32f13
2022-06-14 21:20:05 +00:00
Tracy Zhou
844efbaa75 Merge "Use withLayer for live tile layering" into tm-qpr-dev 2022-06-14 18:12:03 +00:00
Winson Chung
519882d21f Merge "Updating call to match change in interface" into tm-dev am: baf27c1b5b am: c692e966c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18800135

Change-Id: I3480d7b9671b059abda4c391abb67fe8e50d7bdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-14 16:52:30 +00:00
Winson Chung
baf27c1b5b Merge "Updating call to match change in interface" into tm-dev 2022-06-14 13:56:10 +00:00
Schneider Victor-tulias
3bc7b93ea5 Merge "Forcefully move focused task to front when triggering the recents animation in 3-button nav" into tm-qpr-dev 2022-06-13 18:17:56 +00:00
Yunfan Chen
04d206b675 Merge "Modify the way of providing insets per WM change" into tm-qpr-dev 2022-06-13 11:38:14 +00:00
Tracy Zhou
b93f59719a Fix "software rendering doesn't support hardware bitmaps" from task bar all apps
The issue is that there is a delay between when the task bar all apps view is removed and another task bar dispatching draw of an all apps icon. When the window is removed, isHardwareAcceleration() returns false, causing the crash.

This crash further restarts launcher, causing launcher to be in the wrong state for a number of things. And hence, this fix should make all the other crashes moot.

Fixes: 234617317
Test: Keep dragging all apps icons to split
Change-Id: Ifc272d82c1deac8485801473919602563bb3caf0
2022-06-13 05:21:36 +00:00
Hongwei Wang
bf8528c21b Merge "Call setCanAffectSystemUiFlags(false) only for PiP" into tm-qpr-dev 2022-06-10 21:51:14 +00:00
Schneider Victor-tulias
920a86969a Forcefully move focused task to front when triggering the recents animation in 3-button nav
Quickly tapping the recents button can start a recents animation while a quick switch is running. This causes the the wrong page index to be used as the focused task index.

Test: manual on large screen
Fixes: 227562351
Change-Id: If99f74477e52ed0c7f7c5fd7b3dc8b201627068b
2022-06-10 20:11:18 +00:00
Tracy Zhou
92b49faa79 Use withLayer for live tile layering
Bug: 233007237
Test: make sure live tile ordering in overview is correct
Change-Id: I239949878634ff9a46975e7e6b92dc3be797ea88
2022-06-10 00:08:24 +00:00
TreeHugger Robot
adc7347719 Merge "Add grid_x field to DeviceSearchResultContainer." into tm-dev am: a37556ae5c am: 40ad40ed49
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18722495

Change-Id: I541a82b41bf5d4ae92c9cd9146271c73a03b19d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 23:12:50 +00:00
TreeHugger Robot
a37556ae5c Merge "Add grid_x field to DeviceSearchResultContainer." into tm-dev 2022-06-09 22:30:17 +00:00
Tracy Zhou
c3ba24f06e Merge "Patch npe in TaskbarAllAppsController" into tm-qpr-dev 2022-06-09 22:12:08 +00:00
Hongwei Wang
40f049bcb4 Merge "Do not attempt auto-enter-pip if there is no valid leash" into tm-qpr-dev 2022-06-09 19:55:45 +00:00
Tracy Zhou
2583fb48b8 Patch npe in TaskbarAllAppsController
b/234617317#comment3

Bug: 234617317
Test: manual
Change-Id: I7cff0df86db4fdf58b33240594784598950f1a88
2022-06-09 19:22:31 +00:00
Hongwei Wang
24aeafaef1 Call setCanAffectSystemUiFlags(false) only for PiP
It was too aggressive to call that in all cases including swipe
split-screen to home.

Video: http://recall/-/b1EZhgUkQcpML5OwZekLBN/dlG6qSf9pT2f4YlIe2Klb3
Video: http://recall/-/b1EZhgUkQcpML5OwZekLBN/cfXwlpol5vi2AER32rKu2x
Bug: 213598210
Test: 1. follow the reproduce steps in the bug. \
      2. make sure PiP from split-screen has no regressions. \
      see also the videos.
Change-Id: I33d71294595729f8cdf72258c4d45c29a77935c2
2022-06-09 12:10:38 -07:00
Alex Chau
1965e1309c Merge "Use DISPLAY_CATEGORY_ALL_INCLUDING_DISABLED for getDisplays" into tm-dev 2022-06-09 17:40:07 +00:00
Hongwei Wang
1cd4162b82 Do not attempt auto-enter-pip if there is no valid leash
No reproduce path for the bug being reported, this fix is to ensure we
do not start the auto-enter-pip animation with invalid leash at the
first place.

Bug: 234796719
Test: N/A for the bug, verify the normal auto-enter-pip still works
Change-Id: I6f2164a322877f1b0213a1ee09eb476090300c7f
2022-06-09 10:27:18 -07:00
TreeHugger Robot
e9f606f995 Merge "Hide taskbar while VoiceInteractionWindow is visible" into tm-qpr-dev 2022-06-09 16:55:38 +00:00
Alex Chau
cbde3a3a8d Merge "Use normalized CachedDisplayInfo as key" into tm-qpr-dev 2022-06-09 15:10:27 +00:00
Alex Chau
2545e92264 Use DISPLAY_CATEGORY_ALL_INCLUDING_DISABLED for getDisplays
Bug: 227459045
Bug: 221071695
Test: manual
Change-Id: I8c1587e05a30abf75a01a84ebda6522606abb99b
2022-06-09 12:12:57 +00:00