Commit Graph

408 Commits

Author SHA1 Message Date
Shamali P
c5fbb42dcb Add a default widget category provider that uses application category.
The category provider can be customized by any launcher via resource
override. For instance, one can override it to provide custom categories
using an allowlist or use a different mechanism such as query play
services.

We still need to get proper strings for categories from UX writer.

Bug: 318410881
Test: WidgetRecommendationCategoryProviderTest
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: I5c4e0d22eaffc8254ddd54356f8c62f00e22a3c4
2024-01-31 00:43:22 +00:00
Holly Jiuyu Sun
e5d943e848 Merge "[PS] Update resource files to include round background." into main 2024-01-24 03:53:28 +00:00
Sunny Goyal
e0c1649d87 Cleaning up some unused notifications functionality
Bug: 321154530
Test: Presubmit
Flag: N/A
Change-Id: I1ff2a4f19595659d89e7d72ee1b29036bbd54d8f
2024-01-19 00:21:02 -08:00
Holly Sun
22dd6a5435 [PS] Update resource files to include round background.
Bug: 19531436
Test: manual
Flag: aconfig enable_inject_private_space_tile teamfood
Change-Id: I287d5cb1c613419035b5b2e4da7c64f897de7c23
2024-01-16 16:37:41 -08:00
Anushree Ganjam
5e9b71e055 Add "Don't suggest app" shortcut to suggested apps.
This works for suggested apps in both Home and AA+. When enable_shortcut_dont_suggest_app is true, the secondary drop target "Don't Suggest app" is removed instead "Don't suggest app" is added to shortcuts.

Video: https://b.corp.google.com/issues/319250810#comment5

Home: https://screenshot.googleplex.com/d7Wts48X6EmFAYg.png
Private space app suggested: https://screenshot.googleplex.com/BukzCRTvkzbpwQ3.png

AA+: https://screenshot.googleplex.com/ADMCHnQ378jvJEE.png
Private space app suggested : https://screenshot.googleplex.com/AYga8Km3646AqMt.png

Bug: 319250810
Flag: aconfig com.android.launcher.enable_shortcut_dont_suggest_app DEVELOPMENT
Test: Manual.

Change-Id: Ia7df749a1c7d806bd9d74124be138384c3050119
2024-01-12 10:33:24 -08:00
Anna Zhuravleva
eb1966c278 Merge "Add shortcut to install an app to Private space" into main 2024-01-12 15:51:05 +00:00
Anna Zhuravleva
29a3139815 Add shortcut to install an app to Private space
Introduce long-press shortcut to install a copy
of the main user app to private space.

Test: manual, installed apps in different stores
and tried shortcut
https://screenshot.googleplex.com/6oAVamTytiYmvPC.png
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT

Change-Id: I702cd2a27388e3cc6e9e126308d5479836ba6655
2024-01-11 12:40:28 +00:00
Holly Sun
97b1bba413 Implement Install Apps button in Private Space.
UX mock: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?node-id=7246%3A83750&mode=dev
UX icon spec: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=19979-224329&mode=design&t=50SDFdomAtonNU4V-0

Video: https://drive.google.com/file/d/1VtTzxR46dLiaozOo6sOHADv1qTcBOwDP/view?usp=sharing
Screenshot:
https://screenshot.googleplex.com/3ShcUozVrkGMHbc
https://screenshot.googleplex.com/3F4c3yzJ7RUpma7

Reason to use PrivateSpaceInstallAppButtonInfo: reuse `VIEW_TYPE_ICON`, which needs an AppInfo.

Bug: 308064949
Test: manual
Flag: ACONFIG com.android.launcher3.private_space_app_installer_button development
Change-Id: I3fb27fae8324d4b276816b17f9b0a2d9b6f33ed2
2024-01-10 14:28:33 -08:00
Sunny Goyal
f7e7843a2b Merge "Removing unused title change logic in settings" into main 2023-11-17 18:18:08 +00:00
Sunny Goyal
2e005e1e28 Removing unused title change logic in settings
Bug: 305084752
Test: Manual
Flag: N/A
Change-Id: I93e8a58c579223d5892528a47cff5bcafd69dbf1
2023-11-16 12:54:19 -08:00
Himanshu Gupta
08badb3f6f Adding Private Space views to Launcher.
This CL adds the following:
* Static View Elements to be added to AllApps recycler View
* View Controller to load the above elements dynamically
* Private Space Section Decorator
* PrivateProfile Manager containing the logic related to Private Space
* Abstract UserProfileManager as the super class of Work/Private
ProfileManager

Private Space Views Figma
[link](https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=14535-111985&mode=design&t=JLz9W0O551TpzQYH-0)

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I8aa4247c78064a551e5e0d0b46d3fc033873f99d
2023-11-14 11:58:16 +00:00
Liran Binyamin
78f444bdad Adds content description to the overflow bubble.
Flag: LEGACY persist.wm.debug.bubble_bar DISABLED
Bug: 273994695
Test: SystemUIMicrobenchmark:android.platform.test.scenario.sysui.bubble.BubbleBarTest

Change-Id: Ie3fe451c69a39560aa91a6dfd4d615f172cf3299
2023-10-19 14:00:41 -04:00
Holly Jiuyu Sun
6b47dccd73 Merge "[PS] Add private space icon and strings." into main 2023-10-17 22:16:16 +00:00
Holly Sun
6ec3d23a4b [PS] Add private space icon and strings.
Bug: 298227797
Test: manual and unit
Flag: inject_private_space_tile
Change-Id: Ic7ec649ac69f02a82a6ee0b4e63262d8ad3e0916
2023-10-13 12:29:19 -07:00
Jeremy Sim
9d6dbd0a8d App Pairs: Implement app pairs icon
[App Pairs 5/?]

This patch implements the app pairs icon, which displays the two member apps and rotates with the device.

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274835596
Test: Manual
Change-Id: I07085339d1e2d28f004c1661f0948c59e605c76a
2023-10-06 18:57:09 -07:00
Jeremy Sim
6ac8949fc4 App Pairs: App pairs now save with automatic default name and custom split ratios
[App Pairs 4/?]

This patch includes:
- Ability to save and launch app pairs with custom 0.3, 0.7, or 0.5 split ratios
- App pairs now save with default name "App1 | App2"
- Grid migration, prediction, and other misc. flows should now work with app pairs

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: AppPairsControllerTest.java
Change-Id: I46dd3e30f8de03dd3e6d086c8ff9fc52e7e7fd2b
2023-10-03 10:38:03 -07:00
Brandon Dayauon
602c43e90b Add maxWidth to pause work app button and ellipsize at the end
Width of text given by UX is 214dp so we can set the maxWidth and ellipsize at the end.

Bug: 298447370
Test: Manual photo: https://screenshot.googleplex.com/98Jnuh3TmLCtd24
Flag: n/a
Change-Id: I750a1669f94f22f60f4fb22db7d6b0ed7678c506
2023-09-27 16:23:07 +00:00
Sunny Goyal
6773667e34 Revert "Revert "Adding main thread binder tracing in development..."
Revert submission 23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Reason for revert: Fixed broken build
Reverted changes: /q/submissionid:23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Change-Id: I3e130a780b8641c4a17a5cdf799513f2ba08b16e
2023-06-02 18:14:35 -07:00
Santiago Aboy Solanes
ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Sunny Goyal
3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
Marcello Galhardo
4b7b7f1cfa Add custom widget category for Note Taking
Test: manual
Flag: not needed

Fixes: b/261853771
Change-Id: I493fd782cf8569ee9efca5134eefb5652a2bf972
2023-04-24 17:09:31 +00:00
fbaron
6847c9f113 Add entry point for home gardening
Bug: 277817921
Test: Turn on flag MULTI_SELECT_EDIT_MODE and verify that a new button shows up that says "Edit Home Screen"
Change-Id: Ic8027ab80604faf5bdc63a44319ecffc047a495c
2023-04-12 09:31:28 -07:00
Sunny Goyal
84b48d8deb Removing support for adding legacy shortcuts.
All existing legacy shortcuts will be migrated one-time to deep shortcuts
This shortcuts are pinned under the Launcher package, with custom badging

Bug: 275875209
Test: Updated unit tests
Flag: N/A
Change-Id: I7da001f724776ad8d6c807517b7e4e259de626c2
2023-04-10 12:28:52 -07:00
Jeremy Sim
9f0a6b8e82 App Pairs (behind flag): Add Overview menu item, icon, tests
This is the first of several patches implementing the App Pairs feature behind a flag.

This patch includes:
- The icon asset for the "Save app pair" menu option
- The menu option, which will appear in the Overview drop-down menu for split pairs
- Some tests ensuring that the menu item appears when appropriate

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: 2 tests in TaplTestsSplitscreen.java
Change-Id: I174f2c66e7eb6d83ff7fe501eb82cc48e727022c
2023-03-31 17:16:56 -07:00
Liahav Eitan
6b67ef6391 Merge "Update strings when work apps are paused" 2023-02-15 20:54:54 +00:00
Anthony Alridge
edd886b550 Update strings when work apps are paused
Test: Manually tested - screenshots in bug
Change-Id: I0b7b633f1eb71829752c991018e7c260f22d8cbb
Bug: 258628706
2023-02-14 23:52:35 +00:00
Federico Baron
4b1a38bb7d Implement two pane widget picker
The widget picker design is currently not optimized for large screen form factor devices.
We resolve that by adding a two pane widget picker like that of the design in go/widget-picker-2023.

Bug: 256684299
Test: Make sure to be on a tablet in landscape mode.
        1.Turn on flag LARGE_SCREEN_WIDGET_PICKER.
        2. Press and hold on an empty spot in workspace until the popup menu appears.
        3. Click widgets.
        4. Notice the new two pane layout
Change-Id: Ia3ea17dc320f72f9bc5dea52399ff51d9161602b
2023-02-09 16:36:45 -08:00
Vinit Nayak
5a6863f14a Unify split options into single option
* No more split left/right/top, only have
splitscreen and icon shows vertical or horizontal
split windows
* Replace existing split icon for FreeForm

Fixes: 264930810
Test: Tested landscape and portrait, workspace,
overview, allapps

Change-Id: I443f93b6b01760b726bf9f024fb1324fdf0ed03c
2023-02-01 17:27:57 -08:00
Sunny Goyal
af95ddbadc Fixing search behavior in Launcher3
> Showing no-result found only when there are no results
> Removing unnecessary view inflation in RecyclerViewPool for
  various search vide types
> Removing unused market-search link and no-empty-result illustration

Bug: 240343082
Bug: 207573083
Test: Verified Launcher3
Change-Id: Ia44799cd2385ea5dc837ef25732ca237975abde7
2022-07-28 22:05:30 -07:00
Sebastian Franco
930531f669 Make Talkback anounce which page is the icon being move on.
Adding a third argument for the talkback string.

Fix: 230593493
Test: Move an item using Talkback and it should mention the row,
column and page where you can drop the item.

Change-Id: Id3d4435e9ef3348278643e6e2a1cd1e8bf5157b7
2022-06-22 17:17:38 -07:00
Brandon Dayauon
303b4e8aae Fix issue when preference screen title won't change depending on the device..
previously it defaults to just "Search your phone"
Now it correctly displays Phone/Tablet

Before: https://screenshot.googleplex.com/3PJrsP9mGvwMr98
After: https://screenshot.googleplex.com/B2nnUQHeHmEXXPd

Bug: 231611501
Change-Id: I49eab7e827ce4bb31a2722fbf21c244f98145907
2022-05-16 10:25:12 -07:00
TreeHugger Robot
566c676dda Merge "Add Developer Options string to xml." into tm-dev 2022-05-12 14:49:49 +00:00
Brandon Dayauon
e5142c5c53 changed name and dimensions of work_mode_toggle button, changed outline to surface for the (x) icon..
Fixed padding issue (tightness) between Personal/WorkTabs/EduDialog
Aligned Work Toggle button to be the same with the workTabs/eduCard
raised button up 20dp to align with specs

Fixed issue where allApps apps invade the tabs. Fixed RTL issues where it wasn't going RTL.
Fixed RTL issue for the workfab button where there was no margin on the left side of the button
Added DeviceProfile to constructor

Bug: 200810328
Bug: 224731300
Test:
	Before: https://screenshot.googleplex.com/6sRgNZQz4wKYn5n
	After: https://screenshot.googleplex.com/8hBLyDiMbMH9tn2
	After(showingLayoutBounds): https://screenshot.googleplex.com/MuVUXCegukAMzSr

Change-Id: Ibac3f5b8fe7d877c2f54a2c87f4393c1a91dc806
2022-05-06 09:52:05 -07:00
Jon Miranda
f020447a47 Add Developer Options string to xml.
Bug: 228178703
Test: manual
Change-Id: Ib633d324709a17551cbf093c5e6f3195c51ddba7
2022-04-19 11:42:01 -07:00
Sihua Ma
da8759ae29 Showing alert dialog when shortcut version higher than the App
Creating an AlertDialog when the disabled reason of the shortcut is DISABLED_REASON_VERSION_LOWER, which happens when the backed-up shortcut was created from an application that has a version higher than the one installed on the device. The AlertDialog will direct the user to the play store and update the application.

Test: Manual
Fix: 224796975
Change-Id: I0125fada60b48176775de6782ba03ee6790904aa
2022-04-14 01:34:44 -07:00
Steven Ng
120e48b40c Remove unnecessary offset from the app label ICU string
Test: Enable talk back, focus on an app icon that has one notification.
      Talk back announced the number of notification correctly.
Fix: 227131579

Change-Id: I80c21bab27c6cc6813a1ca0e51b702db34d58424
2022-03-30 16:45:48 +01:00
Brandon Dayauon
85a6bab0dc Change Home screen to 'home screen' when it's in middle of a sentence
Test: Manual - Tested on local pixel device
Bug: 224967365
Change-Id: I37365167b0be6d654735d46c4a070b926e828f8e
2022-03-18 14:59:31 -07:00
Vinit Nayak
f957244b88 Show multiple App Info A11y options for split app icons
* AccessibilityNode actions are required to have a
unique resourceId to show as an action in A11y dialog.
For now, only AppInfo option is shown for each app in split,
but moving forward we'll need to add resourceIDs for
each option that can show up for either app.

Fixes: 200609838
Test: Saw multiple options for App Info for each app
come up in talkback mode

Change-Id: I92b349347354ac639537021d775eea814c866a0e
2021-11-18 23:22:46 -08:00
Vinit Nayak
14ed91fb5b Update Split Overview menu strings
Bug: 181704764
Change-Id: Icaf51a702d529e20a0e65c4708fc7bc833e5eeeb
2021-11-11 11:20:04 -08:00
Brian Isganitis
a518fcebe7 Decrease character limit for "Home settings" to 20.
Test: No
Bug: 194892641
Change-Id: I249c270970242cd64a7f2c1c376ffd76c5848ef6
2021-10-28 12:30:08 -04:00
sfufa@google.com
7a620d3673 [Search] Hide A-Z list when search is entered from QSB
preview attached to bug report

Bug: 201781284
Test: manual
Change-Id: I572360d2d49b38577a7d77115aede4c3269d42e9
2021-10-15 15:49:43 -07:00
Steven Ng
29f46c9628 Add a new string for widget configuration drop target
Test: manual. See screenshot in b/201286923
Fix: 201286923
Change-Id: I5be4f723523befe359b922273d11f57fb9f0b3fd
2021-09-29 12:15:07 +01:00
Steven Ng
707b118184 Use ICU to format plural strings
Test: manual
Fix: 199230208
Change-Id: I0b6fe9f8bb134a1479117c832575c63da2a07794
2021-09-17 22:44:06 +01:00
Samuel Fufa
564e9ca223 [Work] Fix work apps showing in personal tab
The problem here is that we are tracking hasWorkApps and usingTabs using the same value.
 This leads to work/personal apps showing together when clearing search since mUsingTabs is overridden to false on setLastSearchQuery and later used to determine if tabs should show.
Bug: 198546279
Test: Manual

Change-Id: I7df5d65472703bedcc9dd688847d9ebd146d5f61
2021-09-08 15:02:24 -07:00
Alina Zaidi
dfa2752d28 Add accessibility announcement when user clicks on 'Add automatically to
home screen' button

Test: Tested manually with talkback on
Bug: 192808036
Bug: 192811245
Change-Id: I1c02738e0e4755b3bbdde12dad96ac2ed1996e6c
2021-07-12 15:37:13 +01:00
Steven Ng
85486d1c2c Set the widget preview title a11y text to "{widget name} widget"
Fix: 187376680
Test: Manual
Change-Id: I211d8e2b437091808d1f5a764075af4c3832ef48
2021-06-29 12:12:43 +01:00
Alina Zaidi
b7e15cf3b3 Merge "Update string for no room on this Home screen toast." into sc-dev 2021-06-23 20:15:52 +00:00
Samuel Fufa
ce820f51e2 Polish work for work profile
Bug: 191478900 Work profile toggle specs
Bug: 187761192 Fix issue where Installing app scrolling apps to top
Bug: 191121890	Fix issue where top of AllApps becomes empty when returning to AllApps
Bug: 191477329 String change for work profile paused state
Test: local
Change-Id: Idbaab333566b54afa3dc879f5bea98e1f77c44fc
2021-06-23 16:46:52 +00:00
Alina Zaidi
95d6df3647 Update string for no room on this Home screen toast.
Bug: 191852136
Test: Tested manually to check that the toast has updated string.
Change-Id: I28f73eda17fdc49dee18e4f8be89224f04471697
2021-06-23 17:15:29 +01:00
Alina Zaidi
267e9b0c04 Rename strings for no search results and no widgets in widget picker.
Also update text size and font.

Bug: 191732424
Test: Not needed, minor string change
Change-Id: I90f00f1316524c48520c4cfc265ab2d5e78e3281
2021-06-22 16:14:59 +01:00