Commit Graph

632 Commits

Author SHA1 Message Date
Shamali Patwa
e66a001ed6 Merge "Fix the horizontal margins on the left panel in the two pane picker." into main 2024-02-02 21:16:55 +00:00
Shamali P
5e855d7912 Fix the horizontal margins on the left panel in the two pane picker.
The recycler view when displayed in single pane picker, for large screen
gets a larger padding. But when displayed in two pane picker, it is not
needed - so we override it.

Foldable's unfolded portrait doesn't seem to have screenshot test
- will look into if we can add one in follow up.

Bug: 322719955
Test: Screenshot test for existing modes & manual (see bug)
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT

Change-Id: Ibd72146e7e5230eec0d2ce01c3917819a73d8f32
2024-02-02 18:20:38 +00:00
Fengjiang Li
2aaccefecb Merge changes I471c27b8,I602cf29b into main
* changes:
  Fix small gap between widget resize frame and widget background.
  Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
2024-02-02 03:31:13 +00:00
Fengjiang Li
b9ba4b9813 Fix small gap between widget resize frame and widget background.
There is a 1dp gap on left/top/right/bottom between widget resize frame and widget background. Increasing the margin by 1dp will fill this gap.

Fix: 291104076
Test: See https://b.corp.google.com/issues/291104076#comment9
Flag: NONE
Change-Id: I471c27b8b5d59850a4bf342fc2d8fee50d6fd65d
2024-02-01 16:24:18 -08:00
Himanshu Gupta
0cc11dbcac Separating system and user-installed apps in PS container.
We add a horizontal line separator in PS container which demarcates
user-installed vs system installed apps in private space.
User-installed are shown above the separator, system ones below.

UX Mock: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?node-id=11546%3A310574&mode=dev
Mock Image: https://photos.app.goo.gl/Wj8sJkS7P7bRbovg8
Demo video: https://photos.app.goo.gl/MBw6HpDnf6PJqUfs8

Bug: 308054233
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Test: AlphabeticalAppsListTest
Change-Id: Iad8e289c49a05ac7ef1978bd8e4ebe7aa0add0ca
2024-01-26 11:04:13 +05:30
Brandon Dayauon
3dd0f12cad Increase predicted app row by 4dp to be same as SEARCH_RESULT_APP_ROW
Verified that there should be no jumping going on in the top app row between A-Z list and Toast.

bug: 312781931
Test: manual -video:
https://drive.google.com/file/d/11GX-5mVr5BoZY29IyX5FvrIA_yT57MOJ/view?usp=sharing
Flag: None

Change-Id: I5c35c04eb500f52780b0b77c542e0a861346a3fd
2024-01-05 17:09:23 -08:00
Fengjiang Li
772675ed11 Merge "Revert "Fix small gap between widget resize frame and widget background."" into main 2024-01-03 00:51:44 +00:00
Fengjiang Li
e81f4b8dc5 Revert "Fix small gap between widget resize frame and widget background."
This reverts commit 1e6bbf368b.

Reason for revert: b/317375712 TAPL is failing

Change-Id: Ib6b200f99c9feb7986ffca50015c02f3e558fc84
2024-01-02 23:00:03 +00:00
Tracy Zhou
5ad10ff6f6 Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification
In nav bar, we assign layout weight 0.25:0.5:1(for home but the content width of home is set to 80dp):0.5:0.25 with a LinearLayout. Since we use a FrameLayout for taskbar (to support both folded and unfolded task bar), in this change we are matching the layout by manually calculating the width of each section (since we are already manipulating like so in different layoutters)

Bug: 230395757
Test: https://screenshot.googleplex.com/3P6vDrgb6geqTUm
Change-Id: I6ba201477621f173e42c5211fcc68b24e3022122
2024-01-02 14:34:51 -08:00
Brandon Dayauon
46884202f5 Merge "Fix padding between text and (x) icon in work profile card." into main 2023-12-21 22:25:41 +00:00
Fengjiang Li
1e6bbf368b Fix small gap between widget resize frame and widget background.
There is a 1dp gap on left/top/right/bottom between widget resize frame and widget background. Increasing the margin by 1dp will fill this gap.

Fix: 291104076
Test: See https://b.corp.google.com/issues/291104076#comment9
Flag: NA
Change-Id: I05143d76c98de7bbcfdca5cfacb21b3ace669861
2023-12-20 14:26:21 -08:00
Brandon Dayauon
6ac1d24876 Fix padding between text and (x) icon in work profile card.
- Simplified the .xml to just use linear layout and remove the extra relativelayout that was used for the button when it can just be a
Framelayout.

- Now according to spec https://www.figma.com/file/mf67dbMngw0a3aev2HTinD/Work-Profile-%26-Bluechip?type=design&node-id=2185-0&mode=design&t=n0pl6vP5rnSrTyyv-0
the additional padding is now included.

bug: 309120438
Test: Manual photos-
before: https://screenshot.googleplex.com/48kUpYCVQGYMwdm
after: https://screenshot.googleplex.com/AcisTmXQeZ3NT3C
Flag: None
Change-Id: I3c1850a20f49a2a4e809410b4aaef688ea9b3e2c
2023-12-18 13:37:16 -08:00
Helen Cheuk
9c0f738cdb Merge "Add focus outline to launcher" into main 2023-12-15 18:03:36 +00:00
helencheuk
b4626f4698 Add focus outline to launcher
Fix: 310953377
Test: TBC
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: Ie395ec74c8a4a13a68539ca7ec6496481d96b860
2023-12-15 16:56:31 +00:00
Tracy Zhou
9ccd5d4257 Introduce taskbar_phone_size
In small screen, we use 48dp for nav bar height, while it's 60dp for task bar.

Bug: 230395757
Test: manual
Change-Id: Ia7083a1b2246981466e1163404c63b645a6bf5b1
2023-12-13 00:38:15 -08:00
Brandon Dayauon
763e40d747 Move UnionDecorationHandler to Launcher
- Create base SectionDecorationInfo.java and RecyclerViewAnimationController.java
- SearchTransitionController now inherits from RecyclerViewAnimationController where RecyclerViewAnimationController will control
animation for private space

Bug: 299294792
Test: Verified SearchTransitionController didn't regress by turning off BACKGROUND_DRAWABLES flag.
- Verified QL highlight still works
- video: https://drive.google.com/file/d/15yjBWofebn6m7VgEnLK6kEYqhC_adJQ3/view?usp=sharing

Flag: None
Change-Id: If34f4bb199be0e113485279931d2927cb9fad397
2023-12-11 11:27:25 -08:00
fbaron
eee16c7ac5 Update widget picker two pane to support foldables
Bug: 301918659
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I5beecf4f8c46235f3e89c7bd8aed65fd292883ce
2023-12-06 12:48:24 -08:00
Pat Manning
f9e64bc0ce Merge "Revert^2 "Update cell drop visualizer radius"" into main 2023-12-04 11:06:00 +00:00
Pat Manning
27efab01f3 Revert^2 "Update cell drop visualizer radius"
This reverts commit 311afc6987.

Reason for revert: Resubmitting with updated screenshots

Change-Id: Ieb114c06376cf46b90b140490a54cbae592c8f5a
2023-12-01 13:56:26 +00:00
Uwais Ashraf
205d707579 Merge "Revert "Update cell drop visualizer radius"" into main 2023-12-01 10:16:29 +00:00
Uwais Ashraf
311afc6987 Revert "Update cell drop visualizer radius"
This reverts commit 77e0faa670.

Reason for revert: Causes a 100% failing test see b/314206230

Change-Id: Icfc5bb4bace17b630bfd74a1460f6d1748d8d9d3
2023-12-01 10:14:54 +00:00
Federico Baron
b89fde7a9a Merge "Update cell drop visualizer radius" into main 2023-11-30 20:07:47 +00:00
fbaron
77e0faa670 Update cell drop visualizer radius
Fix: 313665319
Test: NONE
Flag: NONE
Change-Id: I1a6ab76f2feb8175eca3af5fa62efa2cf8be01ba
2023-11-29 13:49:48 -08:00
Vinit Nayak
eabb37822f Merge "Change SplitInstructionsView cancel from X to "Cancel"" into main 2023-11-29 00:18:42 +00:00
Vinit Nayak
d6efde5cbb Change SplitInstructionsView cancel from X to "Cancel"
* Styling (accent color) is still a TODO,
just made it bold for now.

Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Bug: 295983387
Test: Tested w/ flag on and off, cancel doesn't show
with flag off

Change-Id: Id5214a86abbe0cf095e32f6f75522ea51d6b1f3c
2023-11-28 14:34:12 -08:00
Sunny Goyal
464509b375 Merging widget item click listener to default click listener
> Also removing check for dragHandle, since dragHandle is already removed

Bug: 307306823
Test: atest Launcher3Tests
Flag: N/A
Change-Id: I0b452dd1fbccf15ed686370471e8866b179fd77e
2023-11-28 12:07:16 -08:00
Pat Manning
d3f3308d12 Merge "Update Icon App Chip Menu to new specs." into main 2023-11-17 15:06:42 +00:00
Pat Manning
43c4b50c17 Update Icon App Chip Menu to new specs.
Fix: 304228083
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT

Change-Id: Ib018c7f59e1141b6f21618b28d411facc937ac7c
2023-11-16 18:18:48 +00:00
Himanshu Gupta
08badb3f6f Adding Private Space views to Launcher.
This CL adds the following:
* Static View Elements to be added to AllApps recycler View
* View Controller to load the above elements dynamically
* Private Space Section Decorator
* PrivateProfile Manager containing the logic related to Private Space
* Abstract UserProfileManager as the super class of Work/Private
ProfileManager

Private Space Views Figma
[link](https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=14535-111985&mode=design&t=JLz9W0O551TpzQYH-0)

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I8aa4247c78064a551e5e0d0b46d3fc033873f99d
2023-11-14 11:58:16 +00:00
Charlie Anderson
a2d85dec47 Fixing polish issues with the U app shortcut popup design
Test: locally verified against design
Flag: NONE
Bug: 304807548

Change-Id: Iff22b3515b638700fb66e856944ec4aa1287e401
2023-11-03 11:46:44 -04:00
Uwais Ashraf
aa7fa886d6 Add margins to top and bottom when grid only overview enabled
Fix: 299100244
Test: OverviewImageTest and dump tests
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I22ebced5bf1e27974036d6e2ef72d2b8d63df824
2023-10-24 16:15:39 +00:00
Pat Manning
5643e7c047 Increase pinned taskbar height to fit tooltips.
Fix: 305706286
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states TRUNKFOOD
Test: TaskbarHoverToolTipControllerTest

Change-Id: I767947a752eae7a928d59fe332bc62b9fd5b5f37
2023-10-23 15:52:48 +01:00
fbaron
80b0ce819c Cleanup SHOW_DOT_PAGINATION flag
Fix: 270395278
Flag: no flag
Test: verify everything still works the same
Change-Id: I803d9c22ac4c7040c47410b97cbdb2b11e33e8c9
2023-10-03 21:59:02 +00:00
Pat Manning
1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Brandon Dayauon
602c43e90b Add maxWidth to pause work app button and ellipsize at the end
Width of text given by UX is 214dp so we can set the maxWidth and ellipsize at the end.

Bug: 298447370
Test: Manual photo: https://screenshot.googleplex.com/98Jnuh3TmLCtd24
Flag: n/a
Change-Id: I750a1669f94f22f60f4fb22db7d6b0ed7678c506
2023-09-27 16:23:07 +00:00
Liran Binyamin
a833af316b Adjust the hotseat when the bubble bar becomes visible
When the bubble bar becomes visible the space between icons in the
hotseat is now adjusted. This change only does it when the QSB is
above the icons, but this will be changed in the future to be based
on the amount of space between the hotseat and the edge of the screen.

When the hotseat is adjusted, the new width is smaller by the size of
2 icons. The icons are then translated to be evenly spaced within the
boundaries of the new width.

Since the adjustment is only applied when the QSB is above the icons,
it is resized accordingly to the new width.

All visual updates currently snap to the new position, but will be animated
in a follow up.

Demo: https://recall.googleplex.com/projects/3391fc5c-599d-4827-b6f8-d2deb160aa99/sessions/fad1a5c5-e9cf-4586-92e4-1e92df3b002e

Bug: 280494203
Test: Manual (on tangor)
      - Set device to landscape
      - Make the bubble bar visible by adding a bubble
      - Rotate to portrait mode
      - Observe that the hotseat is adjusted
      - Rotate to landscape
      - Observe that the hotseat adjustment is removed
      - Rotate back to portrait
      - Observe that the hotseat is adjusted again
      - Dismiss the bubble to hide he bubble bar
      - Observe the hotseat adjustment is removed

Change-Id: I5b02a60b6cb301ffa2507a6d825c748a782cca18
2023-09-13 17:08:42 -04:00
Andy Wickham
bc3bac4113 Revert^3 "Change Overview Actions to round buttons."
Awaiting UX alignment.

Test: N/A
Flag: N/A
Change-Id: I05e9627d8b44ea16d29445e005534af2a1abd439
2023-08-08 12:09:59 -07:00
Andy Wickham
be8981442a Revert^2 "Change Overview Actions to round buttons."
f849f2856f

Fix: 293081298

Change-Id: Iaf1553770329ec3a6c6d8a2d9d81b60203e79ed8
2023-07-26 20:56:05 +00:00
Greg Kaiser
f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Andy Wickham
f98949cac3 Change Overview Actions to round buttons.
If floating search is active in Overview (flag enabled and we are
the active Launcher), these buttons will be aligned to the search
bar relative to the bottom of the screen. Otherwise, the buttons
will be aligned below the active task like before.

Demo for Launcher3 build:
https://drive.google.com/file/d/1fVzRRnW5AFDMPkW-E8_w4BOCzTAOURQ_/view?usp=drive_link&resourcekey=0-6-EbFZXkBqcu0rw7uuEzjw

Bug: 292000892
Test: Manual with floating enabled/disabled and
SEPARATE_RECENTS_ACTIVITY enabled/disabled (simulating not being
the active Launcher). Also tested with a 3P Launcher, Nova.
Flag: N/A; this change is enabled by default, but also verified
UI looks correct with ENABLE_FLOATING_SEARCH_BAR.

Change-Id: Ia45f88d2c691c4525b1e73cca4707498d058a917
2023-07-22 07:43:17 +00:00
Vinit Nayak
5f09091583 Show split select instructions toast when starting split on workspace
* Used same animation properties that RecentsView uses to
show the instructions view unfolding
* TODOs:
  * UI polish (correct asset, animation timings, etc)
  * Hook into existing animations (if possible)
  * Migrate recentsView splitInstructionsView to use same/similar code path;
    remove RecentsView#safeRemoveDragLayerView

Bug: 276361926
Test: Create split w/ and w/o flag, works as expected
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Change-Id: I7a51b71c358902399ad73b650287cdbf1dad07c6
2023-07-14 17:49:42 -07:00
Anushree Ganjam
5730f03c9f Introduce Default Ime height.
Assume IME_DEFAULT_HEIGHT_DP = 300.
When ime is yet to be shown but the UI is ready, then use
IME_DEFAULT_HEIGHT_DP.

For the 2nd time onwards save the actual ime height and use it when the
keyboard is not shown yet.

Bug: 285166099
Test: Manual
Change-Id: I33e38cbd5c2910f4a6dc4cc83c8dc4b6d94fbcff
2023-07-12 17:21:40 +00:00
Sunny Goyal
6c304b157d Always insetting the widget by a minimum of 6dp
Removing default widget padding logic. Also widget padding it applied
at ShortcutAndWidgetContainer so that the widgetView always has the
correct size.

Bug: 274826296
Bug: 257589413
Test: Verified using screenshots
Flags: N/A
Change-Id: Id4b5e94db6ec7b2aa3dca87b1e9ccc831b608cac
2023-05-03 12:18:33 -07:00
fbaron
84e19a9bea Fix droptarget button wrong radius on hover
Fix: 277470359
Test: drag app to uninstall or remove on tablet, verify the button shape doesn't change when hovered over
Change-Id: I6b8b2de7357f8d19cdee7632a9957624a3f242a1
2023-04-13 19:27:00 +00:00
fbaron
55fed64ced Rename widgets two pane sheet layout files and spec files to more fitting name
Currently the names used for widgets two pane sheet files are similar to full sheet files, just with "_large_screen" added to it. This is not a good name as it can cause confusion. The new name includes "_two_pane" which is more indicative of the actual functionality of these files.

Fix: 276917926
Test: verify widget picker two pane still works
Change-Id: I23cf2a20fc137cc3e99c5fdc90100648a0926368
2023-04-04 09:55:31 -07:00
Jon Miranda
a97dc04478 Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev am: 085c53869f am: 3cd39729dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22228076

Change-Id: I3cb2d462cef1df514c87418ed70ac624899c21fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 23:02:51 +00:00
Jon Miranda
9c478b6c29 Add taskbarIconSize to GridOption/DisplayOptions
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
  sizes

Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-24 12:29:11 -07:00
fbaron
d11a9e1d08 Widget picker two pane polish
-increase width of two pane picker
-center widgets when they're too few to overflow
-make background stretch out all the way to the bottom even when there aren't multiple widgets
-fit many widgets in one row if they fit

Bug: 256684299
Test: open widget picker and notice that all the listed fixes match the last figma added in the bug
Change-Id: Id4e8445f4ffe484c24c04fd9d1b4ffbf93a00bb2
2023-03-21 16:49:45 -07:00
Jon Miranda
d95c511b2c Merge "New taskbar thresholds." into tm-qpr-dev 2023-03-20 17:16:22 +00:00
Jon Miranda
4a7569b1b0 New taskbar thresholds.
Nav threshold / App window threshold / Home overview threshold / Catch up threshold
Default: 40dp / 88dp / 156dp / 264dp
sw720dp: 30dp / 100dp / 180dp / 300dp

Bug: 267646355
Test: manual
Change-Id: Ic4e99820ca44d3f1bfc12f570d003d4062e6a2cd
2023-03-17 08:16:56 -07:00