Commit Graph

15 Commits

Author SHA1 Message Date
Jon Miranda
a625f58737 Add dynamic thresholds for taskbar based on screen size.
Bug: 274467454
Test: Manually test that each threshold is as expected
Change-Id: Ifa66cfb78f544bb4d14391e70badc92589d47a26
2023-08-04 14:35:56 -07:00
Jon Miranda
04f051045c Allow grids to specify if we should start align taskbar in 3 button
nav.

Bug: 259712417
Test: check layout on tablet
      check layout on multi_display devices

Change-Id: I282f51e5d76a30e9ad9d8c52d03d4853e965d65a
2023-04-05 10:29:51 -07:00
Jon Miranda
9c478b6c29 Add taskbarIconSize to GridOption/DisplayOptions
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
  sizes

Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-24 12:29:11 -07:00
Tony Wickham
c73db73a79 Handle swipe down on taskbar to stash
- Moved all touch-to-stash logic to new TaskbarStashViaTouchController
  (handles both tap outside to stash instantly as well as swipe down
  inside to stash after letting go)
- This is a TouchController on TaskbarDragLayer, so it intercepts
  touches from TaskbarView before icons can be dragged during swipe down

Test: swipe up to invoke transient taskbar in an app, swipe down or
touch outside to stash
Flag: ENABLE_TRANSIENT_TASKBAR=true
Fixes: 246631710

Change-Id: I5cf64848bba34ad32fcc80a93fb4f79ebd2c10a7
2023-03-23 15:13:52 +00:00
Jon Miranda
4a7569b1b0 New taskbar thresholds.
Nav threshold / App window threshold / Home overview threshold / Catch up threshold
Default: 40dp / 88dp / 156dp / 264dp
sw720dp: 30dp / 100dp / 180dp / 300dp

Bug: 267646355
Test: manual
Change-Id: Ic4e99820ca44d3f1bfc12f570d003d4062e6a2cd
2023-03-17 08:16:56 -07:00
Jon Miranda
e17a949950 Align taskbar to the left/right in 3 button nav for certain devices.
Otherwise we position the taskbar in the center.

Bug: 259712417
Fixes: 267997547
Test: transient taskbar unaffected
      persistent taskbar
      - test on small tablet
      - test on large tablet
      - test LTR and RTL

Change-Id: Ieb0a304d9963ebf583bc4ef2deaab747019e8d6d
2023-03-09 22:33:18 +00:00
Tony Wickham
2a058f5be1 Update taskbar to spec
- Space between icons is 24dp in all cases (transient, persistent,
  small tablet, large tablet)
- Persistent taskbar icon size remains 44dp, but transient taskbar icon
  sizes have changed slightly: 57dp -> 52dp for large tablets and
  50dp -> 48dp for small tablets
- Also moved all values to quickstep package to avoid confusion

Test: manual, visual
Fixes: 263465844
Change-Id: I563d64dca2d920762233dd6147395c5bba3ffcf3
2022-12-28 18:56:43 +00:00
Alex Chau
1b276a1ba7 Add transientTaskbarMargin above taskbar in overview
- Also removed transient_taskbar_two_panels_size and use sw720dp override instead, to be consistent with how we handle small vs large tablet in overview
- Also made isTransientTaskbar mockable so we can test that in DeviceProfileDumpTest

Bug: 260596114
Test: DeviceProfileDumpTest
Change-Id: I3c2236b95d91246e9581531478e3c97601cfb2ec
2022-12-19 17:23:27 +00:00
Pat Manning
2335490fe6 Align system navigation setting link in AllSet page for tablets to top/start.
Fix: 233610579
Test: manual
Change-Id: If6d462df02bf795e8a6e73fbb040a6a84ea99404
2022-11-09 13:19:33 +00:00
Andras Kloczl
fb65436fae Improve All Set page UI for large screens
Test: manual
Screenrecordings: https://drive.google.com/drive/folders/1S6kjenZn0kP-W2tPpUemre2x0368ACyr?usp=sharing
Bug: 233610579
Change-Id: I9a33efe193a96e752766feb1e91cf0ac9b30246f
2022-10-25 13:16:47 +00:00
Jeremy Sim
1cfe6d490a Update calculation method for Overview UI placement on tablets
This update slightly changes the calculation method for Overview UI placement, in order to line up better with spec. (The previous calculation caused a small 30dp divergence on tablets.)

Bug: 236760307
Test: Manual by measuring pixels and comparing to spec
Change-Id: I94e9e7b5a6a24c37693425ac8ec71cd066003658
2022-07-28 14:05:24 -07:00
Alex Chau
1fe83fe881 Tune overview icon size and paddings
- Tune overview icon size and paddings across form factors
- Limit handheld overview to 70% of screen width

Fix: 209981696
Test: manual
Change-Id: I946b9bb2e9eb05cdc1e4497b9b1267a91731a8e1
2022-05-11 16:35:14 +01:00
Alex Chau
2e48760e97 Update overview grid icon sizes and paddings
- Introduced additional page spacign for clear all button to match mocks

Fix: 222664142
Test: Quick switch to last task and immediately enter overview
Test: Dismiss last task in overview grid
Change-Id: I4d2f93d843c50b10051f3fb17027cd06e86707e1
2022-03-17 13:44:21 +00:00
Alex Chau
635b3abcf1 Remove ENABLE_OVERVIEW_GRID feature flag
- Use isTablet directly instead of overviewShowAsGrid
- Tablet/landscape resoruces can now be overriden via xml
- Use Landscape resources in tablet in additional to vertical bar layout
  - For resources overwritten in values-land that was intended for vertical bar layout, override them in sw600dp for tablet landscape

Bug: 210597891
Test: manual
Change-Id: I19eac935a5fb1a420485408aa8b4774632726af1
2022-01-27 11:28:35 +00:00
Alex Chau
4f7952ead4 Use percentage scaling for overview thumbnail size
- Limit overview to screen ratio to be at max 70%
- Tuned row spacing and page spacing
- Added 2 more test activities to testOverviewForTablet to avoid dismissing tasks at end of grid, as more grid tasks are now shown

Bug: 207350366
Test: manual
Change-Id: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
2021-12-07 11:00:48 +00:00