Commit Graph

28 Commits

Author SHA1 Message Date
Greg Kaiser
45ba84268c Revert "App Pairs: Implement Overview Actions View button"
Revert submission 25143701-app-pairs-action-button

Reason for revert: Causes P0 b/315292030

Reverted changes: /q/submissionid:25143701-app-pairs-action-button

Change-Id: I1fcbb9f333ca29c5db255232dc9475dec465ac81
2023-12-18 14:53:19 +00:00
Jeremy Sim
e1fcb5390b App Pairs: Implement Overview Actions View button
[App Pairs 6/?]

This patch includes:
- Ability to "save app pair" from Overview Actions
- The actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.

Note: This patch introduces a slight regression (b/315545418) where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Bug: 315545418
Bug: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I0eb1fa9520ba14074ede3480e771b340cf2f6e2c
2023-12-18 02:25:22 +00:00
Greg Kaiser
e8b1d45485 Revert^3 "Refactor/clean up Overview Actions buttons"
6b99fe1a00

Change-Id: I8f4054335b7bdee898ce3943f4a3798ba51c6fbc
2023-12-07 13:54:39 +00:00
Jeremy Sim
6b99fe1a00 Revert^2 "Refactor/clean up Overview Actions buttons"
Second attempt after ag/25292769 was reverted (fixed the screenshot test failure)

Bug: 274835596
Test: atest OverviewImageTest#testOverview
Flag: NA
Change-Id: I3e442264e946b3a0979ca3e401b9ffd30671a291
2023-12-05 11:36:01 +00:00
Uwais Ashraf
60a2d85b68 Revert "Refactor/clean up Overview Actions buttons"
Revert submission 25292769-cleanup-action-buttons

Reason for revert: Causes a 100% failure of OverviewImageTest

Reverted changes: /q/submissionid:25292769-cleanup-action-buttons

Change-Id: Iedd51290e2d6fb7efafc814f1d3d51863b3d3ab7
2023-11-14 09:45:55 +00:00
Jeremy Sim
7030216f48 Refactor/clean up Overview Actions buttons
Since the number of Overview actions is growing, this patch factors out the button hiding logic so it's not all handled in OverviewActionsView.

Also, since splitscreen can now be carried out on Taskbar targets, the split button is no longer ever disabled (only hidden), so removed unused code for that.

Bug: 274835596
Test: Manual
Flag: NA
Change-Id: Icacdee6d0e6071ccb400dfc25a84572e7e9ce772
2023-11-08 13:43:19 -08:00
Andy Wickham
bc3bac4113 Revert^3 "Change Overview Actions to round buttons."
Awaiting UX alignment.

Test: N/A
Flag: N/A
Change-Id: I05e9627d8b44ea16d29445e005534af2a1abd439
2023-08-08 12:09:59 -07:00
Andy Wickham
be8981442a Revert^2 "Change Overview Actions to round buttons."
f849f2856f

Fix: 293081298

Change-Id: Iaf1553770329ec3a6c6d8a2d9d81b60203e79ed8
2023-07-26 20:56:05 +00:00
Greg Kaiser
f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Andy Wickham
f98949cac3 Change Overview Actions to round buttons.
If floating search is active in Overview (flag enabled and we are
the active Launcher), these buttons will be aligned to the search
bar relative to the bottom of the screen. Otherwise, the buttons
will be aligned below the active task like before.

Demo for Launcher3 build:
https://drive.google.com/file/d/1fVzRRnW5AFDMPkW-E8_w4BOCzTAOURQ_/view?usp=drive_link&resourcekey=0-6-EbFZXkBqcu0rw7uuEzjw

Bug: 292000892
Test: Manual with floating enabled/disabled and
SEPARATE_RECENTS_ACTIVITY enabled/disabled (simulating not being
the active Launcher). Also tested with a 3P Launcher, Nova.
Flag: N/A; this change is enabled by default, but also verified
UI looks correct with ENABLE_FLOATING_SEARCH_BAR.

Change-Id: Ia45f88d2c691c4525b1e73cca4707498d058a917
2023-07-22 07:43:17 +00:00
Alex Chau
1bf0fe1b70 Add back screenshot button to Launcher3
- Also make spacing between buttons always 36dp
- Updated screenshot button image for Launcher3

Fix: 208384949
Test: Start overview in Launcher3WithQuickStep, test screenshot button is working
Change-Id: Ieb60ce134813202c1d14137fff0a131e1f5f8c96
2021-12-03 12:32:29 +00:00
Vinit Nayak
455197bf41 Add icons for staged split
Fixes: 208649953
Change-Id: I8b7bb3a650e836608ebe6aa50631026f5f6a7c63
2021-12-01 14:58:53 -08:00
Zak Cohen
283ee7d74b Remove the Share button option from Overview.
It has never been enabled, and is not plan of record.

Bug: 201446691
Test: local and updated unit tests

Change-Id: I5ac6d40ba1dbcf28de4355cc51fff74cfb37ebc6
2021-09-29 14:43:27 -07:00
Vinit Nayak
6174106f68 Add Split button in OverviewActions
Shows up only for large screen devices, not phones.
Tested for NexusLauncher, general 3P launcher support
needed for staged split (TODO b/195607777)

Bug: 195423591
Change-Id: I4d455769b17637174b590c640516b9fbb6352c3d
2021-08-26 11:49:38 -07:00
Alex Chau
5fd9d491b0 Tune Overview size according to VisD
- Removed modalTransformY as overview actions no longer need to move in modal view
- Moved row spacing and page spacing to DeviceProfile
- Added several tablet / orientation specific DeviceProfile params

Bug: 194194694
Test: Manual
Change-Id: Id5435e7f6fc1b6fb7c0e55e55fa240cf84c4d6da
2021-07-26 12:01:30 +01:00
Treehugger Robot
54161e66f9 Merge "Modifying screenshot button visibility" am: 3e6c445003 am: a3410d3947 am: 8848ba2497
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1461822

Change-Id: Ic1dd59d597b060b609afe818fe2b9584282078fe
2021-04-19 04:05:57 +00:00
Treehugger Robot
3e6c445003 Merge "Modifying screenshot button visibility" 2021-04-19 02:58:56 +00:00
Sunny Goyal
11d7d34f0d Removing unnessary resource split in overview
Bug: 184169818
Test: Presubmit
Change-Id: Iff5a8510be337472f05acb5629712ec088361471
2021-04-02 11:43:29 -07:00
Jon Spivack
3a1cfc9082 Add NIU Actions buttons to the Go Overview
The buttons send Intents to the designated app (specified by
niu_actions_package) to do the following:
Listen - Read the contents of the screen aloud
Translate - Translate the contents of the screen
Search - Perform a visual search on the contents of the screen

The Intents also include (via URI) the screenshot of current app used as
a thumbnail by Recents.

The feature is controlled by the enable_niu_actions flag, set to false
here. Both this flag and the niu_actions_package String must be set for
a given Launcher to use these buttons.

Bug: 177955244
Bug: 177955748
Test: Manual (enabled on LauncherGoGoogle and sent Intents to demo Lens
app)

Change-Id: I3d1f870bb176ed0cbae637a45c072bd8acac1d4b
2021-02-09 14:50:56 -08:00
mtk20437
02fc23c993 Modifying screenshot button visibility
Just like "Share" button, we are modifying Screenshot button visibility to gone.

Bug: 168754258
Change-Id: Ie92552c931857eed5d11af130af5a79923ee72e8
2020-10-15 03:31:52 +00:00
Sreyas
46aba2a46e Adding content push button behind flag to OAV.
Tested: TaplTestsNexus:testOverviewActions()
Change-Id: I83bc6e5033e2292776c927fba363214f347e01ce
2020-09-10 12:59:55 -07:00
Hyunyoung Song
45c0918f47 Merging ub-launcher3-rvc-qpr-dev to rvc-qpr-dev
Bug: 162366734
Test: system image builds

Change-Id: I6675431b180976798afacc7a99251ae36764a50a
Merged-In: Ibff46b3ef7ff89accb459db323f31179adb4ef21
2020-07-30 00:26:39 -07:00
Sreyas
5e19073c23 Fixing oav text overlap.
Bug: 159240113

Change-Id: I89d8249c21cca86f21cdf57a017745237b4b6cf1
2020-07-17 00:57:56 +00:00
Sreyas
ae23746fa0 Remove overview share to match spec
Bug: 157174391
Change-Id: Iabfeb34b77abcb885b1518d348cac45e71dc92a9
2020-05-28 17:04:42 -07:00
Sreyas
dbedb91ad8 Putting Overview Share button behind flag
https://drive.google.com/file/d/1Io5N-LyXoRa9LHQjJNd1BAgBkVuBvnhr/view?usp=sharing
https://drive.google.com/file/d/15HhNvNoUn5qX1GhkjDaifA3G05PLoIwO/view?usp=sharing
Bug: 157174391

Change-Id: I8314d5aa309fe020a4121753d4e76ca10370c626
2020-05-28 12:03:12 -07:00
Zak Cohen
b4ee058955 OverviewActions - make button ripple workspace text color.
Uses a theme to set the control highlight color.

Test: local on dark and light wallpaper
Change-Id: Iddb668fcbd3ab760faabd9c296274315d63e044f
2020-05-04 17:17:52 -07:00
Sunny Goyal
01d8541f14 Fixing actions view getting visible sometimes
> Linking actions view to state flags
> Creating multiple visibility channels that can be controlled separately

Bug: 153906903
Change-Id: I33d20f5fdc8bcdf0520dae3aac986548eb7e0058
2020-04-20 09:59:13 -07:00
Sreyas
1963d3f3ed OverviewActions: Adding action buttons to Oem quickstep.
Change-Id: Id5c0d8f1b41107535c1bac982b47f67eb2574c21
2020-03-27 16:42:10 -07:00