Commit Graph

49 Commits

Author SHA1 Message Date
Himanshu Gupta
69f37fd722 Merge "Preventing DragAndDrop for PS apps." into main 2024-02-01 09:14:43 +00:00
Himanshu Gupta
3ec66fb333 Preventing DragAndDrop for PS apps.
This Cl restricts item dragging for PS apps from
all launcher surfaces such as AllApps, AppPredictionRow, etc.

Video: https://photos.app.goo.gl/PKGw8n23hJVJMyUk7

Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_item_drag DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I2c5dbaa325095ec63aedf39b6b2c269f745d58ca
2024-02-01 06:46:25 +00:00
Sunny Goyal
fffb4feb4e Adding a flag to support activity overlay on home screen
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: N/A
Change-Id: Ic29c2c21da22554213a1792a38caf6907438c86d
2024-01-31 11:34:00 -08:00
Shamali P
c48c660bb5 Add a feature flag for displaying categorized widget recommendations.
Bug: 318410881
Test: NONE
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_suggestions DEVELOPMENT
Change-Id: I6f8a0cc8f74823f1a29cef1b5f8ac0a3e9411609
2024-01-29 18:40:22 +00:00
Himanshu Gupta
f591ce5f17 Restricting Accessibility flows for Private Profile.
Adding PS apps to the home screen is restricted.
This CL prevents the same from accessibility drags.

Bug: 289223923
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_accessibility_drag DEVELOPEMENT
Test: Ran Launcher3 Tests.
Change-Id: I3e2b7b196b96a4d2ba34d8ece5fd6e0463f17253
2024-01-25 04:19:20 +00:00
Sunny Goyal
7ec2e11b0c Merge "Implementing an unfold animation using CannedAnimationController" into main 2024-01-22 19:06:41 +00:00
Sebastián Franco
82d88d3fdc Merge "Updating launcher settings so that they become split-screen" into main 2024-01-22 04:58:09 +00:00
Sunny Goyal
2faf66e5d3 Merge "Revert "Set aconfig container to "system""" into main 2024-01-19 23:31:17 +00:00
Sebastian Franco
9ae403298d Updating launcher settings so that they become split-screen
Following this guide:
https://developer.android.com/guide/topics/large-screens/activity-embedding#extract_an_activity_from_a_split_to_full_window

Bug: 204463748
Test: Open the settings app and open multiple settings, for now
only the options inside of the launcher3 package work
Flag: ACONFIG com.android.launcher3.Flags.enableTwoPaneLauncherSettings DEVELOPMENT

Change-Id: Ie6a9eb3760171da92d94cf06376127b02afff8df
2024-01-19 22:33:20 +00:00
Sunny Goyal
d609f6ea39 Revert "Set aconfig container to "system""
This reverts commit 2916945dbf.

Reason for revert: breaks android-studio development flow

Change-Id: I219eb87c170b2b0dd1bb98894afa680bffb360b5
2024-01-19 21:35:29 +00:00
Sunny Goyal
2c206400a2 Implementing an unfold animation using CannedAnimationController
Bug: 297057373
Flag: aconfig enable_unfold_state_animation DISABLED
Test: Manual
Change-Id: Iaa352133ebf06ab74b9ba4b8c4d3523f27666089
2024-01-18 11:49:37 -08:00
Oriol Prieto Gascó
8cba27bc8a Merge "Set aconfig container to "system"" into main 2024-01-18 14:29:17 +00:00
Sunny Goyal
d3ee2c3427 Merge "Adding feature flags for Launcher reboot and load improvements" into main 2024-01-18 00:07:54 +00:00
Anushree Ganjam
cbfa8043c8 Merge "Add "Don't suggest app" shortcut to suggested apps." into main 2024-01-17 22:25:17 +00:00
Sunny Goyal
24d68d852b Adding feature flags for Launcher reboot and load improvements
Bug: 318539160
Bug: 298231234
Test: N/A
Flag: ACONFIG com.android.launcher3.enable_reboot_unlock_animation DEVELOPMENT
Flag: ACONFIG com.android.launcher3.enable_workspace_inflation DEVELOPMENT
Change-Id: Ica99710a4168eae556ea656f65a444628f9fd8e9
2024-01-17 14:14:23 -08:00
Charlie Anderson
da3138cd91 Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag.
This is necessary because the value of the read-write flag will not be updated in time for backup/restore.

Bug: 307527314
Test: compiles
Flag: ACONFIG ENABLE_LAUNCHER_BR_METRICS_FIXED TEAMFOOD
Change-Id: I67a1a820734d8881b3ed5be4a1f2f1556e6e4704
2024-01-12 14:33:29 -05:00
Anushree Ganjam
5e9b71e055 Add "Don't suggest app" shortcut to suggested apps.
This works for suggested apps in both Home and AA+. When enable_shortcut_dont_suggest_app is true, the secondary drop target "Don't Suggest app" is removed instead "Don't suggest app" is added to shortcuts.

Video: https://b.corp.google.com/issues/319250810#comment5

Home: https://screenshot.googleplex.com/d7Wts48X6EmFAYg.png
Private space app suggested: https://screenshot.googleplex.com/BukzCRTvkzbpwQ3.png

AA+: https://screenshot.googleplex.com/ADMCHnQ378jvJEE.png
Private space app suggested : https://screenshot.googleplex.com/AYga8Km3646AqMt.png

Bug: 319250810
Flag: aconfig com.android.launcher.enable_shortcut_dont_suggest_app DEVELOPMENT
Test: Manual.

Change-Id: Ia7df749a1c7d806bd9d74124be138384c3050119
2024-01-12 10:33:24 -08:00
Anna Zhuravleva
eb1966c278 Merge "Add shortcut to install an app to Private space" into main 2024-01-12 15:51:05 +00:00
Anna Zhuravleva
29a3139815 Add shortcut to install an app to Private space
Introduce long-press shortcut to install a copy
of the main user app to private space.

Test: manual, installed apps in different stores
and tried shortcut
https://screenshot.googleplex.com/6oAVamTytiYmvPC.png
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT

Change-Id: I702cd2a27388e3cc6e9e126308d5479836ba6655
2024-01-11 12:40:28 +00:00
Oriol Prieto Gasco
2916945dbf Set aconfig container to "system"
Bug: 312769710
Flag: NA
Test: TH
Change-Id: I7fbb8e31629b7aa90fbdf2b029932c111cce8d42
2024-01-10 19:52:57 +00:00
Tracy Zhou
899c28193c Merge "Delete enable_split_from_fullscreen_with_keyboard_shortcuts from aconfig" into main 2024-01-05 21:20:33 +00:00
Tracy Zhou
ef8e4e2e77 Delete enable_split_from_fullscreen_with_keyboard_shortcuts from aconfig
It's merged with split_contextual in ag/25511408

Bug: 270394122
Test: N/A
Change-Id: Idabddee7c566ec426be744261ff50d7b360e2afa
2024-01-05 10:45:22 -08:00
Rohit Goyal
2e6010c421 Add support for progress bar during unarchival of app.
* With this change, progress bar should appear whenever app update for archived app reaches non-zero progress.
* Once the update is cancelled, the progress bar should also disappear.

Test: PromiseIconUiTest and manually tested the progress bar using Play Store
Bug: 302115555
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iacf7a0fd865dba34915fa09f59c63a1da6e47315
2024-01-03 23:44:52 +05:30
Jagrut Desai
2107717252 Merge "Change Tracking Bug for Taskbar pinning feature flag" into main 2024-01-02 20:52:50 +00:00
Jagrut Desai
5bcad413ec Change Tracking Bug for Taskbar pinning feature flag
Test: Presubmit
Bug: 296231746
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I4be1d2a247f0aa6b39854a667b576a523a8a776a
2023-12-20 11:09:50 -08:00
Himanshu Gupta
ce2b013d31 Merge "Adding methods to access LauncherApps APIs." into main 2023-12-19 11:27:09 +00:00
Himanshu Gupta
6c25654e84 Adding methods to access LauncherApps APIs.
These methods are added to ApiWrapper class
so that Launcher can acess these APIs.

Bug: 308054233
Test: Presubmit
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Change-Id: Ic2e64b38cc8b0d262d3f6e9614e2b3fceb9d82a0
2023-12-18 19:47:13 +00:00
helencheuk
b4626f4698 Add focus outline to launcher
Fix: 310953377
Test: TBC
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: Ie395ec74c8a4a13a68539ca7ec6496481d96b860
2023-12-15 16:56:31 +00:00
fbaron
5176d7b074 Add ACONFIG flag enable_tablet_two_pane_picker_v2
Bug: 315055849
Test: NONE
Flag: ACONFIG com.android.launcher3.enable_tablet_widget_picker_v2 DEVELOPMENT
Change-Id: I7c7e49dc6fe2de3c4f3f28a9b8f67035c67831e6
2023-12-05 17:44:15 -08:00
fbaron
9efed13652 Add ACONFIG flag enable_unfolded_two_pane_picker
Bug: 301918659
Test: NONE
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I16e4cafb676564faa9da2d7402357cb815fd178e
2023-11-29 20:56:09 +00:00
Charlie Anderson
c23a440f8d Add aconfig flag enable_launcher_br_metrics
Flag: ACONFIG  com.android.launcher3.enable_launcher_br_metrics DEVELOPMENT
Bug: 307527314
Bug: 305984208
Test: locally verify
Change-Id: I28488de7133d898e6ef990183f0af5f34732cced
2023-11-17 17:38:33 +00:00
Tracy Zhou
859edd00e9 Migrate ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS to aconfig
Bug: 270394122
Test: N/A
Change-Id: I9bacd906099518b4a4c43a9f80ab0c753beac89a
2023-11-13 13:12:09 -08:00
Jagrut Desai
bd997801e9 Merge "Migrate ENABLE_TASKBAR_PINNING to aconfig flag" into main 2023-11-13 20:13:15 +00:00
Jagrut Desai
90dd098c85 Migrate ENABLE_TASKBAR_PINNING to aconfig flag
Test: Manual, Presubmit
Bug: 265437087
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I4800230c04feceefa2398e189c493c8c4a7b2fe5
2023-11-09 23:20:03 +00:00
Brandon Dayauon
f7f607109b Create privateSpaceAnimation Flag
bug: 299294792
Test: Presubmit
Flag: ACONFIG com.android.launcher3.private_space_animation DEVELOPMENT
Change-Id: I8a5bd4f436e98a69d82cff1eb3efcf6b2c616a34
2023-11-09 10:24:37 -08:00
Jon Miranda
60ae29ef08 Migrate ENABLE_HOME_TRANSITION_LISTENER to launcher.aconfig
Also set flag to TEAMFOOD.

Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TEAMFOOD
Bug: 306053414
Test: manual
Change-Id: Icf3947e61fa9f20f5b6e5ca2af96e693b55d3edc
2023-10-27 16:43:01 +00:00
Alex Chau
9f2bc12884 Update feature bug for responsive grid
Bug: 302189128
Test: None
Flag: None
Change-Id: Id07a500225d6f105d35c339cbdbd662f0fbf9512
2023-10-26 13:59:24 +01:00
Tracy Zhou
867f7f8360 Merge "Migrate ENABLE_TASKBAR_NO_RECREATION to launcher.aconfig" into main 2023-10-25 17:45:09 +00:00
Tracy Zhou
00f9e52575 Migrate ENABLE_TASKBAR_NO_RECREATION to launcher.aconfig
Bug: 274517647
Test: manual
Change-Id: I29fe58691440ee757c9f391bd574ef80eefb5ae6
2023-10-24 18:42:15 -07:00
Anushree Ganjam
e1e71191dc Add launcher_search.aconfig in launcher3.
Add enable_private_space in launcher_search.aconfig.

Bug: 306187906
Flag: Aconfig enable_private_space Development
Test: NA
Change-Id: Icaddc2d8f746618ff645e968b400afc971c31e59
2023-10-23 14:39:46 -07:00
Pat Manning
1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Thales Lima
ca31b6105e Migrate ENABLE_RESPONSIVE_WORKSPACE to aconfig
- Keeping FeatureFlags.ENABLE_RESPONSIVE_WORKSPACE for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_RESPONSIVE_WORKSPACE in tests as aconfig still can't be mocked

Bug: 299935275
Test: manual
Change-Id: I092df894a3624dca6b9d381d56ada71d807547b5
2023-09-25 16:25:15 -07:00
Pat Manning
349f101411 Merge "Migrate ENABLE_CURSOR_HOVER_STATES to aconfig" into main 2023-09-19 16:56:45 +00:00
Alex Chau
c40e64e0cb Update enable_grid_only_overview to use correct release bug
Bug: 270397206
Test: presubmit
Change-Id: I513d77c61ee87485ecf0061d3b3a3c3a74c45982
2023-09-14 12:27:37 +01:00
Pat Manning
c49d60b946 Migrate ENABLE_CURSOR_HOVER_STATES to aconfig
- Keeping FeatureFlags.ENABLE_CURSOR_HOVER_STATES for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_CURSOR_HOVER_STATES in tests as aconfig still can't be mocked

Bug: 300054410
Test: manual
Change-Id: Id385e8ee32ccf8b920b9b7f9cc620af32def589f
2023-09-14 11:08:02 +01:00
Alex Chau
e1955fe4b9 Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig
- Keeping FeatureFlags.ENABLE_GRID_ONLY_OVERVIEW for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_GRID_ONLY_OVERVIEW in tests as aconfig still can't be mocked

Bug: 270397206
Test: manual
Change-Id: I799e05311adc21184a6ad7ce92a3abdab3f25c25
2023-09-13 15:59:01 +01:00
Anushree Ganjam
2a14b978c6 Remove the test aconfig lib.
zhidou@ from ACE team is working on AConfigFakelib which will be useful
to set fake flag values in both unit tests and UI automator tests.
Meanwhile, we will mock the flag values for unit tests and UI automator
tests will have all flags values defaulted to false.

testAConfigLib with "test:true" doesn't generate fake flags values and
forces us to set the flag values using "SetFlagsRule". "SetFlagsRule"
doesn't work with Out Of Proc tests and hence doesn't serve the purpose
for us. AConfigFakelib and FakeFlagTargetPreparer should use for Out Of
Proc tests.

testAConfigLib with "test:true" is suitable for java host tests where
there is no device involved. Launcher tests are instrumentation tests and tests run on actual
devices. So we can use the production version of the AConfig lib and device
config flag values will be fetched for UI Automator tests.

Also migrating "enable_twoline_allapps" to trunk stable. Unit tests is
using mockito to mock the flag value as false. The owner of
"enable_twoline_allapps" can mock the value to true in unit tests as
next step.

Bug: 294913042
Test: Local studio build and soong build
Flag: enable_twoline_allapps

Change-Id: Iea42bf18197832a9ecbddc1c3aaa8c9e36169131
2023-08-30 15:20:51 -07:00
Anushree Ganjam
813e96e1ab Include all *.aconfig files under aconfig directory
Forward fix for  https://googleplex-android-review.git.corp.google.com/c/platform/vendor/unbundled_google/packages/NexusLauncher/+/24579326/4/build.gradle

Bug: 294913042
Test: Local studio build
Flag: NA
Change-Id: Ib16469096c92eff4b50167e58fe5132e5467fdde
2023-08-29 15:47:10 -07:00
Anushree Ganjam
8a6b74e51b Move aconfig files to aconfig folder
- Set packageName as com.android.launcher3
- Follow folder structure as per go/sysui-aconfig-structure

Bug: 294913042

Test: adb shell device_config put launcher com.android.launcher3.enable_all_apps_rv_preinflation true

Flag: enable_all_apps_rv_preinflation

Change-Id: Ib45a24d9100b657e7776c6120bdf9625533e9ed7
2023-08-28 18:27:11 -07:00