Commit Graph

619 Commits

Author SHA1 Message Date
android-build-team Robot
9b83fe225d Merge "Quickstep onboarding backward compatibility for devices release with Android N & O." into ub-launcher3-edmonton 2018-05-02 20:51:37 +00:00
Tracy Zhou
8b23c6f60b Quickstep onboarding backward compatibility for devices release with Android N & O.
Quickstep introduces swipe up gesture to open Overview and removes the
Recents button. We still want to show shelf bounce animation for Android
N & O users with Recents button because Overview is updated and swiping
up from there takes users to All Apps.

Test: manual test
Change-Id: I917c91564c47c78d2dc3883b8a7bf7824b5f5bc8
Fixes: 78647939
2018-05-02 13:41:28 -07:00
android-build-team Robot
d79759556d Merge "New calculation for clear-all alpha." into ub-launcher3-edmonton 2018-05-02 20:39:15 +00:00
Vadim Tryshev
80cd825c0f New calculation for clear-all alpha.
Per UX feedback, alpha changes from the central position of the last
task and its overscrolled position. Button location is not used.

Bug: 72222505
Test: Manual
Change-Id: Ifc22c935940eaeb1b1ec6e4a5f2709ac7ae8253b
2018-05-02 13:14:16 -07:00
Tony Wickham
f325b19de3 Merge "Gracefully handle some edge cases in quick scrub" into ub-launcher3-edmonton 2018-05-02 16:21:21 +00:00
Tony Wickham
7a5d4ae64f Merge "Fix some state issues with user-controlled animations" into ub-launcher3-edmonton 2018-05-02 16:20:19 +00:00
Jorim Jaggi
bbeedd1d2f Merge "Fix some jank with transitions" into ub-launcher3-edmonton 2018-05-02 13:17:42 +00:00
Tony
f47e5ce3cf Gracefully handle some edge cases in quick scrub
- Switch to normal overview if task fails to launch in onQuickScrubEnd()
- Stop auto-advancing if recents isn't visible
- Wait until transition to quick scrub completes before launching

Bug: 77521777
Bug: 78557737
Change-Id: I5206c0d3c52bf792f52cf3e7adcf03f8a2de18bb
2018-05-01 14:21:04 -05:00
Tony
31fbd4c08b Fix some state issues with user-controlled animations
Previously, user-controlled animations weren't properly being canceled when a
non-user-controlled animation started, e.g. when hitting home. Thus, we could
end in the wrong or inconsistent state because the user-controlled animation's
end runnable was still used. Now we add a cleanup callback for when we reset
the user-controlled animation for one that isn't user-controlled.

Also fixed a couple typos.

Tests (easier with animation durations extended):
- Swipe up and hit home before reaching overview -> land on home
- Go to overview, swipe down slightly (before threshold to go to workspace)
  and let go -> return to overview without flash (recents was resetting)
- Swipe up, press home while swiping -> goes home, stops responding to drag
- Start dismissing task and hit home before it finishes (or while dragging)
  -> goes home, stops responding to drag

Bug: 78249220
Change-Id: If11d8999e3fadba38c987b25af67cd2304cd859b
2018-05-01 13:45:27 -05:00
Winson Chung
976047647e Merge "Also notify the user when a task view fails to launch." into ub-launcher3-edmonton 2018-05-01 18:41:02 +00:00
android-build-team Robot
a269a81881 Merge "Accessibility of clear-all button" into ub-launcher3-edmonton 2018-05-01 18:31:25 +00:00
Winson Chung
6dceb7755a Also notify the user when a task view fails to launch.
Bug: 78660939

Change-Id: I8041d3bdd6da1caed72affb1e295c416214a92d4
2018-05-01 11:27:02 -07:00
Vadim Tryshev
4e3e54a45a Accessibility of clear-all button
Making it visible to accessibility even when it’s completely hidden
behind a task. I had to mark it visible as a view. Now it’s invisible
only when there are no tasks in RecensView, to hide it from
accessibility.

Focusing on the button completely reveals it.

Bug: 72222505
Test: Manual
Change-Id: Ia31a1136e07faed93b4a44d5be69483d3b88364d
2018-05-01 11:20:14 -07:00
android-build-team Robot
954157a228 Merge "Remove associated task views if task is removed while Overview is showing" into ub-launcher3-edmonton 2018-05-01 18:12:34 +00:00
Winson Chung
3b0c3b981b Remove associated task views if task is removed while Overview is showing
Bug: 78660939
Change-Id: Iccfb09c985662c150f42d382b92d17f853abaaea
2018-05-01 10:04:46 -07:00
android-build-team Robot
4c6b638e24 Merge "Secondary split screen app will be next to the navigation bar (2/2)" into ub-launcher3-edmonton 2018-05-01 00:40:27 +00:00
Sunny Goyal
36d090df67 Adding a round rect background for the self in Overview
Bug: 78771910
Change-Id: I71460a284ed185e82d66fe65104402fb99d6b312
2018-04-30 15:37:39 -07:00
Matthew Ng
8013843fbd Secondary split screen app will be next to the navigation bar (2/2)
Refactored docked position code into PhoneWindowManager to determine
which side the docked app should go based on the position of the nav bar
in landscape (as portrait will only have top). Fixed the split screen
entrance animation for quick step's overview.

Change-Id: I0035214cecb9c6403c59f4b938c2d1ae924f34b0
Fixes: 73250406
Test: play around with splitscreen and minimized mode
2018-04-30 15:01:32 -07:00
android-build-team Robot
6dcf142f61 Merge "Fixing task open animation in split screen mode" into ub-launcher3-edmonton 2018-04-30 21:27:38 +00:00
Vadim Tryshev
83b4bb0421 Making sure Clear-all button can't be clicked when transparent
There are times when the button is visible, but completely transparent.
Fixing: now when transparent, it's invisible, consequently, unclickable.

Bug: 72222505
Test: Manual
Change-Id: I1be162b56d6e694199fad7845c64f3438415a190
2018-04-30 12:14:58 -07:00
android-build-team Robot
3aa3eb51e2 Merge "Alpha-optimizing Clear All button." into ub-launcher3-edmonton 2018-04-28 03:20:08 +00:00
Vadim Tryshev
94ab3eee48 Alpha-optimizing Clear All button.
Similar approach is used for its sister buttons in System UI
(like id/dismiss_text which is
"FooterViewButton extends AlphaOptimizedButton").

Bug: 72222505
Test: Manual
Change-Id: Ibb8157bfbf2bf9cddb501c1e80fb9c7c79bb694b
2018-04-27 20:02:38 -07:00
android-build-team Robot
68f138990b Merge "Let Launcher handle proxy touch events even if it is not focused" into ub-launcher3-edmonton 2018-04-28 00:25:01 +00:00
Sunny Goyal
09cc13e20c Let Launcher handle proxy touch events even if it is not focused
Bug: 74616863
Bug: 78367228
Change-Id: I8c9271e95583793af0832e3b07c988261b6267e8
2018-04-27 17:14:05 -07:00
Hyunyoung Song
cbebaa19f9 Add user event logging for clear all button (follow up CL)
Bug: 72222505

Change-Id: I95e3bb8dbf55e9ae4ca8de4040eb89ddfb161368
2018-04-27 16:39:23 -07:00
Sunny Goyal
5fdd300e8a Fixing task open animation in split screen mode
Removing duplicate logic for task bounds calculation and using
ClipAnimationHelper everywhere

Bug: 78126501
Change-Id: I5ed8b2f9162f0bd6144a849f5b677963776d325c
2018-04-27 16:36:19 -07:00
Hyunyoung Song
63311a2ddc Add user event logging for clear all button
Bug: 72222505

----------------------------------------------
Verified

UserEvent: action:TAP
UserEvent:  Source child:CLEAR_ALL_BUTTON
UserEvent:  Elapsed container 8142 ms, session 11322 ms, action 0 ms
----------------------------------------------
Change-Id: I3ace51c30129728017c5eb198c52ab1bfd94c0ac
2018-04-27 15:54:15 -07:00
android-build-team Robot
15260fdd00 Merge "Enable Clear-all button by default" into ub-launcher3-edmonton 2018-04-27 20:44:02 +00:00
Vadim Tryshev
cc0c98ad94 Enable Clear-all button by default
Making it work with all 4 combinations of RTL and flip-recents.

Bug: 72222505
Test: Manual
Change-Id: Ifb2428e006674abfe9a2609fd3d8f3f648eff0b8
2018-04-27 13:32:28 -07:00
android-build-team Robot
c2c907edec Merge "Preventing new object creation during animation frame" into ub-launcher3-edmonton 2018-04-27 19:15:32 +00:00
Sunny Goyal
70abd3f91c Preventing new object creation during animation frame
Bug: 74556464
Change-Id: I85c106839c11f9588d5f4a6f1ffa35cafb754624
2018-04-27 12:04:29 -07:00
android-build-team Robot
e14a462e9f Merge "Using the split screen secondory bounds returned by SystemUIProxy" into ub-launcher3-edmonton 2018-04-27 17:05:11 +00:00
Sunny Goyal
a18918a0ed Using the split screen secondory bounds returned by SystemUIProxy
Bug: 77281732
Change-Id: I0ae75528ec2fae006a11833b06383369ba593365
2018-04-27 16:48:51 +00:00
TreeHugger Robot
553f13a13e Merge "Shared touch and drag slops for quick step changes with density (2/3)" into ub-launcher3-edmonton 2018-04-26 21:07:47 +00:00
Matthew Ng
4df80700c4 Shared touch and drag slops for quick step changes with density (2/3)
All shared touch and drag slops are not static anymore but are computed
for the current system density if the user were to switch density of
device.

Test: change density and use quick scrub
Fixes: 78244075
Change-Id: Idc35e78bdd9c6d9b31a1ccbdd9cd0e7fec87185f
2018-04-26 13:57:11 -07:00
Winson Chung
473730fcf9 Call Activity.onTrimMemory() to ensure render thread cache is also trimmed
Bug: 76162466
Change-Id: Ie3cf9076ba8149c0f2d7e58b5ca0c974ae914c18
2018-04-26 12:07:39 -07:00
TreeHugger Robot
1d2c3fb9be Merge "Fix issue with z order layering" into ub-launcher3-edmonton 2018-04-26 18:18:57 +00:00
Winson Chung
90749604f4 Fix issue with z order layering
- Move first frame remote animation logic into the same method to ensure
  we consistently update the layers and state for every animation

Bug: 78249267
Change-Id: Id0378cfe3e1be56128c2a1cd607929225927e3b4
2018-04-26 10:58:01 -07:00
Sunny Goyal
23f83a8b7b Revert "Revert "Fixing recents transition not getting completed when using QuickScrub""
This reverts commit dea746cb4c.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I695dbd069eeea266c74e15cb76c7fbcdf553ac84
2018-04-26 17:56:17 +00:00
Sunny Goyal
6a9bc7dfa7 Revert "Revert "Long swipe from an app goes all the way to all-apps""
This reverts commit 1b6e81ed14.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I3d97f70a04a7d75d959b24f79198f6c9f7014b10
2018-04-26 17:29:36 +00:00
Sunny Goyal
1b6e81ed14 Revert "Long swipe from an app goes all the way to all-apps"
This reverts commit f39e602a00.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I4d812a200f78447d9c9a1c4c2fcc9dca0b0c2ca9
2018-04-26 16:32:34 +00:00
Sunny Goyal
dea746cb4c Revert "Fixing recents transition not getting completed when using QuickScrub"
This reverts commit 22c72167ae.

Reason for revert: <INSERT REASONING HERE>

Change-Id: Iecb5d145af299c6ee2a6383d5bf8c912f546a8e9
2018-04-26 16:21:38 +00:00
Sunny Goyal
22c72167ae Fixing recents transition not getting completed when using QuickScrub
Bug: 78615441
Change-Id: I30a876abb1f4129c7dc022762154f4cc21e677f1
2018-04-26 08:19:40 -07:00
Jorim Jaggi
118295e07c Fix some jank with transitions
- Animations in WorkspacePageIndicator while the app transition
was running was causing layer trashing, potentially leading to
jank.
- Make sure to use a layer in the wallpaper open animation.

Test: Open app while indicators are about to fade out.
Bug: 75985430
Change-Id: Iad6a511d98dff81b5cde727f4472f0f039ffc4be
2018-04-26 14:47:44 +02:00
Tony Wickham
dcad5534a0 Merge "Animate icon scale when hitting recents button" into ub-launcher3-edmonton 2018-04-26 01:27:47 +00:00
Tony Wickham
0ca2b2b75a Animate icon scale when hitting recents button
Change-Id: I8d34ef6c44ee8264f50489173e204a19c83cb3e1
2018-04-25 17:45:02 -07:00
Tony Wickham
7a0e965c4f Merge "Don't animate hotseat when launching if swipe up disabled" into ub-launcher3-edmonton 2018-04-26 00:44:45 +00:00
Tony Wickham
4923c0557f Don't animate hotseat when launching if swipe up disabled
Bug: 78248316
Change-Id: Iaee33a81db5b46fc73d6e08ec1b109a1da842106
2018-04-25 17:12:18 -07:00
Sunny Goyal
f39e602a00 Long swipe from an app goes all the way to all-apps
Bug: 76449024
Change-Id: Ie6a0c5b7fd6d497ea8ac5f0a861a84c2290f84b1
2018-04-25 15:44:13 -07:00
Sunny Goyal
dcb74be7a6 Only rotate screenshots taken in full-screen mode
Bug: 78155683
Change-Id: I8a730c1fbd85c4cb8548049231daccc48c1a3627
2018-04-25 14:46:21 -07:00