Commit Graph

18147 Commits

Author SHA1 Message Date
Uwais Ashraf
99fdf7a75e App chip refactor
- Adds background outline replacing 2 circles + rect approach. This
enables easier shadow drawing code.
- Simplify structure of AppChipView.
- Adds an anchor View to simplify laying out of menu around app chip

Bug: 313644427
Bug: 317007147
Fix: 322760765
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest
Change-Id: I56c2644779863c083ae475a740a84321b1d0c396
2024-02-09 12:09:42 +00:00
Jagrut Desai
8f4e0d0c83 Merge "Fixing NPE android.platform.test.scenario.launcher.overview testcases" into main 2024-02-06 22:57:09 +00:00
Fengjiang Li
7f827e1527 Merge "[Predictive Back] Replace legacy flag with aconfig flag in launcher" into main 2024-02-06 21:57:34 +00:00
Shamali Patwa
efebbb21fe Merge "Update prediction task to provide categorized suggestions." into main 2024-02-06 21:36:14 +00:00
Tracy Zhou
b7efb5cb49 Merge "Only hide back button in SUW when ime is rendering it" into main 2024-02-06 20:24:29 +00:00
Sunny Goyal
d1176bccf9 Merge "Using system API for rotating DisplayCutout instead of rotating it ourselves" into main 2024-02-06 20:20:47 +00:00
Jagrut Desai
77d2e7860a Fixing NPE android.platform.test.scenario.launcher.overview testcases
Test: Presubmit, run staging platinum test on this change
Bug: 303256981
Flag: NONE
Change-Id: I9f807b008bb08909b4a08e750b4357b7d23eba39
2024-02-06 11:41:44 -08:00
Sunny Goyal
a90500d233 Using system API for rotating DisplayCutout instead of rotating it ourselves
Bug: 321913010
Flag: NONE
Test: Manual
Change-Id: Iebbc8c17dc3b92a73866b7e22dfbde18eb3a52ff
2024-02-06 10:26:18 -08:00
Shamali P
57c1eedbc6 Update prediction task to provide categorized suggestions.
Also adds a helper in popup data provider to provide categorized
suggestions. Used in follow up CL to update the UI.

Bug: 318410881
Test: WidgetsPredictionUpdateTaskTest and manual with follow up changes
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: Ie80e8ba7bbe874f7c4b0e579446edf571036555e
2024-02-06 18:14:49 +00:00
Alex Chau
1380459097 Merge "Fix Select mode problem with animation off" into main 2024-02-06 16:55:56 +00:00
Johannes Gallmann
2441874a75 Merge "Fix crash for predictive back to home fallback animation" into main 2024-02-06 16:13:30 +00:00
Alex Chau
55b8b43fef Fix Select mode problem with animation off
- Avoid calling resetTaskVisuals when entering Modal state with animation off, it should only be called when leaving Overview, to be consistent with animation on case
- Use a separate property to control alpha for modalness, to avoid being overridden by other transition

Fix: 320314839
Test: presubmit
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I12a35682e25c3a70bc263afdc90a7895d6c56f11
2024-02-06 14:16:43 +00:00
Vinit Nayak
bc663baab0 Merge "Fix bug with portrait-fold devices animating app pairs launch wrongly" into main 2024-02-06 13:15:33 +00:00
Jeremy Sim
2d0fd0780a Fix bug with portrait-fold devices animating app pairs launch wrongly
This CL makes it so that isLeftRightSplit is correctly called instead of isLandscape when animating an app pair launch.

Fixes: 318756992
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: Id766a3f9bd315abc277e36a118fd233156cf3898
2024-02-06 18:40:03 +08:00
Vinit Nayak
d471844135 Merge "Revert^2 "Prevent taskbar animation for contextual split from home"" into main 2024-02-06 03:53:38 +00:00
Vinit Nayak
c5376624c8 Merge "Update split with self test since it didn't account for contextual split" into main 2024-02-06 03:47:17 +00:00
Fengjiang Li
cd60d191a8 [Predictive Back] Replace legacy flag with aconfig flag in launcher
Fix: 323971106
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Test: manual
Change-Id: Ie8051af2540699a7d75f1ed05132584d0b40d17d
2024-02-05 16:41:29 -08:00
Vinit Nayak
fe35d069d2 Update split with self test since it didn't account for contextual split
* Right now we split from all apps and we stay in all apps with
contextual split.
* We now have 2 paths, if we are in contextual split then we
should select the same app from all apps again

Fixes: 323418145
Change-Id: I3bde59847b9e47951a6acdc93660b600114c3ddd
2024-02-05 16:08:30 -08:00
Schneider Victor-tulias
05511943c2 Merge "Add TAPL test cases for KQS from taskbar all apps." into main 2024-02-06 00:01:48 +00:00
Vinit Nayak
5f2b7242f3 Revert^2 "Prevent taskbar animation for contextual split from home"
This reverts commit 8b78849c44.

Reason for revert: Did not fix failing test b/323418145

Change-Id: Ic0897dda930a76aa27fba6e9de925b653d63a7f4
2024-02-06 00:00:35 +00:00
Saumya Prakash
548add276e Merge "Increase the character limit for translations in taskbar pinning edu" into main 2024-02-05 23:44:58 +00:00
Jordan Silva
d5df5b3e11 Merge "Refactoring TAPL functions for OverviewTask" into main 2024-02-05 23:03:49 +00:00
Fengjiang Li
3088ae55d1 Merge "Add unit test for StatusBarTouchController.java" into main 2024-02-05 22:29:35 +00:00
Saumya Prakash
1613fe6b13 Increase the character limit for translations in taskbar pinning edu
The current character limit for the taskbar pinning edu subtitle does
not fit many translations. We are increasing the character limit to
enable proper translations.

Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Fix: 323943380
Test: N/A
Change-Id: I56225711c475e617451e5db0b1c226e3603e5c02
2024-02-05 21:40:38 +00:00
Schneider Victor-tulias
853d7d3b4c Add TAPL test cases for KQS from taskbar all apps.
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 323218341
Test: TaplTestsKeyboardQuickSwitch
Change-Id: Ie8f23ad14e4a32abbc5b49edc05ce407bbb774e6
2024-02-05 15:41:19 -05:00
Vinit Nayak
562fe01e5e Merge "Update fail fast check logic" into main 2024-02-05 20:00:08 +00:00
Fengjiang Li
1f0465e9f2 Add unit test for StatusBarTouchController.java
Test: this one
Flag: NONE
Bug: 282945183
Change-Id: I76eb4389d71d7a03e038ed6b01b6f5b7923fd11a
2024-02-05 11:51:01 -08:00
Vinit Nayak
ccab39e714 Merge "Revert "Prevent taskbar animation for contextual split from home"" into main 2024-02-05 19:39:00 +00:00
Vadim Tryshev
3517550379 Merge "Starting measuring displacement from the edge of the slop zone" into main 2024-02-05 18:22:12 +00:00
Vinit Nayak
628a039721 Update fail fast check logic
* Incorrectly wasn't erroring out when flag was not enabled

Bug: 295467097
Change-Id: I5716309f832d1170ea92ad357897299c0438d2d0
2024-02-05 10:21:26 -08:00
Jagrut Desai
c5be03f062 Merge "Change Persistent/Pinned Taskbar App Icon Size to 40dp" into main 2024-02-05 16:54:32 +00:00
Jordan Silva
ebd71c6cc9 Refactoring TAPL functions for OverviewTask
This CL refactors some methods in OverviewTask to rely on OverviewSplitTask. It also changes the BaseOverview getTasks function to retrieve the parent task and support cases where only the bottomright_snapshot is available in the recent tasks.

Bug: 320633351
Test: TaplTestsSplitscreen
Flag: N/A
Change-Id: I226f895810ce3b46cc107f76cd85e2918abf7088
2024-02-05 13:50:23 +00:00
Uwais Ashraf
810a82f13e Merge "Extract GroupedTaskView size calcs to a method to prevent measure calls" into main 2024-02-05 11:35:11 +00:00
Uwais Ashraf
0d355abe38 Extract GroupedTaskView size calcs to a method to prevent measure calls
Bug: 313644427
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest
Change-Id: I494f09455104372209b9087d13a704a4fe52bb62
2024-02-05 10:27:12 +00:00
Tracy Zhou
6474a3b455 Merge "Add split instructions to stage split from keyboard shortcut" into main 2024-02-03 06:02:48 +00:00
Tony Wickham
cac7c6f682 Merge "Send finish callback even if there is no icon to animate to" into main 2024-02-02 22:37:44 +00:00
Vinit Nayak
92dd621d8e Merge "Intercept clicks for non-supported split targets on workspace" into main 2024-02-02 22:07:53 +00:00
Mady Mellor
5912d0f6d9 Merge "Launcher: use aconfig flag for bubble bar" into main 2024-02-02 21:04:32 +00:00
Vadim Tryshev
94477b23e9 Send finish callback even if there is no icon to animate to
Fixes: 321297170
Test: TaplAllAppsIconsWorkingTest#testAppIconLaunchFromAllAppsFromHome
Flag: none
Change-Id: Ia6084dd14715bab36c7dd1c983fabedcf9b10630
2024-02-02 20:42:02 +00:00
Tracy Zhou
d0b9aae52c Add split instructions to stage split from keyboard shortcut
Fixes: 319098298
Test: When launching split from fullscreen app via keyboard shortcut, the split instruction shows
Change-Id: Ie64e5e65384a24825edc7ae6c8dea3203e2bd916
2024-02-02 11:29:10 -08:00
Vinit Nayak
ec52ed9f99 Intercept clicks for non-supported split targets on workspace
* If we're in split selection state we disable the following
- G icon on PSB
- Lens icon on PSB
- Smartspace
- Widgets

Bug: 295467097
Test: Enter split contextual and observe split instructions
view going boing when tapping on unsupported target
Flag: com.android.wm.shell.enable_split_contextual

Change-Id: Ia7783472f3de9359c2784788be5f35596cbc8deb
2024-02-02 08:17:13 -08:00
Sam Cackett
8b997289f0 Merge "Fix issue with IconAppChipView animated states" into main 2024-02-02 12:27:45 +00:00
samcackett
fee52acb29 Fix issue with IconAppChipView animated states
Cancel in progress animations and resume from previous position.
Display TaskMenuView once.

Fixes: 322813710
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I73410d6116876ca83f3b16311d2e9eb372308295
2024-02-02 11:08:47 +00:00
Vinit Nayak
8b78849c44 Revert "Prevent taskbar animation for contextual split from home"
This reverts commit febd61fb3f.

Reason for revert: b/323418145, testing to see if this is the culprit

Change-Id: Ie72ce0d24c6008e93340c1868b18bce68902c7cc
2024-02-02 01:55:18 +00:00
Sunny Goyal
b2f38376c4 Merge "Blocking gestureNav on taskFragments within the Launcher activity" into main 2024-02-02 00:23:29 +00:00
Mady Mellor
cc138663ca Launcher: use aconfig flag for bubble bar
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DISABLED
Test: make & enable / disable flag to check if it works:
      adb shell device_config put multitasking
         com.android.wm.shell.enable_bubble_bar true
Test: PlatformScenarioTests:
      android.platform.test.scenario.sysui.bubble.BubbleBarTest
Bug: 286246694
Change-Id: I0820973848675e8596e0e1605c7e43158d870382
2024-02-01 23:18:53 +00:00
Sunny Goyal
2829c361f3 Blocking gestureNav on taskFragments within the Launcher activity
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: Verified on device
Change-Id: Ie812e17012feb8e99e06d0593207a87ef0c768e3
2024-02-01 13:35:30 -08:00
Schneider Victor-tulias
3dafeb2d09 Merge "Update KQS overview launch animation" into main 2024-02-01 17:55:54 +00:00
Schneider Victor-tulias
8b9ca27cb8 Merge "Handle slow gesture handling" into main 2024-02-01 16:27:21 +00:00
Schneider Victor-tulias
1ca66992c1 Update KQS overview launch animation
Updated the KQS overview launch animation to match the spec: open overview and scroll to the focused task in one fluid motion

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313608085
Test: Opened KQS from home and overview
Change-Id: I2d617db29ff46e89fab50bb6f8aee900b6fe649f
2024-02-01 14:49:29 +00:00