Commit Graph

1136 Commits

Author SHA1 Message Date
Anushree Ganjam
c8ecd62615 Merge "Use BySelector to search for text in search results." into main 2024-06-14 01:46:13 +00:00
Anushree Ganjam
4d404d9f8b Use BySelector to search for text in search results.
Verify the text after it's collected. I ran the test 20 times and
couldn't find the stale object exception being thrown.

Bug: 340341450
Bug: 339737008
Test: Manual
Flag: com.google.android.apps.nexuslauncher.enable_inject_private_space_tile

Change-Id: Ib153205db36cdd8b5fba4734b8b68930857659ff
2024-06-13 15:56:25 -07:00
Jagrut Desai
b09b1a73a2 Merge "Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon" into main 2024-06-13 18:38:05 +00:00
Jagrut Desai
1c794082a7 Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: I69d64ac8a0a496c947acf7fdce142a37005aeedc
2024-06-13 09:30:55 -07:00
Schneider Victor-tulias
11eaec69f4 Add debug logs to BaseOverview#isActionsViewVisible
Flag: NONE debug logs
Bug: 336660988
Test: TaplTestsQuickstep#testQuickSwitchFromHome
Change-Id: If241cd732cfce83d4799895f5e43048d775d72ed
2024-06-12 15:43:16 +00:00
Jeremy Sim
c1470021c8 Fix flaky test
Attempts to fix a flaky test by ensuring that recents is always cleared before creating a split pair (so the split pair under test is always the same).

Bug: 340935208
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair(), testSplitTaskTapBothIconMenus()
Flag: TEST_ONLY
Change-Id: Ibc81b90fac531f0e78e93a494ff59073ab5e52cf
2024-06-10 14:51:53 -07:00
Tracy Zhou
acb4a3d1e8 Support trackpad tapl tests in 3-button mode
Currently we have logic to only enable input monitor when a trackpad is connected. Tapl tests need to have infrastructure to override that logic

Bug: 335146977
Test: presubmit
Change-Id: Ib7f80c828760f8b5abd7ed2788b246e47fca6e34
2024-05-29 21:58:20 -07:00
Vadim Tryshev
d3ef050bc3 Merge "Removing high-level events mismatch diagnostics." into main 2024-05-29 18:42:47 +00:00
Vadim Tryshev
314c35c410 Removing high-level events mismatch diagnostics.
They hide actual sequences, are not necessary for Tigers who are power users and require maintenance.

Bug: 187761685
Test: presubmit
Flag: NONE for test
Change-Id: I5d4b3d80a916845fcf8c08a0ecd135527466fa5a
2024-05-28 13:36:19 -07:00
Jeremy Sim
1ab32a7942 Address jank and memory issues with OverviewActionsView
Attempt to improve jank and memory regressions by simplifying the view layout of OverviewActionsView.

Bug: 339688091
Bug: 339853741
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair()
Flag: EXEMPT bugfix
Change-Id: Ib4a7c5a813b221c0a083144e7fb1e1c5f3fedb1c
2024-05-28 13:16:52 -07:00
Holly Sun
897791a9e7 [PS] Add TAPL test for tile injection.
Bug: 330892261
Test: tapl
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile nextfood

Change-Id: I4cfaefa26a81a1026d62d4206d90881f323bffd3
2024-05-08 16:51:16 -07:00
Jeremy Sim
7d69804e4e Merge "Fix bug with double-relayout of Overview Actions View" into main 2024-05-08 20:24:21 +00:00
Federico Baron
b09442e16a Merge "Reduce steps for goHome()" into main 2024-05-08 17:58:38 +00:00
fbaron
39e1d52c1b Reduce steps for goHome()
The goHome gesture is slow enough sometimes that it gets confused with an overview gesture. Reducing the step count should resolve this (verified in atest and haven't had it fail after changing this)

Flag: NONE
Bug: 336606166
Test: TaplTestsTrackpad#switchToOverview
Change-Id: I7ad388968205addb363cfd9ff4b7eefece170d1b
2024-05-07 20:48:30 -07:00
Holly Jiuyu Sun
8834a6c450 Merge "[PS] Update Install button string." into main 2024-05-07 21:35:02 +00:00
Jeremy Sim
41eadd1a91 Fix bug with double-relayout of Overview Actions View
This CL refactors Overview Actions View so that a separate view, R.id.group_action_buttons, is used for buttons related to grouped tasks. This also changes the way visibility is handled with actions buttons -- instead of all buttons living on one bar and being toggled on and off, sometimes the whole bar is toggled on and off (to change from single task actions to group actions and vice versa).

This prevents the same view from having its visibility changed twice in in one layout and causing the wrong visibility to be rendered.

Fixes: 333844287
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1b6be4637ac8c8d424e7633c437fca376ecdd757
2024-05-07 11:18:24 -07:00
Holly Sun
64f36f3679 [PS] Update Install button string.
Screenshot: https://screenshot.googleplex.com/B6UrJt92QMMgSuG

Bug: 338357091
Test: manual
Flag: aconfig com.android.launcher3.private_space_app_installer_button nextfood
Change-Id: Ia408ccfa20ea3c142bd22c326954d278fa571815
2024-05-06 20:35:01 -07:00
Himanshu Gupta
bf51b4882e Adding Tapl test for locking/unlocking Private Space
In this test:
1. Private Space is created.
2. Lock Button is clicked, locked view is verified.
3. Unlock Button is clicked, unlocked view is verified.
4. Private Space is removed.

Doc: go/private-space-tapl

Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: NA
Change-Id: I1c399a96ea14a4464113576d31eed8db1caf1f2a
2024-05-06 20:03:23 +01:00
Treehugger Robot
f7ed35fc87 Merge "Locking the All Apps view before asserting PS components." into main 2024-05-02 19:02:42 +00:00
Himanshu Gupta
3a0f024044 Locking the All Apps view before asserting PS components.
Bug: 334946529
Test: NA
Flag: NA
Change-Id: Id8895a993f61ee22fcef1ba562aaa8baf156d6d7
2024-05-01 18:52:32 +01:00
Vadim Tryshev
edfa8480a9 Merge "Saving test artifacts in TAPL when the failure is diagnosed" into main 2024-04-29 20:49:15 +00:00
Vadim Tryshev
7a4d696bbb Saving test artifacts in TAPL when the failure is diagnosed
Not waiting for FailureWatcher to catch the exception and save
artifacts. This will help to save test artifacts before potential
deinitialization in the test which may change the screen contents.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I7aa95028acfae3fe0895fc5df4ea6f6912fcda52
2024-04-29 11:53:08 -07:00
Anushree Ganjam
5a2b0ff434 Add TAPL tests for PredictionRow.
This will help us catch and debug following issues
* Prediction row view is missing
* Prediction row view doesn't contain enough apps

Bug: 332171918
Test: Manual
Flag: NA

Change-Id: I11035997afb26799a2c3b69d5139b4f3c28fc405
2024-04-26 16:27:41 -07:00
Himanshu Gupta
102b723d63 Adding Tapl tests for User Installed App in PS.
This test verifies that a user installed app
is shown above the sys apps divider, within the
Private Space container.

Bug: 322882655
Test: atest NexusLauncherTests:com.android.quickstep.TaplPrivateSpaceTest
Flag: NA
Change-Id: Id85105339ae45c263d9ef52a3bb55784587e887d
2024-04-23 15:22:43 +01:00
Schneider Victor-tulias
abf9f308a5 Remove debug tracing for b/332386996
Flag: N/A
Fixes: 332386996
Test: TaplTestsQuickstep
Change-Id: I0d0aa5d5654dbf391269333eb4808d36f5e645ed
2024-04-22 16:16:42 +00:00
Priyanka Advani
7d92102140 Merge "Revert^3 "Wait for LauncherModel loaded in waitForLauncherInitialized"" into main 2024-04-16 00:46:24 +00:00
Priyanka Advani
4e97c94559 Revert^3 "Wait for LauncherModel loaded in waitForLauncherInitialized"
This reverts commit 503ce966ef.

Reason for revert: Culprit for test breakages in b/334995023. Will be verifying through ABTD for confirmation and before submitting the revert.

Change-Id: Id8707cb2074b4f00ec332ebb14deb7d143ff1bbb
2024-04-15 22:18:31 +00:00
Schneider Victor-tulias
9d4fb2b5be Merge "Revert^2 "Wait for LauncherModel loaded in waitForLauncherInitialized"" into main 2024-04-15 19:30:38 +00:00
Schneider Victor-tulias
503ce966ef Revert^2 "Wait for LauncherModel loaded in waitForLauncherInitialized"
This reverts commit b80c6c347a.

Reason for revert: The original change was not the cause for the test failures

Change-Id: Icfe0da43a96f5471076554c4dd25eae649bee81e
2024-04-15 15:58:19 +00:00
Liana Kazanova
b80c6c347a Revert "Wait for LauncherModel loaded in waitForLauncherInitialized"
This reverts commit f8f00f4233.

Reason for revert: DroidMonitor: Potential culprit for http://b/334162623.  verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Id165df41a87af4757abd3266b8643949ce012a08
2024-04-12 21:30:50 +00:00
Jagrut Desai
49d4429881 Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon test
Test: Presubmit
Bug: 319501259
Flag: NONE
Change-Id: I9566b947bc7d5d64953a8c637fefd4fa37cca87c
2024-04-12 11:37:27 -07:00
Schneider Victor-tulias
f8f00f4233 Wait for LauncherModel loaded in waitForLauncherInitialized
Flag: N/A
Fixes: 326737440
Test: Launcher TAPL tests
Change-Id: I631b370198c393ad84419930c026b6a0ce63ec2b
2024-04-12 12:48:48 -04:00
Himanshu Gupta
6c089d7ac1 Merge "Adding TAPL tests for Private Space in Quickstep." into main 2024-04-09 21:12:09 +00:00
Himanshu Gupta
0d400993a9 Adding TAPL tests for Private Space in Quickstep.
This CL adds an initial test, that creates
private profile and verifies the elements
present in unlocked state.

More tests will be followed in next CL.

Doc: go/private-space-tapl

Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: NA
Change-Id: I6032f4531818031991a5d51e23cfad22518250e6
2024-04-09 20:30:31 +01:00
Jordan Silva
a3eff1fe96 Update save app pair test to validate when icon chip menu is disabled
This CL adds a validation in the test to check if save app pair action is available in the overview actions. Kept the validation to check if save app pair is available in the menu only for overview icon menu flag enabled.

Bug: 330515672
Flag: N/A
Test: TaplTestsSplitscreen
Change-Id: I3097180a24b430f2310d11ddec36e6d6cf4982fb
2024-04-08 12:30:51 -07:00
Alex Chau
7d0edb46ac Reland "Update Split button visibility based on DeviceProfile change"
This reverts commit 38bc885de9.

- Always request layout of action_buttons after changing visibility of its children
- Update Split button visibility based on DeviceProfile change in updateDimension() only
- Update Split button visibility based on 3P launcher in initialization only
- Also simplified action_buttons to wrap_content and layout in middle of parent
- Also removed the space between buttons and use marginStart
- Fixed TAPL to not expect save app pair button on phone. Before this CL actions_buttons are still on view hierarchy despite they're not visible on screen.

Fix: 321291049
Fix: 329255757
Test: Clear all tasks, fold, launch app, swipe up to Overivew; repeat in RTL
Test: OverviewImageTest
Flag: None
Change-Id: I9ecf872279f6f07d2d9bc33fb09031568023cb77
2024-04-04 11:58:35 +01:00
Mateusz Cicheński
5f8124ad05 Support going home from immersive fullscreen in 3 button nav
In gesture nav the swipe happens at the bottom of the screen,
which brings the navbar handle into the view.

In 3 button nav the swipe needs to happen from the right edge of
the screen, because the 3 button nav is always staying fixed in
the "bottom portrait" position, unless it is large screen, in
which case it should happen on the bottom landscape edge.

This can be detected via config_navBarCanMove resource value.

Bug: 313928629
Test: atest NetflixEnterPipTest
Test: above command on foldable in folded and unfolded state
Flag: n/a

Change-Id: I0a94757687fd9eb491b2a5cf0086ae51589ae0aa
2024-03-29 17:31:29 +00:00
Schneider Victor-tulias
02e57b3d62 Add ExtendedLongPressTimeoutRule to all AbstractLauncherUiTest
When devices run slow in pre/post-submit, it is possible for a drag to be processed at a long press before the first move event can be created and dispatched. Added a rule to artificially increase this long press timeout in tests.

Flag: N/A
Fixes: 319257820
Test: TAPL tests
Change-Id: I24e0f3baec15db7558351d0cb2bd93a4e49640e8
2024-03-25 11:22:31 -04:00
Federico Baron
3a7432d782 Merge "Make touch outside container touch at the middle of the container in terms of height" into main 2024-03-20 18:08:14 +00:00
fbaron
30bd886364 Make touch outside container touch at the middle of the container in terms of height
Bug: 326839375
Test: TaplTestsQuickstep#testOverviewDeadzones
Flag: NONE
Change-Id: I7a013ab7d146756cbff009c21b838881e09e044a
2024-03-19 16:44:07 -07:00
Tony Wickham
86d8386ab6 Merge "Add TaplTestsQuickstep#testExcludeFromRecents" into main 2024-03-19 20:28:58 +00:00
Tony Wickham
b84b8524a1 Add TaplTestsQuickstep#testExcludeFromRecents
- Add ExcludeFromRecentsTestActivity, and add it to the manifest
  with excludeFromRecents="true"
- Add the test to check the current Overview task content
  description, ensuring that the excludeFromRecents task is
  present directly after a gesture but not after going home.
Bug: 324495241
Flag: None
Test: TaplTestsQuickstep#testExcludeFromRecents

Change-Id: I06be53673f0ac06924f79b44f19744da066cc7ea
2024-03-18 22:30:13 +00:00
Fengjiang Li
00711e68a5 Merge "Enable predictive back in TAPL tests" into main 2024-03-15 14:52:58 +00:00
Fengjiang Li
e90f098d4f Enable predictive back in TAPL tests
With ag/26349940 we have fixed the bug where back swipe is not working

Fix: 326118348
Test: this is the test
Flag: NONE
Change-Id: I7e826f6ba3022a04d016d4a0a2134e287d85e8be
2024-03-15 00:00:37 -07:00
Sukesh Ram
8229228132 Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: I7c30fb2f3c94770fa79780d2e7748e931552ba56
2024-03-12 02:17:59 +00:00
Anushree Ganjam
461038d5d5 Remove expecting DOWN events in TAPL tests.
ACTION_UP is always preceded by ACTION_DOWN which means when launcher
receives an UP events, down event is obviously sent.

In b/325377690 , we started seeing only in P9 devices the DOWN events didn't reach TAPL. I added InputDispatcher logs which shows both DOWN and UP events are sent by system_server to NexusLauncher.
However TAPL doesn't receive it. After spending lot of time debugging this, I think we are safe to remove DOWN event expectation in TAPL.

Bug: 325377690
Test: Manual, TAPL presubmits
Flag: NA
Change-Id: I6d3587c488d45e3dc53d2c1c4f3b6b49285eae94
2024-03-07 12:31:38 -08:00
Vinit Nayak
91b06fb4ac Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-04 12:26:23 -08:00
Uwais Ashraf
9c2f5a4c62 Remove classes related to E2E testing from deviceless test classpath
Fix: 327187136
Flag: NA
Test: gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Test: presubmits passing
Change-Id: I4f05524bdc55d8473f3b5115cc239eb8cc48a856
2024-03-04 13:45:32 +00:00
Uwais Ashraf
77b97c0729 Replace existing Robolectric test task with functioning one.
This CL does the following:
- Creates a dir for multivalentTests
- Creates symlinks for the dir to keep Android Studio happy
- Moves many files to the multivalentTests dir
- Adjusts gradle and soong build files to use the new dir as part of
their source sets.

Test: ./gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Fix: 316553886
Bug: 316553889
Flag: NA
Change-Id: Iae28fd0c0191b3ecf9bd2950800875950cca2622
2024-01-19 21:39:23 +00:00
Andy Wickham
fb97d92e9a Merge "Ensure "AppIconSelector" does not match folders." into main 2024-01-16 19:18:11 +00:00