Commit Graph

11894 Commits

Author SHA1 Message Date
Brian Isganitis
8aad11912d Merge "Only stash for IME when in-app and in overview." into main 2024-05-31 19:25:31 +00:00
Ats Jenk
348ac13cfe Merge "Notify pin controller about stuck to dismiss" into main 2024-05-31 16:46:54 +00:00
Jordan Silva
a74d1e419b Merge "Add Accessibility Menu support for multiple DWB banners" into main 2024-05-31 11:15:00 +00:00
Jagrut Desai
4c6913395c Merge "Accessibility Annoucement for the always show taskbar switch" into main 2024-05-31 05:33:15 +00:00
Jagrut Desai
7570f36e28 Accessibility Annoucement for the always show taskbar switch
Test: Manual
Bug: 326012899
Flag: com.android.launcher3.enable_taskbar_pinning

Change-Id: Idad1c6349d14153468e0c660703f5ff1808ab8e5
2024-05-30 14:50:53 -07:00
Brian Isganitis
d4d6388c8a Only stash for IME when in-app and in overview.
Making it a force stashed flag does not work because we do not stashing
to occur in Launcher non-overview states.

Flag: EXEMPT bugfix
Fix: 343756969
Test: Manual
Change-Id: Ib9c9e6fd1213777e66e8b48a20a2bbeb210ded8a
2024-05-30 16:02:06 -04:00
Priyanka Advani
34459f0210 Merge "Revert "Always report mandatory insets for button nav"" into 24D1-dev am: 8ec05c628b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27593486

Change-Id: I6242e741fba0b4b95be4b7e47a44ad515faf64b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 18:57:33 +00:00
Priyanka Advani
8ec05c628b Merge "Revert "Always report mandatory insets for button nav"" into 24D1-dev 2024-05-30 18:50:44 +00:00
Tracy Zhou
55308cadcf Merge "Support trackpad tapl tests in 3-button mode" into main 2024-05-30 17:59:13 +00:00
Jordan Silva
1b487619a0 Add Accessibility Menu support for multiple DWB banners
Fix: 341672022
Flag: EXEMPT Bug fix
Test: Manual. With Talkback on, open two apps in split screen and both with DWB enabled, go to Overview, access the Accessibility Menu > Actions.
Change-Id: Iff6adf8d549aa00ea42598cbfbdaf8c7a4164b29
2024-05-30 18:22:38 +01:00
Jordan Silva
8181dfdf92 Fix Talkback wrong label announced going from App to Overview
To fix the incorrect title information being spoken after a transition state ends, a new function named getTitle is introduced in the LauncherState. This function provides the correct title for the transition state. The default accessibility label is set to R.string.home_screen. All Apps and Overview states override the getTitle function to ensure the correct accessibility label for their respective states.

Fix: 265892510
Flag: EXEMPT bugfix
Test: Manual with Talkback. With Talkback enabled, navigate from App to Overview.
Change-Id: I96b820f310f8b778a149709bca687a5912386246
2024-05-30 14:01:32 +00:00
Chaitanya Cheemala
1773b06050 Revert "Always report mandatory insets for button nav"
This reverts commit 4304a14206.

Reason for revert: Likely culprit for b/343564388  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ibc6fae27f31bcb54406da013babc76b2d5fc7f10
2024-05-30 11:44:57 +00:00
Treehugger Robot
1d9f23b1ad Merge "Fix DWB banner not showing up for split tasks" into main 2024-05-30 11:04:37 +00:00
Tracy Zhou
acb4a3d1e8 Support trackpad tapl tests in 3-button mode
Currently we have logic to only enable input monitor when a trackpad is connected. Tapl tests need to have infrastructure to override that logic

Bug: 335146977
Test: presubmit
Change-Id: Ib7f80c828760f8b5abd7ed2788b246e47fca6e34
2024-05-29 21:58:20 -07:00
Tracy Zhou
a27409e8b2 Merge "Register input monitor for trackpad only when trackpad is attached" into main 2024-05-30 04:12:27 +00:00
Winson Chung
50a37b33a9 Merge "Always report mandatory insets for button nav" into 24D1-dev am: 6de4b5286a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27569834

Change-Id: I2fa88ec94e77fc7ecf4086b8de28c9602a9a85cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 23:01:24 +00:00
Winson Chung
6de4b5286a Merge "Always report mandatory insets for button nav" into 24D1-dev 2024-05-29 22:56:05 +00:00
Jeremy Sim
1abc4761cc Address jank and memory issues with OverviewActionsView
Attempt to improve jank and memory regressions by simplifying the view layout of OverviewActionsView.

Bug: 339688091
Bug: 339853741
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair()
Flag: EXEMPT bugfix
Change-Id: Ib4a7c5a813b221c0a083144e7fb1e1c5f3fedb1c
2024-05-29 18:15:32 +00:00
Alex Chau
e081914fb1 Fix DWB banner not showing up for split tasks
- Remove DWB banner and thumbnailView from TaskView when being recycled to avoid multiple banners from staying
- Extracted DWB toastg splitbounds update to not be called whenever task icon is loaded
- Refactor DWB toast to remove unused variable, and extract mSplitBannerConfig to be a getter

Fix: 343212887
Test: OverviewImageTest.digitalWellbeingToast
Flag: EXEMPT bugfix
Change-Id: I2dbdc483a7b99de009c9e2a946e1b026c5e4817f
2024-05-29 16:44:48 +01:00
Uwais Ashraf
3661e3f655 Merge "Add snapshot state to TaskThumbnailView and ViewModel" into main 2024-05-29 14:21:28 +00:00
Uwais Ashraf
bad2e24f72 Add snapshot state to TaskThumbnailView and ViewModel
Bug: 334825222
Test: TaskThumbnailViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I829c346861a6f437b2c53dadb3a7f98084d3c962
2024-05-29 10:47:05 +00:00
Alex Chau
09ae3694e3 Merge "Address jank and memory issues with OverviewActionsView" into main 2024-05-29 09:36:37 +00:00
Winson Chung
4304a14206 Always report mandatory insets for button nav
Fixes: 340134342
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Change-Id: Iee9d5ca9f12ff63f856e7aa94227e5b8273e02a4
2024-05-29 06:39:57 +00:00
Ats Jenk
2b0efdb621 Notify pin controller about stuck to dismiss
Based on changes to the base controller we now only need to notify when
a dragged item is stuck to the dismiss view.

Bug: 339659499
Test: manual
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I82c5c4946b955b06cfba91179931e690d0591107
2024-05-28 16:37:06 -07:00
Vinit Nayak
b34cc291d0 Merge "Return false for isSplitSelectionActive() if controller not initialized" into 24D1-dev 2024-05-28 20:39:58 +00:00
Vinit Nayak
364d784242 Merge "Disable gestures when split apps are animating in from shell" into 24D1-dev 2024-05-28 20:21:53 +00:00
Vinit Nayak
f9b81f24a4 Return false for isSplitSelectionActive() if controller not initialized
Test: unable to repro
Fixes: 342716244
Flag: EXEMPT bugfix
Change-Id: I9d7d54d5f7571286778c0e82ef4082f9b5843c1d
(cherry picked from commit b449116345)
Merged-In: I9d7d54d5f7571286778c0e82ef4082f9b5843c1d
2024-05-28 20:19:46 +00:00
Vinit Nayak
e3f3118bfa Merge "Return false for isSplitSelectionActive() if controller not initialized" into main 2024-05-28 20:19:26 +00:00
Jeremy Sim
1ab32a7942 Address jank and memory issues with OverviewActionsView
Attempt to improve jank and memory regressions by simplifying the view layout of OverviewActionsView.

Bug: 339688091
Bug: 339853741
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair()
Flag: EXEMPT bugfix
Change-Id: Ib4a7c5a813b221c0a083144e7fb1e1c5f3fedb1c
2024-05-28 13:16:52 -07:00
Andy Wickham
28cc86ee38 Merge "Revert "[omni] Handle touch slop for LPAA."" into main 2024-05-28 18:54:08 +00:00
Vinit Nayak
b449116345 Return false for isSplitSelectionActive() if controller not initialized
Test: unable to repro
Fixes: 342716244
Flag: EXEMPT bugfix
Change-Id: I9d7d54d5f7571286778c0e82ef4082f9b5843c1d
2024-05-28 11:23:37 -07:00
Orhan Uysal
f38d739130 Merge "Revert "Fix activity leak"" into main 2024-05-28 12:10:40 +00:00
Orhan Uysal
e0e5460066 Revert "Fix activity leak"
This reverts commit 67c807a1fe.

Reason for revert: <Setting the SplitSelectStateController to null causes NPE in launcher>

Fix: 342553715
Bug: 332339792
Change-Id: I10433e468948c4ba826e79baa06925fdf7dfbe5d
2024-05-28 10:17:53 +00:00
Tracy Zhou
db295670fd Register input monitor for trackpad only when trackpad is attached
Fixes: 335146977
Test: Use logging to make sure that input monitor isn't registered in 3 button mode when trackpad is not attached. When it's attached, it's registered upon attachment
Change-Id: I89fc249546945b3adfc4c804eefd53808138168d
2024-05-26 17:42:30 -07:00
Brian Isganitis
1b973c068d Merge "Use phone handlebar size for tiny taskbar." into main 2024-05-25 21:31:28 +00:00
Brian Isganitis
e25ce33ab8 Merge "Prototype tiny taskbar all apps." into main 2024-05-25 19:15:35 +00:00
Sunny Goyal
b03d274375 Merge "Fixing some missing swipecancelled events" into main 2024-05-25 08:11:56 +00:00
Sunny Goyal
97ceed42e6 Fixing some missing swipecancelled events
Updating NavBarPosition to expose more constructor and getters

Flag: com.android.launcher3.use_activity_overlay
Test: atest SwipeTransitionTest
Bug: 340432854
Change-Id: I86193fa26c0337d50e366cecb2d7debf37940fe1
2024-05-24 17:34:36 -07:00
Jagrut Desai
0214b921aa Revert "[omni] Handle touch slop for LPAA."
This reverts commit 49dc99abb0.

Reason for revert: Failing Nexus Launcher Tests

Change-Id: I145dadaef4ff1959b7e617d7b832150579145725
2024-05-24 21:06:07 +00:00
Brian Isganitis
8f6e33714a Use phone handlebar size for tiny taskbar.
Flag: com.android.wm.shell.enable_tiny_taskbar
Test: Manual
Bug: 341784466
Change-Id: I8dbe04e221ada4d01f9525f62a257a1d983f86f0
2024-05-24 19:12:59 +00:00
Brian Isganitis
7317e42b47 Merge changes I340485ed,Iba07382d into main
* changes:
  Disable taskbar EDU for tiny taskbar.
  Initial prototype of tiny taskbar.
2024-05-24 19:11:55 +00:00
Uwais Ashraf
e497456547 Merge "Add TasksRepository" into main 2024-05-24 15:49:46 +00:00
Uwais Ashraf
f6f34ca441 Add TasksRepository
Bug: 334825222
Test: TasksRepositoryTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I3e08dea7b205df54f8bef456ead6466aa2ce45c6
2024-05-24 12:06:59 +00:00
Pierre Barbier de Reuille
2de842b558 Merge "Update desktop mode to identify minimized tasks" into main 2024-05-24 08:26:48 +00:00
Winson Chung
21bb36fa66 Report gesture height for mandatory system gestures
- We are currently reporting the content insets for the mandatory system
  gestures in taskbar, but for button nav we should actually be
  reporting zero, and for gesture nav we should either report the
  content height if the taskbar is pinned, or the gesture height
  otherwise as the bottom mandatory gesture inset

Fixes: 340134342
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Change-Id: Ie4d56b62c903c273db95c19c9d34fcfe6c9ce486
Merged-In: Ie4d56b62c903c273db95c19c9d34fcfe6c9ce486
(cherry picked from commit 05682a059f)
2024-05-24 07:15:17 +00:00
Winson Chung
0131a2757f Merge "Report gesture height for mandatory system gestures" into main 2024-05-24 04:32:12 +00:00
Vinit Nayak
f08e1afa37 Disable gestures when split apps are animating in from shell
Bug: 286509643
Test: See other CL in topic
Change-Id: Ic770bdf5ae6f847b1deca3b1d7e5a389ddd6663e
Merged-In: Ic770bdf5ae6f847b1deca3b1d7e5a389ddd6663e
2024-05-23 22:54:55 +00:00
Winson Chung
05682a059f Report gesture height for mandatory system gestures
- We are currently reporting the content insets for the mandatory system
  gestures in taskbar, but for button nav we should actually be
  reporting zero, and for gesture nav we should either report the
  content height if the taskbar is pinned, or the gesture height
  otherwise as the bottom mandatory gesture inset

Bug: 340134342
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Change-Id: Ie4d56b62c903c273db95c19c9d34fcfe6c9ce486
2024-05-23 22:43:02 +00:00
Brian Isganitis
7c96392d25 Prototype tiny taskbar all apps.
Makes the scrim opaque for phones so that it looks like the launcher
phone all apps layout.

Flag: com.android.wm.shell.enable_tiny_taskbar
Test: Manual
Bug: 341784466
Change-Id: I0352bf7c13c4ea0a5e1bdecf8b4573fd2008d44b
2024-05-23 16:55:30 -04:00
Brian Isganitis
4aa0b3f261 Disable taskbar EDU for tiny taskbar.
The tooltips are generally too large for phone mode, and since this is a
prototype, let's disable them when in tiny mode :)

Flag: com.android.wm.shell.enable_tiny_taskbar
Test: Manual
Bug: 341784466
Change-Id: I340485edf8bedc6b5d9501cb7c74b0864ae79630
2024-05-23 16:49:24 -04:00