Commit Graph

85 Commits

Author SHA1 Message Date
Jagrut Desai
c1bcdc0f5d Merge "Aconfig flag for taskbar customization." into main 2024-06-14 21:19:18 +00:00
Jagrut Desai
fbd93ef907 Aconfig flag for taskbar customization.
Test: Presubmit
Bug: 347281365
Flag: com.android.launcher3.enable_taskbar_customization

Change-Id: I5a3959a8ca956329faa2df5d6bda297934e1ba62
2024-06-14 10:41:06 -07:00
Andy Wickham
cfafb55331 Convert ENABLE_FLOATING_SEARCH_BAR to aconfig.
Flag: com.android.launcher3.floating_search_bar
Test: Build (existing code unchanged)
Bug: 346408388
Fix: 346406981
Change-Id: Ia8d15ceb1b2b4754657844d602cb95b9555a4ece
2024-06-12 01:24:36 +00:00
Charlie Anderson
9e12c3f152 Adding bugfix flag for archiving bug extras
Bug: 322314760
Test: locally
Flag: com.android.launcher3.enable_first_screen_broadcast_archiving_extras
Change-Id: I33edcf09eee990727613246fb5942263feb49625
2024-06-11 00:07:24 -04:00
Treehugger Robot
9aafa6bd76 Merge changes I8411fb83,I5b757558 into main
* changes:
  Move Desktop running apps support into TaskbarRecentAppsController
  Add flag for Recents in Taskbar
2024-06-11 02:16:56 +00:00
Tony Wickham
be10c0b10c Add flag for Recents in Taskbar
Flag: com.android.launcher3.enable_recents_in_taskbar
Test: none
Bug: 315354060
Change-Id: I5b757558ab8e5905b4142146901b68f55d0c7ef8
2024-06-03 21:12:46 +00:00
Brandon Dayauon
e16a2725d2 Create a bug fix flag for the FloatingMaskView.
Need to create a bug-fix flag since feature flags can't reach nextfood in time for V. We do this by renaming
the current flag.

According to https://g3doc.corp.google.com/company/teams/android-core-experiments/trunk-stable/gantry-stages/bug-fix.md?cl=head

After a flag declaration has been merged, it's no longer possible to change its purpose. If the purpose of a flag changes over time, simply rename the flag; this will create a new workflow and invalidate the previous workflow.
In cases where renaming is not possible, please file a bug for the ACE oncall. Even when re-using the name of a flag for a new purpose, please note that all the progress in the pre-existing workflow will be lost; the new bug-fix workflow will start from scratch.

bug: 339850589
Test: Presubmit/locally adb shell device_config put launcher_search com.android.launcher3.private_space_add_floating_mask_view true
Flag: ACONFIG com.android.launcher3.private_space_add_floating_mask_view STAGING
Change-Id: Iffbc6a93c4ef6bbe121e0c8fb83250174f367b9d
2024-05-28 15:49:58 -07:00
Brian Isganitis
6fd271bb8a Revert "Add flag for Tiny Taskbar"
This reverts commit 1a57e08d84.

Reason for revert: ag/27470277 flag instead
Flag: com.android.wm.shell.enable_tiny_taskbar
Test: None
Bug: 341784466

Change-Id: I1a36c66eabb9c2ddac4595cec6836da222182351
2024-05-23 22:31:07 +00:00
Brian Isganitis
1a57e08d84 Add flag for Tiny Taskbar
Flag: com.android.launcher3.enable_tiny_taskbar
Test: None
Bug: 341784466
Change-Id: I84be4bed652c27c4ebfba5818c13d98acfa9aa60
2024-05-20 23:07:45 +00:00
Tracy Zhou
0bfd21fe2e Add folders in all apps aconfig flag
Bug: 341582436
Change-Id: I615d3b925dba8987c793c3e871f2aebde10ace53
Test: N/A
2024-05-19 22:19:57 +00:00
Brandon Dayauon
892b96f319 Add private_space_floating_mask_view flag.
bug: 339850589
Test: In follow up CL
Flag: ACONFIG com.android.launcher3.private_space_floating_mask_view DEVELOPMENT
Change-Id: Idc03b9d3439046e6a1397599b33c7af9f53b1333
2024-05-10 12:43:45 -07:00
Schneider Victor-tulias
65ae550a92 Add support for animating non-running tasks
It is possible to animate a non-running task to home mid-quick switch, which was not properly supported, causing a janky animation. Added custom animations to handle this more smoothly.

Flag:  ACONFIG com.android.launcher3.enable_additional_home_animations DISABLED
Fixes: 237638627
Test: swipe to home mid-quick switch on handheld/large screen in portrait/landscape from an app present/missing on the workscape in RTL/LTR
Change-Id: I89c9cf1ed1c0b88ff6c3ce71a663cb16e69d5843
2024-05-01 20:06:34 +00:00
fbaron
9d08e0fe70 Migrate smartspace as a widget and smartspace removal toggle flags to aconfig
Bug: 336823684, 336823681
Test: none
Flag: ACONFIG enable_smartspace_as_a_widget DISABLED
Flag: ACONFIG enable_smartspace_removal_toggle DISABLED
Change-Id: I4cba42e09f58365f761ab866b15a494817e6bb0f
2024-04-25 14:26:30 -07:00
Uwais Ashraf
e21525da40 Add a refactored TaskThumbnailView
- Live Tile, swipe (left+right) and dismiss working
- Tests of ViewModel state transitions
- Deprecate the old TaskThumbnailView
- Renaming TaskThumbnailView to TaskThumbnailViewDeprecated

Fix: 335440878
Fix: 331754672
Bug: 331753115
Test: TaskThumbnailViewModelTest
Test: Attached video on bug
Flag: ACONFIG com.android.launcher3.enable_refactor_task_thumbnail DEVELOPMENT
Change-Id: I063b957fe6e56960970dcaadc641848fbd73251c
2024-04-23 23:05:14 +01:00
randypfohl
f968879aa8 Adding in feature flag for Recents in Windows
Test: none

Flag: none

Bug: 292269949
Change-Id: I90683497a97149eb6054d168b92a078385e027e4
2024-04-22 09:38:13 -07:00
Schneider Victor-tulias
f3f0e28762 Reland slow gesture callback handling
Now that b/329324086 has been fixed, we can be more certain that launcher always gets a signal to clean up from WM.

- Relanding original fix for b/285636175 with some additional error checking
- We will now check whether the recents animation start is pending on ACTION_UP
- We will now block entire swipes to prevent sending additional inputs an input consumer while the recents animation start is pending
- We will now only stop blocking inputs on ACTION_DOWN

Flag: LEGACY ENABLE_HANDLE_DELAYED_GESTURE_CALLBACKS TEAMFOOD
Bug: 329324927
Fixes: 285636175
Test: added a delay in RecentsAnimationCallbacks.onAnimationStart and attempted several rapid gestures
Change-Id: I9805114da34bf44e6b28c2a8a665e4cca88904c2
2024-04-16 17:16:40 -04:00
Fengjiang Li
76f148b919 Merge "Revert accidental removal of PURPOSE_BUGFIX of flag enable_add_app_widget_via_config_activity_v2" into main 2024-03-21 03:19:55 +00:00
Fengjiang Li
4cfdbafb20 Revert accidental removal of PURPOSE_BUGFIX of flag enable_add_app_widget_via_config_activity_v2
ag/26538984 accidentally removes PURPOSE_BUGFIX of enable_add_app_widget_via_config_activity_v2,
this CL will revert that part as a forward fix

Bug: 298089923
Flag: ACONFIG enable_add_app_widget_via_config_activity_v2 TEAMFOOD
Test: just a flag change
Change-Id: I29bbb8c60ae71978ee4129a4751fa4ad0d3706d3
2024-03-20 12:56:48 -07:00
Andrew Cole
6667611f59 Merge "Moving FORCE_MONOCHROME_APP_ICONS to New Flag System" into main 2024-03-18 16:10:03 +00:00
Andrew Cole
16b68816ce Moving FORCE_MONOCHROME_APP_ICONS to New Flag System
In order to continue work on theming all app icons we are moving the developer flag over. This is cleanup work

Bug: 270396209
Test: None
Flag: ACONFIG FLAG_FORCE_MONOCHROME_APP_ICONS disabled
Change-Id: Ia290a6761aec68eadd2e78f64ac5dbd233af6033
2024-03-15 14:19:22 -07:00
Willie Koomson
cdc26951ff Add tap-to-add button to widget picker
This change introduces an "Add" button that appears when a widget
preview is clicked in the widget picker. This button disappears when the
preview is clicked again, or another preview is clicked. When the button
is pressed, it adds that widget to the picker. The add button is
available in the app-specific widget sheet as well.

Bug: 323886237
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT

Change-Id: I86a8a4c22119960c54a885fd2efeb91916b4f9a0
2024-03-15 20:10:45 +00:00
Sebastian Franco
5ea61960ab Making 2 flags read only since they are used on backup and restore
The flags are narrow_grid_restore and grid_migration_fix.

Flag: ACONFIG enable_grid_migration_fix enabled
Flag: ACONFIG enable_narrow_grid_restore enabled
Bug: 325286145
Bug: 325285743
Test: BackupAndRestoreDBSelectionTest.kt
Test: GridMigrationTest.kt
Change-Id: Ia6a439553c3c5098115144eae532342ce73be4f2
2024-03-14 17:16:51 +00:00
Luca Zuccarini
c9cbc9d5a1 Introduce a new Home animation for workspace and the outgoing task.
The values are currently the same for all display and orientation
configurations, but they might change before launch.

There are a couple known imperfections:
* Swiping out of a hotseat app with very low velocity doesn't look
  great
* Sometimes, if the window movement reaches its final location faster
  than the background is done scaling, there is a small snap in icon
  position

Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: verified with the flag on and off

Change-Id: Id54c7f0a76f62108d8b92a3b5e78634fff64dbef
2024-03-14 10:48:02 +00:00
Fengjiang Li
ea67949eb0 Fix a bug where PURPOSE_BUGFIX was added to wrong flag
ag/26027892 added `PURPOSE_BUGFIX` to `enable_tablet_two_pane_picker_v2`, instead it should be added to `enable_add_app_widget_via_config_activity_v2`

Flag: aconfig enable_add_app_widget_via_config_activity_v2 DISABLED
Test: NONE
Bug: 284236964
Change-Id: I55ac6ae0f3af7ab1ed239ac11a04dd59eaf95c4a
2024-02-29 11:42:29 -08:00
Sebastián Franco
8833826b00 Merge "Adding grid_migration_fix and narrow_grid_restore flag" into main 2024-02-28 17:20:31 +00:00
LaMont Jones
74f7786401 Fix container for aconfig flags.
This app is in system_ext, not system.

Bug: b/325307746
Test: manual
Flag: NA
Change-Id: Ibb1c7a4b338b6bf900a626e7ec66a28e0f90169d
2024-02-26 14:54:31 -08:00
Sebastian Franco
e28239053d Adding grid_migration_fix and narrow_grid_restore flag
Flag: ACONFIG grid_migration_fix disabled
Flag: ACONFIG narrow_grid_restore disabled
Test: NA
Bug: 325286145
Bug: 325285743
Change-Id: Ibac4f8f7df7b020582bfa6cbc5756fcb743a3d09
2024-02-23 17:55:10 +00:00
Brandon Dayauon
0fa9113028 Merge "Add home settings toggle featureflag for enablingTwoLineText" into main 2024-02-21 18:14:21 +00:00
Fengjiang Li
73ece207a2 Merge "Avoid flicker to drop a widget that needs a config activity." into main 2024-02-17 03:16:40 +00:00
Fengjiang Li
8bd66ee82d Avoid flicker to drop a widget that needs a config activity.
When dropping a widget that requires an config activity, drop a
PendingAppWidgetHostView to workspace

Adb command to try the feature:

adb shell device_config put launcher com.android.launcher3.enable_add_app_widget_via_config_activity_v2 true

Fix: 284236964
Test: manual
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Change-Id: Ifd0be5c607a388cf8a8f6d77b46c03112e3e599f
2024-02-16 17:05:40 -08:00
Willie Koomson
fda1b4b0d0 Merge "Use generated RemoteViews preview for widget picker if available" into main 2024-02-13 21:18:45 +00:00
Willie Koomson
fedc18e9a8 Use generated RemoteViews preview for widget picker if available
WidgetCell will use the generated RemoteViews preview to display
previews in the widget picker. It will fallback to current preview
methods if not available.

Introduces WidgetManagerHelper.loadGeneratedPreviews as a utility
function. WidgetManagerHelper is passed into the constructor of
WidgetItem to avoid calling
context.getSystemService(AppWidgetManager.class) for each widget.

Bug: 308041327
Test: atest Launcher3Tests:GeneratedPreviewTest
Flag: ACONFIG com.android.launcher3.enable_generated_previews DEVELOPMENT
Change-Id: I37429057cda83a5321884ace2537038e050b9a58
2024-02-13 18:49:44 +00:00
Brandon Dayauon
5787a2710c Add home settings toggle featureflag for enablingTwoLineText
- Have shouldUseTwoLine() be decided with the home settings toggle value

bug:316027081
spec: https://www.figma.com/file/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?type=design&node-id=405-384593&mode=design&t=UBkdeuNlAdRh2FGU-0
Test:
Video: https://drive.google.com/file/d/15VUhNVro2fiwv3SzMda1StiPb3PV1eMT/view?usp=sharing
before searchPreferenceScreen: https://screenshot.googleplex.com/3uqdMsZoGSBYb6c
after searchPreferenceScreen: https://drive.google.com/file/d/15dswiHRTnafyhgQA_tL2tRc7vHFWdHbZ/view?usp=sharing
before homeSettingsPage: https://screenshot.googleplex.com/7wsNevxGun2KCCB
after homeSettingsPage: https://drive.google.com/file/d/15m5bjEyewlNHI_h26aygHa7zrgZ5qDF6/view?usp=sharing
AppListSettingsPage: https://drive.google.com/file/d/15hl4ScHBOLgKv3M38HtatMxQw85pgl7t/view?usp=sharing
Flag: enableTwolineToggle DEVELOPMENT

Change-Id: I3ad133dd51dcb97e14ccded730e7737c5049261a
2024-02-12 09:24:48 -08:00
Oriol Prieto Gascó
0f1c6dedf5 Merge "Set the container field of aconfig flags" into main 2024-02-12 16:41:08 +00:00
Oriol Prieto Gasco
59234c574e Set the container field of aconfig flags
Please see go/aconfig-flag-containers for more context

Test: m
Bug: 312769710
Change-Id: I95efda5d266ad45202501d82d256d9e9f8e7826a
2024-02-07 20:00:34 +00:00
Fengjiang Li
cd60d191a8 [Predictive Back] Replace legacy flag with aconfig flag in launcher
Fix: 323971106
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Test: manual
Change-Id: Ie8051af2540699a7d75f1ed05132584d0b40d17d
2024-02-05 16:41:29 -08:00
Himanshu Gupta
69f37fd722 Merge "Preventing DragAndDrop for PS apps." into main 2024-02-01 09:14:43 +00:00
Himanshu Gupta
3ec66fb333 Preventing DragAndDrop for PS apps.
This Cl restricts item dragging for PS apps from
all launcher surfaces such as AllApps, AppPredictionRow, etc.

Video: https://photos.app.goo.gl/PKGw8n23hJVJMyUk7

Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_item_drag DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I2c5dbaa325095ec63aedf39b6b2c269f745d58ca
2024-02-01 06:46:25 +00:00
Sunny Goyal
fffb4feb4e Adding a flag to support activity overlay on home screen
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: N/A
Change-Id: Ic29c2c21da22554213a1792a38caf6907438c86d
2024-01-31 11:34:00 -08:00
Shamali P
c48c660bb5 Add a feature flag for displaying categorized widget recommendations.
Bug: 318410881
Test: NONE
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_suggestions DEVELOPMENT
Change-Id: I6f8a0cc8f74823f1a29cef1b5f8ac0a3e9411609
2024-01-29 18:40:22 +00:00
Himanshu Gupta
f591ce5f17 Restricting Accessibility flows for Private Profile.
Adding PS apps to the home screen is restricted.
This CL prevents the same from accessibility drags.

Bug: 289223923
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_accessibility_drag DEVELOPEMENT
Test: Ran Launcher3 Tests.
Change-Id: I3e2b7b196b96a4d2ba34d8ece5fd6e0463f17253
2024-01-25 04:19:20 +00:00
Sunny Goyal
7ec2e11b0c Merge "Implementing an unfold animation using CannedAnimationController" into main 2024-01-22 19:06:41 +00:00
Sebastián Franco
82d88d3fdc Merge "Updating launcher settings so that they become split-screen" into main 2024-01-22 04:58:09 +00:00
Sunny Goyal
2faf66e5d3 Merge "Revert "Set aconfig container to "system""" into main 2024-01-19 23:31:17 +00:00
Sebastian Franco
9ae403298d Updating launcher settings so that they become split-screen
Following this guide:
https://developer.android.com/guide/topics/large-screens/activity-embedding#extract_an_activity_from_a_split_to_full_window

Bug: 204463748
Test: Open the settings app and open multiple settings, for now
only the options inside of the launcher3 package work
Flag: ACONFIG com.android.launcher3.Flags.enableTwoPaneLauncherSettings DEVELOPMENT

Change-Id: Ie6a9eb3760171da92d94cf06376127b02afff8df
2024-01-19 22:33:20 +00:00
Sunny Goyal
d609f6ea39 Revert "Set aconfig container to "system""
This reverts commit 2916945dbf.

Reason for revert: breaks android-studio development flow

Change-Id: I219eb87c170b2b0dd1bb98894afa680bffb360b5
2024-01-19 21:35:29 +00:00
Sunny Goyal
2c206400a2 Implementing an unfold animation using CannedAnimationController
Bug: 297057373
Flag: aconfig enable_unfold_state_animation DISABLED
Test: Manual
Change-Id: Iaa352133ebf06ab74b9ba4b8c4d3523f27666089
2024-01-18 11:49:37 -08:00
Oriol Prieto Gascó
8cba27bc8a Merge "Set aconfig container to "system"" into main 2024-01-18 14:29:17 +00:00
Sunny Goyal
d3ee2c3427 Merge "Adding feature flags for Launcher reboot and load improvements" into main 2024-01-18 00:07:54 +00:00
Anushree Ganjam
cbfa8043c8 Merge "Add "Don't suggest app" shortcut to suggested apps." into main 2024-01-17 22:25:17 +00:00